[Wikitech-l] Sortable tables broken in 1.18 & trunk; needs tests & fixes or revert

2011-06-22 Thread Brion Vibber
The sortable table system in MediaWiki was completely rewritten in r86088; unfortunately this was done without benefit of any unit testing or regression testing, and there seem to be a lot of new bugs introduced. I've started adding test cases for table sorting in r90595; this adds a qunit test su

Re: [Wikitech-l] Sortable tables broken in 1.18 & trunk; needs tests & fixes or revert

2011-06-22 Thread Krinkle
Brion Vibber wrote: > The sortable table system in MediaWiki was completely rewritten in > r86088; > unfortunately this was done without benefit of any unit testing or > regression testing, and there seem to be a lot of new bugs introduced. The legacy script was removed from svn without depreca

Re: [Wikitech-l] Sortable tables broken in 1.18 & trunk; needs tests & fixes or revert

2011-06-22 Thread Brion Vibber
On Wed, Jun 22, 2011 at 2:32 PM, Krinkle wrote: > Brion Vibber wrote: > > > The sortable table system in MediaWiki was completely rewritten in > > r86088; > > unfortunately this was done without benefit of any unit testing or > > regression testing, and there seem to be a lot of new bugs introduc

Re: [Wikitech-l] Sortable tables broken in 1.18 & trunk; needs tests & fixes or revert

2011-06-22 Thread Brion Vibber
On Wed, Jun 22, 2011 at 1:27 PM, Brion Vibber wrote: > [snip] > The ascending sort by name usually works, but if called twice on two > tables, the second table usually gets sorted *completely* incorrectly. This > can be easily confirmed by manual inspection by copying a page such as > http://test

Re: [Wikitech-l] Sortable tables broken in 1.18 & trunk; needs tests & fixes or revert

2011-06-27 Thread Platonides
Brion Vibber wrote: >> This also makes sure our behaviour is in harmony with the expectation >> set by our javascript deprecation page [1] and will not break gadgets >> that are usiung (parts of) the legacy ts_* functions (which are global >> functions). > > Those are internal functions (just poorl

Re: [Wikitech-l] Sortable tables broken in 1.18 & trunk; needs tests & fixes or revert

2011-06-27 Thread Brion Vibber
On Mon, Jun 27, 2011 at 2:24 PM, Platonides wrote: > Brion Vibber wrote: > > Those are internal functions (just poorly namespaced), anything using > them > > can be expected to fail at any time. > > I agree with you. I but note that the new code won't get the > localization fixes done by overridi

Re: [Wikitech-l] Sortable tables broken in 1.18 & trunk; needs tests & fixes or revert

2011-06-29 Thread Leo Koppelkamm
Additionally, a project can also cleanly define custom parsers (some unusual date/numbers or whatever format they have). $.tablesorter.addParser( { id: "specialFormat", is: function (s) { //Check if content is specialFormat return isSpecialFormat; }, format: function (s) { //Return normalized Str