Re: menu: Fix for menu tracking problem version 2

2003-12-11 Thread Alexandre Julliard
Andrew de Quincey <[EMAIL PROTECTED]> writes: > Do you think such a thing should be implemented in wineserver or in the user32 > DLL? To me, it would go in wineserver 'cos it has all the information > available in one place... plus (to me) its kind of a hard constraint that > should be implemen

Re: Janitorial: Get rid of W->A calls for shlexec (2/2)

2003-12-11 Thread Alexandre Julliard
Marcelo Duarte <[EMAIL PROTECTED]> writes: > Hi, > > Changelog: > Marcelo Duarte <[EMAIL PROTECTED]> > -Janitorial: Get rid of W->A calls for shlexec > -Implementation of FindExecutableW > > Coments: > After you aplying my patch 1/2 and made corrections using sizeof, I see the > problems in the p

Re: gdi: AlphaBlend constants

2003-12-11 Thread Alexandre Julliard
Kirill Smelkov <[EMAIL PROTECTED]> writes: > +/* AlphaBlend flags */ > +#define AC_SRC_NO_PREMULT_ALPHA 0x01 > +#define AC_SRC_NO_ALPHA 0x02 > +#define AC_DST_NO_PREMULT_ALPHA 0x10 > +#define AC_DST_NO_ALPHA 0x20 Where do these come from? I don't see them in the S

Re: shlexec: Fixes for buffer overrun problems

2003-12-11 Thread Alexandre Julliard
Andrew de Quincey <[EMAIL PROTECTED]> writes: > Hi, this is a cleanup of shell32/shlexec.c to remove potential buffer > overruns. I've also tried to make parts of the code a little easier to > follow, without affecting the functionality. It's a very inefficient mechanism, you are reallocating t

Re: ntdll / kernel32: #38

2003-12-11 Thread Dmitry Timoshkov
"Eric Pouech" <[EMAIL PROTECTED]> wrote: > +HANDLE WINAPI OpenConsoleW(LPCWSTR name, DWORD access, LPSECURITY_ATTRIBUTES sa, > + DWORD creation) > +{ > +static const WCHAR coninW[] = {'C','O','N','I','N','$',0}; > +static const WCHAR conoutW[] = {'C','O','N','O','

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars

2003-12-11 Thread Andrew de Quincey
On Thursday 11 December 2003 23:30, Dimitrie O. Paun wrote: > On December 11, 2003 06:07 pm, Andrew de Quincey wrote: > > On second thoughts, that method would need multiple changes in the file > > to ensure the correct value was passed to InvalidateRect(). Whereas the > > method I proposed just ne

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars

2003-12-11 Thread Dimitrie O. Paun
On December 11, 2003 06:07 pm, Andrew de Quincey wrote: > On second thoughts, that method would need multiple changes in the file to > ensure the correct value was passed to InvalidateRect(). Whereas the method > I proposed just needs three lines. Calling InvalidateRect() is the right thing to do,

bugs in d3d8.dll and msvcrt.dll

2003-12-11 Thread Ivan Leo Murray-Smith
There are 2 bugs that prevent mafia (Trial version) from working correctly, they are in d3d8.dll and msvcrt.dll, updated backtraces generated with wine-20031212 are at http://bugs.winehq.com/show_bug.cgi?id=1670 the demo is at http://www.mafia-game.com in the downloads section.

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars

2003-12-11 Thread Andrew de Quincey
On Thursday 11 December 2003 23:00, Andrew de Quincey wrote: > On Thursday 11 December 2003 22:45, Dimitrie O. Paun wrote: > > On December 11, 2003 04:32 pm, Andrew de Quincey wrote: > > > I have concluded that the WM_ERASEBKGND is sent from within WM_PAINT > > > when the toolbar detects that the m

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars

2003-12-11 Thread Andrew de Quincey
On Thursday 11 December 2003 22:45, Dimitrie O. Paun wrote: > On December 11, 2003 04:32 pm, Andrew de Quincey wrote: > > I have concluded that the WM_ERASEBKGND is sent from within WM_PAINT when > > the toolbar detects that the mouse has moved off a button and wants to > > de-highlight it. > > Wel

Re: comctl32/toolbar: Potential fix for button redraw in TBSTYLE_FLAT toolbars

2003-12-11 Thread Dimitrie O. Paun
On December 11, 2003 04:32 pm, Andrew de Quincey wrote: > I have concluded that the WM_ERASEBKGND is sent from within WM_PAINT when > the toolbar detects that the mouse has moved off a button and wants to > de-highlight it. Well, it probably does a InvalidateRect() call. You can try an ugly In

Re: Deadlock?

2003-12-11 Thread Shachar Shemesh
Mike Hearn wrote: How can I attach to two threads? You don't, you attach to a process then pass the thread id to the "bt" command, ie: attach 0x0e (process id) bt 0x9 bt 0x1 ... etc Ok, it finally happened again. Not at the same place (on program exit rather than entry), and without

winefile problem with ShellExecuteEx()

2003-12-11 Thread Martin Fuchs
Hi, here is the patch to correct the problem. There have been missing a view initializations of struct SHELLEXECUTEINFO. This fixes only the crash, which was caused by Winefile. It does not complete the ShellExecuteEx() implementation. -- Martin Fuchs [EMAIL PROTECTED] Index: winefile.c ===

Re: I made a wish, wrote a letter to Santa...

2003-12-11 Thread Lionel Ulmer
> (2) A few things like DirectX and COM are so very closely tied with C++ > objects that implementing them in C seems an overkill to me. But after > knowing they are done, I have nothing against that Well, speaking for DirectX 1-7 , I do not see exactly what C++ would have gained us (

Re: menu: Fix for menu tracking problem version 2

2003-12-11 Thread Andrew de Quincey
On Thursday 11 December 2003 19:48, Andrew de Quincey wrote: > On Saturday 06 December 2003 19:46, Alexandre Julliard wrote: > > Andrew de Quincey <[EMAIL PROTECTED]> writes: > > > I wrote a program in windows which had owner drawn menu items. Whenever > > > I received the WM_DRAWITEM message: > >

Re: Adding support for a USB device

2003-12-11 Thread Eric Pouech
I'm also not sure as to how much such an extension would be wishful in the context of Wine itself or if it would unnecessarily complicate the existing Wine architecture. Maybe someone with more insigth into NTDLL and its supposed architecture could explain more here? I'm currently working on this b

Re: menu: Fix for menu tracking problem version 2

2003-12-11 Thread Andrew de Quincey
On Saturday 06 December 2003 19:46, Alexandre Julliard wrote: > Andrew de Quincey <[EMAIL PROTECTED]> writes: > > I wrote a program in windows which had owner drawn menu items. Whenever I > > received the WM_DRAWITEM message: > > > > 1) I called GetCapture(), and compared it with the hwnd of main w

Re: Crash early in running msiexec.exe

2003-12-11 Thread Dan Kegel
Dan Kegel <[EMAIL PROTECTED]> writes: Dan> This is on RH9 SMP with wine-20031118. Trying to run the MS SFU Dan> 3.0 (hey, I got it for $5 from that special offer they ran on Dan> slashdot a couple weeks ago...) setup.exe from the commandline Dan> yields the crash: Dan> Unhandle

Re: PATCH for Bugs 1844 and 1845

2003-12-11 Thread Dimitrie O. Paun
On December 11, 2003 01:33 pm, Andreas Rosenberg wrote: > I sent two patches about a week ago. > > The first one: "Bug 1844: Point Size in DLG_TEMPLATE may be negative" > made it into the CVS (I browsed with: http://cvs.winehq.com/cvsweb) That's one way to do it. Another is to follow the wine-cvs

Low level dlls

2003-12-11 Thread carlini
Hi, what is a low level dlls in M$ windows nt? (low level dll == ddl whit access win device driver and/or hardware recourses.) They can natively be loaded? tanks Ricardo = Ricardo Carlini Sperandio= = 4! perido= = Ciencia da Computacao

Re: I made a wish, wrote a letter to Santa...

2003-12-11 Thread Subhobroto Sinha
Actually Shachar, I was thinking along these lines: (1) Programs in WINE are making direct calls to internal functions (which are not really Win32, but made by us using which we can use te Win32 functions as wrappers...) and that's just possible because C functions are globally callable (the o

Re: PATCH for Bugs 1844 and 1845

2003-12-11 Thread Andreas Rosenberg
I sent two patches about a week ago. The first one: "Bug 1844: Point Size in DLG_TEMPLATE may be negative" made it into the CVS (I browsed with: http://cvs.winehq.com/cvsweb) The second "Bug 1845: Return values of CharUpperA and CharLowerA" did not. Any reasons to reject this patch? I also wrot

Re: Patch for bug 1848 - TrackPopupMenu returns wrong result, when menu is canceled

2003-12-11 Thread Dimitrie O. Paun
On December 11, 2003 01:20 pm, Andreas Rosenberg wrote: > +if (!(menu = MENU_GetMenu( hmenu ))) > + { > + SetLastError(ERROR_INVALID_MENU_HANDLE); /* - added by A.Rosenberg > 2003.12.11 */ + return FALSE; > + } No need to add the 'added by ...' comment, it uglifies the

dlls/oleaut32/tests/vartype.c problems

2003-12-11 Thread Gerald Pfeifer
The new file dlls/oleaut32/tests/vartype.c, add by the following commit revision 1.1 date: 2003/12/11 05:25:44; author: julliard; state: Exp; Jon Griffiths <[EMAIL PROTECTED]> Test almost all of the low level variant functions adds a couple of warnings: vartype.c:4118: warning: integ

Re: multi-level subdirs under dlls/

2003-12-11 Thread Dimitrie O. Paun
On December 11, 2003 04:49 am, Lionel Ulmer wrote: > dlls/ddraw/ddraw_main.c > dlls/ddraw/ddraw_thunk.c > dlls/ddraw/ddraw_opengl.c > dlls/ddraw/dpalette_main.c > (...) > > I certainly do not like this and prefer the nested directory structure :-) OK, that's another story, the script that generate

Re: Partial success: RoughDraft 2.11

2003-12-11 Thread Mike Hearn
On Thu, 2003-12-11 at 14:46, Dan Kegel wrote: > Sources not available but the author seems like a good guy, and would probably > be willing to work with us if we really needed it (especially if we fixed a few > things first, like that EULA display problem). That's probably our richedit control suc

Re: Partial success: RoughDraft 2.11

2003-12-11 Thread Uwe Bonnes
> "Dan" == Dan Kegel <[EMAIL PROTECTED]> writes: Dan> On a whim, I tried out RoughDraft 2.11 under wine-20031118 this Dan> morning. It installed and ran with some anomolies (e.g. the Dan> installer's EULA doesn't display at all! ... Are you sure there wasn't a windows stacking or

Partial success: RoughDraft 2.11

2003-12-11 Thread Dan Kegel
On a whim, I tried out RoughDraft 2.11 under wine-20031118 this morning. It installed and ran with some anomolies (e.g. the installer's EULA doesn't display at all!, .doc import works really poorly, a few pixels misplaced here and there, can't invoke web browser to display help), but it might be g

Re: I made a wish, wrote a letter to Santa...

2003-12-11 Thread Rein Klazes
On Thu, 11 Dec 2003 12:20:46 +0200, you wrote: > typelib.c is assigned to Rein KLazes (by copy-right). Did you experiment > with also writing the TLB? do you have any > code/documentation/URLs/pointers laying around that I should see before > I start? (That is if you are not doing it?) I take

Re: winefile can't launch any apps!

2003-12-11 Thread Martin Fuchs
Hello, > Found the problem. > launch_entry is using SEE_MASK_IDLIST, which isnt handled by > ShellExecuteExA32 now. > > The optional shell namespace mode should be disabled by a > "#define _NO_EXTENSIONS", but I didnt manage to use it. > Martin, could you bring us some light ? > http://www.winehq.

RE: Adding support for a USB device

2003-12-11 Thread Rolf Kalbermatter
Dan Timis [mailto:[EMAIL PROTECTED] wrote: > I did some further investigation and it looks like CreateFile > (actually > CreateFileW) looks at the filename and if it starts with "\\.\" it > calls DEVICE_Open(). DEVICE_Open() compares the file name > (without the > "\\.\" ) against all the ent

Re: I made a wish, wrote a letter to Santa...

2003-12-11 Thread Boaz Harrosh
I looked at the code (typelib.c/.h) it looks strait forward, read the file. (Microsoft invented yet another file format, this is when they where writing the book about OLE files. nu well ...) I guess it should not be very hard to implement the ICreateTypeLib/2 (I hope). Than WIDL can use that In

Re: multi-level subdirs under dlls/

2003-12-11 Thread Lionel Ulmer
> -- the organization is confusing since it implies some > sort of dependency that's not there (they are all .dlls) Well, I find it nicer to have separate directories for each COM object in D3D. I agree that it's all the same DLL, but well, would you prefer something like : dlls/ddraw/ddra

Re: multi-level subdirs under dlls/

2003-12-11 Thread Andreas Mohr
Hi, On Thu, Dec 11, 2003 at 01:17:08AM -0500, Dimitrie O. Paun wrote: > Hi folks, > > I know people are concerned right now with more important > matters, but given that (1) we're cleaning up the tree, and > (2) we're getting close to 0.9, I figured it maybe time to > bring this up. Namely, unde

Re: oleaut32 low level tests

2003-12-11 Thread Dmitry Timoshkov
"Jon Griffiths" <[EMAIL PROTECTED]> wrote: > Jon Griffiths <[EMAIL PROTECTED]> > > +dlls/oleaut32/tests/vartype.c dlls/oleaut32/tests/Makefile.in > Test almost all of the low level variant functions The only failure I have here: vartype.c:3340: Test failed: hres=0x0, type=8 (should be V