Re: Unixfs as ShellFSFolder?

2006-01-18 Thread Michael Jung
Hey Ge, On Tuesday 17 January 2006 19:55, Ge van Geldorp wrote: shfldr_fs and shfldr_unixfs could both inherit from a common implementation, we can tack on some internal routines to the existing vtable. Redundancy between the two can then be eliminated by extracting the common code to the

Re: PATCH/RFC: defer OLE apartment window creation

2006-01-18 Thread Marcus Meissner
This isn't thread-safe. It would also be better to make this an accessor function for the win field of struct apartment and fix up all callers to use this. I still have to verify on Windows whether this is what it does or whether it does something funny with message loops. I lack

Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread Detlef Riekenberg
Am Dienstag, den 17.01.2006, 14:18 -0600 schrieb James Hawkins: We generally have a policy of silence for the test suite unless a failure occurrs. Then we need to update many Tests, which do not respect this. Why do you need to output the version tested? I have a partial implemented

Re: [D3D8] fix compile error for missing GL define

2006-01-18 Thread H. Verbeet
On 18/01/06, Robert Reif [EMAIL PROTECTED] wrote: I don't know the best way to handle this but this patch does get it to compile again. Fixing it that way makes it a compile time check instead of a runtime check. I think the idea was for d3d to check extension support during runtime.

Wine on SuSE 10 and German Umlauts

2006-01-18 Thread Roland Kaeser
Hello I'm new in this list. I'm the Application Maintainer of Corel Draw 9 and Railroad Tycoo3 so I hope I'm ready to discuss with the developers on a equal level. I have a very strange behaviour when using wine (the original suse rpm, the compiled source code (release or cve)) on SuSE 10 on

Re: Wine on SuSE 10 and German Umlauts

2006-01-18 Thread Marcus Meissner
On Wed, Jan 18, 2006 at 03:17:25PM +0100, Roland Kaeser wrote: Hello I'm new in this list. I'm the Application Maintainer of Corel Draw 9 and Railroad Tycoo3 so I hope I'm ready to discuss with the developers on a equal level. I have a very strange behaviour when using wine (the

Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread Jakob Eriksson
Detlef Riekenberg wrote: Am Dienstag, den 17.01.2006, 14:18 -0600 schrieb James Hawkins: We generally have a policy of silence for the test suite unless a failure occurrs. Then we need to update many Tests, which do not respect this. +1.

Re: GIT rebase changes

2006-01-18 Thread Robert Shearman
Mike McCormack wrote: Hi GIT users, The GIT guys have made rebase and pull incompatible, and to use rebase (which is likely what we want to do for Wine), you must use fetch then rebase, not pull (which does a merge). And on a slightly related note, I wrote a script which works kinda like

Re: GIT rebase changes

2006-01-18 Thread Eric POUECH
why don't you guys use stg (stacked git) it allows you to manage a set of patches, with features like : - re-edit an existing one (basically, you push/pull a set of patches from a stack, and decide which one to use) - you get the upside of git, without the down side (ie a commit is done only once)

FWD: Wine on SuSE 10 and German Umlauts

2006-01-18 Thread Roland Kaeser
Hello I'm new in this list. I'm the Application Maintainer of Corel Draw 9 and Railroad Tycoo3 so I hope I'm ready to discuss with the developers on a equal level. I have a very strange behaviour when using wine (the original suse rpm, the compiled source code (release or cve)) on SuSE 10 on a

Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread James Hawkins
On 1/18/06, Detlef Riekenberg [EMAIL PROTECTED] wrote: Am Dienstag, den 17.01.2006, 14:18 -0600 schrieb James Hawkins: We generally have a policy of silence for the test suite unless a failure occurrs. Then we need to update many Tests, which do not respect this. I agree, but that

Re: mscms: check an appropriate registry key.

2006-01-18 Thread James Hawkins
On 1/18/06, Saulius Krasuckas [EMAIL PROTECTED] wrote: + +hkIcmKey = reg_open_mscms_key(); +if (!hkIcmKey) +{ +trace(Key 'HKLM\\SOFTWARE\\Microsoft\\Windows*\\CurrentVersion\\ICM\\RegisteredProfiles' not found\n ); +return; +} We shoul fail silently

Re: HW address w/o connection in iphlpapi

2006-01-18 Thread Michael Ost
Hi Michael, When you boot a linux box without an ethernet connection, and eth0 configuration fails, GetAdaptersInfo does not return MAC address info for eth0. The problem seems to be that enumerateInterfaces (in dlls/iphlpapi/ifenum.c) doesn't create a record for eth0, because

Re: CVS build error on RH9

2006-01-18 Thread H. Verbeet
On 18/01/06, Michael Jung [EMAIL PROTECTED] wrote: I can confirm this on Debian Sarge. From what I've seen by google'ing, GL_ARB_point_sprite seems to be an OpenGL 1.5 feature. I've attached a patch, but I'm not sure if the right thing is to check on GL_VERSION_1_5 or on GL_ARB_point_sprite.

Re: mscms: check an appropriate registry key.

2006-01-18 Thread Saulius Krasuckas
* On Wed, 18 Jan 2006, James Hawkins wrote: * On 1/18/06, Saulius Krasuckas [EMAIL PROTECTED] wrote: + +hkIcmKey = reg_open_mscms_key(); +if (!hkIcmKey) +{ +trace(Key 'HKLM\\SOFTWARE\\Microsoft\\Windows*\\CurrentVersion\\ICM\\RegisteredProfiles' not found\n );

RE: [Bug 3095] ID Collisions in menus

2006-01-18 Thread Ann Jason Edmeades
Again, the very first thing I'd suggest to do is to write a comprehensive test case and send it to wine-patches with appropriate todo_wine statements to make it pass. Then we could see exact steps which lead to a failure and could start thinking of a possible fix. Attached is a set of tests

Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread Detlef Riekenberg
Am Mittwoch, den 18.01.2006, 13:28 -0600 schrieb James Hawkins: There is one case where I think it's leaning towards the OK side, though it still bugs me, and that is the advpack:GetVersionFromFile tests. This test is in the wrong File (file.c and tests/advpack.c). There's really no way

Re: CVS build error on RH9

2006-01-18 Thread Robert Reif
H. Verbeet wrote: On 18/01/06, Michael Jung [EMAIL PROTECTED] wrote: I can confirm this on Debian Sarge. From what I've seen by google'ing, GL_ARB_point_sprite seems to be an OpenGL 1.5 feature. I've attached a patch, but I'm not sure if the right thing is to check on GL_VERSION_1_5 or on

Re: winspool/tests: dump filename and version of the tested file

2006-01-18 Thread James Hawkins
On 1/18/06, Detlef Riekenberg [EMAIL PROTECTED] wrote: Am Mittwoch, den 18.01.2006, 13:28 -0600 schrieb James Hawkins: There is one case where I think it's leaning towards the OK side, though it still bugs me, and that is the advpack:GetVersionFromFile tests. This test is in the wrong

Re: mscms: check an appropriate registry key.

2006-01-18 Thread James Hawkins
On 1/18/06, Saulius Krasuckas [EMAIL PROTECTED] wrote: * On Wed, 18 Jan 2006, James Hawkins wrote: * On 1/18/06, Saulius Krasuckas [EMAIL PROTECTED] wrote: + +hkIcmKey = reg_open_mscms_key(); +if (!hkIcmKey) +{ +trace(Key

Re: CVS build error on RH9

2006-01-18 Thread Michael Jung
On Thursday 19 January 2006 02:21, Robert Reif wrote: The patch attached to this mail should be the proper way to fix this, but I'm not able to test it myself right now. Works for me. For me too. Bye, -- Michael Jung [EMAIL PROTECTED]