Re: Coverity scan database reset soon...

2006-10-06 Thread Paul Vriens
On Thu, 2006-10-05 at 16:02 -0700, Dan Kegel wrote: Coverity has to reset their database soon to recover from a database problem (the one that's keeping new scans from showing up). Somebody should probably scrape the Wine results from the Coverity database soon so we can avoid losing any

Re: DDraw: Protect the ddraw object list

2006-10-06 Thread Mike McCormack
Stefan Dösinger wrote: @@ -851,6 +853,13 @@ DllMain(HINSTANCE hInstDLL, +/* Initialize the ddraw object list critical section unconditionally + * Even if the app doesn't use multithreaded ddraw objects it can still + * use multiple ddraw objects in multiple threads +

Re: Coverity scan database reset soon...

2006-10-06 Thread Dan Kegel
On 10/5/06, Paul Vriens [EMAIL PROTECTED] wrote: the email sent by Coverity also asks for a 'main contact'. Do we have such a person already? Not that I know. Are you volunteering? Can we give them a date when they could recreate the database? Maybe it's good to have a clean start on this.

Re: Coverity scan database reset soon...

2006-10-06 Thread Paul Vriens
On Thu, 2006-10-05 at 23:55 -0700, Dan Kegel wrote: On 10/5/06, Paul Vriens [EMAIL PROTECTED] wrote: the email sent by Coverity also asks for a 'main contact'. Do we have such a person already? Not that I know. Are you volunteering? If nobody steps up, sure. Can we give them a date

Re: Coverity scan database reset soon...

2006-10-06 Thread Dan Kegel
On 10/6/06, Paul Vriens [EMAIL PROTECTED] wrote: On the other hand, several annotations are from April (6 months development since) and several bugs have been fixed already (but of course not seen). Say, has anybody posted a summary of the Coverity reports lately? e.g. how many issues it

Re: Copy protection

2006-10-06 Thread Vincent Povirk
On 10/5/06, Tim Schmidt [EMAIL PROTECTED] wrote: An application you are running (Application Name) is attempting to access a disk in a potentially unsafe way. Would you like it to access a safe virtual disk instead? Yes No A dialog like this would only serve to confuse people. If a setting

Re: Coverity scan database reset soon...

2006-10-06 Thread Paul Vriens
On Fri, 2006-10-06 at 00:35 -0700, Dan Kegel wrote: On 10/6/06, Paul Vriens [EMAIL PROTECTED] wrote: On the other hand, several annotations are from April (6 months development since) and several bugs have been fixed already (but of course not seen). Say, has anybody posted a summary of

Re: Copy protection

2006-10-06 Thread Tim Schmidt
On 10/6/06, Vincent Povirk [EMAIL PROTECTED] wrote: On 10/5/06, Tim Schmidt [EMAIL PROTECTED] wrote: An application you are running (Application Name) is attempting to access a disk in a potentially unsafe way. Would you like it to access a safe virtual disk instead? Yes No A dialog like

Re: wined3d/BltFast

2006-10-06 Thread Stefan Dösinger
Am Donnerstag 05 Oktober 2006 09:45 schrieb Christopher GAUTIER: It was due to GL_REGISTER_COMBINERS_NV being glEnabled() before entering IWineD3DSurfaceImpl_BltOverride. I believe it should be glDisabled() temporarily while blitting. Yes, they should be disabled, good catch :-)

Re: A wine success story

2006-10-06 Thread Stefan Dösinger
Am Freitag 06 Oktober 2006 03:39 schrieb EA Durbin: Are there any windows based dvd players that will work under wine? I was working on ddraw overlays the last 2 days which would help getting them working, but I have to pause my efforts until the wined3d-wgl move is done. pgp7q052xlxMw.pgp

Re: WineD3D: Add WINED3DUSAGE_OVERLAY

2006-10-06 Thread Stefan Dösinger
Hi, Should we split lines like this? It's doesn't fit even on my 1600x1200 display. I wanted to do a lot of reformating like this, but AJ put a veto before I even started :-/ diff --git a/include/wine/wined3d_types.h b/include/wine/wined3d_types.h index e70a814..278e7d7 100644 ---

Re: DDraw: Protect the ddraw object list

2006-10-06 Thread Stefan Dösinger
Am Freitag 06 Oktober 2006 08:42 schrieben Sie: Stefan Dösinger wrote: @@ -851,6 +853,13 @@ DllMain(HINSTANCE hInstDLL, +/* Initialize the ddraw object list critical section unconditionally + * Even if the app doesn't use multithreaded ddraw objects it can still +

Re: Copy protection

2006-10-06 Thread Kai Blin
On Friday 06 October 2006 10:19, Tim Schmidt wrote: Again, works for me. I believe the only part missing for this case is the simulation. Of course, there's the added possibility that apps will go mucking about with data other apps care about, in which case a per-executable simulated device

Re: [WINED3D 1/6] Move D3DSIO structure into the WINED3D namespace.

2006-10-06 Thread Stefan Dösinger
Am Freitag 06 Oktober 2006 04:48 schrieb Ivan Gyurdiev: I don't have a problem with creating another file if you think that's better, but please come up with another name, don't use the same name as the global header. Henri and Stefan, any preference? (you better have an opinion since

Re: Copy protection

2006-10-06 Thread Tim Schmidt
On 10/6/06, Kai Blin [EMAIL PROTECTED] wrote: On Friday 06 October 2006 10:19, Tim Schmidt wrote: Again, works for me. I believe the only part missing for this case is the simulation. Of course, there's the added possibility that apps will go mucking about with data other apps care about,

Re: [WINED3D 1/6] Move D3DSIO structure into the WINED3D namespace.

2006-10-06 Thread H. Verbeet
Maybe something like wined3d_private_types.h, although perhaps that's a bit long.

Re: WineD3D: Add WINED3DUSAGE_OVERLAY

2006-10-06 Thread H. Verbeet
On 06/10/06, Stefan Dösinger [EMAIL PROTECTED] wrote: Hi, Should we split lines like this? It's doesn't fit even on my 1600x1200 display. I wanted to do a lot of reformating like this, but AJ put a veto before I even started :-/ If you're changing the line, it should generally be ok to eg.

Re: WineD3D: Add WINED3DUSAGE_OVERLAY

2006-10-06 Thread Michael Stefaniuc
Stefan Dösinger wrote: Should we split lines like this? It's doesn't fit even on my 1600x1200 display. I wanted to do a lot of reformating like this, but AJ put a veto before I even started :-/ If you change the line anyway you can split it up too. It dosn't add an additional entry to the

Re: A wine success story

2006-10-06 Thread Jan Zerebecki
On Thu, Oct 05, 2006 at 07:50:34PM -0400, Tim Schmidt wrote: On 10/5/06, Martin Owens [EMAIL PROTECTED] wrote: I wonder if we can get the shockwave player working with the linux version of linux via some kind of wine layer instead of installing firefox for windows.

Re: opengl32: Correctly size and position opengl child windows

2006-10-06 Thread Roderick Colenbrander
Hi, The plan is to get all the X-specific opengl code into winex11.drv and to get rid of things like ExtEscape. I also want to avoid using WineGLContext in opengl32.dll as I plan to change this too. A call like SyncCurrentDrawable should in the end be placed inside winex11.drv. I haven't

RE: Copy protection

2006-10-06 Thread Rolf Kalbermatter
Tim Schmidt wrote: Again, works for me. I believe the only part missing for this case is the simulation. Of course, there's the added possibility that apps will go mucking about with data other apps care about, in which case a per-executable simulated device would be best. Wouldn't such a

Re: opengl32: Correctly size and position opengl child windows

2006-10-06 Thread Ulrich Czekalla
On Fri, Oct 06, 2006 at 01:30:43PM +0200, Roderick Colenbrander wrote: Hi, The plan is to get all the X-specific opengl code into winex11.drv and to get rid of things like ExtEscape. I also want to avoid using WineGLContext in opengl32.dll as I plan to change this too. A call like

Re: WineD3D: Add WINED3DUSAGE_OVERLAY

2006-10-06 Thread Francois Gouget
On Thu, 5 Oct 2006, Vitaliy Margolen wrote: [...] @@ -274,7 +274,7 @@ static HRESULT WINAPI IDirect3DDevice9I TRACE((%p) : w(%d) h(%d) fmt(%d) [EMAIL PROTECTED], This, Width, Height, Format, *ppSurface); -hrc =

Re: [PATCH 1/5] lz32/tests: Test more last errors set by LZOpenFile[AW].

2006-10-06 Thread Saulius Krasuckas
* On Thu, 5 Oct 2006, Vitaliy Margolen wrote: * Saulius Krasuckas wrote: --- a/dlls/lz32/tests/lzexpand_main.c +++ b/dlls/lz32/tests/lzexpand_main.c @@ -131,6 +131,7 @@ static void test_LZOpenFileA_existing_co memset(filled_0xA5, 0xA5, OFS_MAXPATHNAME); memset(test, 0xA5,

Re: opengl32: Correctly size and position opengl child windows

2006-10-06 Thread Willie Sippel
Am Freitag, 6. Oktober 2006 15:26 schrieb Ulrich Czekalla: From our discussions at wineconf we concluded that overriding the various functions such as glViewport and glScissor will get us there for most applications. The only thing this will not do is handle the case where a child window

Client-side DIB copy optimization patch on Bugzilla

2006-10-06 Thread Willie Sippel
Hi there. A patch by Iulian Marinescu was posted on Bugzilla a few days ago to optimize client-side DIB copy operations. I tested it, and it definitely improves the performance of a few applications quite a bit (Propellerhead Reason for example). Even though I can't comment on the quality of

Re: [PATCH 1/5] lz32/tests: Test more last errors set by LZOpenFile[AW].

2006-10-06 Thread Alexandre Julliard
Saulius Krasuckas [EMAIL PROTECTED] writes: Unless Alexandre confirms the requirement directly. In such case I am going to put this stuff into our Wiki ^^ even write a patch for cleaning the calls myself ;) There's no need to enforce 0xdeadbeef, other similar magic values work just as

Re: opengl32: Correctly size and position opengl child windows

2006-10-06 Thread Roderick Colenbrander
Am Freitag, 6. Oktober 2006 15:26 schrieb Ulrich Czekalla: From our discussions at wineconf we concluded that overriding the various functions such as glViewport and glScissor will get us there for most applications. The only thing this will not do is handle the case where a child

recent ole32/shdocvw regression crashes adobe installers

2006-10-06 Thread James Hawkins
Hi, A recent patch by Rob Shearman has caused two Adobe installers to crash when they try to load up a WebBrowser control to display a EULA: Commit: ccb634fdee50936c35880a6cffd70e0bcd946b5a URL: http://source.winehq.org/git/?p=wine.git;a=commit;h=ccb634fdee50936c35880a6cffd70e0bcd946b5a

ListView_InsertColumn() question

2006-10-06 Thread Andrew Talbot
Can you verify something for me, please? The SDK declares ListView_InsertColumn() as: int ListView_InsertColumn( HWND hwnd, int iCol, const LPLVCOLUMN pcol ); In commctrl.h, we have: #define ListView_InsertColumnA(hwnd,iCol,pcol) \

Re: Coverity scan database reset soon...

2006-10-06 Thread Dan Kegel
On 10/6/06, Paul Vriens [EMAIL PROTECTED] wrote: Say, has anybody posted a summary of the Coverity reports lately? e.g. how many issues it flagged in Wine, and how many have been examined? http://scan.coverity.com/ is the only place I know of.OK, I just logged in there and scraped the two main

Re: Copy protection

2006-10-06 Thread James Courtier-Dutton
Tim Schmidt wrote: On 10/6/06, Kai Blin [EMAIL PROTECTED] wrote: On Friday 06 October 2006 10:19, Tim Schmidt wrote: Again, works for me. I believe the only part missing for this case is the simulation. Of course, there's the added possibility that apps will go mucking about with data

Re: [PATCH] oleaut32: Add tmarshal conformance test

2006-10-06 Thread James Hawkins
On 10/6/06, Michal Okresa [EMAIL PROTECTED] wrote: --- dlls/oleaut32/tests/tmarshal.c | 1099 dlls/oleaut32/tests/tmarshal.idl | 159 + dlls/oleaut32/tests/tmarshal.rc| 30 + dlls/oleaut32/tests/tmarshal_dispids.h | 34 + 4 files

Re: Coverity scan database reset soon...

2006-10-06 Thread James Hawkins
On 10/6/06, Paul Vriens [EMAIL PROTECTED] wrote: For example, if something is marked as a BUG then I'd expect the person that marked it, to follow up (either by a patch, by chasing somebody to look into this, or to create a bugzilla entry). He/she has spent already some time looking into this

Re: ListView_InsertColumn() question {revised]

2006-10-06 Thread Andrew Talbot
[I meant to say that pointer declarations are read right-to-left, not left-to-right. So the corrected question is:] Can you verify something for me, please? The SDK declares ListView_InsertColumn() as: int ListView_InsertColumn( HWND hwnd, int iCol, const LPLVCOLUMN pcol ); In

Wine and HeidiSQL

2006-10-06 Thread Ansgar Becker
Hi there, I'm Ansgar Becker, the main-author of HeidiSQL. I saw that HeidiSQL is in your appdb! very cool ;) http://appdb.winehq.org/appview.php?iAppId=3326 However, some of the buttons on HeidiSQL's main-toolbar are twisted. I'm not a C programmer, so I'm a bit lost in Wine... but I can fix

ping about bug #1598

2006-10-06 Thread Alex Villací­s Lasso
Has there been any discussion or progress on how to fix bug #1598 about Delphi/VisualBasic applications not having minimize/maximize decorations (http://bugs.winehq.org/show_bug.cgi?id=1598)? According to one of the comments, the window management code would not be touched before 0.9 . However

Re: Wine and HeidiSQL

2006-10-06 Thread Alex Villací­s Lasso
Ansgar Becker escribió: Hi there, I'm Ansgar Becker, the main-author of HeidiSQL. I saw that HeidiSQL is in your appdb! very cool ;) http://appdb.winehq.org/appview.php?iAppId=3326 However, some of the buttons on HeidiSQL's main-toolbar are twisted. I'm not a C programmer, so I'm a bit

Re: oleaut32: Add 64-bit proxy/stub code for core COM interfaces

2006-10-06 Thread Mike McCormack
Ge van Geldorp wrote: Changelog: Ge van Geldorp [EMAIL PROTECTED] - Add 64-bit proxy/stub code for core COM interfaces It's unlikely that this patch will be accepted. It's better to fix widl to generate the 64bit code rather than add more midl generated code. Mike

Re: [PATCH 1/5] lz32/tests: Test more last errors set by LZOpenFile[AW].

2006-10-06 Thread Vitaliy Margolen
Saulius Krasuckas wrote: * On Thu, 5 Oct 2006, Vitaliy Margolen wrote: Unless Alexandre confirms the requirement directly. In such case I am going to put this stuff into our Wiki ^^ even write a patch for cleaning the calls myself ;) No wonder people can't get _any_ response to their