Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread Mike McCormack
Alexandre Julliard wrote: Peter Beutner <[EMAIL PROTECTED]> writes: Besides i think it's a bad idea to blindly mark pages executable like this: "hey, we successfully catched an attempted buffer overflow attack, thanks for NX. But lets ignore it and let the code run anyway ..." :p Well, the

Re: d3d8/wined3d [5]: Create implicit surfaces with refcount 0.

2006-11-15 Thread Markus Amsler
Stefan Dösinger wrote: Currently our CreateTexture(surface, vertexbuffer, ...) increases the device refcount and initializes the refcount to 1. In my eyes it would be cleaner to init the refcount of everything to 0, and if the interface is not implicit AddRef it(from 0 to 1) in Create*. In AddR

Re: wined3d [3]: Add IsImplicit/SetImplicit surface functions.

2006-11-15 Thread Markus Amsler
Stefan Dösinger wrote: Does wined3d have to know if the surface is implicit? Wouldn't it be sufficient to just store it in the d3d8/9 surface? This would avoid adding more complexity to wined3d. The problem is the implicit surface (IS) destruction in wined3d (device and swapchain). Release won'

Re: wined3d [3]: Add IsImplicit/SetImplicit surface functions.

2006-11-15 Thread Stefan Dösinger
Am Mittwoch 15 November 2006 23:33 schrieb Markus Amsler: > --- > dlls/wined3d/surface.c | 14 ++ > dlls/wined3d/surface_gdi.c |2 ++ > dlls/wined3d/wined3d_private.h |3 +++ > include/wine/wined3d_interface.h |4 > 4 files changed, 23 insertio

Re: d3d8/wined3d [5]: Create implicit surfaces with refcount 0.

2006-11-15 Thread Stefan Dösinger
Am Mittwoch 15 November 2006 23:35 schrieb Markus Amsler: > Depends on [1]. > This fixes all d3d8 implicit surface refcount problems. > if (This->parentDevice && ref == 1) { > if (implicit) { > IUnknown_AddRef(This->parentDevice); > } else { > /* This can only happen on dev

Re: shlwapi: Cast-qual warnings fix (2 of 4)

2006-11-15 Thread Dimi Paun
On Wed, November 15, 2006 5:02 pm, Andrew Talbot wrote: > - static const WCHAR szProperty[] = { > + static WCHAR szProperty[] = { '{','D','0','F','C','A','4','2','0', If they aren't constant, shouldn't they be non-static too? -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc.

Re: winequartz.drv: Second glance at Window support.

2006-11-15 Thread Detlef Riekenberg
On Mo, 2006-11-13 at 20:32 +0100, Pierre d'Herbemont wrote: > +++ b/dlls/winequartz.drv/carbon_imports.h > +++ b/dlls/winequartz.drv/quartzdrv_carbon.c You are using various "fprintf(stderr, ..." here. Please use: #include "wine/debug.h" ERR(...) -- By by ... Detlef

Re: winequartz.drv: Second glance at Window support.

2006-11-15 Thread Detlef Riekenberg
On Mo, 2006-11-13 at 20:32 +0100, Pierre d'Herbemont wrote: > +void CARBON_HideWindow(WindowRef win) > +{ > +if (carbonPtr_ShowWindow) carbonPtr_ShowWindow(win); > +} This looks like a Copy & Paste bug. -- By by ... Detlef

Re: Coverity reports on possible overruns of static arrays

2006-11-15 Thread Eric Pouech
Paul Vriens a écrit : Hi, we have quite a few places in the code where we do: WCHAR param[any-value]; len = sizeof(param) / sizeof(WCHAR); param[len] = '\0'; and of course more-or-less the same for CHAR arrays. This could lead (and the example does) to writing behind the end of param. I've

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread L. Rahyen
> Well, the next step can be to pop up a message box of some kind, and > let the user decide whether to proceed or not. It still gives more > control than blindly making all pages executable from the start... This is only acceptable if it pop ups only once for each application by default

Re: localspl: Implement ConfigurePort (API-doc are my own words)

2006-11-15 Thread Detlef Riekenberg
> Changelog: > - localspl: Implement ConfigurePort Forgot to mention: I did the Function-Description with my own words (same for winspool.drv a while ago) -- By by ... Detlef

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread L. Rahyen
On Wednesday November 15 2006 19:25, Marcus Meissner wrote: > This is incorrect, even with NX most applications will work. Only those with > broken PE headers like above will not. For me (at least) this is correct. Most of my application crashes. Even classical games like Unreal Tournamen

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread L. Rahyen
On Wednesday November 15 2006 19:25, Marcus Meissner wrote: > In this case we should perhaps try to detect such applications and mark > them executable accordingly. > > (Like... "does any section has exec flag? if not ... make all of them > exec") If we implement pop up then this isn't nec

Re: Debugging solidworks 2006

2006-11-15 Thread Jaap Stolk
On 11/15/06, Kartik Thakore <[EMAIL PROTECTED]> wrote: After doing the suggested tactis it still failed but with fewer errors: Did you already setup a bug number for this? what number? It would be best to attach log outputs to the bug report. Doesn't Solidworks use the (Macromedia) Safecast co

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread Peter Beutner
Alexandre Julliard schrieb: > Peter Beutner <[EMAIL PROTECTED]> writes: > >> Alexandre Julliard schrieb: >>> Peter Beutner <[EMAIL PROTECTED]> writes: >>> Besides i think it's a bad idea to blindly mark pages executable like this: "hey, we successfully catched an attempted buffer ov

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread Marcus Meissner
On Wed, Nov 15, 2006 at 06:09:40PM +, L. Rahyen wrote: > > So for fixing some _broken_ applications this patch unconditionally > > disables nx protection for every application running under wine. Seems like > > a bad tradeoff imo. (Though I don't know how widespread these kind of > > broken app

Re: Add small comment to function

2006-11-15 Thread James Hawkins
On 11/15/06, Anatoly <[EMAIL PROTECTED]> wrote: Hi! This fix add comment in cosole.c Changelog: Add comment for function GetConsoleWindow in console.c (../dlls/kernel32/console.c) Please read [1] to learn how to write API documentation for Wine. Also, this looks like you copied the documentat

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread Peter Beutner
L. Rahyen schrieb: >> So for fixing some _broken_ applications this patch unconditionally >> disables nx protection for every application running under wine. Seems like >> a bad tradeoff imo. (Though I don't know how widespread these kind of >> broken applications are. But there are definitly appli

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread Alexandre Julliard
Peter Beutner <[EMAIL PROTECTED]> writes: > Alexandre Julliard schrieb: >> Peter Beutner <[EMAIL PROTECTED]> writes: >> >>> Besides i think it's a bad idea to blindly mark pages executable like this: >>> >>> "hey, we successfully catched an attempted buffer overflow attack, thanks >>> for NX. Bu

HLSL2GLSL

2006-11-15 Thread Ian Macfarlane
ATI has released software called HLSL2GLSL which converts D3D9 High Level Shader Language (HLSL) into the OpenGL equivalent GLSL. It's open source, and appears to be under a BSD license, so may be possible to integrate into WINE (I'm not sure if it's old or new BSD license). The source code is h

Success story with Wine

2006-11-15 Thread Darryl Dixon
Hi All, Just a quick note to say thanks to the Devs for the incredible job that you are doing on the march to 1.0. I have been following Wine development for many many years, and the progress in the last year is truly extraordinary. Earlier today I fired up my copy of Firefox 1.5.0.7 for Wind

Re: Debugging solidworks 2006

2006-11-15 Thread Kartik Thakore
After doing the suggested tactis it still failed but with fewer errors: Here is the output " fixme:msvcrt:MSVCRT__wsetlocale 4 L"English_United States.1252" fixme:msvcrt:MSVCRT__wsetlocale 4 L"C" fixme:msvcrt:MSVCRT__wsetlocale 4 L"English_United States.1252" fixme:msvcrt:MSVCRT__wsetlocale 4 L"

Re: OLE Automatization Linux's OpenOffice from wine app

2006-11-15 Thread Alexandr Kochmin
DK> Kochmin wrote: DK>> I have windows application wich use OLE Automatization to fill-in DK>> OpenOffice document It's create OleObject like DK>> OpenOffice := CreateOleObject('com.sun.star.ServiceManager'); DK>> .. DK>> How can I rewrite it, or use any tools, to work when OpenOffice is DK>> inst

HLSL2GLSL

2006-11-15 Thread Ian Macfarlane
ATI has released software called HLSL2GLSL which converts D3D9 High Level Shader Language (HLSL) into the OpenGL equivalent GLSL. It's open source, and appears to be under a BSD license, so may be possible to integrate into WINE (I'm not sure if it's old or new BSD license). The source code is h

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread Peter Beutner
Alexandre Julliard schrieb: > Peter Beutner <[EMAIL PROTECTED]> writes: > >> Besides i think it's a bad idea to blindly mark pages executable like this: >> >> "hey, we successfully catched an attempted buffer overflow attack, thanks >> for NX. But lets >> ignore it and let the code run anyway ...

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread Alexandre Julliard
Peter Beutner <[EMAIL PROTECTED]> writes: > Besides i think it's a bad idea to blindly mark pages executable like this: > > "hey, we successfully catched an attempted buffer overflow attack, thanks for > NX. But lets > ignore it and let the code run anyway ..." :p Well, the next step can be to p

Re: HLSL2GLSL

2006-11-15 Thread Roderick Colenbrander
Hi, Unfortunately ATI's project is not that usefull for Wine. In case of Direct3D9 the hlsl shader part is implemented by the d3dx9_xx dlls. For instance you let the helper dll open a shader file and then later on it outputs directx shader assembly. A programmer then feeds this data to standard

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread L. Rahyen
> So for fixing some _broken_ applications this patch unconditionally > disables nx protection for every application running under wine. Seems like > a bad tradeoff imo. (Though I don't know how widespread these kind of > broken applications are. But there are definitly applications out there > whi

Coverity reports on possible overruns of static arrays

2006-11-15 Thread Paul Vriens
Hi, we have quite a few places in the code where we do: WCHAR param[any-value]; len = sizeof(param) / sizeof(WCHAR); param[len] = '\0'; and of course more-or-less the same for CHAR arrays. This could lead (and the example does) to writing behind the end of param. I've submitted two patches f

Re: localspl: Implement ConfigurePortW

2006-11-15 Thread Detlef Riekenberg
On Di, 2006-11-14 at 15:39 -0800, Juan Lang wrote: > Hi Detlef, > > +IDS_NOTHINGTOCONFIG "This Port has no Options to configure" > > This should be "This port has no options to configure." Thanks. I build an updated patch. -- By by ... Detlef

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread Peter Beutner
Marcus Meissner schrieb: > On Wed, Nov 15, 2006 at 05:58:44PM +0100, Peter Beutner wrote: >> Mike McCormack schrieb: >>> --- >>> >>> This should fix bug #6622. >> The application in question doesn't crash because it needs an executable >> stack, but because the >> PE image header of the exe is tot

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread Marcus Meissner
On Wed, Nov 15, 2006 at 05:58:44PM +0100, Peter Beutner wrote: > Mike McCormack schrieb: > > --- > > > > This should fix bug #6622. > > The application in question doesn't crash because it needs an executable > stack, but because the > PE image header of the exe is totally broken, no section is

Re: loader: Mark the stack as executable if possible.

2006-11-15 Thread Peter Beutner
Mike McCormack schrieb: > --- > > This should fix bug #6622. The application in question doesn't crash because it needs an executable stack, but because the PE image header of the exe is totally broken, no section is marked as executable there at all. Wine does exactly what it should do here(sa

Re: ntdll: prevent test from crashing on amd64

2006-11-15 Thread Peter Beutner
Marcus Meissner schrieb: > On Mon, Nov 13, 2006 at 08:54:33AM +0100, Peter Beutner wrote: >> Putting code in the .data section means it will be mapped RW only, causing >> segfaults when trying to execute it (at least on NX-capable systems). >> >> As a quick workaround mark it const, i.e. put it int

HLSL2GLSL

2006-11-15 Thread Ian Macfarlane
ATI has released software called HLSL2GLSL which converts D3D9 High Level Shader Language (HLSL) into the OpenGL equivalent GLSL. It's open source, and appears to be under a BSD license, so may be possible to integrate into WINE (I'm not sure if it's old or new BSD license). The source code is h

Re: user32: Update the edit control when the IME composition string is emptied.

2006-11-15 Thread Michael Stefaniuc
Hello, Byeong-Sik Jeon wrote: > I tested for this patch with the patched Xlib(XFilterEvent deadlock > problem with XInitThreads). > https://bugs.freedesktop.org/show_bug.cgi?id=1182 > https://bugs.freedesktop.org/attachment.cgi?id=4874 > > Changelog: > Update the edit control when the "IME c

Re: Debugging solidworks 2006

2006-11-15 Thread Andrey Turkin
First thing to do is to open bug at bugs.winehq.org and describe your problem there. Then, please try to: 1) copy msimtf.dll from Windows to your wine's system32, register it with regsvr32 and try if Solid Works issue persists 2) copy atl.dll from Windows to your wine's system32, register it and

Re: RFC: d3d8 refcount implementation

2006-11-15 Thread Stefan Dösinger
Hi, Maybe its the best way not to construct the implicit surfaces in d3d8 at device creation time, only its wined3d counterpart(with parent = NULL). When GetBackBuffer or whatever is called, the wined3d backbuffer is returned, and a d3d8 surface created for it. The wined3d surface gets the d3d8/