Re: [5/5] usp10: remote todo_wine

2006-12-15 Thread Matt Finnicum
I think that what James Hawkins had meant something like this: Apply patch one, run the tests. If patch one fixed any of them, remove the todo_wine's for those tests as a part of patch one. Otherwise, leave them todo_wine. Apply patch two, run the tests. If patch two fixed any of them, remove th

Re: [AppDB] Add generic sound help (resend)

2006-12-15 Thread Chris Morgan
Is it ok if we link to this entry in the Wine documentation instead: http://winehq.org/site/docs/wineusr-guide/config-wine-main#AEN282 Chris On Friday 15 December 2006 12:27 pm, Alexander Nicolaysen Sørnes wrote: > (I assume this was overlooked.) > > Add a paragraph about sound problems on the

Re: [1] WineD3D: Add the state dirtification infrastructure

2006-12-15 Thread Stefan Dösinger
Am Freitag 15 Dezember 2006 18:31 schrieb Stefan Dösinger: > This patch adds the dirty list infrastructure. A dirty marker consists of a > DWORD containing the state it marks dirty, and the list structure to build > the list. > > The wined3ddevice has 3 new members: > dirtyStateList: The list of di

Re: [5/5] usp10: remote todo_wine

2006-12-15 Thread Clinton Stimpson
Ok. There are 4 functions that have to be implemented at the same time in order to not break any tests, because of how the tests were written. A few days ago, I sent a single patch that implemented those 4 functions, including an update of the tests. It wasn't accepted, and it was suggested to b

Re: usp10: fix tests to allow atomic patches for new implementation

2006-12-15 Thread Clinton Stimpson
James Hawkins wrote: On 12/15/06, Clinton Stimpson <[EMAIL PROTECTED]> wrote: Hi, Here's a patch to make unimplemented functions return E_NOTIMPL instead of S_OK. Even dependent functions already return E_NOTIMPL. Also fixing tests to check that the return value is S_OK before testing the 'ou

Re: [5/5] usp10: remote todo_wine

2006-12-15 Thread Clinton Stimpson
I can change the tests a bit, and change the currently empty functions to return E_NOTIMPL instead of S_OK. Then I can do it piecemeal. Is that how y'all want it? Clint Clinton Stimpson wrote: Ok. There are 4 functions that have to be implemented at the same time in order to not break any tes

Re: msi: Enable cab compression and delete any resulting cabs using SHFileOperation

2006-12-15 Thread Alexandre Julliard
"James Hawkins" <[EMAIL PROTECTED]> writes: > +static void delete_cab_files(void) > +{ > +SHFILEOPSTRUCT shfl; > +CHAR path[MAX_PATH]; > + > +lstrcpyA(path, CURR_DIR); > +lstrcatA(path, "\\*.cab\0"); > + > +shfl.hwnd = NULL; > +shfl.wFunc = FO_DELETE; > +shfl.pFrom = (L

Re: configure: add ncursesw detecting [try 2]

2006-12-15 Thread Alexandre Julliard
Vitaly Lipatov <[EMAIL PROTECTED]> writes: > We can't get correct non latin output in utfed console with normal ncurses. > As > far as I know there is some problems in normal ncurses with utf8 (multbyte > symbols)... Only ncursesw supports utf8 output correctly (and wide char)... I > am wrong?

Re: configure: add ncursesw detecting [try 2]

2006-12-15 Thread Vitaly Lipatov
В сообщении от 15 декабря 2006 13:39 Alexandre Julliard написал(a): > Vitaly Lipatov <[EMAIL PROTECTED]> writes: > > Try 2, with ncursesw/ncurses detecting > > In order to build wineconsole run properly in utf8 locale, we use > > ncursesw, which can handle wchar strings. > > Why would you need wcha

Re: ddraw: Fix warnings

2006-12-15 Thread Stefan Dösinger
Am Freitag 15 Dezember 2006 13:16 schrieb Dmitry Timoshkov: > "Stefan Dösinger" <[EMAIL PROTECTED]> wrote: > > > -TRACE("(%p) : incrementing IDirectDraw4 refcount from %lu.\n", > > > This, ref -1); +TRACE("(%p) : incrementing IDirectDraw4 refcount > > > from %u.\n", This, ref -1); > > > > S

Re: ddraw: Fix warnings

2006-12-15 Thread Dmitry Timoshkov
"Stefan Dösinger" <[EMAIL PROTECTED]> wrote: > -TRACE("(%p) : incrementing IDirectDraw4 refcount from %lu.\n", This, ref -1); > +TRACE("(%p) : incrementing IDirectDraw4 refcount from %u.\n", This, ref -1); Sorry I forgot to check your original patch for this, but did you check if the I

Re: ddraw: Fix warnings

2006-12-15 Thread Stefan Dösinger
Am Freitag 15 Dezember 2006 08:02 schrieb Dmitry Timoshkov: > Hello, > > Changelog: > ddraw: Fix warnings. > > --- > dlls/ddraw/ddraw_thunks.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/ddraw/ddraw_thunks.c b/dlls/ddraw/ddraw_thunks.c > index ef8af6b.

Re: configure: add ncursesw detecting [try 2]

2006-12-15 Thread Alexandre Julliard
Vitaly Lipatov <[EMAIL PROTECTED]> writes: > Try 2, with ncursesw/ncurses detecting > In order to build wineconsole run properly in utf8 locale, we use ncursesw, > which can handle wchar strings. Why would you need wchar strings if you use utf-8? Have you configured your locale properly? -- A