Re: [comctl32] MonthCalendar - Fix wrong date selected when clicknext/prev months day (#6967)

2006-12-25 Thread Dmitry Timoshkov
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: - retval = *daypos + (7 * *weekpos) - firstDay; + retval = *daypos + ((7 * *weekpos) - firstDay); return retval; } This change doesn't make any difference, neither in functionality, nor in readability IMO. Please avoid this kind of changes, it

Re: [Winmm/winealsa] Don't use asynchronous callbacks in dsound any more

2006-12-25 Thread Eric Pouech
Maarten, nice work on Alsa (which is definitively needed !!) a couple of comments: - I know the winmm code (and drivers) is crippled by bad synchronisation tricks (like cleaning a field in a structure to signal a thread). This is bad (TM). So I'd suggest using here a real synchronisation

Re: Building a full win32 winetest.exe

2006-12-25 Thread Hans Leidekker
On Monday 25 December 2006 11:22, Paul Vriens wrote: These are the MinGW packages I'm currently using: mingw-binutils-2.16.91-9hl mingw-w32api-3.6-18hl mingw-gcc-core-3.4.5-13hl mingw-runtime-3.9-18hl I think I'll get around to building a new set of RPMs this week. Lets go for a Wine 1.0

Re: [comctl32] MonthCalendar - Fix wrong date selected when clicknext/prev months day (#6967)

2006-12-25 Thread Vijay Kiran Kamuju
Hi, On 12/25/06, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: - retval = *daypos + (7 * *weekpos) - firstDay; + retval = *daypos + ((7 * *weekpos) - firstDay); return retval; } This change doesn't make any difference, neither in

Re: [comctl32] MonthCalendar - Fix wrong date selected whenclicknext/prev months day (#6967)

2006-12-25 Thread Dmitry Timoshkov
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: -return TRUE; +/*return TRUE;*/ If you are not sure that the return should be removed, it's a sign that you need a test case, just commenting it out without any explanation is not a solution. Same comment to all other similar cases.

Re: [2/2] wined3d: Restore texture bindings in the FBO code

2006-12-25 Thread Stefan Dösinger
Am 25.12.2006 um 17:12 schrieb H. Verbeet: Previously all textures were (re)bound each DrawPrimitive call. With the new state management only dirty textures are bound, so we need to restore the texture binding if we change it. Changelog: - Restore texture bindings in the FBO code

Re: [2/2] wined3d: Restore texture bindings in the FBO code

2006-12-25 Thread H. Verbeet
On 25/12/06, Stefan Dösinger [EMAIL PROTECTED] wrote: Why are you not using glPushAttrib / glPopAttrib? The relevant bit to push would be GL_TEXTURE_BIT, but that pushes the bindings for all texture units and pretty much all related state, ie glTexParameter glTexEnv state. Since we're only

dlls/kernel32/tests: test failure in locale.c

2006-12-25 Thread Claudio Fontana
Hello, while tweaking other things in kernel32, I noticed that latest version fails a test in locale.c: $ cd dlls/kernel32/tests $ make test ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so locale.c touch locale.ok locale.c:1990: Test failed: Enumerated grp

Re: kernel32 (profile.c): current section and key implementation

2006-12-25 Thread Claudio Fontana
Hello Robert, On 12/24/06, Robert Shearman [EMAIL PROTECTED] wrote: Hi Claudio, The patch looks good, apart from the specific version check for win95. Do you think you could add some tests to our test framework (dlls/kernel32/tests) to test for this issue that you've found. Then the tests

more meaningful traces?

2006-12-25 Thread Lei Zhang
Hi, I noticed several files in dlls/winmm have a getMessage() function to translate message numbers to message names. This is extremely helpful for debug traces, where one can immediately see the name of the messages sent, instead of wondering what 0x105 is. So my question is, why is winmm the

adding a data point to ALSA vs Wine sound discussion

2006-12-25 Thread Molle Bestefich
Adding a data point to the ALSA and Wine sound discussion. ALSA has a general problem with: * Doubling volume * Playing sound bites two times when it doesn't receive data fast enough from an application. I tried playing a video file over a network using a non-wine player, then paused the