Re: tests/msi.c fails when run twice on Wine?

2007-07-30 Thread Paul Vriens
James Hawkins wrote: On 7/27/07, Paul Vriens [EMAIL PROTECTED] wrote: Hi, The msi test currently fails for me on Wine when run the second time after getting a clean environment: rm -rf ~/.wine make msi.ok msi: 101 tests executed (0 marked as todo, 0 failures), 0 skipped. rm msi.ok make

Re: [advapi32/tests] Use skip when we don't have enough rights

2007-07-30 Thread Edwin Smulders
This is a little offtopic, but the extra testresults might be because the test link was posted in the comments of a well-known dutch computer site (in dutch) http://tweakers.net/meuktracker/15817/Wine-0.9.42.html I thought you might want to know, and I'll try to link the test more often there :)

Re: [PATCH] winecfg: Add trackbar to set screen resolution in graphics tab (try 2)

2007-07-30 Thread Alexandre Julliard
Nigel Liang [EMAIL PROTECTED] writes: +/* Utility functions to convert between WCHAR and long */ +long wcstolong(WCHAR * wcs) +{ +int i; +long lRet = 0; +BOOL bNeg = FALSE; + +for (i = 0; wcs[i] != '\0'; i++) { +if (i == 0 wcs[i] == '-') { +bNeg =

Re: [PATCH 3/5] winecfg: Make winecfg resources compilable by aWindows resource compiler

2007-07-30 Thread Dmitry Timoshkov
Steven Edwards [EMAIL PROTECTED] wrote: In this case do you mean windres or rc? I ask because if its rc then shouldn't we fix wrc to not accept these sources also? If its windres thats broken I think there is a workaround for the problem. This patch is aimed to make winecfg resources

Re: msvcr80 support!

2007-07-30 Thread Stefan Dösinger
Did you find a fix for this? As per Alexandre's suggestion I tried installing native common controls, and also copying all the manifest files from a Windows machine (even the whole winsxs directory), but I still get the same error as you when I try to run my application. No, I didn't find a

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.

2007-07-30 Thread Paul Vriens
Hans Leidekker wrote: These APIs were introduced with Vista. -Hans Changelog Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime. Hi Hans, I was going through some test failures (already

Re: [PATCH 3/5] winecfg: Make winecfg resources compilable by aWindows resource compiler

2007-07-30 Thread Frank Richter
On 30.07.2007 16:37, Dmitry Timoshkov wrote: Steven Edwards [EMAIL PROTECTED] wrote: In this case do you mean windres or rc? I ask because if its rc then shouldn't we fix wrc to not accept these sources also? If its windres thats broken I think there is a workaround for the problem. This

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.

2007-07-30 Thread Hans Leidekker
On Monday 30 July 2007 16:58:59 Paul Vriens wrote: It appears that a lot of the used strings, like System Up Time is depending on the locale. Some Dutch tests show Systeem ingeschakeld instead. Any idea how to fix that? Another thing is that pdh.dll is not by default present on NT4 and

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.

2007-07-30 Thread Alexandre Julliard
Paul Vriens [EMAIL PROTECTED] writes: Another thing is that pdh.dll is not by default present on NT4 and below so the tests have to be changed to cope with that as well. Should I have a go at that? It may be a good idea to add generic support for that in winetest. It's a bit silly to have to

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.

2007-07-30 Thread Paul Vriens
Alexandre Julliard wrote: Paul Vriens [EMAIL PROTECTED] writes: Another thing is that pdh.dll is not by default present on NT4 and below so the tests have to be changed to cope with that as well. Should I have a go at that? It may be a good idea to add generic support for that in winetest.

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.

2007-07-30 Thread Alexandre Julliard
Paul Vriens [EMAIL PROTECTED] writes: And how would you do that? The first thing that winetest does is go through all the tests to retrieve all the subtests. If it finds a missing dll (or depending dll) we could/should catch that and not run the tests. Is it as simple as that? Well, since

Re: msvcr80 support!

2007-07-30 Thread Kovács András
Hi, Msn live messenger can be started by commenting out @ stdcall FindActCtxSectionStringA(long ptr long str ptr) @ stdcall FindActCtxSectionStringW(long ptr long wstr ptr) lines from kernel32.spec file. By the way it needs native gdiplus.dll, otherwise you won't get it's

Re: [PATCH 3/5] winecfg: Make winecfg resources compilable by aWindows resource compiler

2007-07-30 Thread Dmitry Timoshkov
Frank Richter [EMAIL PROTECTED] wrote: What's the actual problem? rc simply doesn't handle \ or constructs. Also, wouldn't it be nicer to devise a fix that retains the “fancy” quote characters, instead of replacing them with boring 's? The problem is that those characters don't exist in

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.

2007-07-30 Thread Paul Vriens
Alexandre Julliard wrote: Paul Vriens [EMAIL PROTECTED] writes: And how would you do that? The first thing that winetest does is go through all the tests to retrieve all the subtests. If it finds a missing dll (or depending dll) we could/should catch that and not run the tests. Is it as

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.

2007-07-30 Thread Alexandre Julliard
Paul Vriens [EMAIL PROTECTED] writes: I'll have a look. How do yo want to report a missing test? In the normal report file? If that's the case we should also change the dissect/gather scripts: It has to be part of the report data, so yes the scripts probably need to be updated. If this

Re: [PATCH 3/5] winecfg: Make winecfg resources compilable by aWindows resource compiler

2007-07-30 Thread Frank Richter
On 30.07.2007 18:54, Dmitry Timoshkov wrote: Frank Richter [EMAIL PROTECTED] wrote: What's the actual problem? rc simply doesn't handle \ or constructs. Hm, I have some .rc files here with that work just fine with MS' rc. (Tho maybe it's braindead enough to have it supportted in one

Re: tests/msi.c fails when run twice on Wine?

2007-07-30 Thread James Hawkins
On 7/30/07, Paul Vriens [EMAIL PROTECTED] wrote: James Hawkins wrote: On 7/27/07, Paul Vriens [EMAIL PROTECTED] wrote: Hi, The msi test currently fails for me on Wine when run the second time after getting a clean environment: rm -rf ~/.wine make msi.ok msi: 101 tests

Re: tests/msi.c fails when run twice on Wine?

2007-07-30 Thread Paul Vriens
James Hawkins wrote: On 7/30/07, Paul Vriens [EMAIL PROTECTED] wrote: James Hawkins wrote: On 7/27/07, Paul Vriens [EMAIL PROTECTED] wrote: Hi, The msi test currently fails for me on Wine when run the second time after getting a clean environment: rm -rf ~/.wine make msi.ok msi: 101

Re: tests/msi.c fails when run twice on Wine?

2007-07-30 Thread Juan Lang
It's still strange though that it doesn't happen on your box (you are the only one that came back, and of course Alexandre cause I guess he runs the tests every time before he commits something). It also succeeds when running twice here. (make install.ok hangs here, though.) --Juan

Re: [PATCH] winecfg: Add trackbar to set screen resolution in graphics tab (try 2)

2007-07-30 Thread Nigel Liang
On 7/30/07, Alexandre Julliard [EMAIL PROTECTED] wrote: Nigel Liang [EMAIL PROTECTED] writes: +/* Utility functions to convert between WCHAR and long */ +long wcstolong(WCHAR * wcs) +{ +int i; +long lRet = 0; +BOOL bNeg = FALSE; + +for (i = 0; wcs[i] != '\0'; i++)

Linuxworld BOF?

2007-07-30 Thread Dan Kegel
Anyone going to Linuxworld in San Francisco next week? It's free to go to the exhibits and BOFs if you register in advance; go here to register (and scroll to the bottom for the exhibit-only free choice): http://linuxworldexpo.com/live/12/TB296182 I'm probably going to hang out in the exhibit

Re: tests/msi.c fails when run twice on Wine?

2007-07-30 Thread Paul Vriens
Juan Lang wrote: It's still strange though that it doesn't happen on your box (you are the only one that came back, and of course Alexandre cause I guess he runs the tests every time before he commits something). It also succeeds when running twice here. (make install.ok hangs here, though.)

Re: tests/msi.c fails when run twice on Wine?

2007-07-30 Thread James Hawkins
On 7/30/07, Paul Vriens [EMAIL PROTECTED] wrote: Juan Lang wrote: It's still strange though that it doesn't happen on your box (you are the only one that came back, and of course Alexandre cause I guess he runs the tests every time before he commits something). It also succeeds when

Re: tests/msi.c fails when run twice on Wine?

2007-07-30 Thread Paul Vriens
James Hawkins wrote: On 7/30/07, Paul Vriens [EMAIL PROTECTED] wrote: Juan Lang wrote: It's still strange though that it doesn't happen on your box (you are the only one that came back, and of course Alexandre cause I guess he runs the tests every time before he commits something). It also

Re: [inkobj 2/2] Add stub test for inkobj.dll Try #2 with attachment

2007-07-30 Thread Paul Vriens
John Klehm wrote: Adds directory, makefile.in, and c file for simple test. This test tries to do LoadLibrary(inkobj.dll). I apologize for forgetting the attachment. Regards, John Hi, Are you planning on having

Re: [inkobj 2/2] Add stub test for inkobj.dll Try #2 with attachment

2007-07-30 Thread John Klehm
On 7/30/07, Paul Vriens [EMAIL PROTECTED] wrote: John Klehm wrote: Adds directory, makefile.in, and c file for simple test. This test tries to do LoadLibrary(inkobj.dll). I apologize for forgetting the attachment. Regards, John

Re: tests/msi.c fails when run twice on Wine?

2007-07-30 Thread Juan Lang
It also succeeds when running twice here. (make install.ok hangs here, though.) After a 'rm ~/.wine' ? Yes. Could this be a compiler/platform issue (difference). Perhaps. If you run 'WINEDEBUG=+msi make msi.ok' do you see garbage in the 'squished ...' output? No. --Juan

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-07-30 Thread Peter Dons Tychsen
On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote: Peter Dons Tychsen wrote: OK. Please review this diff: I will re-submit it if you like it. /Pedro Alright looks good now (you might want to remove the extra white space your patch adds - git complains about those). Just

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice

2007-07-30 Thread Peter Dons Tychsen
On Mon, 2007-07-30 at 21:20 +0200, Peter Dons Tychsen wrote: On Sun, 2007-07-29 at 17:43 -0600, Vitaliy Margolen wrote: Peter Dons Tychsen wrote: OK. Please review this diff: I will re-submit it if you like it. /Pedro Alright looks good now (you might want to remove the

winex11.drv compile failure

2007-07-30 Thread James Hawkins
Compile fails for me with today's git: opengl.c: In function 'ConvertAttribWGLtoGLX': opengl.c:676: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) opengl.c:676: error: (Each undeclared identifier is reported only once opengl.c:676: error: for each function it appears in.)

Re: wine3d3: Check the destination recangle when for FastBlt().

2007-07-30 Thread Peter Dons Tychsen
On Sun, 2007-07-29 at 23:08 +0200, Stefan Dösinger wrote: Am Sonntag, 29. Juli 2007 21:28 schrieb Peter Dons Tychsen: Hello Wine! I have fixed a small bug in FastBlt(), which caused Wine to crash if the application tried to do FastBlt() to a surface using a bad destination setup. The

Re: winex11.drv compile failure

2007-07-30 Thread H. Verbeet
On 30/07/07, James Hawkins [EMAIL PROTECTED] wrote: Compile fails for me with today's git: opengl.c: In function 'ConvertAttribWGLtoGLX': opengl.c:676: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) opengl.c:676: error: (Each undeclared identifier is reported only

Re: winex11.drv compile failure

2007-07-30 Thread Roderick Colenbrander
On Monday 30 July 2007 22:28, H. Verbeet wrote: On 30/07/07, James Hawkins [EMAIL PROTECTED] wrote: Compile fails for me with today's git: opengl.c: In function 'ConvertAttribWGLtoGLX': opengl.c:676: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) opengl.c:676:

Re: oleaut32: Constify some variables

2007-07-30 Thread Marcus Meissner
On Mon, Jul 30, 2007 at 09:27:45PM +0100, Andrew Talbot wrote: Changelog: oleaut32: Constify some variables. diff -urN a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c --- a/dlls/oleaut32/typelib.c 2007-07-30 17:23:19.0 +0100 +++ b/dlls/oleaut32/typelib.c 2007-07-30

build regression, GLX_RGBA_FLOAT_BIT_ARB undeclared?

2007-07-30 Thread Dan Kegel
I just did a git pull, and compilation is failing with opengl.c:676: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) I think that symbol reference was added just today: http://winehq.org/pipermail/wine-cvs/2007-July/034660.html and is supposed to come from glext.h. Do we

Re: build regression, GLX_RGBA_FLOAT_BIT_ARB undeclared?

2007-07-30 Thread Roderick Colenbrander
Could you update to the latest GIT? :) Roderick On Monday 30 July 2007 23:39, Dan Kegel wrote: I just did a git pull, and compilation is failing with opengl.c:676: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) I think that symbol reference was added just today:

Re: build regression, GLX_RGBA_FLOAT_BIT_ARB undeclared?

2007-07-30 Thread Dan Kegel
On 7/30/07, Roderick Colenbrander [EMAIL PROTECTED] wrote: Could you update to the latest GIT? :) Better, thanks!

Re: [PATCH] winecfg: Add menu font settings to desktop integration tab

2007-07-30 Thread Nigel Liang
On 7/27/07, Vitaliy Margolen [EMAIL PROTECTED] wrote: Nigel Liang wrote: On 7/25/07, Vitaliy Margolen [EMAIL PROTECTED] wrote: Nigel Liang wrote: diff --git a/programs/winecfg/En.rc b/programs/winecfg/En.rc index 5972c3b..e61bf29 100644 --- a/programs/winecfg/En.rc +++

About new environment variable

2007-07-30 Thread Zhongli Xu
After I add an environment avriable in the system.reg file, e.g. [System\\CurrentControlSet\\Control\\Session Manager\\Environment] 1185851455 MY_VARIABLE=VALUE I tried to read this variable thru the API GetEnvironmentVariable(), but it failed. Other variables, such as PATH, OS, are OK. Any idea

Re: [PATCH 3/5] winecfg: Make winecfg resources compilable by aWindows resource compiler

2007-07-30 Thread Dmitry Timoshkov
Frank Richter [EMAIL PROTECTED] wrote: What's the actual problem? rc simply doesn't handle \ or constructs. Hm, I have some .rc files here with that work just fine with MS' rc. rc doesn't support embedded or escaped quotes at all. So statements like LTEXT String with

Re: user32: erase parent when hiding child

2007-07-30 Thread Dmitry Timoshkov
Clinton Stimpson [EMAIL PROTECTED] wrote: ChangeLog: user32: erase parent when hiding child As I already pointed out erasing a parent is supposed to be done in the server. You need to look there why it doesn't happen and add a fix there. -- Dmitry.

Re: About new environment variable

2007-07-30 Thread Vitaliy Margolen
Zhongli Xu wrote: After I add an environment avriable in the system.reg file, e.g. Don't ever do that. Use regedit or proper registry API. Also do not crosspost. If you asking in user channel, then ask there. If you asking developers, then ask on wine-devel only. Vitaliy.