Re: user32 : Temporarily disable test for _WIN64.

2008-04-24 Thread Erik de Castro Lopo
Dmitry Timoshkov wrote: > I'll let you figure this out on your own, that's a helpful thing to learn. > user32 is not required for a simple "Hello World" app, isn't it? I didn't disable test for user32, I disabled a single test. That test was testing edit controls and I am 100% sure that ed

Re: [PATCH] advapi32: add more checks in CRYPT_CreateMachineGuid.

2008-04-24 Thread Lei Zhang
On Thu, Apr 24, 2008 at 10:42 PM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: > "Lei Zhang" <[EMAIL PROTECTED]> wrote: > > > > I'm getting a crash in CRYPT_CreateMachineGuid() with native > > rpcrt4.dll. This adds some checks to work around it. > > > > I assume that "native" == "win9x" in this cas

Re: [PATCH] advapi32: add more checks in CRYPT_CreateMachineGuid.

2008-04-24 Thread Dmitry Timoshkov
"Lei Zhang" <[EMAIL PROTECTED]> wrote: > I'm getting a crash in CRYPT_CreateMachineGuid() with native > rpcrt4.dll. This adds some checks to work around it. I assume that "native" == "win9x" in this case. > pRpcStringFree = GetProcAddress(lib, "RpcStringFreeW"); > +if (!pUuidCreate || !

Re: user32 : Temporarily disable test for _WIN64.

2008-04-24 Thread Dmitry Timoshkov
"Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > I has _WIN64, but if _WIN64 is defined then GWL_WNDPROC is undefined > and the test in dlls/user32/tests/edit.c fails to compile. I'll let you figure this out on your own, that's a helpful thing to learn. >> I assume that you have all other prob

Re: user32 : Temporarily disable test for _WIN64.

2008-04-24 Thread Erik de Castro Lopo
Dmitry Timoshkov wrote: > "Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > > > In include/winuser.h we have: > > > >#if !defined _WIN64 && !defined __WINESRC__ > ># define GWL_USERDATA(-21) > ># define GWL_ID (-12) > ># define GWL_HWNDPARENT (-8) > >

Re: "make test" - only four tests failing!

2008-04-24 Thread James Hawkins
On Thu, Apr 24, 2008 at 11:50 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > "make test" is pretty darn close to passing; > only four tests left to fix. (Oddly, different > sets fail depending on display mode.) > Details at the end of > http://bugs.winehq.org/show_bug.cgi?id=9916 > > Let's get th

"make test" - only four tests failing!

2008-04-24 Thread Dan Kegel
"make test" is pretty darn close to passing; only four tests left to fix. (Oddly, different sets fail depending on display mode.) Details at the end of http://bugs.winehq.org/show_bug.cgi?id=9916 Let's get these fixed before code freeze!

Re: Add an include/config.h variable WINE_IS_WIN64 which is 1 whenconfigured with --enable-win64 and 0 otherwise.

2008-04-24 Thread Erik de Castro Lopo
Dmitry Timoshkov wrote: > "Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > > > Add an include/config.h variable WINE_IS_WIN64 which is 1 when > > configured with --enable-win64 and 0 otherwise. > > It would be helpful to at least provide an explanation why yo need > this, and why _WIN64 macro

Re: user32 : Temporarily disable test for _WIN64.

2008-04-24 Thread Dmitry Timoshkov
"Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > In include/winuser.h we have: > >#if !defined _WIN64 && !defined __WINESRC__ ># define GWL_USERDATA(-21) ># define GWL_ID (-12) ># define GWL_HWNDPARENT (-8) ># define GWL_HINSTANCE (-6) >#

Re: ntdll : Do not error out on AMD-64 architecture when compiling win64.

2008-04-24 Thread Erik de Castro Lopo
Dmitry Timoshkov wrote: > "Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > > > +#if WINE_IS_WIN64 > > +if (nt->FileHeader.Machine == IMAGE_FILE_MACHINE_AMD64) > > +MESSAGE("Support for AMD-64 architecture in progress but not yet > > working\n"); > > +else > > +#endif > > What'

Re: Wine t-shirts?

2008-04-24 Thread Dan Kegel
James McKenzie <[EMAIL PROTECTED]> wrote: > At one time I was a supporter and tester for Project Odin and its > predecessors. Wow. I gave up on OS/2 Warp right from the git-go, when they shipped me 30 floppies instead of a cd-rom. I really wanted Microsoft to have competition, but I just couldn'

Re: ntdll : Do not error out on AMD-64 architecture when compiling win64.

2008-04-24 Thread Dmitry Timoshkov
"Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > +#if WINE_IS_WIN64 > +if (nt->FileHeader.Machine == IMAGE_FILE_MACHINE_AMD64) > +MESSAGE("Support for AMD-64 architecture in progress but not yet > working\n"); > +else > +#endif What's the point of this? -- Dmitry.

Re: Add an include/config.h variable WINE_IS_WIN64 which is 1 whenconfigured with --enable-win64 and 0 otherwise.

2008-04-24 Thread Dmitry Timoshkov
"Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > Add an include/config.h variable WINE_IS_WIN64 which is 1 whenconfigured with > --enable-win64 and 0 otherwise. It would be helpful to at least provide an explanation why yo need this, and why _WIN64 macro is not enough. -- Dmitry.

Re: user32 : Temporarily disable test for _WIN64.

2008-04-24 Thread Erik de Castro Lopo
Dmitry Timoshkov wrote: > "Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > > > The file dlls/user32/tests/edit.c currently doesn't compile when > > configured with --enable-win64 because GWL_WNDPROC (in include/winuser.h) > > is not defined when _WIN64 is defined. > > Then you need to fix the

Re: shel32/tests : Use LOWORD to extract rc from pointer.

2008-04-24 Thread Dmitry Timoshkov
"Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > -rc=(int)ShellExecute(NULL, operation, file, parameters, directory, > - SW_SHOWNORMAL); > +rc=LOWORD(ShellExecute(NULL, operation, file, parameters, directory, > + SW_SHOWNORMAL)); > >

Re: user32 : Temporarily disable test for _WIN64.

2008-04-24 Thread Dmitry Timoshkov
"Erik de Castro Lopo" <[EMAIL PROTECTED]> wrote: > The file dlls/user32/tests/edit.c currently doesn't compile when > configured with --enable-win64 because GWL_WNDPROC (in include/winuser.h) > is not defined when _WIN64 is defined. Then you need to fix the test instead of disabling it. -- Dmit

Re: Safedisc for 1.0+ ?

2008-04-24 Thread Vitaliy Margolen
TheBlunderbuss wrote: > It has just occurred to me that safedisc copy protection (bug 219!) > wasn't put on the Wine 1.0 task list. It's a pretty major bug and covers > a wide range of programs, with a wide range of safedisc versions. > Considering this, how should we plan for this implementa

Re: Wine t-shirts?

2008-04-24 Thread James McKenzie
Jeremy White wrote: >> http://kegel.com/wine/wine-penguin-corkscrew.png >> > > Jon Parshall is proud of his ability to draw those penguins, > and we'd gladly send that artwork to anyone that wanted to make a T-shirt. > > Note, though, that we felt we had to (very sadly) drop the penguin; it do

Safedisc for 1.0+ ?

2008-04-24 Thread TheBlunderbuss
    It has just occurred to me that safedisc copy protection (bug 219!) wasn't put on the Wine 1.0 task list. It's a pretty major bug and covers a wide range of programs, with a wide range of safedisc versions. Considering this, how should we plan for this implementation?

Re: dinput: Limit number of supported axis and buttons [try 2]

2008-04-24 Thread Vitaliy Margolen
Christoph Frick wrote: > On Thu, Apr 24, 2008 at 09:04:11AM -0600, Vitaliy Margolen wrote: > > ok, don't beat me on this one (i guess i could have asked this also for > try one): > >> +FIXME("Can't support %d axes. Clamping down to 16\n", >> newDevice->axes); >> ... >> +WARN("Can

Re: dnghelp : Fix pointer cast.

2008-04-24 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > > Make the pointer cast safe for Wine64. Please disregard this one as there is a better patch on the way. Cheers, Erik -- - Erik de Castro Lopo -

Re: [PATCH 06/12] widl: Create a statement object for import statements.

2008-04-24 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > Move the writing of include directives into the generated header into > header.c. This one doesn't work right, it doesn't output the #include statements so the resulting .h files don't compile. -- Alexandre Julliard [EMAIL PROTECTED]

Call for testers

2008-04-24 Thread Eric Pouech
Has you may have seen, a new rendering interface is now available for Winhelp It should be better (with the last row of patches) than the old one, but still not perfect And likely not bug free, hence the call for testers I'm waiting for some real feedback from real users about reading your old

Re: dinput: Limit number of supported axis and buttons [try 2]

2008-04-24 Thread Christoph Frick
On Thu, Apr 24, 2008 at 09:04:11AM -0600, Vitaliy Margolen wrote: ok, don't beat me on this one (i guess i could have asked this also for try one): > +FIXME("Can't support %d axes. Clamping down to 16\n", > newDevice->axes); > ... > +WARN("Can't support %d buttons. Clamping down

Re: SOC 2008 Projects Announced

2008-04-24 Thread RazZziel
> Could the students come forward and say something about themself? Hi there I'm from Spain and I'm supposed to hack DirectPlay support up until wine can fully run at least GTA2 multiplayer out of the box, but I hope to have time enough to give some love to other dplay games. I'll try not to hav

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-24 Thread Alexandre Julliard
"Steven Edwards" <[EMAIL PROTECTED]> writes: > On Thu, Apr 24, 2008 at 5:36 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: >> You certainly don't want to call through explorer for that, showing a >> message box directly is fine. You have to be careful to only do it when >> loading the main e

Re: dinput: Limit number of supported axis and buttons

2008-04-24 Thread Vitaliy Margolen
Christoph Frick wrote: > On Thu, Apr 24, 2008 at 08:06:07AM -0600, Vitaliy Margolen wrote: > >> +FIXME("Can't support %d axis. Clamping down to 16\n", >> newDevice->axes); >FIXME("Can't support %d axes. Clamping down to 16\n", > newDevice->axes); > Thanks for catching it. F

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-24 Thread Steven Edwards
On Thu, Apr 24, 2008 at 5:36 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > You certainly don't want to call through explorer for that, showing a > message box directly is fine. You have to be careful to only do it when > loading the main exe, not for any random dll load; also you have to >

Re: mshtml #5: Added more IDispatchEx tests.

2008-04-24 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > mshtml.tlb needs to be rebuilt after "mshtml.idl: Added > DispHTMLUnknownElement declaration." patch. make depend is not enough. I see, make depend needs to be fixed. I'll have a look. -- Alexandre Julliard [EMAIL PROTECTED]

Re: winmm/tests: waveOutGetDevCaps called with invalid size

2008-04-24 Thread Peter Åstrand
> > > There are only two options: only pass the number of bytes requested > > > or return an error for unreasonable sizes. What is Terminal Server > > > doing? > > > > It's returning an error. > > > And what is the error? If you know the error code returned, Ill add it > to the code so we

Re: mshtml #5: Added more IDispatchEx tests.

2008-04-24 Thread Jacek Caban
Alexandre Julliard wrote: > Jacek Caban <[EMAIL PROTECTED]> writes: > > >> dlls/mshtml/tests/dom.c | 56 >> +++ >> 1 files changed, 37 insertions(+), 19 deletions(-) >> > > It doesn't work here: > > ../../../tools/runtest -q -P wine -M mshtml.d

Re: dinput: Limit number of supported axis and buttons

2008-04-24 Thread Christoph Frick
On Thu, Apr 24, 2008 at 08:06:07AM -0600, Vitaliy Margolen wrote: > +FIXME("Can't support %d axis. Clamping down to 16\n", > newDevice->axes); FIXME("Can't support %d axes. Clamping down to 16\n", newDevice->axes); -- cu pgpCuOEwa3C1c.pgp Description: PGP signature

Re: [1/7] D3D9: Make the offscreen format test a bit more tolerant

2008-04-24 Thread H. Verbeet
2008/4/24 Stefan Dösinger <[EMAIL PROTECTED]>: > FWIW, for my texop test I wrote a function to do this in a generic way. I'll probably submit that in the next few days.

Re: [3/4] user32: Set the vkey value to VK_PROCESSKEY when IME process key.

2008-04-24 Thread Aric Stewart
Thank you for these investigations This is really nice. I support those patches. I just wanted to also communicate a bit of additional information from my investigations just in case someone asks. I placed hooks on both WH_KEYBOARD_LL and WH_KEYBOARD. Even when the IME is active both of thos

Re: mshtml #5: Added more IDispatchEx tests.

2008-04-24 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > dlls/mshtml/tests/dom.c | 56 > +++ > 1 files changed, 37 insertions(+), 19 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M mshtml.dll -T ../../.. -p mshtml_test.exe.so dom.c && touc

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-24 Thread Austin English
On Thu, Apr 24, 2008 at 4:50 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Thu, Apr 24, 2008 at 2:36 AM, Alexandre Julliard <[EMAIL PROTECTED]> > wrote: > > You certainly don't want to call through explorer for that, showing a > > message box directly is fine. > > Well, that's easier :-) > > > Y

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-24 Thread Dan Kegel
On Thu, Apr 24, 2008 at 2:36 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > You certainly don't want to call through explorer for that, showing a > message box directly is fine. Well, that's easier :-) > You have to be careful to only do it when > loading the main exe, not for any random

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-24 Thread Alexandre Julliard
"Steven Edwards" <[EMAIL PROTECTED]> writes: > On Wed, Apr 23, 2008 at 11:14 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: >> Why not? I thought Explorer was the first thing to start up... > > Your right, I thought it was loaded yet but I guess it does anytime > user32 is initalized. Looking at the

Re: 1.0 idea - ntdll - add a messagebox for missing dlls

2008-04-24 Thread Dan Kegel
On Wed, Apr 23, 2008 at 9:45 PM, Steven Edwards <[EMAIL PROTECTED]> wrote: > On Thu, Apr 24, 2008 at 12:33 AM, Steven Edwards <[EMAIL PROTECTED]> wrote: > > Your right, I thought it was loaded yet but I guess it does anytime > > user32 is initalized. Looking at the process list after the messag

Re: imm32: If ImmNotifyIME fails, ImmSetOpenStatus should also fail.

2008-04-24 Thread ByeongSik Jeon
Kusanagi Kouichi wrote: > if (!fOpen != !data->IMC.fOpen) > { > +if (!ImmNotifyIME( hIMC, NI_CONTEXTUPDATED, 0, IMC_SETOPENSTATUS)) > +return FALSE; > data->IMC.fOpen = fOpen; > -ImmNotifyIME( hIMC, NI_CONTEXTUPDATED, 0, IMC_SETOPENSTATUS); >