2008/7/8 Austin Lund [EMAIL PROTECTED]:
2008/7/7 Austin Lund [EMAIL PROTECTED]:
2008/7/3 Austin Lund [EMAIL PROTECTED]:
I get a crash all the time in winetest since 1.0. Seems there is not
a problem with any of the tests themselves (i.e. running make test).
The last few lines of output from
2008/7/7 Tobias Jakobi [EMAIL PROTECTED]:
The test doesn't get run this way. If it did it would fail of course,
so you should either submit the test after your second patch, or put
the ok that tests the pool type inside a todo_wine block and remove it
again in your second patch.
Andrew Talbot [EMAIL PROTECTED] writes:
Anything wrong with this patch? It does accord with GL/gl.h.
You should fix the other functions too, there are many more similar
cases.
--
Alexandre Julliard
[EMAIL PROTECTED]
Mikołaj Zalewski [EMAIL PROTECTED] writes:
diff --git a/dlls/shell32/dialogs.c b/dlls/shell32/dialogs.c
index 0e858b8..a30cf33 100644
--- a/dlls/shell32/dialogs.c
+++ b/dlls/shell32/dialogs.c
@@ -139,9 +139,11 @@ static INT_PTR CALLBACK RunDlgProc (HWND hwnd, UINT
message, WPARAM wParam,
Mikołaj Zalewski [EMAIL PROTECTED] writes:
diff --git a/programs/services/services.c b/programs/services/services.c
index 36ed117..b166d51 100644
--- a/programs/services/services.c
+++ b/programs/services/services.c
@@ -344,7 +344,7 @@ struct service_entry
Am Montag, den 07.07.2008, 18:22 -0700 schrieb Maarten Lankhorst:
Reworks the code so that the lock is taking in the called procedures now.
+InputPin *pin = (InputPin *)pTransformFilter-ppPins[0];
+
+EnterCriticalSection(pTransformFilter-csFilter);
+if (pTransformFilter-state ==
Lei Zhang [EMAIL PROTECTED] writes:
@@ -1808,6 +1808,10 @@ static BOOL fixup_flags( WINDOWPOS *winpos )
if ((wndPtr-rectWindow.right - wndPtr-rectWindow.left == winpos-cx)
(wndPtr-rectWindow.bottom - wndPtr-rectWindow.top == winpos-cy))
winpos-flags |= SWP_NOSIZE;
James Hawkins ha scritto:
On Mon, Jul 7, 2008 at 1:56 PM, Massimo Del Fedele [EMAIL PROTECTED] wrote:
Listen, I don't want to come off as mean, but like you say yourself,
you are not knowledgeable about msi or the Win32 API for that matter.
AppSearchReg queries the specified registry entry
Intended, see patch 2/3 - the testcase is activated there (since it pass
then).
Hi!
I hame implemented mscoree:GetCORSystemDirectory function. (Patch included)
It find a folder of the latest .Net installation in the registry.
So there are several problems:
1) Registry entry doesn't exist. I don't know how to add it correctly. Now I
import it from the Windows registry by
Jon Griffiths [EMAIL PROTECTED] writes:
+BOOL WINAPI AcceptEx(SOCKET listener, SOCKET acceptor, PVOID dest, DWORD
dest_len,
+ DWORD local_addr_len, DWORD rem_addr_len, LPDWORD
received,
+ LPOVERLAPPED overlapped)
{
-FIXME((listen=%ld,
Jon Griffiths [EMAIL PROTECTED] writes:
+while (send_len)
+{
+wsabuf.len = send_len;
+if (wsabuf.len chunk_len)
+wsabuf.len = chunk_len;
+if (!ReadFile(packet-u.s.hFile, wsabuf.buf, wsabuf.len,
I've been cleaning my patches, thanks to the infinite patience of Kai,
and I'm starting to send them right now. However my progress can be
tracked in http://repo.or.cz/w/wine/gsoc_dplay.git
The main problem so far was to adapt my workflow to an style I've
never worked with, and to realize I still
Dylan Smith wrote:
Yes, that is right.
Thanks for catching that.
By the way, should I be replying to wine-devel? Or should I only be doing
that if something is wrong with the patch so that Julliard can ignore it?
This should do.
thanks
bye
michael
On Tue, Jul 8, 2008 at 8:05 AM,
Looks ok to me.
Posted a alternate version of the patchset to wine-patches, now using
todo_wine and activating the testcase in the first patch.
Patch no. 3 didn't change though, but I reposted it anyway.
Greets,
Tobias
I'm sorry. I forgot to attach a patch.
--
Best wishes,
Vitaly Perov
Russia, Saint-Petersburg. www.etersoft.ru
From 85cc12d39b616865a5a7f44854f24086f79a4342 Mon Sep 17 00:00:00 2001
From: Vitaly Perov [EMAIL PROTECTED]
Date: Tue, 27 May 2008 20:30:35 +0400
Subject: [PATCH] mscoree: add
Yes, add conformance tests for the new ntoskrnl functions
and usbd.sys, and break the patch up a lot...
Conformance tests should consist of a driver and a program to load
it. I do not know other method to call functions from ntoskrnl.exe and
usbd.sys on Windows. But I have a problem with
Massimo Del Fedele wrote:
Yes. You're verifying everything I've told you several times.
I already verified that the patch does no harm AND solves a problem.
For me that's more than enough.
Please make a test and submit it along with your patch. Otherwise your
changes won't get in.
Detlef Riekenberg wine.dev at web.de writes:
Louis, please do not give up and reopen the bug.
You got already some comments, and I want to give some more Ideas.
- You told, that you reuse the code for the cube from the internet.
That is a no-go because of copyright and license
I think I am using winemaker wrong. It does not give me a .res file as the
winelib user's guide says I need, and the guide says I should be getting a
Makefile.in and configure script. When I try to use it and link to the
libcudart.so.2.0 file it acts like the target directory is libcudart.so.2.0
You should not change scmdatabase_find_service_by_displayname, it does
what its name implies. You should fix the callers where necessary.
The scmdatabase_find_service_by_displayname is currently wrong. It
dereferences a NULL pointer if the registry database contains a service
without a
I already verified that the patch does no harm AND solves a problem.
For me that's more than enough.
That's fine for a patch for your local tree, but it's not enough for
Wine. Submit with a test case that proves you're right and we'll be
more likely to accept your patch.
--Juan
On Mon, 2008-07-07 at 14:39 -0700, Maarten Lankhorst wrote:
Hi students,
As you might know it's time for midterm evaluations. Unfortunately for
some students I haven't seen the progress they made, and I highly
encourage all students to send their patches early and often, even if
it's not
Massimo Del Fedele wrote:
I already verified that the patch does no harm AND solves a problem.
For me that's more than enough.
Ciao
Max
Can you provide proof that beyond the shadow of a doubt it will always be
correct? One way to provide that proof is to write a test.
-Zac
Also, I would like to hear from all students now a reflection. What
went well, and what didn't, and what did you accomplish so far? :-)
My project so far has gone fairly well, and I'd say I'm currently just a
little ahead of schedule, which I'm pleased about. The first part of the
project was
* On Mon, 14 Apr 2008, Alexander Dorofeyev wrote:
I was able to isolate it in a very small and simplistic testcase, which
shows this same problem. It will be included as attachment. Holding a
key and moving mouse over the window steadily increases main loop
latency from 10 to 50 (and even
From http://www.codesampler.com/disclaimer.htm:
Kevin R. Harris retains all ownership rights to all documents
(including but not limited to image, html, text files, and archived
source code) on the Web Site (www.CodeSampler.com). Use of the Web
Site is governed by applicable copyright law. ...
On Tue, Jul 8, 2008 at 12:59 PM, John Reiser [EMAIL PROTECTED] wrote:
Attached is the patch for http://bugs.winehq.org/show_bug.cgi?id=14357
undefined edge padding in bitmaps annoys valgrind
+memset(image-data, 0, image-bytes_per_line * height); /* valgrind */
I don't think we should add
James Hawkins wrote:
2008/7/8 Huw Davies [EMAIL PROTECTED]:
Fixes a todo_wine and a Valgrind warning.
@@ -699,10 +699,7 @@ static HDDEDATA CALLBACK
server_ddeml_callback(UINT uType, UINT uFmt, HCONV hcon
ptr = (LPSTR)DdeAccessData(hdata, size);
ok(!lstrcmpA(ptr, poke
On Tue, Jul 8, 2008 at 1:18 PM, Huw Davies [EMAIL PROTECTED] wrote:
James Hawkins wrote:
2008/7/8 Huw Davies [EMAIL PROTECTED]:
Fixes a todo_wine and a Valgrind warning.
@@ -699,10 +699,7 @@ static HDDEDATA CALLBACK
server_ddeml_callback(UINT uType, UINT uFmt, HCONV hcon
ptr =
John Reiser [EMAIL PROTECTED] writes:
Attached is the patch for http://bugs.winehq.org/show_bug.cgi?id=14357
undefined edge padding in bitmaps annoys valgrind
Please stop filing bugs for your patches. Just submit the patches with a
proper changelog entry and explanations, instead of a pointer
Zac Brown ha scritto:
Massimo Del Fedele wrote:
I already verified that the patch does no harm AND solves a problem.
For me that's more than enough.
Ciao
Max
Can you provide proof that beyond the shadow of a doubt it will always be
correct?
Nobody can :-)
One way to provide that
Hello,
On Monday 07 of July 2008 23:39:25 Maarten Lankhorst wrote:
Also, I would like to hear from all students now a reflection. What
went well, and what didn't, and what did you accomplish so far? :-)
I've been working on two parts of my MSXML projects:
1) Fixing bugs
That went well. I have
Hi Michael,
2008/7/8 Michael Karcher [EMAIL PROTECTED]:
Am Montag, den 07.07.2008, 18:22 -0700 schrieb Maarten Lankhorst:
Reworks the code so that the lock is taking in the called procedures now.
+InputPin *pin = (InputPin *)pTransformFilter-ppPins[0];
+
+
On Tue, 2008-07-08 at 13:20 +0100, Huw Davies wrote:
---
dlls/gdiplus/tests/font.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
On my Windows system I can't find MSSansSerif, only Microsoft Sans
Serif. I'm not sure if that's a valid test to prove that point.
I think there's code that does that for render targets. It would be good if
those are combined, or the render target flag adjustment just removed if it is
not needed any longer
-Original Message-
From: [EMAIL PROTECTED] [mailto:wine-patches-
[EMAIL PROTECTED] On Behalf Of Alexander
John Reiser [EMAIL PROTECTED] writes:
Attached is the patch for http://bugs.winehq.org/show_bug.cgi?id=14359
clear new reserved slots in new argv[]
I don't see any case where the reserved slots wouldn't be
initialized. Please provide more details.
--
Alexandre Julliard
[EMAIL PROTECTED]
John Reiser [EMAIL PROTECTED] writes:
+static void subheap_notify_free_all(SUBHEAP const *const subheap)
+{
+char const *ptr = (char const *)subheap-base + subheap-headerSize;
+
+//DPRINTF(subheap_notify_free_all heap @%p, arena=%p\n, subheap, ptr);
Please clean up that sort of
Adam Petaccia wrote:
On Tue, 2008-07-08 at 13:20 +0100, Huw Davies wrote:
---
dlls/gdiplus/tests/font.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
On my Windows system I can't find MSSansSerif, only Microsoft Sans
Serif. I'm not sure if that's a valid test to prove
John Reiser [EMAIL PROTECTED] writes:
I call mmap(0,,,MAP_FIXED,,) often, and I get what I expect [*],
namely a [new] mapping at 0, replacing any previous mapping at 0,
regardless of the state of existing mappings. See testcase below.
Yes, the replacing existing mappings is precisely the
On Tue, Jul 8, 2008 at 2:10 AM, Alexandre Julliard [EMAIL PROTECTED] wrote:
Lei Zhang [EMAIL PROTECTED] writes:
@@ -1808,6 +1808,10 @@ static BOOL fixup_flags( WINDOWPOS *winpos )
if ((wndPtr-rectWindow.right - wndPtr-rectWindow.left == winpos-cx)
(wndPtr-rectWindow.bottom -
Stefan Dösinger wrote:
I think there's code that does that for render targets. It would be good if
those are combined, or the render target flag adjustment just removed if it
is not needed any longer
I found some code to that effect in IDirectDrawImpl_CreateNewSurface, but there
the logic
Alexandre Julliard wrote:
John Reiser [EMAIL PROTECTED] writes:
Attached is the patch for http://bugs.winehq.org/show_bug.cgi?id=14360
dosmem forgot MAP_FIXED
No, it's not forgotten, that's the way it's supposed to work. What are
you trying to fix?
Some environments strictly enforce
Alexandre Julliard wrote:
John Reiser [EMAIL PROTECTED] writes:
Some environments strictly enforce the semantics of mmap(), namely a
successful
return value need not equal the requested address unless MAP_FIXED,
even if the requested address is unmapped and otherwise available.
Unless
Hi Michael,
open inputs read as one, so reads without responder return 0xFF.
You're right, testing it on dosbox it does return 0xff for non hercules cards.
As long as bit seven never toggles though, any app reading it will still infer
that a hercules card isn't present. I didn't catch the
Hi Dan,
Not *quite* all. Inquiring minds always want to know what
app it will help and/or bugzilla entry it will fix.
Fair enough. The bug in question is 2408, for LocoScript (a rather ancient dos
text editor). Note that a couple of other people have reported unrelated bugs
in that bug due
Hello Vincent,
Looks like you've some DOS line breaks mixed into this patch through the
register_parent_wnd_class function. Not sure if you meant to do that.
Peace,
-Roy
On Tue, Jul 8, 2008 at 3:22 PM, Vincent Povirk [EMAIL PROTECTED] wrote:
I did not; it's an artifact of copying/pasting from an old test case.
Vincent Povirk
On Tue, Jul 8, 2008 at 6:01 PM, Roy Shea [EMAIL PROTECTED] wrote:
Hello Vincent,
Looks like you've some DOS line breaks mixed into this patch through the
register_parent_wnd_class function. Not sure if you
Hi Kario,
btw. if you want that i send to you diff/patch file,
please write me the full command for git
You should avoid sending messages in HTML to the mailing lists. Send
them in plain text instead. With regards to generating a patch, see this
wiki page:
John Reiser wrote:
Attached is the patch for http://bugs.winehq.org/show_bug.cgi?id=14365
do not touch high address space (initial stack, user_space_limit)
So what's wrong with what Wine doing now? The part you removed states what
it's there for - to prevent needless allocation attempts at the
John Reiser wrote:
Attached is the patch for http://bugs.winehq.org/show_bug.cgi?id=14370
adjust timeout interval for virtulaizers
This should go into registry not environment. See other discussion about the
same topic.
Vitaliy.
Kario wrote:
hi, my name is Mario Kacmar and I am from Slovakia
I made Slovak translation for comctl32
please commit this patch
if there is needed GPL header, feel free to append it
You have to explicitly state the license of your contribution. Not the GPL
will not work, as Wine is
Piotr Caban [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
---
dlls/msxml3/tests/Makefile.in |3 +-
dlls/msxml3/tests/saxreader.c | 225
+
2 files changed, 227 insertions(+), 1 deletions(-)
create mode 100644
Piotr Caban [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
---
dlls/msxml3/saxreader.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
Hi Piotr,
You need to check the parameter
On Tue, Jul 8, 2008 at 8:45 PM, Alistair Leslie-Hughes
[EMAIL PROTECTED] wrote:
Piotr Caban [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
---
dlls/msxml3/tests/Makefile.in |3 +-
dlls/msxml3/tests/saxreader.c | 225
+
2 files changed,
Piotr Caban [EMAIL PROTECTED] wrote in message
news:[EMAIL PROTECTED]
---
dlls/msxml3/domdoc.c | 22 ++
1 files changed, 18 insertions(+), 4 deletions(-)
Hi Piotr,
Your missing test
Alistair,
Piotr already said that he's just trying to get the initial tests in.
More tests can be added later, by Piotr and anyone else that feels
like more tests are needed.
Hi James,
I know that, but with 18 patches sent, and this is only test for SAX. If
there
was another patch
On Tue, Jul 8, 2008 at 9:07 PM, Alistair Leslie-Hughes
[EMAIL PROTECTED] wrote:
Alistair,
Piotr already said that he's just trying to get the initial tests in.
More tests can be added later, by Piotr and anyone else that feels
like more tests are needed.
Hi James,
I know that, but with
I'm mentoring Piotr for SOC, and he knows that he needs to write more
tests and plans on doing so. With these 18 patches, he was working to
fix the Photoshop installer, not completely and thoroughly implement
this feature. If you have a problem with the current implementation
as
I've spent the whole day reading different things and I'm just not sure why
it is creating an empty file. I'm still getting the same error messages even
when using winemaker correctly.
[EMAIL PROTECTED]:~/wine/patches/cuda$ make
winegcc -shared cuda.dll.spec -mno-cygwin -o cuda.dll.so cudart.o
Alexandre Julliard wrote:
Module: wine
Branch: master
Commit: b648dac7e12f593589661d03449e0f092b363f87
URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b648dac7e12f593589661d03449e0f092b363f87
Author: Alexandre Julliard [EMAIL PROTECTED]
Date: Tue Jul 8 17:49:03 2008 +0200
62 matches
Mail list logo
