Re: one liner patch to stop crash, everquest2.exe

2008-07-20 Thread H. Verbeet
2008/7/21 Stefan Dösinger <[EMAIL PROTECTED]>: > Is the shader backend recreated properly after the reset? > Just to clarify, in dlls/wined3d/device.c, IWineD3DDeviceImpl_Reset(), line 7355 there's a call to shader_alloc_private(). This call is supposed to recreate This->shader_priv.

Re: kernel32/tests: Fix a failing test in vista

2008-07-20 Thread Dmitry Timoshkov
"Nicolas Le Cam" <[EMAIL PROTECTED]> wrote: > Vista introduced new flags for CompareString, as stated in [1]. > The value defined for LINGUISTIC_IGNORECASE is 0x10. So the invalid flag > test don't fail as expected starting from this platform. > > [1] http://msdn.microsoft.com/en-us/library/ms647

RE: one liner patch to stop crash, everquest2.exe

2008-07-20 Thread Stefan Dösinger
Is the shader backend recreated properly after the reset? From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Andrew Fenn Sent: Sunday, July 20, 2008 11:11 PM To: H. Verbeet Cc: wine-devel@winehq.org Subject: Re: one liner patch to stop crash, everquest2.exe I think that both cal

Re: one liner patch to stop crash, everquest2.exe

2008-07-20 Thread Andrew Fenn
I think that both calls are coming from d3d9:IDirect3DDevice9Impl_Reset I put some FIXME's in the code and it passes the same function. In the log below you can see where the crash is happening. fixme:d3d9:IDirect3DDevice9Impl_Reset RESET DEVICE fixme:d3d_shader:shader_glsl_free FREE SHADER fixme

Re: one liner patch to stop crash, everquest2.exe

2008-07-20 Thread Andrew Fenn
I'm not sure how to investigate this properly is there a way to get a back trace every time it hits that function? On Thu, Jul 17, 2008 at 10:44 PM, H. Verbeet <[EMAIL PROTECTED]> wrote: > 2008/7/17 Andrew Fenn <[EMAIL PROTECTED]>: > > Here's what I got from the debug log. > > > > Backtrace: > >

Re: taskmgr: Add full translation [1/2]

2008-07-20 Thread Detlef Riekenberg
On So, 2008-07-20 at 22:58 +0500, Vladimir Pankratov wrote: First of all, your Idea is great, but your Patch is far to large. Please move only some strings (usual is from one source file) to the resources at once. Then you must keep the resources in sync. That means, when you move one string to t

Re: MBCS minor bug fix

2008-07-20 Thread Juan Lang
Hi Hirofumi, the subject of your patch doesn't tell us very much. Most submissions are in fact bug fixes in fact, so please describe what the bug is at least. A test case showing what's wrong with the existing code, and that shows that your patch fixes it, would be much better. Furthermore, -

[RFC] crypt32: fixed the base64 tests on Vista.

2008-07-20 Thread Reece Dunn
This patch fixes the base64 tests on Vista (http://test.winehq.org/data/b3f4091b47e70681a9909bfccd19dee95657fabd/vista_APetacciaVistaNXSet/crypt32:base64.html), however to me this feels wrong. In the call to pCryptStringToBinaryA, Vista is returning TRUE in some cases, and for those is sometimes n

Interface fonts and locale woes

2008-07-20 Thread RafałMużyło
I wasn't sure if I should post this to the devel or user list. A coin toss decided on this one. First of all, I'd like to praise the author of the patch at http://www.winehq.org/pipermail/wine-patches/2008-July/057033.html for "brilliance of simplicity". As I have all the fonts I needed, it annoyed

Re: [2/6] winhttp: Allow winhttp to use wininet.h with winhttp.h

2008-07-20 Thread Kari Hurtta
Hans Leidekker <[EMAIL PROTECTED]> writes in gmane.comp.emulators.wine.devel: > On Friday 18 July 2008 16:11:37 Dan Kegel wrote: > > > Building winhttp on top of wininet lets us develop on trunk and > > is probably the fastest path to making a bunch of applications > > happy, isn't it? That's t

re: Visual Runtime conflicts with the debugger?

2008-07-20 Thread Dan Kegel
Markus Hitter wrote: >My pet app (Catia) works partially now. That's great! I have a copy, too, but the only thing I did with it was file a bug about the installer... >The thing most missing is, it >can't open a file. As soon as I attempt to do so, the app freezes for >a minute, then a "Visual C

Re: [1/2] server: fix async read on mailslot

2008-07-20 Thread Andrey Turkin
2008/7/19 Michael Karcher <[EMAIL PROTECTED]>: > Am Freitag, den 18.07.2008, 20:37 +0400 schrieb Andrey Turkin: > > Also, please attach patches with disposition inline, not attachment > > (git can do that) - this make review somehow easier. > If this is an official wine policy (I do see your point

Visual Runtime conflicts with the debugger?

2008-07-20 Thread Markus Hitter
Hello all, My pet app (Catia) works partially now. The thing most missing is, it can't open a file. As soon as I attempt to do so, the app freezes for a minute, then a "Visual C++ Runtime Exception" is shown. The shown dialog doesn't feature any meaningful information. So I moved from "wi

Re: Japanese conversion tests

2008-07-20 Thread Dmitry Timoshkov
"Aric Stewart" <[EMAIL PROTECTED]> wrote: > --- > dlls/mlang/tests/mlang.c | 173 > ++ > 1 files changed, 173 insertions(+), 0 deletions(-) This behaviour is not mlang specific, and should be added to dlls/kernel32/tests/codepage.c instead. -- Dmit

Re: [PATCH] gdi32: Glyph advances should be measured for unrotated characters.

2008-07-20 Thread Dmitry Timoshkov
"Lei Zhang" <[EMAIL PROTECTED]> wrote: > Committish 85c16fc45 broke some text rendering for me. It looks like > when the font has orientation set, adv got the width of the rotated > chars, whereas the comment in struct GM says it's the width of the > unrotated chars. > > Dmitry, can you comment o