Add Wine FAQ entry to Wine menu?

2008-07-22 Thread Dan Kegel
Recently, several newbies had trouble finding the FAQ and were surprised to hear that it could be helpful. Perhaps if our packages added a Wine FAQ menu item, they'd have less trouble finding it. Here's a patch to add that to the Debian / Ubuntu packages. What do people think? --- /dev/null

ntdll/server and unix_fd handling

2008-07-22 Thread Kai Blin
Hi folks, I'm currently trying to get some integrated Wine/Samba tests working and in order to do so, I'm trying to add Samba socket wrapper support to Wine (i.e. allow Wine to hook into Samba's fake AF_FILE-based networking for testing). The socket wrapper code keeps track of the unix_fds of

Re: [RFC] crypt32: fixed the base64 tests on Vista.

2008-07-22 Thread Kai Blin
On Monday 21 July 2008 22:00:44 Reece Dunn wrote: I'll need to take a look at the tests in more detail and the API documentation (if I can get to the non-WinCE docs on MSDN!) to see what is really going on and which ones are failing and why. I will dig deeper into this.

Re: rasapi32: the tests need raserror.h to build using MS headers.

2008-07-22 Thread Reece Dunn
2008/7/21 Stefan Leichter [EMAIL PROTECTED]: Am Monday 21 July 2008 21:44 schrieb Reece Dunn: The error constants (e.g. ERROR_BUFFER_TOO_SMALL) are defined in raserror.h, which is needed for the tests to build using the Microsoft headers (checked against the Vista SDK headers). - Reece my

Re: ntdll/server and unix_fd handling

2008-07-22 Thread Alexandre Julliard
Kai Blin [EMAIL PROTECTED] writes: After some more digging, upstream of the get_sock_fd call, the server_get_unix_fd() call always gets the same fd, either from wineserver or from the cache. wine_server_handle_to_fd() then seems to call dup() on the unix_fd. This seems to be needed because

Re: Add Wine FAQ entry to Wine menu?

2008-07-22 Thread Scott Ritchie
Dan Kegel wrote: Recently, several newbies had trouble finding the FAQ and were surprised to hear that it could be helpful. Perhaps if our packages added a Wine FAQ menu item, they'd have less trouble finding it. Here's a patch to add that to the Debian / Ubuntu packages. What do people

Re: oleaut32: fix the SafeArrayGetVartype tests on Vista and use that behaviour. [try 3] [resend]

2008-07-22 Thread Alexandre Julliard
Reece Dunn [EMAIL PROTECTED] writes: This includes Rob Shearman's suggestion of marking the old behaviour as broken() as it is clearly a bug, and also updated the SafeArrayGetVartype implementation to return the correct value in this case. The tests pass on Vista and on Wine. Was there

Re: [Gdiplus try3 02/16] Implement GdipCreateRegion

2008-07-22 Thread Huw Davies
Hi Adam, Some comments inlined below: On Tue, Jul 22, 2008 at 01:22:56AM -0400, Adam Petaccia wrote: diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h index e7ca874..9c0246b 100644 --- a/dlls/gdiplus/gdiplus_private.h +++ b/dlls/gdiplus/gdiplus_private.h @@ -196,4

Re: quartz: Add support for the file writer filter

2008-07-22 Thread Alexandre Julliard
Maarten Lankhorst [EMAIL PROTECTED] writes: This should be in qcap, however it doesn't have the directshow primitives (wine directshow base classes) that quartz has. If you reject it for that reason, please let me know.. If it's in qcap on Windows it should clearly be in qcap on Wine. --

Re: [Gdiplus try3 01/16] Mark the tests todo_wine, instead of skipping over them all.

2008-07-22 Thread Alexandre Julliard
Adam Petaccia [EMAIL PROTECTED] writes: todo_wine +{ ok(status == Ok, status %08x\n, status); -if(status != Ok) return; - status = GdipGetRegionDataSize(region, needed); ok(status == Ok, status %08x\n, status); -ok(needed == 20, got %d\n, needed); +

Re: netapi32: add stub for NetShareGetInfo

2008-07-22 Thread Vitaly Perov
I am sorry. It was wrong file attached. -- Best wishes, Vitaly Perov Russia, Saint-Petersburg. www.etersoft.ru From a11d55bebddff866ce1e5af3f9b393e90bab442a Mon Sep 17 00:00:00 2001 From: Vitaly Perov [EMAIL PROTECTED] Date: Tue, 22 Jul 2008 13:19:58 +0400 Subject: [PATCH] netapi32: Add stub for

Re: [3/9] shell32: Load Control Panel title from resources

2008-07-22 Thread Alexandre Julliard
Owen Rudge [EMAIL PROTECTED] writes: --- a/dlls/shell32/shell32_Bg.rc +++ b/dlls/shell32/shell32_Bg.rc @@ -219,4 +219,6 @@ STRINGTABLE IDS_CDBURN_AREA Local Settings\\Application Data\\Microsoft\\CD Burning IDS_NEWFOLDER New Folder + +

Re: dinput: the DIK_ keycode is not the same as the scancode.

2008-07-22 Thread Vitaliy Margolen
Aric Stewart wrote: It is mapped with the keyboard mapping to the resulting character. so the key 'A' is DIK_A nomatter what its scancode or vkey would be. This is relevent to Japanese keymapping where the '@' key is in the '[' location the scancode for both is 0x22 but dinput generates

Re: dinput: the DIK_ keycode is not the same as the scancode.

2008-07-22 Thread Aric Stewart
Thanks, I will look into what i can do. I worried about using VK codes because sometimes the same VK can produce different characters. The specific example I am looking at is VK_OEM_3 which produces the '@' in Japanese and often the '`' character in other layouts. I could use VK from the

Re: Add Wine FAQ entry to Wine menu?

2008-07-22 Thread Dan Kegel
On Tue, Jul 22, 2008 at 3:11 AM, Scott Ritchie [EMAIL PROTECTED] wrote: Recently, several newbies had trouble finding the FAQ and were surprised to hear that it could be helpful. Perhaps if our packages added a Wine FAQ menu item, they'd have less trouble finding it. The FAQ is english only,

Re: [Gdiplus try3 02/16] Implement GdipCreateRegion

2008-07-22 Thread Adam Petaccia
On Tue, 2008-07-22 at 11:11 +0100, Huw Davies wrote: Hi Adam, Some comments inlined below: Thanks for the review. On Tue, Jul 22, 2008 at 01:22:56AM -0400, Adam Petaccia wrote: diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h index e7ca874..9c0246b 100644

Re: wined3d: universal surface convertor function for unsigned integer color formats(2nd attempt)

2008-07-22 Thread Victor
It has been a couple of days since I've submitted patch. Patch still isn't in git. Will it be accepted? If not, what should be changed to make it acceptable? -- With best regards Victor Eremin ([EMAIL PROTECTED]) signature.asc Description: This is a digitally signed message part.

Re: [3/9] shell32: Load Control Panel title from resources

2008-07-22 Thread Owen Rudge
The indentation is wrong, looks like you are using the wrong tab size. I've resubmitted the patches with the indentation matching each .rc file. Not all of the .rc files have the same indentation, and even within them they are inconsistent, but my lines should now be consistent with most of

Re: [Gdiplus try3 02/16] Implement GdipCreateRegion

2008-07-22 Thread Huw Davies
Adam Petaccia wrote: On Tue, 2008-07-22 at 11:11 +0100, Huw Davies wrote: +} RegionElement; It would be better to avoid the mixed upper/lower case names, since this makes it look like they're win32 api structures. Something like typedef struct region_element region_element is nicer. Same

Re: general question..

2008-07-22 Thread Chris Ahrendt
Vitaliy Margolen wrote: Chris Ahrendt wrote: fail: if(wined3d_fake_gl_context_hdc) ReleaseDC(wined3d_fake_gl_context_hwnd, wined3d_fake_gl_context_hdc); wined3d_fake_gl_context_hdc = NULL; if(wined3d_fake_gl_context_hwnd)

Convert 565 to 0888

2008-07-22 Thread Einars
I had graphical problems with an online game called Angels Online, when just a black screen was visible, and complaints about missing converter from WINED3DFMT_R5G6B5 to WINED3DFMT_X8R8G8B8, so I added a converter for this format, and the game runs flawlessly now on wine, the 1.1.1 release as

RE: wined3d: universal surface convertor function for unsigned integer color formats(2nd attempt)

2008-07-22 Thread Stefan Dösinger
It has been a couple of days since I've submitted patch. Patch still isn't in git. Will it be accepted? If not, what should be changed to make it acceptable? I think the problem was that I forgot to reply to your mail. I think the idea of using this as a fallback if no special conversion

RE: general question..

2008-07-22 Thread Stefan Dösinger
The bigger question is why there is a huge if-else statement, and why this function is so large. Huge if-else statement = 2 sub-functions Shader dirty constants - do shader internals really belong here ? Well, in ARB shader constants are a context global state, opposed to GLSL where they are

EverQuest2.exe and context.c

2008-07-22 Thread Chris Ahrendt
Stefan and all... in context.c the following lines: /* When findCompatible is set and no suitable format was found, let ChoosePixelFormat choose a pixel format in order not to crash. */ if(!iPixelFormat !findCompatible) { ERR(Can't find a suitable iPixelFormat\n);

Re: [Gdiplus 1/6] Valgrind: Fix a memory leak

2008-07-22 Thread James Hawkins
On Tue, Jul 22, 2008 at 10:06 PM, Adam Petaccia [EMAIL PROTECTED] wrote: If this patch is rejected, the others will still apply and I will drop this from my tree. Technically a leak shouldn't occur here as the call before it is invalid, but because Gdiplus doesn't correctly handle this, we

RE: EverQuest2.exe and context.c

2008-07-22 Thread Stefan Dösinger
why not remove this and go ahead and call ChoosePixelFormat? If ChoosePixelFormat fails then we say we can't find a suitable pixel format? This removes one problem when EverQuest2.exe runs where I get 2-3 calls to WineD3D_ChoosePixelFormat Roderick has written this code, and he is on