Re: wined3d: Call apply_fbo_state() from inside ActivateContext()

2008-07-29 Thread H. Verbeet
2008/7/29 Vitaliy Margolen [EMAIL PROTECTED]: H. Verbeet wrote: This should prevent setting an incorrect draw buffer when an FBO is active. This patch breaks Psychonauts and possibly other multi-threaded games with OffscreenRendering=FBO on Nvidia hardware. I thought you said it was the

Re: [PATCH] relay: Avoid reading stack memory on unprotected side of stack pointer

2008-07-29 Thread Alexandre Julliard
John Reiser [EMAIL PROTECTED] writes: +output( \tmovl %d(%%ecx),%%edx; movl %%edx,%%es:0*4(%%eax)\n, CONTEXTOFFSET(Eax) ); +output( \tmovl %d(%%ecx),%%edx; movl %%edx,%%es:1*4(%%eax)\n, CONTEXTOFFSET(Ecx) ); +output( \tmovl %d(%%ecx),%%edx; movl %%edx,%%es:2*4(%%eax)\n,

Re: wined3d: universal surface convertor function for unsigned integer color formats(5th attempt)

2008-07-29 Thread Alexandre Julliard
Victor [EMAIL PROTECTED] writes: I've changed things a bit and resubmitted patch. Now there will be less ifdefs. Not much better I'm afraid. I'm not sure which data types are you talking about, since I'll need per-byte surface access in any case, and It doesn't look like it can be

Re: wined3d: Call apply_fbo_state() from inside ActivateContext()

2008-07-29 Thread Alexandre Julliard
H. Verbeet [EMAIL PROTECTED] writes: This should prevent setting an incorrect draw buffer when an FBO is active. It doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c touch visual.ok visual.c:8465: Tests skipped: D3DFMT_G16R16F textures

Re: wined3d: Call apply_fbo_state() from inside ActivateContext()

2008-07-29 Thread H. Verbeet
2008/7/29 Alexandre Julliard [EMAIL PROTECTED]: It doesn't work here: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c touch visual.ok visual.c:8465: Tests skipped: D3DFMT_G16R16F textures not supported visual.c:8465: Tests skipped: D3DFMT_G32R32F

Re: [WideChar conversion improvements - 1/5] Add a new check for 'dstlen 0' to WideCharToMultiByte

2008-07-29 Thread Alexandre Julliard
Colin Finck [EMAIL PROTECTED] writes: @@ -1893,7 +1893,7 @@ INT WINAPI WideCharToMultiByte( UINT page, DWORD flags, LPCWSTR src, INT srclen, const union cptable *table; int ret, used_tmp; -if (!src || (!dst dstlen)) +if (!src || (!dst dstlen) || dstlen 0) There are

Hang in user32/tests/dde.c:test_msg_client()

2008-07-29 Thread Dan Kegel
I'm running the tests on a slowish uniprocessor (Athlon XP 2100+, not dual as I mistakenly said in last post), and I'm running into a hang in user32/tests/dde.c. This is a two process test. One process is hung in 8 test_ddeml_server+0x1ad(hproc=0x4c) [dlls/user32/tests/dde.c:797] in

Re: [WideChar conversion improvements - 1/5] Add a new check for'dstlen 0' to WideCharToMultiByte

2008-07-29 Thread Colin Finck
Alexandre Julliard wrote: There are places in Wine that use a negative dstlen, you have to fix them first. Done here now: http://www.winehq.org/pipermail/wine-patches/2008-July/058743.html Best regards, Colin

RE: wined3d: universal surface convertor function for unsigned integer color formats(5th attempt)

2008-07-29 Thread Stefan Dösinger
No, you shouldn't be accessing the surface per byte either, the access should depend on the format, i.e. for a 32-bit format you want to access DWORD by DWORD. This defeats the point of a format-independent conversion function I think

Re: Missed patches concerning valgrind-detected issues

2008-07-29 Thread Kirill K. Smirnov
В сообщении от 29 июля 2008 Alexandre Julliard написал(a): Kirill K. Smirnov [EMAIL PROTECTED] writes: Hello, Alexandre, dsound: check error status of waveOutGetVolume() function before using retrieved values (found by valgrind)

Re: [PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path.

2008-07-29 Thread Vitaliy Margolen
Lei Zhang wrote: Hi, On Windows, the Msi.Package action registry keys have the full path to msiexec.exe. +HKCR,Msi.Package\shell\Open\command,,0x20002,%SystemRoot%\System32\msiexec.exe /i %1 %*

Re: [PATCH 2/3] mstask: Task stub with AddRef, QueryInterface, and Release

2008-07-29 Thread Dan Hipschman
On Tue, Jul 29, 2008 at 04:45:31PM -0700, Roy Shea wrote: +static HRESULT WINAPI MSTASK_ITask_GetTriggerString( +ITask* iface, +WORD iTrigger, +LPWSTR *ppwszTrigger) +{ +FIXME((%p, %d, %p): stub\n, iface, iTrigger, ppwszTrigger); +FIXME(Not implemented\n); +

Final Final patch on setrenderstate

2008-07-29 Thread Chris Ahrendt
ok finally learned how to do git... here is the git patch... I thought of moving the if statement which is at the bottom of the function to the begining as I am not sure why you would want to reassign the same value then check to see if it was the same.. Why are you doing it that way? As