Re: Spore patch to fix UI and Part descriptions

On Fri, Aug 22, 2008 at 02:51:56PM +0700, Andrew Fenn wrote: I made a new patch this time including a test. I put in some extra checking in SetScissorRect making sure that if rect was null or it was an invalid rectangle that it was returned as invalid as it should be. I'm not able to do a

Re: user32: fix error setting in FindWindow (try 2)

Louis. Lenders [EMAIL PROTECTED] writes: diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 1964e88..246347f 100644 --- a/dlls/user32/tests/win.c +++ b/dlls/user32/tests/win.c @@ -4789,14 +4789,20 @@ static void test_hwnd_message(void) SetLastError(0xdeadbeef);

Re: regedit 1/2: Convert key creation to unicode

Alexander Nicolaysen Sørnes wrote: regedit 1/2: Convert key creation to unicode Why do you add extra TCHARs then? You replace one or two with WCHAR and then add a lot more TCHARs. From 2f56e158d55011ac4294d113f844c32fb998a2c2 Mon Sep 17 00:00:00 2001 From:

Re: [PATCH 1/2] mstask: Implemented CreateTrigger.

dlls/mstask/task.c |4 ++-- dlls/mstask/tests/task.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Please disregard this and the subsequent patch in the set. Patchwatecher found a few incorrect todo_wine statements that I forgot to remove. A revised version of the two

Re: user32: fix error setting in FindWindow (try 2)

- Original Message From: Alexandre Julliard [EMAIL PROTECTED] To: Louis. Lenders [EMAIL PROTECTED] Cc: wine-devel@winehq.org Sent: Friday, 22 August, 2008 4:54:49 AM Subject: Re: user32: fix error setting in FindWindow (try 2) Louis. Lenders [EMAIL PROTECTED] writes: diff --git

Regression with d3d: Remove IWineD3DDevice::SetHwnd.

Hi This patch is causing a regression in the game Return to mysterious Island. When the game start it crashes displaying the trace I added at the end of the mail. I'm not an expert at all with ddraw but as it crashes on a NULL pointer, maybe there is an inconsistency between This-dest_window and

Re: [PATCH] shell32 - handle WM_CLOSE in the Control Panel window (fixed)

Vincent Povirk [EMAIL PROTECTED] at Aug 21, 2008 8:49 PM (MST) wrote about [PATCH] shell32 - handle WM_CLOSE in the Control Panel window (fixed) WM_CLOSE is already handled by the default window procedure, DefWindowProcW, which calls DestroyWindow. It's only necessary to override the default for

Re: appwiz: fix some typos in the french resources

David Adam [EMAIL PROTECTED] writes: - CONTROL Ce logiciel peut être automatiquement désinstaller. Pour supprimer un programme ou modifier ses composants, sélectionner le dans la liste, et cliquer sur Ajouter/Supprimer., 1002, STATIC, SS_LEFT | WS_CHILD | WS_VISIBLE | WS_GROUP, 40, 57,

Re: regedit 1/2: Convert key creation to unicode

Alexander Nicolaysen Sørnes wrote: regedit 1/2: Convert key creation to unicode Why do you add extra TCHARs then? You replace one or two with WCHAR and then add a lot more TCHARs. Some of them are removed by patch 2/2, others were added to consistently store the treeview text in multi-byte

RE: Spore patch to fix UI and Part descriptions

+rect.right = 0; +rect.top = NULL; +rect.left = NULL; +rect.bottom= 0; NULL is (void *) 0, so this test is the same as the one above, except that the compiler may warn about an implicit cast from pointer to integer. Otherwise, this goes into the right direction.

Patchwatcher status

I think I fixed the charset munging, so patches of non-english stretches of code should work now. That was the last big source of false failure reports, so I'm going to enable email notification to people whose patches fail. I'll probably clear the results page tonight to get rid of all the bogus

Re: wined3d/d3d9: Set the initial scissor rect to the window size

H. Verbeet schrieb: 2008/8/21 Rico Schüller [EMAIL PROTECTED]: +/* Set the scissor rect values */ +scissor.left=0; +scissor.right=ThisDevice-ddraw_width; +scissor.top=0; +scissor.bottom=ThisDevice-ddraw_height; +IWineD3DDevice_SetScissorRect(device, scissor); +

Re: wined3d/d3d9: Set the initial scissor rect to the window size

2008/8/22 Rico Schüller [EMAIL PROTECTED]: H. Verbeet schrieb: 2008/8/21 Rico Schüller [EMAIL PROTECTED]: +/* Set the scissor rect values */ +scissor.left=0; +scissor.right=ThisDevice-ddraw_width; +scissor.top=0; +scissor.bottom=ThisDevice-ddraw_height; +

Re: Summer of code evaluations

On Wed, 2008-08-20 at 01:14 +0200, Maarten Lankhorst wrote: Hi all, As you may know yesterday was the pens down for summer of code 2008 Students are still allowed to write code, but it won't count for the mentors evaluation any more. I intend to clean up and make sure almost everything

Re: Spore patch to fix UI and Part descriptions

Andrew Fenn schrieb: I made a new patch this time including a test. I put in some extra checking in SetScissorRect making sure that if rect was null or it was an invalid rectangle that it was returned as invalid as it should be. I'm not able to do a test on windows so if anyone does one

RE: wined3d/d3d9: Set the initial scissor rect to the window size

Are you sure you shouldn't be using the primary swapchain's backbuffer dimensions? I'm not sure what exactly you mean. Something like this: IWineD3DSwapChain *swapchain; IWineD3DSurface *backbuffer; D3DSURFACE_DESC desc; IWineD3DDevice_GetSwapChain(device, 0, swapchain)