Re: setupapi: Implement installing catalog files

2008-10-15 Thread Vincent Povirk
The patch you sent doesn't match the subject line. Vincent Povirk On Wed, Oct 15, 2008 at 11:05 AM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > --- > The functions called here are stubs, but don't cause this code to bomb out. > > From 04917f75269b6f4f51924ba734c20dc05617d882 Mon Sep 17 00:00

Try #3 for IDirectDrawSurface_GetSurfaceDesc error checking in ddraw test

2008-10-15 Thread chris ahrendt
Michael / All here is the third go at the ddraw test... and the patch for that... note I went ahead and used the goto. Also I found an error in the test where it was allocating the buffer in one place and it did not free it. Now here is the curious thing... When I did the first run of the dd

re: Wineg++ and structured exception handling

2008-10-15 Thread Dan Kegel
See http://wiki.winehq.org/CompilerExceptionSupport

Re: [RFC] jscript: Fix shift/reduce conflict by removing redundant FunctionDeclaration rule.

2008-10-15 Thread Jacek Caban
Hi Rob, Rob Shearman wrote: > The rule is implemented by FunctionExpression which is reduced using > the Statement rule. > --- > dlls/jscript/parser.y | 37 - > 1 files changed, 0 insertions(+), 37 deletions(-) > > The tests pass with this change, but I haven

Re: shdocvw: [Patch 1/2] Implement URLSubRegQueryA [Resend]

2008-10-15 Thread Detlef Riekenberg
On Mi, 2008-10-15 at 16:53 +0200, Alexandre Julliard wrote: > Detlef Riekenberg <[EMAIL PROTECTED]> writes: > > > +len = sizeof(buffer); > > +res = SHRegGetUSValueA(regpath, name, NULL, buffer, &len, FALSE, > > NULL, 0); > > +if (!res) { > > +lstrcpynA(out, buffer, outlen); >

Re: [PATCH 03/10] jscript: Added NaN value implementation.

2008-10-15 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > Alexandre Julliard wrote: >> I'd suggest to take advantage of the variant union instead of copying >> all these glibc definitions. Something like >> >> #ifdef NAN >> V_R8(&vt) = NAN; >> #else >> V_I8(&vt) = nan_magic_pattern; >> #endif >> > > Th

Re: [PATCH 03/10] jscript: Added NaN value implementation.

2008-10-15 Thread Jacek Caban
Alexandre Julliard wrote: I'd suggest to take advantage of the variant union instead of copying all these glibc definitions. Something like #ifdef NAN V_R8(&vt) = NAN; #else V_I8(&vt) = nan_magic_pattern; #endif The problem is that nan_magic_pattern would have to be 8 bytes and AFAI

Re: Michael Stefaniuc : shlwapi: Remove break after return (Smatch).

2008-10-15 Thread Lei Zhang
On Wed, Oct 15, 2008 at 2:11 PM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: > Hello Alexandre, > > I'm pretty sure that my patch contained only the second chunk of the > patch commited. The first part seems to have been credited to me by mistake. > The first chunk should have been in commit dc9e

Re: Michael Stefaniuc : shlwapi: Remove break after return (Smatch).

2008-10-15 Thread Michael Stefaniuc
Hello Alexandre, I'm pretty sure that my patch contained only the second chunk of the patch commited. The first part seems to have been credited to me by mistake. Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: d6359edd3cbe366c71f22e09e27d3e427520f609 > URL: > http://sour

Re: Wineg++ and structured exception handling

2008-10-15 Thread Scott Ritchie
Michael Ost wrote: > Hi, > > Is there a way for wineg++ to catch windows exceptions and handle them > as g++ does --- cleaning up stack variables, etc? > > My C++ winelib app, built with wineg++, is loading Windows DLLs. I want > to catch windows exceptions from functions that I call from those

Wineg++ and structured exception handling

2008-10-15 Thread Michael Ost
Hi, Is there a way for wineg++ to catch windows exceptions and handle them as g++ does --- cleaning up stack variables, etc? My C++ winelib app, built with wineg++, is loading Windows DLLs. I want to catch windows exceptions from functions that I call from those DLLs. I need to do some cleanup

Re: advapi32: Fall back to /dev/random if /dev/urandom can't be opened, and add warnings if opening either fails

2008-10-15 Thread Juan Lang
Hi Austin, > FWIW: http://en.wikipedia.org/wiki/Urandom (snip) > "A software program called EGD (entropy gathering daemon) is a common > alternative for Unix systems which do not support the /dev/random > device. Yep, I know. The problem with using EGD is that there isn't a standard path to it.

Re: advapi32: Fall back to /dev/random if /dev/urandom can't be opened, and add warnings if opening either fails

2008-10-15 Thread Austin English
On Wed, Oct 15, 2008 at 1:13 PM, Juan Lang <[EMAIL PROTECTED]> wrote: > Let me know if you think the fallback is a bad idea, or if a FIXME is > more appropriate than a WARN here. > --Juan > > > > FWIW: http://en.wikipedia.org/wiki/Urandom "/dev/random and /dev/urandom are also available on Solari

Re: wininet: quiet a noisy fixme

2008-10-15 Thread Maarten Lankhorst
I think this one can be better removed entirely, wine will never get support for dialup programs or other fancy ways to connect to the internet, so this fixme is useless.

Re: winex11.drv: Prevent XCreateIC from returning NULL when input style isn't "root". (try 3)

2008-10-15 Thread Alexandre Julliard
"Muneyuki Noguchi" <[EMAIL PROTECTED]> writes: > diff --git a/dlls/winex11.drv/x11drv.h b/dlls/winex11.drv/x11drv.h > index e5a40aa..f58342b 100644 > --- a/dlls/winex11.drv/x11drv.h > +++ b/dlls/winex11.drv/x11drv.h > @@ -701,6 +701,7 @@ struct x11drv_win_data > RECTwhole_rect; /*

Re: shdocvw: [Patch 1/2] Implement URLSubRegQueryA [Resend]

2008-10-15 Thread Alexandre Julliard
Detlef Riekenberg <[EMAIL PROTECTED]> writes: > +len = sizeof(buffer); > +res = SHRegGetUSValueA(regpath, name, NULL, buffer, &len, FALSE, NULL, > 0); > +if (!res) { > +lstrcpynA(out, buffer, outlen); > +if (outlen > 0) { > +out[min(outlen-1,len)] = '\0';

re: [user32: 2/2] Testcase for font size = 0x7fff

2008-10-15 Thread Dan Kegel
Koro wrote: > That is an *excellent* explanation. Everything becomes > clear now, and indeed this should be documented somewhere > (except I can't find how to edit the wiki without making an account). That's because you need an account. (Otherwise there's too much spam. Accounts are free.) >

Re: SourceForge community awards ... we won ... ;)

2008-10-15 Thread Kai Blin
On Wednesday 15 October 2008 15:46:25 Marcus Meissner wrote: > Hi, > > We won in the > SourceForge.net2008 Community Choice Awards > https://sourceforge.net/community/cca08/ > > in the Category: "Most Likely to Be Ambiguously and Baselessly Accused of > Patent Violation" So, given that this was ov

Re: Patchwatcher is watching lostwages patches

2008-10-15 Thread Dan Kegel
On Tue, Oct 14, 2008 at 11:11 PM, Scott Ritchie <[EMAIL PROTECTED]> wrote: > Just a small bug, but patchwatcher is complaining about my lostwages > patch not applying. Yeah, that's one of the many known bugs. When I have time to work on patchwatcher, which isn't often, my top priority is getting

Re: SourceForge community awards ... we won ... ;)

2008-10-15 Thread Henri Verbeet
2008/10/15 Marcus Meissner <[EMAIL PROTECTED]>: > Hi, > > We won in the > SourceForge.net2008 Community Choice Awards > https://sourceforge.net/community/cca08/ > > in the Category: "Most Likely to Be Ambiguously and Baselessly Accused of > Patent Violation" > > :) > > Ciao, Marcus > Cool :-)

SourceForge community awards ... we won ... ;)

2008-10-15 Thread Marcus Meissner
Hi, We won in the SourceForge.net2008 Community Choice Awards https://sourceforge.net/community/cca08/ in the Category: "Most Likely to Be Ambiguously and Baselessly Accused of Patent Violation" :) Ciao, Marcus

[RFC] jscript: Fix shift/reduce conflict by removing redundant FunctionDeclaration rule.

2008-10-15 Thread Rob Shearman
The rule is implemented by FunctionExpression which is reduced using the Statement rule. --- dlls/jscript/parser.y | 37 - 1 files changed, 0 insertions(+), 37 deletions(-) The tests pass with this change, but I haven't looked in detail as to whether it will

Re: [PATCH 03/10] jscript: Added NaN value implementation.

2008-10-15 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > +#include > +#include "basetsd.h" > + > +#ifndef NAN > + > +#ifdef __GNUC__ > + > +# define NAN \ > + (__extension__ > \ > + ((union { unsigned __l __attribute__ ((__mode__ (__SI__))); float

Re: rpcrt4(2/2): Use pseudo-random numbers to generate UUIDs rather than using the (old, deprecated) MAC-address-and-time generation algorithm

2008-10-15 Thread Alexandre Julliard
"Juan Lang" <[EMAIL PROTECTED]> writes: >> The change is OK but you'll want to flesh out RtlGenRandom first, >> currently it will fail pretty badly if /dev/urandom isn't available. > > Ah, good point. Thanks. Where isn't it available, out of curiosity? I thought it was missing on Solaris, but a

Re: Kernel32: 3GB UserSpace boot option

2008-10-15 Thread Dmitry Timoshkov
You still need to prove the second part of your claims. Please don't omit wine-devel from the cc: list. [I'm intentionally top posting so that you caould see why it's bad] "Stefan Reimer" <[EMAIL PROTECTED]> wrote: > Yeap I did, see: > > [EMAIL PROTECTED] ~ $ winedump .wine/drive_c/Program\ Fi

Re[9] [user32: 2/2] Testcase for font size = 0x7fff

2008-10-15 Thread Koro
> This will also affect the Wine RC compiler as well. Even the Windows RC compiler emits an invalid template in that case. I just tested with this .rc file: #include MSGBOXFONT DIALOGEX 0,0,128,128 STYLE WS_SYSMENU|WS_CAPTION|WS_POPUP|DS_SETFONT|DS_MODALFRAME CAPTION "Test" FONT 0x7fff,"",

Re: Kernel32: 3GB UserSpace boot option

2008-10-15 Thread Chris Robinson
On Wednesday 15 October 2008 01:37:46 am Dmitry Timoshkov wrote: > There is no need for hacks like that, 3 Gb address space limit is already > implemented in Wine, but is being activated only for applications marked > as IMAGE_FILE_LARGE_ADDRESS_AWARE for obvious reasons. Doesn't that only work if

Re[5] [user32: 2/2] Testcase for font size = 0x7fff

2008-10-15 Thread Koro
> This is not the intent of an Open Source project like Wine. The object > is to get your name in 'lights' and help fix a problem or implement new > code. Others then my modify it or even correct problems you did not > envision when you produced your code. > This directly violates the spirit an

Re: Kernel32: 3GB UserSpace boot option

2008-10-15 Thread Dmitry Timoshkov
"Stefan Reimer" <[EMAIL PROTECTED]> wrote: > The EQ2 binary is large address aware. > > Windows changes it upper most user space address from 0x7FFE to > 0xBFFE booting with /3GB and this is not possible in wine right now as > I think. Did you really check that? -- Dmitry.

Re: Kernel32: 3GB UserSpace boot option

2008-10-15 Thread Stefan Reimer
The EQ2 binary is large address aware. Windows changes it upper most user space address from 0x7FFE to 0xBFFE booting with /3GB and this is not possible in wine right now as I think. Stefan > "Stefan Reimer" <[EMAIL PROTECTED]> wrote: > >> I hacked wine to enable 3GB user address space j

Re: setupapi tests question

2008-10-15 Thread Reece Dunn
2008/10/15 Dmitry Timoshkov <[EMAIL PROTECTED]>: > "Reece Dunn" <[EMAIL PROTECTED]> wrote: > >> When building the setupapi tests with VC9 and the MSVC headers (Vista >> version) after using msvcmaker, I get the following output: >> >> 2>-- Build started: Project: setupapi_test, Configuration: D

Re: Kernel32: 3GB UserSpace boot option

2008-10-15 Thread Dmitry Timoshkov
"Stefan Reimer" <[EMAIL PROTECTED]> wrote: > I hacked wine to enable 3GB user address space just like the /3GB boot.ini > option for windows. ( see patch ) > This actually works like a charm playing everquest2 which crashes from > time to time without this patch due to running out of memory. > >

Re: setupapi tests question

2008-10-15 Thread Dmitry Timoshkov
"Reece Dunn" <[EMAIL PROTECTED]> wrote: > When building the setupapi tests with VC9 and the MSVC headers (Vista > version) after using msvcmaker, I get the following output: > > 2>-- Build started: Project: setupapi_test, Configuration: Debug > MSVC Headers Win32 -- > 2>Linking... > 2>mis

Re: Kernel32: 3GB UserSpace boot option

2008-10-15 Thread Scott Ritchie
Stefan Reimer wrote: > Hi, > I hacked wine to enable 3GB user address space just like the /3GB boot.ini > option for windows. ( see patch ) > This actually works like a charm playing everquest2 which crashes from > time to time without this patch due to running out of memory. Coincidentally, I saw

setupapi tests question

2008-10-15 Thread Reece Dunn
When building the setupapi tests with VC9 and the MSVC headers (Vista version) after using msvcmaker, I get the following output: 2>-- Build started: Project: setupapi_test, Configuration: Debug MSVC Headers Win32 -- 2>Linking... 2>misc.obj : error LNK2019: unresolved external symbol _MyFr

Kernel32: 3GB UserSpace boot option

2008-10-15 Thread Stefan Reimer
Hi, I hacked wine to enable 3GB user address space just like the /3GB boot.ini option for windows. ( see patch ) This actually works like a charm playing everquest2 which crashes from time to time without this patch due to running out of memory. To do it right, should this "3GB Option" be enabled