Re: [PATCH 2/4] advapi32/tests: Simple tests of GetFileSecurity()/SetFileSecurity()

2008-11-04 Thread James Hawkins
On Wed, Nov 5, 2008 at 1:01 AM, Paul Bryan Roberts <[EMAIL PROTECTED]> wrote: > This is a resubmission > > This patch has been reworked. > The changes in the Wine server is withdrawn. > Only a minimum of tests of GetFileSecurity() and SetFileSecuirty() for the > 'file case' are provided. > I haven

Re: [PATCH] comctl32: support drawing themed push buttons. [try 4] [resend]

2008-11-04 Thread Reece Dunn
2008/11/5 Roderick Colenbrander <[EMAIL PROTECTED]>: > Hi, > > I have the feeling that some of the drawing code is not correct and should > use information which is buried inside the theme file. Things like content > margins, text positions and things like that. I think it also requires test > c

Re: [PATCH] comctl32: support drawing themed push buttons. [try 4] [resend]

2008-11-04 Thread Roderick Colenbrander
Hi, I have the feeling that some of the drawing code is not correct and should use information which is buried inside the theme file. Things like content margins, text positions and things like that. I think it also requires test cases on what has to be done when a property isn't set in the the

Wine theming (follow up)

2008-11-04 Thread Roderick Colenbrander
Hi, The way to go for Wine theming is to use Windows XP themes. Unfortunately the file format itself is not documented. Based on Wine its uxtheme code (BTW our uxtheme is quite complete) and an analysis of some 'free' XP themes like 'ClearLook' I was able to write my own theme template. First

Re: Wine support for win64

2008-11-04 Thread Francois Gouget
On Tue, 4 Nov 2008, Michael Stefaniuc wrote: [...] > > The fix for all these is to replace 'long' with 'LONG' which Wine keeps > > 32bit just like Windows (though I wonder if we should not use something > > lile 'wine_long' instead). > What would 'wine_long' gain us? LONG is already ugly enough.

Re: Wine support for win64

2008-11-04 Thread Michael Stefaniuc
Francois Gouget wrote: > On Tue, 4 Nov 2008, Stefan Dösinger wrote: > [...] >> I think we still have the problem that gcc doesn't support the calling >> convention Win64 uses, so we can't compile a Wine that is compatible with >> Win64 apps. > > In the meantime we can work on the long vs. LONG iss

Re: Wine support for win64

2008-11-04 Thread Reece Dunn
2008/11/4 Francois Gouget <[EMAIL PROTECTED]>: > On Tue, 4 Nov 2008, Stefan Dösinger wrote: > [...] >> I think we still have the problem that gcc doesn't support the calling >> convention Win64 uses, so we can't compile a Wine that is compatible with >> Win64 apps. > > In the meantime we can work o

RE: Wine support for win64

2008-11-04 Thread Francois Gouget
On Tue, 4 Nov 2008, Stefan Dösinger wrote: [...] > I think we still have the problem that gcc doesn't support the calling > convention Win64 uses, so we can't compile a Wine that is compatible with > Win64 apps. In the meantime we can work on the long vs. LONG issue: * there are a number of place

Re: [ddraw/tests] Fix a test on W2K3

2008-11-04 Thread chris ahrendt
Paul Vriens wrote: > Henri Verbeet wrote: > >> 2008/11/4 Paul Vriens <[EMAIL PROTECTED]>: >> >>> Hi, >>> >>> I upgraded to VMware 6.5.0 this morning and overlay tests are run now on my >>> W2K3 >>> box. As the return value indicates E_NOTIMPL I decided to add a skip() for >>> one particular

Re: [ddraw/tests] Fix a test on W2K3

2008-11-04 Thread Paul Vriens
Henri Verbeet wrote: > 2008/11/4 Paul Vriens <[EMAIL PROTECTED]>: >> And how would you like to approach that? Most of us run tests on some piece >> of virtualization software. Should we check for VMware and don't run >> d3d8/9/10 and ddraw tests anymore at all? We do want to have a green >> test.wi

Re: [ddraw/tests] Fix a test on W2K3

2008-11-04 Thread Henri Verbeet
2008/11/4 Paul Vriens <[EMAIL PROTECTED]>: > And how would you like to approach that? Most of us run tests on some piece > of virtualization software. Should we check for VMware and don't run > d3d8/9/10 and ddraw tests anymore at all? We do want to have a green > test.winehq.org after all. > I sup

Re: [ddraw/tests] Fix a test on W2K3

2008-11-04 Thread Paul Vriens
Henri Verbeet wrote: > 2008/11/4 Paul Vriens <[EMAIL PROTECTED]>: >> Hi, >> >> I upgraded to VMware 6.5.0 this morning and overlay tests are run now on my >> W2K3 >> box. As the return value indicates E_NOTIMPL I decided to add a skip() for >> one particular test. >> > VMware is not a valid test pl

Re: [ddraw/tests] Fix a test on W2K3

2008-11-04 Thread Henri Verbeet
2008/11/4 Paul Vriens <[EMAIL PROTECTED]>: > Hi, > > I upgraded to VMware 6.5.0 this morning and overlay tests are run now on my > W2K3 > box. As the return value indicates E_NOTIMPL I decided to add a skip() for > one particular test. > VMware is not a valid test platform for ddraw.

Re: Wine support for win64

2008-11-04 Thread Marcus Meissner
On Tue, Nov 04, 2008 at 02:36:02PM +0100, Stefan Dösinger wrote: > > This summer Maarten Lankhorst did some basic work on win64 support but > > for the rest no work has been done it for a long time. I'm not sure > > what Maarten exactly did but but there is a lot of work to be done > > before it wi

Re: Wine support for win64

2008-11-04 Thread Steven Edwards
On Tue, Nov 4, 2008 at 8:36 AM, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > I think we still have the problem that gcc doesn't support the calling > convention Win64 uses, so we can't compile a Wine that is compatible with > Win64 apps. > > That may be fixed in gcc already though. I haven't checke

RE: Wine support for win64

2008-11-04 Thread Stefan Dösinger
> This summer Maarten Lankhorst did some basic work on win64 support but > for the rest no work has been done it for a long time. I'm not sure > what Maarten exactly did but but there is a lot of work to be done > before it will run even a basic app. I think we still have the problem that gcc doesn

Re: [PATCH 2/6] server: Fix lacuna in server side implementation of SetFileSecurity()

2008-11-04 Thread Alexandre Julliard
Paul Bryan Roberts <[EMAIL PROTECTED]> writes: > The bit I take issue with is not cloning the "FIXME: get Unix uid and > call fchown" in file_set_sd(), nor really the idea that this bit of > code does nothing, not even return an error to indicate it has not > succeeded but that it is always execut

Re: [PATCH 1/6] advapi32: GetFileSecurity() a couple of simple tests and a fix

2008-11-04 Thread Alexandre Julliard
Paul Bryan Roberts <[EMAIL PROTECTED]> writes: > This patch adds a couple of conformance tests that check 'error' > return codes. GetFileSecurity() is expected to be called twice - once > to find out how much memory to allocate and again once the memory has > been allocated. It seems the Windows

Re: advapi32/tests: Run a test on more platforms (try2)

2008-11-04 Thread Nicolas Le Cam
2008/11/4 Alexandre Julliard <[EMAIL PROTECTED]>: > Nicolas Le Cam <[EMAIL PROTECTED]> writes: > >> @@ -614,7 +614,9 @@ static void test_enum_provider_types(void) >> DWORD dwTypeCount; >> >> /* actual values */ >> - DWORD index = 0; >> + /* the first provider type registry key m

Re: [PATCH] comctl32: support drawing themed push buttons. [try 4] [resend]

2008-11-04 Thread Alexandre Julliard
"Reece Dunn" <[EMAIL PROTECTED]> writes: > +static WCHAR *get_button_text(HWND hwnd, int *len) > +{ > +WCHAR *text; > +*len = GetWindowTextLengthW(hwnd); > +text = HeapAlloc(GetProcessHeap(), 0, (*len + 1) * sizeof(WCHAR)); > +if (text) > +GetWindowTextW(hwnd, text, *len +

Re: advapi32/tests: Run a test on more platforms (try2)

2008-11-04 Thread Alexandre Julliard
Nicolas Le Cam <[EMAIL PROTECTED]> writes: > @@ -614,7 +614,9 @@ static void test_enum_provider_types(void) > DWORD dwTypeCount; > > /* actual values */ > - DWORD index = 0; > + /* the first provider type registry key may not have a TypeName subkey > + * we use the

Re: (try 5) comdlg32/tests: Windows XP+ cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.

2008-11-04 Thread Alexandre Julliard
Aric Stewart <[EMAIL PROTECTED]> writes: > @@ -182,19 +182,26 @@ static UINT CALLBACK create_view_window2_hook(HWND dlg, > UINT msg, WPARAM wParam, > > hr = IShellView2_GetCurrentInfo(shell_view2, &folder_settings); > ok(SUCCEEDED(hr), "GetCurrentInfo returned %#x\n",

Re: user32: handle GetMenuItemCount returning -1 (coverity 229)

2008-11-04 Thread Alexandre Julliard
Aric Stewart <[EMAIL PROTECTED]> writes: > diff --git a/dlls/user32/mdi.c b/dlls/user32/mdi.c > index fe70b80..1404436 100644 > --- a/dlls/user32/mdi.c > +++ b/dlls/user32/mdi.c > @@ -393,7 +393,8 @@ static LRESULT MDISetMenu( HWND hwnd, HMENU hmenuFrame, > */ > static LRESULT MDI_RefreshMenu(M

Re: Wine support for win64

2008-11-04 Thread Roderick Colenbrander
This summer Maarten Lankhorst did some basic work on win64 support but for the rest no work has been done it for a long time. I'm not sure what Maarten exactly did but but there is a lot of work to be done before it will run even a basic app. Roderick > Hi, i'd like to know if anyone knows the