Re: mshtml: suppress module unloading while gecko is loaded

2008-12-01 Thread Paul Bryan Roberts
Dan Kegel wrote: Thanks to Mike Hearn for pointing out that mshtml reference counting was wrong, and Jacek for pointing out how to fix it for now. Once gecko is loaded, don't let mshtml unload. This fixes a crash in starting Sketchup (bug 16164), and probably fixes a number of

Error Message and Office 2000

2008-12-01 Thread [EMAIL PROTECTED]
Hi, I'm in Southern California. I did a search for the event when my Office 2000 Professional gave me an error message. It won't setup. The event was 1000 and the fault address is the same as a read out of your computer that you posted online.

Re: d3d9 : do not proceed reset or release from another thread than the one which created the device.

2008-12-01 Thread Henri Verbeet
2008/11/30 Jérôme Gardou [EMAIL PROTECTED]: -if (ref == 0) { +if (ref = 0) { This doesn't work, of course. ref is an ULONG. The check for Reset should probably go into wined3d.

Re: wineconsole: Wait on events in curses backend using select instead of poll

2008-12-01 Thread Martin Storsjö
On Mon, 1 Dec 2008, Kai Blin wrote: On Sunday 30 November 2008 00:52:57 Martin Storsjö wrote: poll can't handle terminal devices on Darwin, since Tiger. See the following discussion: http://lists.apple.com/archives/Darwin-dev/2006/Apr/msg00066.html There's reasons we switched from select to

Re: ole32: implement CoGetCallContext and CoSwitchCallContext

2008-12-01 Thread Rob Shearman
2008/11/30 Austin English [EMAIL PROTECTED]: +if( !ppv) +return E_INVALIDARG; + +/* get COM tls */ +info = COM_CurrentInfo(); +if( !info) Please try to keep the style consistent here. The style that the rest of the file uses is a space after the if and no space

Re: [advapi32/tests] Fix some crashes on NT4 (Try2)

2008-12-01 Thread Paul Vriens
On Sat, Nov 29, 2008 at 12:52 PM, Paul Vriens [EMAIL PROTECTED] wrote: Hi, (Try2 removes some useless LocalFree's when NewAcl is NULL, duh). NT4 crashes at 3 distinct places. The first two we can get rid of by removing the LocalFree on failure. The third one we can skip as we can detect NT4

USB device drivers support

2008-12-01 Thread Alexander Morozov
Hello, I sent patch Add support of WDM drivers for USB devices. in October and received such reply from Alexandre Julliard: Your design needs a lot more thought. You can't add all these Wine-specific modules, or make winedevice special-case usb devices, or poll the server for the add_device

Re: wined3d: Sign-compare warnings fix

2008-12-01 Thread Andrew Talbot
Austin English wrote: This-baseShader.device; int i; -unsigned int extra_constants_needed = 0; +unsigned int i, extra_constants_needed = 0; You forgot to remove 'int i' here. Thanks, Austin. Good catch! -- Andy.

Fwd: [1/2] shell32/autocomplete: fix handling of WM_KILLFOCUS messages (try 2)

2008-12-01 Thread Jan de Mooij
Hello, Anybody knows why this patch was rejected? Thanks in advance. -- Forwarded message -- From: Jan de Mooij [EMAIL PROTECTED] Date: Sat, Nov 29, 2008 at 8:57 PM Subject: [1/2] shell32/autocomplete: fix handling of WM_KILLFOCUS messages (try 2) To: [EMAIL PROTECTED]

Re: [1/4] winemenubuilder: move path normalization to Process_Link and Process_URL

2008-12-01 Thread Francois Gouget
On Sun, 30 Nov 2008, Ambroz Bizjak wrote: [...] To allow that, I've modified winemenubuilder to record created shortcuts to registry, and my service will obtain and maintain the list of .lnk/url files from there. The general idea is good, but I don't think you should store these paths in

Re: [2/2] shell32/autocomplete: add unit tests for autocomplete

2008-12-01 Thread Paul Vriens
Jan de Mooij wrote: Tests pass on 98, XP and Wine (after applying my previous patch) There is an unrelated change to shelllink.c in this patch. -- Cheers, Paul.

Re: [2/2] shell32/autocomplete: add unit tests for autocomplete

2008-12-01 Thread Jan de Mooij
Hi Paul, Thanks for your reply. On Mon, Dec 1, 2008 at 3:35 PM, Paul Vriens [EMAIL PROTECTED] wrote: There is an unrelated change to shelllink.c in this patch. It's not unrelated, initguid.h needs to be included exactly once or you will get linker warnings (multiple definitions for...). It

Re: [2/2] shell32/autocomplete: add unit tests for autocomplete

2008-12-01 Thread Paul Vriens
Jan de Mooij wrote: Hi Paul, Thanks for your reply. On Mon, Dec 1, 2008 at 3:35 PM, Paul Vriens [EMAIL PROTECTED] wrote: There is an unrelated change to shelllink.c in this patch. It's not unrelated, initguid.h needs to be included exactly once or you will get linker warnings

Mono integration to Wine

2008-12-01 Thread Kornél Pál
Hi, Wine is still using Mono by creating a new process altough it has support for _CorExeMain and _CorDllMain. There is a MonoFixupCorEE method exported by mono.dll that could be used. I also did some research on executing exe assemblies without creating a mono.exe process on MS Windows by

Re: Did anyone have any trouble compiling wine today? Or was it just me ....

2008-12-01 Thread Susan Cragin
I don't know off hand then. I'd say run a regression test. As a guess, you might try removing: #ifdef HAVE_LINUX_SERIAL_H #include linux/serial.h #endif but that would just be a kludgy workaround. -- -Austin Will try both tomorrow. Thanks. Austin: Did not see above section, but did see this,

netapi32: Why my patch is ignored?

2008-12-01 Thread Vitaly Perov
What is wrong with my patch? I have fixed all errors found by Juan Lang. I resent this patch several times, but hasn't received any answer. Why my patch is ignored? Maybe something is still wrong, but why somebody just tell me about it? Juan Lang [EMAIL PROTECTED] wrote: Hi Vitaliy, overall

Re: netapi32: Why my patch is ignored?

2008-12-01 Thread Alexandre Julliard
Vitaly Perov [EMAIL PROTECTED] writes: +GetCurrentDirectoryA(MAX_PATH, tmpPath); +result = SetCurrentDirectoryW(path); +SetCurrentDirectoryA(tmpPath); +if (!result) return ERROR_FILE_NOT_FOUND; This is not the right way to test if a directory exists. -- Alexandre Julliard

Re: [1/4] winemenubuilder: move path normalization to Process_Link and Process_URL

2008-12-01 Thread Ambroz Bizjak
On Monday 01 December 2008, Francois Gouget wrote: On Sun, 30 Nov 2008, Ambroz Bizjak wrote: [...] To allow that, I've modified winemenubuilder to record created shortcuts to registry, and my service will obtain and maintain the list of .lnk/url files from there. The general idea is

Re: netapi32: Why my patch is ignored?

2008-12-01 Thread Paul Vriens
Vitaly Perov wrote: What is wrong with my patch? I have fixed all errors found by Juan Lang. I resent this patch several times, but hasn't received any answer. Why my patch is ignored? Maybe something is still wrong, but why somebody just tell me about it? Juan Lang [EMAIL PROTECTED]

Re: mshtml: suppress module unloading while gecko is loaded

2008-12-01 Thread Dan Kegel
On Mon, Dec 1, 2008 at 12:08 AM, Paul Bryan Roberts [EMAIL PROTECTED] wrote: In mshtml, I count 7 dll reference count inc/dec pairs, including the server lock pair, in main.c, htmldoc.c and protocol.c I count 28 pairs of InterlockedDecrement / InterlockedIncrement calls around the creation /

Re: netapi32: Why my patch is ignored?

2008-12-01 Thread Vitaly Perov
On Monday 01 December 2008 18:45:22 Alexandre Julliard wrote: Vitaly Perov [EMAIL PROTECTED] writes: +GetCurrentDirectoryA(MAX_PATH, tmpPath); +result = SetCurrentDirectoryW(path); +SetCurrentDirectoryA(tmpPath); +if (!result) return ERROR_FILE_NOT_FOUND; This is not the

Re: Did anyone have any trouble compiling wine today? Or was it just me ....

2008-12-01 Thread Susan Cragin
On Mon, Dec 1, 2008 at 9:06 AM, Susan Cragin [EMAIL PROTECTED] wrote: I don't know off hand then. I'd say run a regression test. As a guess, you might try removing: #ifdef HAVE_LINUX_SERIAL_H #include linux/serial.h #endif but that would just be a kludgy workaround. -- -Austin Will try both

Patchwatcher locked up?

2008-12-01 Thread Michael Stefaniuc
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Dan, did the patchwatcher look up? The last patch it shows is from 30-Nov-2008 14:01. bye michael -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with Red Hat - http://enigmail.mozdev.org

Re: Error Message and Office 2000

2008-12-01 Thread Rob Shearman
2008/11/30 [EMAIL PROTECTED] [EMAIL PROTECTED]: Hi, I'm in Southern California. I did a search for the event when my Office 2000 Professional gave me an error message. It won't setup. The event was 1000 and the fault address is the same as a read out of your computer that you posted

Re: Bugzilla's down again

2008-12-01 Thread Lei Zhang
On Wed, Nov 26, 2008 at 2:15 PM, Austin English [EMAIL PROTECTED] wrote: On Wed, Nov 26, 2008 at 4:12 PM, Jeremy Newman [EMAIL PROTECTED] wrote: mysqld didn't crash at least. This seems to be a temporary issue that cleared up when the server load came back down. I don't think the server has

Re: [08/12] msxml3: Add an internal IUnknown object for xmlnode

2008-12-01 Thread Michael Karcher
Am Samstag, den 29.11.2008, 10:52 +0100 schrieb Michael Karcher: This makes the xmlnode structures kind-of aggregatable COM objects. The explanation of the new reference management is in the rather verbose comment at the top of the new node_unk.c file. For reference, the comment explaining the

Re: winetest.exe now available on test.winehq.org

2008-12-01 Thread Paul Millar
On Saturday 29 November 2008 15:40:33 Paul Vriens wrote: This also means that Paul Millars winetest is no longer available. Yup, this is true. After providing winetest.exe for (I think) a little over 4 years, quisquiliae is falling silent and WineHQ is picking up the baton for winetest.exe.

Status of 64 bit Wine

2008-12-01 Thread Michael Ost
Hi list, Every once in a while my boss asks me about 64 bit wine. And today was the day. So what's the status? From my understanding there are two parts to the question. First, is anyone using a 64 bit build of Wine? How successfully? Does it pass the internal wine tests? And second, is