Re: [try2] dinput: joydevs[id].name (EVIOCGNAME) is product name, joydevs[id].device is a path

2009-02-10 Thread Ben Klein
2009/2/10 Vincent Pelletier plr.vinc...@gmail.com: On Tue, Feb 10, 2009 at 8:51 AM, Ben Klein shackl...@gmail.com wrote: You're taking out the strcpy into device, and replacing it with a strcpy into instance_name. What value will the device field hold? Err... strcpy from instance_name to the

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Alexandre Julliard
Vitaliy Margolen wine-de...@kievinfo.com writes: Alexandre Julliard wrote: Again, please demonstrate the exact sequence that leads to an actual problem, not just vague hearsay of people reporting problems that may or may not have anything to do with this. Will this work? BTW default Open

Re: [PATCH] winegcc: Free the temporary string arrays (Coverity)

2009-02-10 Thread Alexandre Julliard
Marcus Meissner mar...@jet.franken.de writes: Hi, This fixes CID 883, 882, 881, 880, 879, 878, 877, which are all basically missing strarray_free(arr)s. winegcc is a short-lived program, there's no reason to care about memory leaks. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] winegcc: Free the temporary string arrays (Coverity)

2009-02-10 Thread Michael Stefaniuc
Alexandre Julliard wrote: Marcus Meissner mar...@jet.franken.de writes: This fixes CID 883, 882, 881, 880, 879, 878, 877, which are all basically missing strarray_free(arr)s. winegcc is a short-lived program, there's no reason to care about memory leaks. Right but the problem is that

Re: [PATCH] winegcc: Free the temporary string arrays (Coverity)

2009-02-10 Thread Alexandre Julliard
Michael Stefaniuc mstef...@redhat.com writes: Alexandre Julliard wrote: Marcus Meissner mar...@jet.franken.de writes: This fixes CID 883, 882, 881, 880, 879, 878, 877, which are all basically missing strarray_free(arr)s. winegcc is a short-lived program, there's no reason to care about

Re: spoolss: Implement EnumPorts [try 2]

2009-02-10 Thread Alexandre Julliard
Detlef Riekenberg wine@web.de writes: Synced to current git. It doesn't work here: ../../../tools/runtest -q -P wine -M winspool.drv -T ../../.. -p winspool.drv_test.exe.so info.c touch info.ok info.c:505: Test failed: got 1 with 127 (expected '0' with ERROR_INVALID_PARAMETER) make: ***

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Francois Gouget
On Tue, 10 Feb 2009, Ben Klein wrote: [...] Application tried to create a window, but no driver could be loaded. Make sure that your X server is running and that $DISPLAY is set correctly. Interesting. xauth problem. Again, I'd be surprised if this happened with sudo. Not so surprised if it

Re: itss: Replace malloc() with HeapAlloc()

2009-02-10 Thread Francois Gouget
On Tue, 10 Feb 2009, Nikolay Sivov wrote: [...] Why didn't you replace corresponding free() calls? Also, for everyone's information, there's more calls to malloc() and free(). I only grepped in the dlls/ directory where they are the most suspicious. I removed some obvious false positives but

Re: mshtml/tests: Better check for installed Gecko.

2009-02-10 Thread Alexandre Julliard
Jacek Caban ja...@codeweavers.com writes: @@ -4199,9 +4199,8 @@ static void run_domtest(const char *str, domtest_t test) } hres = IHTMLDocument2_get_body(doc, body); -ok(hres == S_OK, get_body failed: %08x\n, hres); - -if(body) { +if(hres != E_UNEXPECTED) { +

Re: [PATCH] gdi32: handle failure in __wine_make_gdi_object_system (Coverity)

2009-02-10 Thread Alexandre Julliard
Marcus Meissner mar...@jet.franken.de writes: @@ -445,6 +445,11 @@ static const struct DefaultFontInfo default_fonts[] = void CDECL __wine_make_gdi_object_system( HGDIOBJ handle, BOOL set) { GDIOBJHDR *ptr = GDI_GetObjPtr( handle, 0 ); + +if (!ptr) { +ERR(System object

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Vitaliy Margolen
Alexandre Julliard wrote: Vitaliy Margolen wine-de...@kievinfo.com writes: Alexandre Julliard wrote: Again, please demonstrate the exact sequence that leads to an actual problem, not just vague hearsay of people reporting problems that may or may not have anything to do with this. Will

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Austin English
On Tue, Feb 10, 2009 at 8:38 AM, Vitaliy Margolen wine-de...@kievinfo.com wrote: Alexandre Julliard wrote: Vitaliy Margolen wine-de...@kievinfo.com writes: Alexandre Julliard wrote: Again, please demonstrate the exact sequence that leads to an actual problem, not just vague hearsay of people

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Alexandre Julliard
Austin English austinengl...@gmail.com writes: That's not the (main) problem. The main problem is people installing stuff as root when they have no reason to do so. Alexandre, how would you feel about a one time warning, e.g., by setting a registry key, a la wineboot when run on a

Re: imagicos

2009-02-10 Thread Jeremy White
EA Durbin wrote: I just saw this linux distribution on distrowatch. They claim to be able to run all microsoft products. Interesting. Just for the record, these folks are customers of ours. It is my belief that their distribution of CrossOver complies with all of the terms of the LGPL; we try

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Austin English
On Tue, Feb 10, 2009 at 10:44 AM, Alexandre Julliard julli...@winehq.org wrote: Austin English austinengl...@gmail.com writes: That's not the (main) problem. The main problem is people installing stuff as root when they have no reason to do so. Alexandre, how would you feel about a one time

Re: Fixing AppDB once and for all

2009-02-10 Thread Rosanne DiMesio
Could we also have some discussion about improving the interface for admins/maintainers? I've found that the limitations of the current interface make it very difficult to do basic admin tasks. -- Rosanne DiMesio dime...@earthlink.net Rosanne, I think thats a good idea.

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Alexandre Julliard
Austin English austinengl...@gmail.com writes: On Tue, Feb 10, 2009 at 10:44 AM, Alexandre Julliard julli...@winehq.org wrote: No, a warning that will get drowned in a bunch of other fixmes is not useful. We could make it a popup warning, again, only on first run. No, warning message boxes

Re: imagicos

2009-02-10 Thread James Mckenzie
Jeremy White jwh...@winehq.org wrote: EA Durbin wrote: I just saw this linux distribution on distrowatch. They claim to be able to run all microsoft products. Interesting. Just for the record, these folks are customers of ours. Thank you for the clarification of your relationship with this

Re: gdiplus: add a drawing test for GdipFillRectangleI

2009-02-10 Thread Nikolay Sivov
Vincent Povirk wrote: This is a very simple drawing test that I've created to establish a precedent for drawing tests in gdiplus. Gdiplus currently has no tests that draw things and then check what was drawn. I've added some functions that should make this easy. It's important to get this

Re: gdiplus: add a drawing test for GdipFillRectangleI

2009-02-10 Thread Vincent Povirk
As for me I'm not against it if it'll work stably, but will this really help? It's much easier to check this visually, comparing with native output. I think it will help. It should be stable as long as we are careful about how strict the tests are. It's probably not as appropriate to be this

Re: gdiplus: add a drawing test for GdipFillRectangleI

2009-02-10 Thread Nikolay Sivov
Vincent Povirk wrote: As for me I'm not against it if it'll work stably, but will this really help? It's much easier to check this visually, comparing with native output. I think it will help. It should be stable as long as we are careful about how strict the tests are. It's probably not

Re: gdiplus: add a drawing test for GdipFillRectangleI

2009-02-10 Thread Vincent Povirk
P.S. there's no place for todo_wine in you expect_pixel. You can write todo_wine expect_pixel(...);

Re: itss: Replace malloc() with HeapAlloc()

2009-02-10 Thread Andrew Talbot
Francois Gouget wrote: Also, for everyone's information, there's more calls to malloc() and free(). There are also many calls to realloc() - a function with complexities of its own - and other functions with realloc in their name. -- Andy.

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Ben Klein
2009/2/10 Francois Gouget fgou...@free.fr: On Tue, 10 Feb 2009, Ben Klein wrote: [...] Application tried to create a window, but no driver could be loaded. Make sure that your X server is running and that $DISPLAY is set correctly. Interesting. xauth problem. Again, I'd be surprised if this

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Vincent Povirk
How about this: If uid = 0, SUDO_USER is set to a valid username, HOME is owned by that user, and WINEPREFIX is not set, then refuse to start, printing a message explaining the situation. Perhaps the message can be something like You're running Wine for the first time as root, but your home

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Ben Klein
2009/2/11 Vincent Povirk madewokherd+8...@gmail.com: How about this: If uid = 0, SUDO_USER is set to a valid username, HOME is owned by that user, and WINEPREFIX is not set, then refuse to start, printing a message explaining the situation. To abstract what you're saying here, you're

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Vitaliy Margolen
Ben Klein wrote: This is not a problem with Wine, this is OpenSUSE breaking the environment when sudo is called. Remember, Wine is not the only X11 app out there. Others will need $DISPLAY working! This is something called security

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Vincent Povirk
To abstract what you're saying here, you're suggesting to extend the wineprefix ownership test to include $HOME when $WINEPREFIX is not set and $HOME/.wine does not exist? That doesn't sounds like a bad idea to me. But I'm not so sure about specifically testing on UID=0 or SUDO_USER. This

Fully automated bisecting with git bisect run [LWN.net]

2009-02-10 Thread nn
Fully automated bisecting with git bisect run [LWN.net]: http://lwn.net/SubscriberLink/317154/5dec0c8146e58b61/ Would this be useful to add to the instructions on the wine wiki. Make Yahoo!7 your homepage and win a trip to the Quiksilver Pro. Find out more

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Ben Klein
2009/2/11 Vitaliy Margolen wine-de...@kievinfo.com: Ben Klein wrote: This is not a problem with Wine, this is OpenSUSE breaking the environment when sudo is called. Remember, Wine is not the only X11 app out there. Others will need $DISPLAY working! This is something called security This

Re: Fully automated bisecting with git bisect run [LWN.net]

2009-02-10 Thread Ben Klein
2009/2/11 nn saturn_syst...@yahoo.com: Fully automated bisecting with git bisect run [LWN.net]: http://lwn.net/SubscriberLink/317154/5dec0c8146e58b61/ Would this be useful to add to the instructions on the wine wiki. If I understand this correctly, this is only useful when the regression is

Re: Fully automated bisecting with git bisect run [LWN.net]

2009-02-10 Thread Vincent Pelletier
On Wed, Feb 11, 2009 at 7:06 AM, Ben Klein shackl...@gmail.com wrote: If I understand this correctly, this is only useful when the regression is something that can be tested without human interaction. This makes it virtually useless for Wine, as most regressions involve loss of functionality