Re: NetBSD compiler warnings patches - review request

2009-04-24 Thread David Laight
On Thu, Apr 23, 2009 at 11:46:38AM -0500, Austin English wrote: Howdy, I recently started retesting NetBSD (5.0 this time), and have filed bugs for most of the warnings. A few of them I have patches ready for, but figured I should probably get reviewed first: There's a NetBSD bug here.

Re: richedit: Null terminate streamed out rich text.

2009-04-24 Thread Massimo Del Fedele
Dylan Smith ha scritto: This can easily be tested by saving a rich text document in wordpad. The rich text will always be null terminated, unlike plain text files which will not have a terminating null byte. I noticed in a bug 14827 that AutoCAD 2005 looked for this NULL byte to determine the

Re: Redirector code in Wine?

2009-04-24 Thread Kai Blin
On Friday 24 April 2009 06:00:04 you wrote: Kai wrote: I'm trying to figure out where the wine server actually decides if a file actually is a file on disk, a local or a remote pipe. Any pointers? Search for FileFsDeviceInformation in ntdll/file.c, maybe. Hm, I should have worded this

Re: [3/5] wined3d: The first shader token should be the version token.

2009-04-24 Thread Stefan Dösinger
Am Freitag, 24. April 2009 09:21:23 schrieb Henri Verbeet: Did you test this? What if the shader starts with a comment?

Re: Extensive ScrollDC investigation (resubmit)

2009-04-24 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: @@ -120,13 +122,58 @@ BOOL CDECL X11DRV_ScrollDC( HDC hdc, INT dx, INT dy, const RECT *lprcScroll, if( TRACE_ON( scroll)) dump_region( Destination scroll region: , DstRgn); /* if there are any, do it */ if( res NULLREGION) { -

Re: [1/4] Resend: ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

2009-04-24 Thread Alexandre Julliard
Jeff Latimer l...@yless4u.com.au writes: @@ -55,6 +55,9 @@ ok ( cond tmp, msg, GetCurrentThreadId(), err); \ } while (0); +/* Function pointers */ +static HMODULE hws2_32 = 0; +static PCTSTR (WINAPI *pInetNtop)(int,LPVOID,LPTSTR,ULONG) = 0; There's no point in resending

Re: [3/5] wined3d: The first shader token should be the version token.

2009-04-24 Thread Henri Verbeet
2009/4/24 Stefan Dösinger stefandoesin...@gmx.at: Am Freitag, 24. April 2009 09:21:23 schrieb Henri Verbeet: Did you test this? What if the shader starts with a comment? It doesn't make sense to try and parse a shader before knowing what version it is. Besides, this is consistent with

Dan's dotest reports

2009-04-24 Thread chris ahrendt
Are the Wine Developers using this report? Chris

Re: [1/4] Resend: ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

2009-04-24 Thread Jeff Latimer
There's no point in resending if you don't fix the reason it was rejected the first time. My apology, I corrected what I thought was the problem but did not see the others. Have resubmitted it.

Re: [1/7] [wined3d] move creation of NP2 fixup uniforms into separate loop (retry)

2009-04-24 Thread Tobias Jakobi
Stefan Dösinger wrote: Am Donnerstag, 23. April 2009 14:54:54 schrieb Tobias Jakobi: NAK Suggestions? Explanations? Like explained putting this into prog_link won't work. It doesn't make sense in the first place. Using a separate struct for GLSL and ARB isn't also making sense, since the

Re: Dan's dotest reports

2009-04-24 Thread chris ahrendt
André Hentschel wrote: chris ahrendt schrieb: Are the Wine Developers using this report? Chris If you are talking about the testsuite(test.winehq.org) then it is not the only source of information for developers but an important one. yes that is what I am talking

Re: Dan's dotest reports

2009-04-24 Thread André Hentschel
chris ahrendt schrieb: Are the Wine Developers using this report? Chris If you are talking about the testsuite(test.winehq.org) then it is not the only source of information for developers but an important one.

Re: [1/7] [wined3d] move creation of NP2 fixup uniforms into separate loop (retry)

2009-04-24 Thread Stefan Dösinger
Am Donnerstag, 23. April 2009 14:54:54 schrieb Tobias Jakobi: NAK Suggestions? Explanations? Like explained putting this into prog_link won't work. It doesn't make sense in the first place. Using a separate struct for GLSL and ARB isn't also making sense, since the data stored in the

Re: Dan's dotest reports

2009-04-24 Thread Austin English
On Fri, Apr 24, 2009 at 11:25 AM, chris ahrendt celtich...@yahoo.com wrote: André Hentschel wrote: chris ahrendt schrieb: Are the Wine Developers using this report? Chris If you are talking about the testsuite(test.winehq.org) then it is not the only source of information for

Re: [1/7] [wined3d] move creation of NP2 fixup uniforms into separate loop (retry)

2009-04-24 Thread Stefan Dösinger
I think Henri is generally against adding something to the ps_compiled_shader structure - but I might be wrong there. However I don't know how to implement the code without introducing new data to ps_compiled_shader. No, he doesn't like having this info visible outside the backend. You can

Re: [1/7] [wined3d] move creation of NP2 fixup uniforms into separate loop (retry)

2009-04-24 Thread Tobias Jakobi
Stefan Dösinger wrote: I think Henri is generally against adding something to the ps_compiled_shader structure - but I might be wrong there. However I don't know how to implement the code without introducing new data to ps_compiled_shader. No, he doesn't like having this info visible outside

Re: [1/2] D3D: Limit d3d8 and d3d9 vshader constants to 256

2009-04-24 Thread Henri Verbeet
Not my preferred fix, but I suppose it works. @@ -359,6 +359,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetDeviceCaps(LPDIRECT3DDEVICE8 iface if(pCaps-VertexShaderVersion D3DVS_VERSION(1,1)){ pCaps-VertexShaderVersion = D3DVS_VERSION(1,1); } +

Re: [1/2] D3D: Limit d3d8 and d3d9 vshader constants to 256

2009-04-24 Thread Stefan Dösinger
Am Freitag, 24. April 2009 22:48:51 schrieb Henri Verbeet: Not my preferred fix, but I suppose it works. @@ -359,6 +359,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetDeviceCaps(LPDIRECT3DDEVICE8 iface if(pCaps-VertexShaderVersion D3DVS_VERSION(1,1)){

Generating stats on regression bugs in bugzilla

2009-04-24 Thread Scott Ritchie
I had a theory that we might be getting better at preventing regressions now than a year or so ago due to the expansion of things like AppDB and the test suite. It'd be nice to have some sort of data though. Would it be reasonable to comb through the bugzilla database for all the bugs tagged

Need help writing test

2009-04-24 Thread Igor Tarasov
Hi! I've found few visual glitches in comctl32/toolbar, and now try to write this all down as conformance tests, but I have some problems. I see that there is bug, when I test it with control spy. But when I repeat it in testcase, it won't work. Here is how you can reproduce it: TB_SETBITMAPSIZE

Re: Generating stats on regression bugs in bugzilla

2009-04-24 Thread Austin English
On Fri, Apr 24, 2009 at 6:40 PM, Scott Ritchie sc...@open-vote.org wrote: I had a theory that we might be getting better at preventing regressions now than a year or so ago due to the expansion of things like AppDB and the test suite.  It'd be nice to have some sort of data though. Would it

Re: Generating stats on regression bugs in bugzilla

2009-04-24 Thread Ken Sharp
Austin English wrote: On Fri, Apr 24, 2009 at 6:40 PM, Scott Ritchie sc...@open-vote.org wrote: I had a theory that we might be getting better at preventing regressions now than a year or so ago due to the expansion of things like AppDB and the test suite. It'd be nice to have some sort of

Re: [2/2] wininet: HTTP_HttpAddRequestHeadersW should ignore 0-lengthheaders

2009-04-24 Thread Dmitry Timoshkov
Paul TBBle Hampson paul.hamp...@pobox.com wrote: +if (strlenW(lpszStart)==0) +{ +/* Skip 0-length headers */ +lpszStart = lpszEnd; +bSuccess = TRUE; +continue; +} Instead of 'if (strlenW(lpszStart)==0)' it's much simpler

Re: [2/2] wininet: HTTP_HttpAddRequestHeadersW should ignore 0-lengthheaders

2009-04-24 Thread Paul TBBle Hampson
On Sat, Apr 25, 2009 at 11:52:20AM +0900, Dmitry Timoshkov wrote: Paul TBBle Hampson paul.hamp...@pobox.com wrote: +if (strlenW(lpszStart)==0) +{ +/* Skip 0-length headers */ +lpszStart = lpszEnd; +bSuccess = TRUE; +continue;