Re: (resubmit: need a hint) user32: when needed, recalculate menu size of menu bar before tracking starts.

2009-05-07 Thread Austin English
On Thu, May 7, 2009 at 1:52 AM, Rein Klazes w...@online.nl wrote: Fixes bug 10845 Changes from previous patch: menu position calculations moved to nonclient.c. Can you add a testcase? -- -Austin

Re: (resubmit: need a hint) user32: when needed, recalculate menu size of menu bar before tracking starts.

2009-05-07 Thread Rein Klazes
On Thu, 7 May 2009 01:54:23 -0500, you wrote: On Thu, May 7, 2009 at 1:52 AM, Rein Klazes w...@online.nl wrote: Fixes bug 10845 Changes from previous patch: menu position calculations moved to nonclient.c. Can you add a testcase? I don't see what you would like to test. The menu-Height ==

Re: (resubmit: need a hint) user32: when needed, recalculate menu size of menu bar before tracking starts.

2009-05-07 Thread Nicolas Le Cam
2009/5/7 Rein Klazes w...@online.nl: On Thu, 7 May 2009 01:54:23 -0500, you wrote: On Thu, May 7, 2009 at 1:52 AM, Rein Klazes w...@online.nl wrote: Fixes bug 10845 Changes from previous patch: menu position calculations moved to nonclient.c. Can you add a testcase? I don't see what you

Re: (resubmit: need a hint) user32: when needed, recalculate menu size of menu bar before tracking starts.

2009-05-07 Thread Reece Dunn
2009/5/7 Rein Klazes w...@online.nl: On Thu, 7 May 2009 01:54:23 -0500, you wrote: On Thu, May 7, 2009 at 1:52 AM, Rein Klazes w...@online.nl wrote: Fixes bug 10845 Changes from previous patch: menu position calculations moved to nonclient.c. Can you add a testcase? I don't see what you

Getting my test for DrawIcon and DrawIconEx included

2009-05-07 Thread Joel Holdsworth
Is there a reason why my patch (attached) hasn't been included yet? This is my first patch, so maybe someone can help me get it in. Joel From e8398597bfe4772e065ebd98aa3f93a9f681a2fc Mon Sep 17 00:00:00 2001 From: Joel Holdsworth j...@airwebreathe.org.uk Date: Sat, 2 May 2009 10:13:45 +0100

Re: Getting my test for DrawIcon and DrawIconEx included

2009-05-07 Thread Nikolay Sivov
Joel Holdsworth wrote: Is there a reason why my patch (attached) hasn't been included yet? This is my first patch, so maybe someone can help me get it in. Joel+ Just a quick look: 1) +Sleep(200); + +return hWnd; +} + Why are you sleeping here? 2) Why do you need a window here?

Re: notepad: Use the explicit W-form of the types.

2009-05-07 Thread Reece Dunn
2009/5/7 Michael Stefaniuc mstef...@redhat.de:         LoadString(Globals.hInstance, STRING_ERROR, szTitle, SIZEOF(szTitle));         FormatMessage(             FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, -            NULL, error, 0, -            (LPTSTR) lpMsgBuf, 0, NULL);

Re: notepad: Use the explicit W-form of the types.

2009-05-07 Thread Michael Stefaniuc
Reece Dunn wrote: 2009/5/7 Michael Stefaniuc mstef...@redhat.de: LoadString(Globals.hInstance, STRING_ERROR, szTitle, SIZEOF(szTitle)); FormatMessage( FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, -NULL, error, 0, -(LPTSTR)

Re: resubmit: [PATCH] crypt32: change salt allocation to handle errors (Coverity 133)

2009-05-07 Thread Alexandre Julliard
Marcus Meissner mar...@jet.franken.de writes: Coverity 133 shows that we need a error handling on failing memory allocation here. Please handle the error correctly, returning FALSE is not enough. -- Alexandre Julliard julli...@winehq.org

Re: (resubmit: need a hint) user32: when needed, recalculate menu size of menu bar before tracking starts.

2009-05-07 Thread Alexandre Julliard
Rein Klazes w...@online.nl writes: Fixes bug 10845 Changes from previous patch: menu position calculations moved to nonclient.c. You shouldn't need that, the menu size should be recomputed when it gets repainted. And if the menu was changed the whole window size needs to be recomputed

RE: Getting my test for DrawIcon and DrawIconEx included

2009-05-07 Thread Ge van Geldorp
Hi Joel, From: Joel Holdsworth Is there a reason why my patch (attached) hasn't been included yet? This is my first patch, so maybe someone can help me get it in. You are aware that this patch introduces test failures on Windows 2000, Vista and 2008? See

Re: gdiplus: use the mode passed to GdipCreateLineBrushFromRect

2009-05-07 Thread Alexandre Julliard
Vincent Povirk vinc...@codeweavers.com writes: From 5ff18c519843d8df18bbb9d398079ed6a532c8c6 Mon Sep 17 00:00:00 2001 From: Vincent Povirk vinc...@codeweavers.com Date: Wed, 6 May 2009 16:36:06 -0500 Subject: [PATCH] gdiplus: use the mode passed to GdipCreateLineBrushFromRect It doesn't work

Re: [1/3](resend)msctf: implement ITfKeystrokeMgr::PreserveKey

2009-05-07 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: --- dlls/msctf/tests/inputprocessor.c |6 ++-- dlls/msctf/threadmgr.c| 59 +++- 2 files changed, 60 insertions(+), 5 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M

Re: comctl32/test: test CheckState Macros

2009-05-07 Thread André Hentschel
Austin English schrieb: 2009/5/5 André Hentschel n...@dawncrow.de: --- dlls/comctl32/tests/listview.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) This patch fails without your other patch. In the future, please combine them into one patch, or number them in a series.

Re: [5/5] wined3d: Add support for immediate constants to the GLSL backend.

2009-05-07 Thread Stefan Dösinger
Am Donnerstag, 7. Mai 2009 16:39:19 schrieb Henri Verbeet: I don't see an issue with the code in this patch, but did you find out anything new regarding the geforce 8 immval handling in the Nvidia driver? Remember the issue where my more-uniforms patch blew the constant limit because the

RE: Severity levels

2009-05-07 Thread Nicklas Börjesson
To every Wine user, their application not working is critical. This is clear by all the bugs that are logged incorrectly every day, because nobody bothered reading the FAQ. Yep, but that's more an indication on how much work remains to be done on wine than it is an incorrect severity level.

RE: Severity levels

2009-05-07 Thread Nicklas Börjesson
So you suggest making the severity ratings meaningless to anyone but ... well, you don't actually mention anyone knowing what they *really* mean, but I assume an exclusive clique of developers or bugzilla admins? Users have different opinions on what level of bug they encounter depending on what

Re: Severity levels

2009-05-07 Thread Ken Sharp
Nicklas Börjesson wrote: No it isn't. It's an indication on how many people think they're more important than anyone else filing a bug. I think that you are wrong. Granted, some people do, they are called morons. But most people aren't morons. They are people, and to them, the issue really

Re: Severity levels

2009-05-07 Thread Nicklas Börjesson
How many times does this have to be repeated? Severity levels are NOT determined by how much a user wants the app to work. They're just not, deal with it. I have never said it is, either. I said it think it should be determined by how severe the user thinks it is(if devs then cares about it

RE: Severity levels

2009-05-07 Thread Nicklas Börjesson
Why should there be multiple support forums? Well, not forums, but as I said different lists for different kinds of applications(games/business/graphics), since they should(?) have related problems. I would think so, anyway. The wiki has _a lot_ of info, most of the time when bugs are closed

RE: Severity levels

2009-05-07 Thread Nicklas Börjesson
How many times does this have to be repeated? Severity levels are NOT determined by how much a user wants the app to work. They're just not, deal with it. I have never said it is, either. I said it think it should be determined by how severe the user thinks it is(if devs then cares

RE: Severity levels

2009-05-07 Thread Nicklas Börjesson
I think this argument is circular...Wine has no shortage of bugs being reported, we have plenty of new users reporting bugs, and new developers contributing often. You're proposing adding an extra severity rating that no developer will look at, and will only add to confusion (users now have to

RE: Severity levels

2009-05-07 Thread Nicklas Börjesson
As I wrote in my earlier post, Austin told me about the voting functionality, and If that is considered when priorities are made, it is likely to keep things pretty on track, making my proposed changes far less important. I still think my thoughts aren't that off anyway, but now they feel a bit

GUI debugging

2009-05-07 Thread Benoit SCHWINDEN
Hello, I am trying to make a very special application working with Wine 1.1.20 (Loris, from Ever Ezida, a library management software). Almost everything is functionnal, but there is a little graphical bug with some texfields. Also, I would like to know if there are some ways to debug a GUI,

RE: Severity levels

2009-05-07 Thread Nicklas Börjesson
Just changing the default to normal should solve a lot of the problem; people are less likely to change the severity level if the one they're presented with looks reasonable. I think so too. Especially if the selected one, enhancement almost certainly is wrong. I know what Major and Critical

RE: Severity levels

2009-05-07 Thread Nicklas Börjesson
You're one guy against the world. So far, no one on this thread has responded positively to your proposal to overhaul severities. I'd suggest you stop acting like it's an inevitability Ok then. Once again bugzilla is a developer's tool, not a collection of data for users. We already have the

GUI debugging

2009-05-07 Thread Benoit SCHWINDEN
Hello, I am trying to make a very special application working with Wine 1.1.20 (Loris, from Ever Ezida, a library management software). Almost everything is functionnal, but there is a little graphical bug with some texfields. Also, I would like to know if there are some ways to debug a GUI,

Re: Severity levels

2009-05-07 Thread IneedAname
On Mon, 4 May 2009 22:12:04 +1000 Ben Klein shackl...@gmail.com wrote: 2009/5/4 Ben Klein shackl...@gmail.com: Then they disappear. There would be no way to search for metabugs, for example, whereas at the moment you can search for Blockers. There's no point in keeping metabugs if there's

Re: Severity levels

2009-05-07 Thread IneedAname
On Sun, 3 May 2009 23:31:45 -0400 Mike Kaplinskiy mike.kaplins...@gmail.com wrote: +1. Or just remove priorities for users altogether. Looks like some one is thinking round here! That gets my vote to.

RE: Severity levels

2009-05-07 Thread Nicklas Börjesson
Guys, y'all are going in a circular argument. No need to cc wine-devel on it anymore. I am rather fed up with it as well, also I will soon not have any more time for it since I'll be going back to work tomorrow. I've had stomach flu(!swine) the last week. Circular? More plain disagreement i'd

msvcrt crash issue, tracing

2009-05-07 Thread Kjell Rune Skaaraas
Hello, I've been working for some time now trying to resolve bug 15817 because it's a kickass game that apart from one crashing issue works great under wine. The situation in brief is that it works with a msvcrt.dll override, but crashes randomly and sometimes consistantly using wine's stub.

RE: Shuttleworth on Wine

2009-05-07 Thread Nicklas Börjesson
I'd say that attitutudes might change, though. For example, he is mentioning photoshop(of course) which I use at home under win. It works great there. There are only a few quirks with the installation: 1. it need 1.1.17 to work 2. a DLL is needed for the text-tool to work. 3. A winetricks has

RE: Severity levels

2009-05-07 Thread Nicklas Börjesson
However, a developer should be aware of the impact on the user experience and the user's determined severity of a problem. That has been my point all the time. I was told that the users perceptions were not important since, a least according what I understood, they could not be trusted to be

Does wine handle virtual midi ports correct on OSX?

2009-05-07 Thread Dewdman42
Does anyone know if Darwine can be fixed to handle virtual midi ports correctly? They work very sporadically right now. It seems to be related to getting the ports flushed or initialized or something. When there is a virtual midi port present (under OSX), Wine seems to see it and lists it as

Re: Resend of xinput patch for bug 18218

2009-05-07 Thread Austin English
On Sun, May 3, 2009 at 7:12 PM, Rafał Mużyło galtge...@gmail.com wrote: I didn't put DllMain in this file, as it was not in the current version, just added numbers and sorted (latter probably unnecessary). --- dlls/xinput1_3/xinput1_3_main.c.old 2009-04-25 16:54:42.0 +0200

Re: Shuttleworth on Wine

2009-05-07 Thread Austin English
2009/5/6 Nicklas Börjesson nicklas.borjes...@ws.se: If I were the leader of the wine project, the moment photoshop CS4 works all the way, that would be the basis of the next stable version(to avoid regessions to the highest degree).. As has been said plenty of times before, we don't want to

Re: [5/5] wined3d: Add support for immediate constants to the GLSL backend.

2009-05-07 Thread Henri Verbeet
2009/5/7 Stefan Dösinger stefandoesin...@gmx.at: Am Donnerstag, 7. Mai 2009 16:39:19 schrieb Henri Verbeet: I don't see an issue with the code in this patch, but did you find out anything new regarding the geforce 8 immval handling in the Nvidia driver? Remember the issue where my

Re: Shuttleworth on Wine

2009-05-07 Thread David Gerard
2009/5/7 Austin English austinengl...@gmail.com: Though, I must say, the majority of people I see/hear using Photoshop *are* using it as a toy/hobby, not for 'real' work, i.e., a full time job. Yes. The biggest problem for free-as-in-freedom software - Linux and GIMP, and to some extent Wine

Re: Severity levels

2009-05-07 Thread Austin English
2009/5/3 Nicklas Börjesson nicklas.borjes...@ws.se: Explained to me?? ...this is just incredible. Regardless of what I have said, you have repeated almost the same things, it's like you haven't been reading my posts! Leave me alone, I want to talk to someone else. No offense, but you should

Re: msvcrt crash issue, tracing

2009-05-07 Thread Austin English
On Tue, May 5, 2009 at 6:08 PM, Kjell Rune Skaaraas kjell...@yahoo.no wrote: However, I've been looking at the functions in the trace and it doesn't seem to be any of these functions causing the crash. Now, having looked at what msvcrt.dll is, it's much, much more than these functions, it's

Re: Does wine handle virtual midi ports correct on OSX?

2009-05-07 Thread Ken Thomases
On May 6, 2009, at 11:20 PM, Dewdman42 wrote: Does anyone know if Darwine can be fixed to handle virtual midi ports correctly? They work very sporadically right now. It seems to be related to getting the ports flushed or initialized or something. When there is a virtual midi port present

Dynamically adding debug channels (__wine_dbg_set_channel_flags)

2009-05-07 Thread Daniel Santos
It would seem quite helpful for debugging odd situations to be able to turn debugging on and off programmatically.  I like not having every debug class loaded in memory by default (and everything that goes with maintaining that global list), but it would seem quite helpful for troubleshooting,

Re: Severity levels

2009-05-07 Thread richardvo...@gmail.com
2009/5/7 Austin English austinengl...@gmail.com 2009/5/3 Nicklas Börjesson nicklas.borjes...@ws.se: Explained to me?? ...this is just incredible. Regardless of what I have said, you have repeated almost the same things, it's like you haven't been reading my posts! Leave me alone, I

Re: Severity levels

2009-05-07 Thread Ben Klein
2009/5/8 richardvo...@gmail.com richardvo...@gmail.com: 2009/5/7 Austin English austinengl...@gmail.com 2009/5/3 Nicklas Börjesson nicklas.borjes...@ws.se: Explained to me?? ...this is just incredible. Regardless of what I have said, you have repeated almost the same things, it's like

Re: Severity levels

2009-05-07 Thread James McKenzie
IneedAname wrote: Wine does have meta bugs look at the application data base. Each application has a list of bugs that effect that program. I think that you missed what a meta-bug is in the Bugzilla sense. A meta-bug would collect all of the applications affected by a particular problem,