Gerald Pfeifer wrote:
Not sure how to else handle this; possibly remove this whole subtest?
Gerald
ChangeLog:
Simplify code in dlls/imm32/tests/imm32.c (and avoid false warning).
diff --git a/dlls/imm32/tests/imm32.c b/dlls/imm32/tests/imm32.c
index 1951242..3e35ac1 100644
---
Gerald Pfeifer wrote:
I believe, after looking at the ranges of D3DLIGHTSTATETYPE, that
the below is the actual intention of this code (to ensure we are
in range).
Gerald
ChangeLog:
Fix error checking in IDirect3DExecuteBufferImpl_Execute().
diff --git a/dlls/ddraw/executebuffer.c
Mikołaj Zalewski miko...@zalewski.pl writes:
It's online again. Having it on WineHQ would probably give a better
uptime (and a much better latency, but this should also improve on my
side, when I won't need a temporary SSH tunnel anymore and will move
the HTTP server from my good old Pentium
It's now online at http://source.winehq.org/transl/ and will be updated
every time there's a git push. Please let me know if you find any
problems. The source is also available now in the tools.git repository.
It looks like there is a problem with CSS - some formatting is gone
and I get a
On Sat, 20 Jun 2009, Paul Vriens wrote:
- if (!ci-u1.dlstLightStateType
(ci-u1.dlstLightStateType D3DLIGHTSTATE_COLORVERTEX))
+if (!ci-u1.dlstLightStateType ||
(ci-u1.dlstLightStateType D3DLIGHTSTATE_COLORVERTEX))
Would:
if ((ci-u1.dlstLightStateType
Hello Gerald Pfeifer,
You did,
/* behavior differs between win9x and NT */
ret = ImmGetCompositionString(imc, GCS_COMPSTR, resstr, sizeof(resstr));
-ok(ret || !ret, You'll never read this.\n);
+ok(TRUE, You'll never read this.\n);
Wouldn't it be better to do something like:
Mikołaj Zalewski miko...@zalewski.pl writes:
It's now online at http://source.winehq.org/transl/ and will be updated
every time there's a git push. Please let me know if you find any
problems. The source is also available now in the tools.git repository.
It looks like there is a problem
On Saturday 20 June 2009 17:17:53 Gerald Pfeifer wrote:
Hi Gerald,
not really about this patch in specific, but would you mind sticking to the
established practice of prefixing your patches with the area of wine you're
affecting? That makes it easier to skim the wine-patches list for the dlls I
I'm trying to track down an issue with Launchpad Enhanced were it fails to
download its updates (Bug #17443). It appears that the issue stems from
recv being called with a buffer from a different process, so as a result the
call fails. I put together a hack that gets around the problem (
2009/6/20 Gerald Pfeifer ger...@pfeifer.com:
This makes it more clear that ! applies to the overall condition,
not just to the first part which is then and-ed.
I happened to have the same patch. Note that this does fix a real bug,
! has higher precedence than .
10 matches
Mail list logo