Re: user32: Add check for the need to redraw static control after STM_SETIMAGE and STM_SETICON

2009-09-28 Thread Ilya Shpigor
On Saturday 26 September 2009 12:09:30 Nikolay Sivov wrote: --- + if ((style SS_TYPEMASK) != SS_ICON) return (HICON)-1; ... + if ((style SS_TYPEMASK) != SS_BITMAP) return (HBITMAP)-1; ... + if ((style SS_TYPEMASK) != SS_ENHMETAFILE) return (HENHMETAFILE)-1; --- Add tests for that

Re: user32: Add check for the need to redraw static control afterSTM_SETIMAGE and STM_SETICON

2009-09-28 Thread Dmitry Timoshkov
Ilya Shpigor shpi...@etersoft.ru wrote: Yes, MSDN tells about 0. The -1 value is used for detecting the errors inside Wine and blocking the static controls redrawing. Then the 0 value is returned to application: - STATIC_TryPaintFcn( hwnd, full_style ); + if (lResult != -1) +

Re: comctl32/tests: Fix monthcal test on NT4

2009-09-28 Thread Nikolay Sivov
Ge van Geldorp wrote: Ignore MCHT_TITLEBK, title elements might be adjacent without any background in between. Changelog: comctl32/tests: Fix monthcal test on NT4 --- dlls/comctl32/tests/monthcal.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) Hi, Ge. This

Re: comctl32/tests: Fix monthcal test on NT4

2009-09-28 Thread Greg Geldorp
Hi Nikolay, Ge van Geldorp wrote: Changelog: comctl32/tests: Fix monthcal test on NT4 Hi, Ge. This one interfere with a mine, sent yesterday: http://www.winehq.org/pipermail/wine-patches/2009-September/078955.html Could you wait a bit? I hope this could fix some failures. Sure.

Re: [PATCH 06/12] d3d10: Implement ID3D10EffectType::GetMemberName().

2009-09-28 Thread Henri Verbeet
static LPCSTR STDMETHODCALLTYPE d3d10_effect_type_GetMemberName(ID3D10EffectType *iface, UINT index) { -FIXME(iface %p, index %u stub!\n, iface, index); +struct d3d10_effect_type *This = (struct d3d10_effect_type *)iface; -return NULL; +TRACE(iface %p, index %u\n, iface,

Re: [PATCH 12/12] d3d10/tests: Add test_effect_constant_buffer_type test.

2009-09-28 Thread Henri Verbeet
2009/9/28 Rico Schüller kgbric...@web.de: +ID3D10Effect* effect; I'd prefer it if that was written as ID3D10Effect *effect; +ok(SUCCEEDED(hr), ID3D10EffectType::GetDesc failed!\n); Please print the actual error code as well. +ok(type_desc.Elements == 0, Elements is %i, expected

Re: ole32/tests: fix clipboard tests on Windows

2009-09-28 Thread Alexandre Julliard
Ge van Geldorp ggeld...@vmware.com writes: @@ -417,18 +417,23 @@ static HRESULT DataObjectImpl_CreateComplex(LPDATAOBJECT *lplpdataobj) InitFormatEtc(obj-fmtetc[1], cf_stream, TYMED_ISTREAM); InitFormatEtc(obj-fmtetc[2], cf_storage, TYMED_ISTORAGE);

Re: user32: Add check for the need to redraw static control afterSTM_SETIMAGE and STM_SETICON

2009-09-28 Thread Ilya Shpigor
First thing to do (as usual) is to add the test to show the drawing behaviour. Ok. I will make TRY 4 of tests. -- Best regards, Ilya Shpigor.

Re: d3d9: Don't release the parent device before destroying its children

2009-09-28 Thread Allan Tong
On Mon, Sep 28, 2009 at 10:51 AM, Henri Verbeet hverb...@gmail.com wrote: 2009/9/28 Allan Tong acton...@gmail.com: Note that this patch only changes d3d9. Could you write one for d3d8 as well? Otherwise I'll send one tomorrow. Will do. - Allan

Re: comctl32: Send the parent notification after the Wine has set the tooltip position (bug #14336)

2009-09-28 Thread Nikolay Sivov
Could you please add a test for that?

Re: comctl32/tests: Fix monthcal test on NT4

2009-09-28 Thread Nikolay Sivov
Greg Geldorp wrote: Hi Nikolay, Ge van Geldorp wrote: Changelog: comctl32/tests: Fix monthcal test on NT4 Hi, Ge. This one interfere with a mine, sent yesterday: http://www.winehq.org/pipermail/wine-patches/2009-September/078955.html Could you wait a bit? I hope this

Patch for [Bug 14222] RpcBindingSetAuthInfo(Ex) fails with RPC_C_AUTHN_GSS_NEGOTIATE

2009-09-28 Thread Stefan Kuhr
Hello everyone, please find attached a patch for Bug 14222. IIRC I sent a similar patch a year ago or so and never received feedback why it was rejected. Austin encouraged me to send it again, so please if it is unacceptable, let me know why. The patch will make RPC clients work that are

Re: [PATCH 3/4] mshtml: Add helper function get_url_components

2009-09-28 Thread Andrew Eikum
Detlef Riekenberg wrote: On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote: +static HRESULT get_url_components(HTMLLocation *This, URL_COMPONENTSW *url) +{ +const WCHAR *doc_url; +if(!InternetCrackUrlW(doc_url, 0, 0, url)) { +FIXME(InternetCrackUrlW failed\n); Such a

Re: [PATCH 06/12] d3d10: Implement ID3D10EffectType::GetMemberName().

2009-09-28 Thread Rico Schüller
Am 28.09.2009 15:08, schrieb Henri Verbeet: static LPCSTR STDMETHODCALLTYPE d3d10_effect_type_GetMemberName(ID3D10EffectType *iface, UINT index) { -FIXME(iface %p, index %u stub!\n, iface, index); +struct d3d10_effect_type *This = (struct d3d10_effect_type *)iface; -return

Review Request: Patch to selectively bind to interfaces while still allowing broadcast packets

2009-09-28 Thread Erich Hoover
Attached is a patch I have been working to fix Bug #7929 (CC 3 network does not work). This patch replaces interface-specific bind requests (on UDP datagrams only) with a global bind and stores the interface index. The patch then uses IP_PKTINFO to set the outgoing interface and filter incoming