Re: [PATCH] Replace builtin WineFile Execute Dialog with standard RunFile Dialog - try2

2009-12-29 Thread Steven Edwards
damnit. sorry about that, that's what I get for trying to amend. Here is the correct patch, try 3 On Tue, Dec 29, 2009 at 12:34 PM, Steven Edwards wrote: > I don't know why this didn't get through, resending from gmail. > > This time incorporating (most of) the feedback from Dmitry Timoshkov > an

Re: dlls/user32/combo.c: Fix an issue where pressing 's' in a combobox shows the dropdown isntead of finding an entry starting with 's'.

2009-12-29 Thread David Quintana (gigaherz)
I had already sent a second patch without the C++-style comment. But regardless, if you say other parts of the code are also wrong, then I will leave this to someone closer to the project, who knows better what is it that should be done here. 2009/12/29 Dmitry Timoshkov > "David Quintana (gigahe

Re: CPPCheck Dec 29

2009-12-29 Thread Alasdair Sinclair
On 30/12/09 03:55, chris ahrendt wrote: I just ran CPP check this evening and got the following : rpcrt4/rpc_transport.c 490 (error) Uninitialized variable smb_floor 761 (error) Uninitialized variable pipe_floor 885 (error) Uninitialized variable tcp_floor

CPPCheck Dec 29

2009-12-29 Thread chris ahrendt
I just ran CPP check this evening and got the following : rpcrt4/rpc_transport.c 490 (error) Uninitialized variable smb_floor 761 (error) Uninitialized variable pipe_floor 885 (error) Uninitialized variable tcp_floor If you look at the code : static size_t

Re: Removing WPARAM/LPARAM Casts

2009-12-29 Thread James McKenzie
Michael Stefaniuc wrote: > On 12/28/2009 03:06 AM, James Mckenzie wrote: >> I've noticed that Michael Stefuic (sp?) has removed quite a few >> WPARAM/LPARAM casts when calling SendMessage() and was >> wondering/inquiring if he was going do this to riched20/tests/editor.c >> since I noticed he put i

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Matteo Bruni
2009/12/29 Henri Verbeet : > 2009/12/29 Matteo Bruni : >> I added the fake parser for two reasons: because I have to initialize >> an asm_parser structure anyway in the create__parser functions >> (and I prefer to use parser_fake for the unimplemented shader versions >> instead of parser_vs_3)

Linux Gaming: Are We There Yet?

2009-12-29 Thread Jaime Rave
Excelent review from the guys in AnandTech of the current status of gaming in Linux, they have tested Wine vs CrossOver Games vs Cedega vs Windows 7 and the results are quite good. http://www.anandtech.com/linux/showdoc.aspx?i=3700 -- Jaime Rave Torres Ingeniero de Sistemas Miembro de la Fundaci

Re: dbghelp: Make sure the ClientPointers flag is set correctly

2009-12-29 Thread Henri Verbeet
2009/12/29 Jason Green : > Using "stg show" from stgit 0.14.2.  Looks like that function is mostly just > a passthrough to "git show".  git-format-patch seems nicer since it gives > the number of line items changed, etc., although there's probably an option > in "git show" somewhere that will do th

Re: dbghelp: Make sure the ClientPointers flag is set correctly

2009-12-29 Thread Jason Green
On Dec 29, 2009, at 2:37 PM, Henri Verbeet wrote: > 2009/12/29 Jason Green : >> commit 317da09400946ca9f97361a47a227595c5bedfe3 >> Author: Eric van Beurden >> Date: Tue Dec 29 12:35:03 2009 -0500 >> >>Make sure the ClientPointers flag isn't set incorrectly > > Mostly out of curiosity, how

Re: dbghelp: Make sure the ClientPointers flag is set correctly

2009-12-29 Thread Henri Verbeet
2009/12/29 Jason Green : > commit 317da09400946ca9f97361a47a227595c5bedfe3 > Author: Eric van Beurden > Date: Tue Dec 29 12:35:03 2009 -0500 > > Make sure the ClientPointers flag isn't set incorrectly Mostly out of curiosity, how did you generate this patch? That looks like the kind of outp

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Michael Stefaniuc
On 12/29/2009 04:54 PM, Matteo Bruni wrote: 2009/12/29 Alexandre Julliard: Matteo Bruni writes: + +%option reentrant bison-bridge These won't work on old flex versions, and will get you in trouble with the flex police (aka Michael Stefaniuc ;-) All that because the Wine maintainer puts a lo

Re: Guide for creating new AppInstall tests

2009-12-29 Thread Austin English
On Tue, Dec 29, 2009 at 9:12 AM, Sam S. wrote: > Hi Austin, > > thank you for your reply. I'll give it another try. > > Btw, I do realise that some questions of the step-by-step list I gave > at the end are already (at least partially) answered in various places > - this was intended more as an ou

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Henri Verbeet
2009/12/29 Matteo Bruni : > I added the fake parser for two reasons: because I have to initialize > an asm_parser structure anyway in the create__parser functions > (and I prefer to use parser_fake for the unimplemented shader versions > instead of parser_vs_3) and I want to avoid having some t

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Matteo Bruni
2009/12/29 Alexandre Julliard : > Matteo Bruni writes: > >> + >> +%option reentrant bison-bridge > > These won't work on old flex versions, and will get you in trouble with > the flex police (aka Michael Stefaniuc ;-) > Alexandre, now you have another person on your side against RHEL 5 and old fl

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Matteo Bruni
2009/12/29 Henri Verbeet : > 2009/12/28 Matteo Bruni : >> > Why do you need the fake parser? Can't you just not support those > shader versions yet? There's also (in general) not much of a point in > adding structure fields that aren't used yet. > I added the fake parser for two reasons: because I

Re: Guide for creating new AppInstall tests

2009-12-29 Thread Sam S.
Hi Austin, thank you for your reply. I'll give it another try. Btw, I do realise that some questions of the step-by-step list I gave at the end are already (at least partially) answered in various places - this was intended more as an outline of how a step-by-step guide useful to users with no pr

Re: Building and packaging Wine Gecko

2009-12-29 Thread Jacek Caban
On 12/29/09 2:07 PM, André Hentschel wrote: Jacek Caban schrieb: On 12/28/09 8:34 AM, Ove Kaaven wrote: OK, I've almost got a wine-gecko package built 100% from source, but there's a problem: the gcc version in Debian's mingw32, namely gcc 4.2.1-sjlj, apparently miscompiles the wine-g

Re: Building and packaging Wine Gecko

2009-12-29 Thread Jacek Caban
On 12/29/09 5:45 AM, Austin English wrote: On Mon, Dec 28, 2009 at 6:53 PM, Jacek Caban wrote: On 12/29/09 1:44 AM, Ove Kaaven wrote: gcc 4.4.2 is already released, and Debian unstable is using it as the default compiler. And like I mentioned, they even have a mingw32 cross compiler

Re: Building and packaging Wine Gecko

2009-12-29 Thread André Hentschel
Jacek Caban schrieb: > On 12/28/09 8:34 AM, Ove Kaaven wrote: >> OK, I've almost got a wine-gecko package built 100% from source, but >> there's a problem: the gcc version in Debian's mingw32, namely gcc >> 4.2.1-sjlj, apparently miscompiles the wine-gecko 1.0.0 sources, the >> resulting Gecko just

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Alexandre Julliard
Matteo Bruni writes: > + > +%option reentrant bison-bridge These won't work on old flex versions, and will get you in trouble with the flex police (aka Michael Stefaniuc ;-) -- Alexandre Julliard julli...@winehq.org

Re: [3/4] d3dx9: Implement D3DXAssembleShader function, really basic shader assembler.

2009-12-29 Thread Henri Verbeet
2009/12/28 Matteo Bruni : > Why do you need the fake parser? Can't you just not support those shader versions yet? There's also (in general) not much of a point in adding structure fields that aren't used yet. > +/* This file needs the original d3d9 definitions. The bwriter ones > + * aren't useab