Re: [tools]winetest: fix child-result coloring and counting

2010-01-05 Thread Alexandre Julliard
Paul Vriens paul.vriens.w...@gmail.com writes: Hi André, That log also shows server: 1 failures in child process. I'm not a 100% sure but from the looks of it this is that one/1 failure mentioned in that last line: server: 120 tests executed (1 marked as todo, 1 failure), 0 skipped. If

Re: [2/5] WineD3D: Call the non-wrapped GLfinish in the PBO test

2010-01-05 Thread Henri Verbeet
2010/1/4 Stefan Dösinger ste...@codeweavers.com: In this case you can just release the GL lock, although the call is just an OS X hack in the first place.

Re: [4/5] WineD3D: Implement manual fencing with GL_APPLE_flush_buffer_range

2010-01-05 Thread Henri Verbeet
2010/1/4 Stefan Dösinger ste...@codeweavers.com: +if(This-query.context) context_free_event_query(This-query); +This-query.context = NULL; context_free_event_query() already clears the context field. + if(This-resource.device-adapter-gl_info.supported[APPLE_FENCE]) You

Version test crashing

2010-01-05 Thread Stefan Dösinger
Hi, Since a few days my nightly cxtest runs show crashes in the version:info test: http://test.winehq.org/data/f74e312bf81032c46bd2ce080a5f6a33c7ac3ee3/wine_stefand-amd64/version:info.html (Ubuntu 8.10, 64 bit build) Test.winehq.org has more results, for this wine build I am seeing 3 more

Re: advpack: Use GetModuleHandle instead of LoadLibrary.

2010-01-05 Thread Paul Vriens
On 01/05/2010 02:46 AM, James Hawkins wrote: --- dlls/advpack/tests/advpack.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) Hi James, Don't think this works: advpack: 0 tests executed (0 marked as todo, 0 failures), 0 skipped. -- Cheers, Paul.

Re: Version test crashing

2010-01-05 Thread Paul Vriens
On 01/05/2010 11:54 AM, Stefan Dösinger wrote: Hi, Since a few days my nightly cxtest runs show crashes in the version:info test: http://test.winehq.org/data/f74e312bf81032c46bd2ce080a5f6a33c7ac3ee3/wine_stefand-amd64/version:info.html (Ubuntu 8.10, 64 bit build) Test.winehq.org has more

Re: (try2)[PATCH 1/2] d3d10: Add a function to initialize the null variables.

2010-01-05 Thread Alexandre Julliard
Rico Schüller kgbric...@web.de writes: +static void d3d10_null_effect_variable_init(struct d3d10_effect_variable *v, struct ID3D10EffectVariableVtbl *vtbl) +{ +v-vtbl = vtbl; +v-buffer = null_local_buffer; +v-type = null_type; +} + +void d3d10_null_effect_variable_init_all()

Re: [4/5] WineD3D: Implement manual fencing with GL_APPLE_flush_buffer_range

2010-01-05 Thread Stefan Dösinger
Am 05.01.2010 um 11:50 schrieb Henri Verbeet: + if(This-resource.device-adapter-gl_info.supported[APPLE_FENCE]) I'm not sure you can test for APPLE_fence to determine if event queries are available. directx.c disables NV_fence if APPLE_fence is available. We prefer the APPLE

Re: Revert dsound: Remove refcounting in classfactory.

2010-01-05 Thread Alexandre Julliard
Maarten Lankhorst m.b.lankho...@gmail.com writes: This reverts commit 1b94450f789791908a370f16e125087b84f35bcb. See bug 21196 Again, when sending a revert you need to include a justification for why it must be reverted. Referencing a bug is not good enough, the git log must be understandable

Re: [4/5] WineD3D: Implement manual fencing with GL_APPLE_flush_buffer_range

2010-01-05 Thread Henri Verbeet
2010/1/5 Stefan Dösinger stefandoesin...@gmx.at: Am 05.01.2010 um 11:50 schrieb Henri Verbeet: +             if(This-resource.device-adapter-gl_info.supported[APPLE_FENCE]) I'm not sure you can test for APPLE_fence to determine if event queries are available. directx.c disables NV_fence if

Re: (try2)[PATCH 1/2] d3d10: Add a function to initialize the null variables.

2010-01-05 Thread Henri Verbeet
2010/1/5 Alexandre Julliard julli...@winehq.org: That's not much of an improvement, static initialization is nicer. In general yes, but it makes adding fields to d3d10_effect_variable or changing their order a bit of a pain. C99 struct initialization would help a bit there, but I doubt it's an

Re: (try2)[PATCH 1/2] d3d10: Add a function to initialize the null variables.

2010-01-05 Thread Alexandre Julliard
Henri Verbeet hverb...@gmail.com writes: 2010/1/5 Alexandre Julliard julli...@winehq.org: That's not much of an improvement, static initialization is nicer. In general yes, but it makes adding fields to d3d10_effect_variable or changing their order a bit of a pain. C99 struct initialization

Re: Version test crashing

2010-01-05 Thread Stefan Dösinger
Am 05.01.2010 um 12:06 schrieb Paul Vriens: Does a single 'make info.ok' in the version/tests directory work? Yes, this works. Apparently only the winetest run fails, or it is a random failure that happens sometimes but not all the time.

Re: Revert dsound: Remove refcounting in classfactory.

2010-01-05 Thread Maarten Lankhorst
Hi AJ, Sorry, wrong revert. I shouldn't send patches after 18 hours no sleep :) Cheers, Maarten.

Re: dmloader: Fix a possible null dereference

2010-01-05 Thread Paul Vriens
On 01/05/2010 02:18 PM, David Adam wrote: Hello This patch fixes the bug 13986 A+ David Searc Hi David, +hr = CoInitialize(NULL); +if ( FAILED(hr) ) +{ +skip(CoInitializeEx failed.\n); +return; +} The skip() message doesn't match the actual function

Re: [tools]winetest: fix child-result coloring and counting

2010-01-05 Thread Paul Vriens
On 01/05/2010 10:23 AM, Alexandre Julliard wrote: Paul Vrienspaul.vriens.w...@gmail.com writes: Hi André, That log also shows server: 1 failures in child process. I'm not a 100% sure but from the looks of it this is that one/1 failure mentioned in that last line: server: 120 tests executed

Re: gdi32: Use the LOGFONT charset field on OEM font creation

2010-01-05 Thread Dmitry Timoshkov
Ilya Shpigor shpi...@etersoft.ru wrote: Some explanation for this patch: The fsCsb is bitfield that is used as boolean value. If this is false the DEFAULT_CHARSET is using and the real charset is choosen through the current ANSI codepage. But this is mistake in case of the OEM charset. A

Re: [tools]winetest: fix child-result coloring and counting

2010-01-05 Thread Alexandre Julliard
Paul Vriens paul.vriens.w...@gmail.com writes: On 01/05/2010 10:23 AM, Alexandre Julliard wrote: winetest_wait_child_process will add the child failures, but I don't think it's used consistently everywhere, so that would be the first thing to fix. The 'adding of child failures' is needed

Re: [4/5] WineD3D: Implement manual fencing with GL_APPLE_flush_buffer_range

2010-01-05 Thread Stefan Dösinger
After the discussion on IRC I wasn't quite sure what you intended with wined3d_event_query_wait(), but maybe it was something like this: I've based the sync code on IWineD3DQuery event queries now rather than using the GL APIs. This way the buffer code is insulated from the thread switch

Re: [PATCH 1/2] msi: queue dynamically allocated strings in cond.y

2010-01-05 Thread Nate Gallaher
James Hawkins wrote: On Mon, Jan 4, 2010 at 7:05 AM, Nate Gallaher ngalla...@deepthought.org wrote: James Hawkins wrote: On Sat, Jan 2, 2010 at 10:36 AM, Nathan Gallaher ngalla...@deepthought.org wrote: +struct cond_mem { +struct list entry; +void *ptr; +};

Re: [PATCH 1/2] msi: queue dynamically allocated strings in cond.y

2010-01-05 Thread James Hawkins
On Tue, Jan 5, 2010 at 9:11 AM, Nate Gallaher ngalla...@deepthought.org wrote: James Hawkins wrote: On Mon, Jan 4, 2010 at 7:05 AM, Nate Gallaher ngalla...@deepthought.org wrote: James Hawkins wrote: On Sat, Jan 2, 2010 at 10:36 AM, Nathan Gallaher ngalla...@deepthought.org wrote:

Re: valgrind progress: only 426 errors left?!

2010-01-05 Thread Dan Kegel
On Mon, Jan 4, 2010 at 4:11 PM, Dan Kegel d...@kegel.com wrote: http://kegel.com/wine/valgrind/logs/2010-01-04-10.14 woot!  The stats are now      1 Invalid free/ delete / delete[]      1 Use of uninitialised value of size 4      2 Source and destination overlap in memcpy      3 Syscall

visual c++ 2005 success

2010-01-05 Thread Dan Kegel
Well, golly. Now that Rob has fixed the /Zi bug, Visual C++ 2005 seems to be building small apps pretty well. There are three or so gotchas to be aware of: 1) apps like gyp's unit test won't be able to build until you've run the IDE once so it can register itself 2) you have to install winbind

The (Casual) Game Support Report in Wine (Jan 2009)

2010-01-05 Thread Reece Dunn
Hi, With Dan reporting on the success of Visual C++ 2005, I thought I would post my findings of various casual (and other) games. In general, my observations are that: 1/ the games themselves tend to work very well (and have done for a long while now thanks to the great work CodeWeavers did

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-05 Thread Michael Stefaniuc
On 01/05/2010 03:44 AM, Jeremy White wrote: The Top Ten Single Charts - This are the messages with the most occurrences in a single file. Nifty! Well, I'm not that proud of that table: Interestingly seven out of the top ten FIXMEs in a single file have been seen *only*

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-05 Thread Reece Dunn
2010/1/5 Michael Stefaniuc mstef...@redhat.com:  2040  |  36   | ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c109 0xc109 is NT_STATUS_MESSAGE_NOT_FOUND according to http://lists.samba.org/archive/jcifs/2004-February/003038.html. Interestingly, in dlls/ntdll/tests/error.c, there is

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-05 Thread Vincent Povirk
It might be interesting to select for err:module:import_dll lines, which are (sometimes) missing dll's.   77   |   99  | ole:CoGetClassObject no class object {9a5ea990-3034-4d6f-9128-01f3c61022bc} could be created for context 0x1   75   |   98  | ole:CoGetClassObject class

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-05 Thread James McKenzie
Reece Dunn wrote: 2010/1/5 Michael Stefaniuc mstef...@redhat.com: 877 | 209 | shell:DllCanUnloadNow stub DllCanUnloadNow is a hint to the operating system to know if it can free the library, unloading it from memory. It is fine for this to always return S_FALSE (i.e. never

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-05 Thread Reece Dunn
2010/1/6 James McKenzie jjmckenzi...@earthlink.net: Reece Dunn wrote: 2010/1/5 Michael Stefaniuc mstef...@redhat.com:   877  | 209   | shell:DllCanUnloadNow stub DllCanUnloadNow is a hint to the operating system to know if it can free the library, unloading it from memory. It is fine for

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-05 Thread Andrew Eikum
On 01/05/2010 07:02 PM, Reece Dunn wrote: 2010/1/6 James McKenziejjmckenzi...@earthlink.net: Reece Dunn wrote: 2010/1/5 Michael Stefaniucmstef...@redhat.com: 877 | 209 | shell:DllCanUnloadNow stub DllCanUnloadNow is a hint to the operating system to know if it can free the library,

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-05 Thread James McKenzie
Reece Dunn wrote: 2010/1/6 James McKenzie jjmckenzi...@earthlink.net: Reece Dunn wrote: 2010/1/5 Michael Stefaniuc mstef...@redhat.com: 877 | 209 | shell:DllCanUnloadNow stub DllCanUnloadNow is a hint to the operating system to know if it can free the

Re: Wine FIXME Report 2009 Aug - Dec

2010-01-05 Thread Wolfram Sang
2040 | 36 | ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c109 0xc109 is NT_STATUS_MESSAGE_NOT_FOUND according to http://lists.samba.org/archive/jcifs/2004-February/003038.html. Interestingly, in dlls/ntdll/tests/error.c, there is already an entry for STATUS_MESSAGE_NOT_FOUND,

FIXMEs in DllCanUnloadNow and friends (and how to handle them)

2010-01-05 Thread Reece Dunn
Hi, As a result of the Wine FIXME Report 2009 Aug - Dec thread, I created the following to hunt for DllCanUnloadNow calls that were marked as being FIXME stubs: cat DllCanUnloadNow.pl EOF #!/usr/local/bin/perl # Based on