Re: [PATCH 3/3] gdiplus/test: Remove todos for tests that pass now [Try 4]

2010-02-25 Thread Justin Chevrier
On Thu, Feb 25, 2010 at 9:19 PM, Charles Davis wrote: > Justin Chevrier wrote: >> --- >>  dlls/gdiplus/tests/graphics.c |   22 +++--- >>  1 files changed, 11 insertions(+), 11 deletions(-) > You're still not getting it! > > Remember, when each patch is applied, all the tests must p

Re: [PATCH 3/3] gdiplus/test: Remove todos for tests that pass now [Try 4]

2010-02-25 Thread Charles Davis
Justin Chevrier wrote: > --- > dlls/gdiplus/tests/graphics.c | 22 +++--- > 1 files changed, 11 insertions(+), 11 deletions(-) You're still not getting it! Remember, when each patch is applied, all the tests must pass. That's the rule. If the second patch is applied without this

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [Try 3]

2010-02-25 Thread Vincent Povirk
> Do I need that for the 1,4 and 8bpp tests? With my patch to > GdipGetNearestColor these tests pass and behave like Windows 7. I did > forget a todo_wine on the 16bpp grayscale test though... The tests should pass independently after each patch in the series is applied. The todo_wine's are in cas

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [Try 3]

2010-02-25 Thread Justin Chevrier
Do I need that for the 1,4 and 8bpp tests? With my patch to GdipGetNearestColor these tests pass and behave like Windows 7. I did forget a todo_wine on the 16bpp grayscale test though... On Thu, Feb 25, 2010 at 7:53 PM, Vincent Povirk wrote: >> +        status = GdipGetNearestColor(graphics, &col

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [Try 3]

2010-02-25 Thread Vincent Povirk
> +        status = GdipGetNearestColor(graphics, &color); > +        expect(Ok, status); I think you still need to mark this as todo_wine.

Fw: Re: Unable to Compile Wine on MacOSX

2010-02-25 Thread James Mckenzie
-Forwarded Message- >From: James Mckenzie >Sent: Feb 25, 2010 6:52 AM >To: Charles Davis >Subject: Re: Unable to Compile Wine on MacOSX > >>James McKenzie wrote: >>> Interestingly enough, I have run into the 'Unable to compile' problem >>> building the latest git on MacOSX. Maybe ther

Re: Preferred way of dll registration

2010-02-25 Thread Jacek Caban
Hi Paul, On 2/25/10 11:43 AM, Paul Vriens wrote: Hi Jacek, On 02/24/2010 09:30 PM, Jacek Caban wrote: Hi Paul, On 2/24/10 8:59 PM, Paul Vriens wrote: Hi, We seem to have 2 different approaches for dll registration: 1) a regsvr.c file with all the necessary functions and registry informatio

Re: shell32: implements shell link's GetCurFile (with tests, fixes bug #21297) [try5]

2010-02-25 Thread Alexandre Julliard
Mikołaj Zalewski writes: > @@ -33,6 +33,30 @@ > > #include "shell32_test.h" > > +#define expect_eq_x(expected, actual) \ > +do { \ > + int value = (actual); \ > + ok((expected) == value, "Expected " #actual " to be 0x%x (" #expected > ") is 0x%x\n", \ > + (expected),

Re: LinuxTag Berlin - call for projects

2010-02-25 Thread Kai Blin
On Thursday 25 February 2010 12:12:41 Jan Gerrit Möltgen wrote: Hi Jan, > I'm not sure, if this is the right place for my question, but I thought > it's better than the user-list. The LinuxTag in Berlin makes a call for > projects ( http://wiki.linuxtag.org/w/fp:Call_for_Projects ) and in my > op

Re: [PATCH 1/3] kernel32/tests: Add test for 'all processors' flag on Vista and newer.

2010-02-25 Thread Joerg-Cyril.Hoehle
Charles Davis wrote: >I have noticed a change in configure behavior, though. Me too. On MacOS. Since 1.1.39, Makefiles are created at the rate of ~ 1 per sec. It was much faster in 1.1.38 and before, I estimate ~6 files per second. Anyone to confirm this? >I always do git fetch; git rebase ori

LinuxTag Berlin - call for projects

2010-02-25 Thread Jan Gerrit Möltgen
Hello together, I'm not sure, if this is the right place for my question, but I thought it's better than the user-list. The LinuxTag in Berlin makes a call for projects ( http://wiki.linuxtag.org/w/fp:Call_for_Projects ) and in my oppinion Wine should be represented there. Has somebody already

Re: Preferred way of dll registration

2010-02-25 Thread Paul Vriens
Hi Jacek, On 02/24/2010 09:30 PM, Jacek Caban wrote: Hi Paul, On 2/24/10 8:59 PM, Paul Vriens wrote: Hi, We seem to have 2 different approaches for dll registration: 1) a regsvr.c file with all the necessary functions and registry information. 2) an inf file and some code to register/unregis

Re: [1/2] cmd: Add test case for bug 18346: cmd "^" escape char

2010-02-25 Thread Paul Vriens
On 02/25/2010 08:35 AM, John Chow wrote: This patch adds the test case for bug 18346: cmd does not support the "^" escape character (http://bugs.winehq.org/show_bug.cgi?id=18346). The test fails on Wine but passes on WineTestBot. -John Chow You forgot the patch (and also in the second mail)