Re: [2/3] shell32: Implement SHParseDisplayName with basic tests

2010-03-04 Thread Reece Dunn
On 4 March 2010 07:55, Paul Vriens paul.vriens.w...@gmail.com wrote: On 03/03/2010 03:18 AM, Nikolay Sivov wrote: This call is used by open file function of IE7. Some added tests crash on W2K and below. I already sent a patch for that (http://source.winehq.org/patches/data/58988). There

Re: [2/3] shell32: Implement SHParseDisplayName with basic tests

2010-03-04 Thread Paul Vriens
On 03/04/2010 09:12 AM, Reece Dunn wrote: On 4 March 2010 07:55, Paul Vrienspaul.vriens.w...@gmail.com wrote: On 03/03/2010 03:18 AM, Nikolay Sivov wrote: This call is used by open file function of IE7. Some added tests crash on W2K and below. I already sent a patch for that

Re: shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 3]

2010-03-04 Thread Ilya Basin
Hello. I can see you ran my tests on a test bot and they don't fail. Thanks. Why don't you put the patch into git? I'm willing to fix the code of the dll itself after the tests are there.

Re: shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 3]

2010-03-04 Thread Paul Vriens
On 03/04/2010 10:56 AM, Ilya Basin wrote: Hello. I can see you ran my tests on a test bot and they don't fail. Thanks. Why don't you put the patch into git? I'm willing to fix the code of the dll itself after the tests are there. I was just acting as a manual patchwatcher here ;) Alexandre

Re: [2/3] shell32: Implement SHParseDisplayName with basic tests

2010-03-04 Thread Nikolay Sivov
On 3/4/2010 10:55, Paul Vriens wrote: On 03/03/2010 03:18 AM, Nikolay Sivov wrote: This call is used by open file function of IE7. Some added tests crash on W2K and below. I already sent a patch for that (http://source.winehq.org/patches/data/58988). There are however also failures

Re[2]: shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 3]

2010-03-04 Thread Ilya Basin
PV On 03/04/2010 10:56 AM, Ilya Basin wrote: Hello. I can see you ran my tests on a test bot and they don't fail. Thanks. Why don't you put the patch into git? I'm willing to fix the code of the dll itself after the tests are there. PV I was just acting as a manual patchwatcher here ;) PV

Re: Forward SHLocalAlloc to kernel32 LocalAlloc

2010-03-04 Thread Christoph von Wittich
since v5 this is SHCreateDesktop 200 stdcall -noname SHCreateDesktop(ptr) see http://www.geoffchappell.com/viewer.htm?doc=studies/windows/shell/shell32/api/index.htm Am 07.02.2010 14:29, schrieb Vladimir Pankratov:

Re: Problems compiling Wine 1.1.39 in Solaris 10

2010-03-04 Thread Albert Lee
On Thu, 04 Mar 2010 12:05:55 +, Dimitris Vikeloudas d...@softcase.co.uk wrote: Hi there I am trying to compile wine 1.1.39 for Solaris 10 x86 technology. I stack on compilation errors of the acledit dll. I am not sure how to proceed forward. I used ./tools/wineinstall and the

Re: Re[2]: shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 3]

2010-03-04 Thread Austin English
On Thu, Mar 4, 2010 at 5:32 AM, Ilya Basin basini...@gmail.com wrote: PV On 03/04/2010 10:56 AM, Ilya Basin wrote: Hello. I can see you ran my tests on a test bot and they don't fail. Thanks. Why don't you put the patch into git? I'm willing to fix the code of the dll itself after the tests

Re: oleaut32: Fix BSTR to DATE conversion

2010-03-04 Thread Alexandre Julliard
André Hentschel n...@dawncrow.de writes: diff --git a/dlls/oleaut32/variant.c b/dlls/oleaut32/variant.c index 450856f..4ed4f01 100644 --- a/dlls/oleaut32/variant.c +++ b/dlls/oleaut32/variant.c @@ -85,6 +85,7 @@ static inline HRESULT VARIANT_Coerce(VARIANTARG* pd, LCID lcid, USHORT wFlags,

cmd: fix buffer overflow in WCMD_run_program

2010-03-04 Thread Eric Ho
Hi Guys, I'm a UCLA student working with Dan Kegel on cmd. This attached patch adds tests for the following buffer overflows, and passes on winetestbot. Fixes http://bugs.winehq.org/show_bug.cgi?id=21344. Overflows fixed: 1. overflow due to long path name (unchecked memcpy,strcpy to thisDir) 2.

Re: cmd: fix buffer overflow in WCMD_run_program

2010-03-04 Thread Austin English
On Thu, Mar 4, 2010 at 11:20 AM, Eric Ho ericho...@gmail.com wrote: Hi Guys,  I'm a UCLA student working with Dan Kegel on cmd.  This attached patch adds tests for the following buffer overflows, and passes on winetestbot.  Fixes http://bugs.winehq.org/show_bug.cgi?id=21344. Overflows fixed:

Re: shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 4]

2010-03-04 Thread Juan Lang
Hi Ilya, I think you're still confused by the prohibition against using GetVersion. Your changes follow the letter of that edict, but not the spirit: +HMODULE hkernel32 = GetModuleHandle(kernel32); +BOOL isreallyXP_2k3_plus = NULL != GetProcAddress(hkernel32, AttachConsole); +BOOL

Re: cmd: fix buffer overflow in WCMD_run_program

2010-03-04 Thread Detlef Riekenberg
On Do, 2010-03-04 at 09:20 -0800, Eric Ho wrote: Hi Eric. Welcome to Wine. Fixes http://bugs.winehq.org/show_bug.cgi?id=21344. Overflows fixed: 1. overflow due to long path name (unchecked memcpy,strcpy to thisDir) 2. overflow due to long file name (unchecked strcpy into stemofsearch) 3.

re: gdiplus: Create a full BITMAPINFO to prevent clobbering memory with palette data.

2010-03-04 Thread Dan Kegel
See also http://bugs.winehq.org/show_bug.cgi?id=21613

Re: gdiplus: Create a full BITMAPINFO to prevent clobbering memory with palette data.

2010-03-04 Thread Alasdair Sinclair
On 05/03/10 02:35, Dan Kegel wrote: See also http://bugs.winehq.org/show_bug.cgi?id=21613 Thanks, I hadn't looked in bugzilla for it, only looked at it as winetest started failing on most wine installs. Also just noticed that my log entry was back to front and it was of course crashing

cedega sdk for intel set-top boxes?

2010-03-04 Thread Dan Kegel
Anyone seen the sdk at http://www.gametree.tv/developers/ yet? I hesitate to download it, but perhaps someone out there is braver, and can describe what it includes?

Re: Help Text for Inbuilt Commands in cmd

2010-03-04 Thread Jeff Zaroyko
On Fri, Mar 5, 2010 at 12:22 PM, Arjun Comar mand...@rose-hulman.edu wrote: Added help text for a bunch of the inbuilt commands in cmd. I tried as much as possible to stick to the help texts in the windows command prompts, using the same wording where possible. -- Arjun Comar, Rose-Hulman