On 12 August 2010 15:48, Vitaliy Margolen wrote:
> You can't test that. All you can test is that you got the IDirectMusicPort
> back or not. What exactly inside is irrelevant.
>
> And if IDirectMusicPerformance8_PChannelInfo succeeds and you getting not
> null pDirectMusicPort back but it points t
On 08/11/2010 11:11 PM, Austin Lund wrote:
On 12 August 2010 14:23, Vitaliy Margolen wrote:
On 08/11/2010 09:14 PM, Austin Lund wrote:
On 11 August 2010 20:12, David Adamwrote:
I wasn't sure of the best way to do this. But basically I want to
check that the Vtbl had been set. I cannot c
On 08/11/2010 11:16 PM, Austin Lund wrote:
On 12 August 2010 14:32, Vitaliy Margolen wrote:
What are those magic numbers? Please use constants. If they are missing, add
them to appropriate header file first.
They are the numbers passed to the InitAudio method from bug 22598.
1 is DMUS_APATH
On 12 August 2010 14:32, Vitaliy Margolen wrote:
>
> What are those magic numbers? Please use constants. If they are missing, add
> them to appropriate header file first.
They are the numbers passed to the InitAudio method from bug 22598.
I've seen quite a few places where "magic" numbers are use
On 12 August 2010 14:23, Vitaliy Margolen wrote:
> On 08/11/2010 09:14 PM, Austin Lund wrote:
>>
>> On 11 August 2010 20:12, David Adam wrote:
>> I wasn't sure of the best way to do this. But basically I want to
>> check that the Vtbl had been set. I cannot cast to
>> IDirectMusicPortImpl and I
On 08/11/2010 08:58 PM, Austin Lund wrote:
+static BOOL test_InitAudio(void)
+{
+hr =
IDirectMusicPerformance8_InitAudio(idmusicperformance,NULL,&pDirectSound,NULL,1,128,0x3f,NULL);
+if (hr != S_OK) return FALSE;
+else return TRUE;
+}
Please put spaces after comas, as you do in t
On 08/11/2010 09:14 PM, Austin Lund wrote:
On 11 August 2010 20:12, David Adam wrote:
I wasn't sure of the best way to do this. But basically I want to
check that the Vtbl had been set. I cannot cast to
IDirectMusicPortImpl and I'm still confused by the COM macros.
You shouldn't be checking
On 08/11/2010 05:03 AM, joerg-cyril.hoe...@t-systems.com wrote:
> Hi,
>
> what happened to this patch? It's still marked new.
> Is the discovery too surprising?
> (Maybe it's the wrong time to ask with AJ still on vacation)
According to this:
http://www.winehq.org/pipermail/wine-devel/2010-Augus
Sorry, I failed at Gmail again. >_<
-- Forwarded message --
From: Paul "TBBle" Hampson
Date: 12 August 2010 13:52
Subject: Re: Should we expect Liberation fonts to be installed?
To: Scott Ritchie
On 8 August 2010 13:02, Scott Ritchie wrote:
> On 08/03/2010 01:57 PM, Scott Ritc
On 12 August 2010 13:16, James McKenzie wrote:
> Austin Lund wrote:
>
> Why the try2? It is always nice to put why you are doing this in the git
> commit notes.
I was responding to review. I'm sorry if I've done something confusing.
Austin Lund wrote:
Why the try2? It is always nice to put why you are doing this in the
git commit notes.
AJ is on vakay and will not be back until next week so there are NO
reviews ongoing this week, except developer peer ones.
James McKenzie
On 11 August 2010 20:12, David Adam wrote:
> Hello,
thanks for the comments. I've resent.
> + todo_wine ok(*(ULONG *)pDirectMusicPort != 0, "IDirectMusicPort not
> set\n");
>
> Why is this cast useful?
I wasn't sure of the best way to do this. But basically I want to
check that the Vtbl ha
Am 11.08.2010 um 21:51 schrieb Rico Schüller:
> --- a/dlls/d3d10/d3d10_private.h
> +++ b/dlls/d3d10/d3d10_private.h
> @@ -212,6 +212,17 @@ struct d3d10_effect
> struct d3d10_effect_technique *techniques;
> };
>
>
> +extern const struct ID3D10BlobVtbl d3d10_blob_vtbl DECLSPEC_HIDDEN;
Do you n
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=4405
Your paranoid android.
On Wed, 11 Aug 2010, joerg-cyril.hoe...@t-systems.com wrote:
> Hi,
>
> testbot.winehq.org job #4404 now contains another patch and binary. I removed
> the call to
> set c door closed
> estimating that this was the most likely among the three suspects to cause
> the error
> (I also reduced the Sl
On Wednesday, August 11, 2010 3:12:23 am David Adam wrote:
> Hello,
>
> some comments about this patch
> +if (hr != S_OK) return FALSE;
> +else return TRUE;
>
> could be simplified as
> return SUCCEEDED(hr);
SUCCEEDED encompasses more than just S_OK (S_FALSE, for instance; basically
any
Hi,
testbot.winehq.org job #4404 now contains another patch and binary. I removed
the call to
set c door closed
estimating that this was the most likely among the three suspects to cause the
error
(I also reduced the Sleep() time).
Please test yet once again. I've not changed anything about the
Hi,
what happened to this patch? It's still marked new.
Is the discovery too surprising?
(Maybe it's the wrong time to ask with AJ still on vacation)
Is it not robust enough (lacking testing with network drives)?
It explains bugs #20887 and #23355.
It may explain intermittent failures in test.win
Hello,
some comments about this patch
+if (hr != S_OK) return FALSE;
+else return TRUE;
could be simplified as
return SUCCEEDED(hr);
+trace("HRESULT when creating instance (%x)\n", hr);
Since tests are assumed to pass, we dont care about debug informations. So,
traces are useless in
Hi,
No more MCIERR_HARDWARE in David's latest test result, hurray!
The difference with prior tests is that I temporarily eliminated 3 commands
a) resume c
b) set c video audio all off
c) set c door closed notify
We are not done yet. Users who saw that error please feed the following
scripts in
20 matches
Mail list logo
