Re: [PATCH] comctl32/tests: DateTimePicker and MonthCalendar controls only support Gregorian calendar.

On 19 August 2010 16:34, Nikolay Sivov wrote: > On Thu, Aug 19, 2010 at 9:50 AM, Austin Lund wrote: >> http://www.microsoft.com/middleeast/msdn/ArabicCalendar.aspx > > Hi, Austin. > > This information is outdated probably. There's a message to set a > calendar for MonthCal at least, see: > > http

Re: [PATCH] comctl32/tests: DateTimePicker and MonthCalendar controls only support Gregorian calendar.

On Thu, Aug 19, 2010 at 9:50 AM, Austin Lund wrote: > http://www.microsoft.com/middleeast/msdn/ArabicCalendar.aspx Hi, Austin. This information is outdated probably. There's a message to set a calendar for MonthCal at least, see: http://msdn.microsoft.com/en-us/library/bb760995%28VS.85%29.aspx

Re: [PATCH 5/5] ddraw: Allow creating back buffer for DirectX 1 interfaces. (try 5, resend)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4557 Your paranoid android.

Re: [PATCH 1/5] ddraw/tests: Add test for bad size of surface caps in CreateSurface. (try 5, resend)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4553 Your paranoid android.

Re: [PATCH 2/2] gameux/tests: verifying registry values created by GameExplorer (try 2)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4552 Your paranoid android.

Re: ntdll: IMAGE_REL_BASED_HIGH, IMAGE_REL_BASED_HIGH and IMAGE_REL_BASED_HIGHLOW are supported on win64.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4548 Your paranoid android.

Re: dlls/d3dx9_36/bytecodewriter.c oddity

2010/8/18 Gerald Pfeifer : > Metteo et al, > > I noticed d3dx9_36/bytecodewriter.c can be simplified as follows, but > somewhat tells me this may rather point out a problem somewhere in that > code, so I am not sending this to wine-patches. > > (The only functional difference should be the missing

dlls/d3dx9_36/bytecodewriter.c oddity

Metteo et al, I noticed d3dx9_36/bytecodewriter.c can be simplified as follows, but somewhat tells me this may rather point out a problem somewhere in that code, so I am not sending this to wine-patches. (The only functional difference should be the missing WARN in some cases, and I could restore

Re: [PATCH 1/3] gameux: Add definitions of resource identifiers to header file

W dniu 18.08.2010 19:34, GOUJON Alexandre pisze: On 08/18/2010 07:06 PM, Mariusz Pluciński wrote: Can I do it by passing __LINE__ macro as parameter to my _validate* functions? Some tests already use __LINE__ as a parameter. See http://source.winehq.org/git/wine.git/?a=blob;f=dlls/advapi32/tes

Re: [PATCH 1/3] gameux: Add definitions of resource identifiers to header file

On 08/18/2010 07:06 PM, Mariusz Pluciński wrote: Can I do it by passing __LINE__ macro as parameter to my _validate* functions? Some tests already use __LINE__ as a parameter. See http://source.winehq.org/git/wine.git/?a=blob;f=dlls/advapi32/tests/cred.c#l260 and http://source.winehq.org/git/

Re: [PATCH 1/3] gameux: Add definitions of resource identifiers to header file

W dniu 18.08.2010 18:09, Vincent Povirk pisze: I think it would be helpful if you passed a string description to your _validate functions so that in case of failure, you can tell where the original call to _validateGameRegistryKey was, instead of just the line containing the ok() call. Can I do

Re: [PATCH 3/3] gameux/tests: verifying registry values created by GameExplorer

W dniu 18.08.2010 18:28, Andrew Eikum pisze: This result is strange, cause routine modified by this patch (called test_add_remove_game ) is not even called on these operating systems - and test added by my previous patch demonstrates it (and it succeeded). Did I something wrong? I cannot imagine

Re: [PATCH 3/3] gameux/tests: verifying registry values created by GameExplorer

> You can see the error message dialog in the screenshots on the testbot > result webpage.  In this case, you've got missing exports, > ConvertSidToSidStringW and RegGetValueW.  Some solutions are to make those > into function pointers (and skip appropriately if they're missing), use the > A versio

Re: [PATCH 3/3] gameux/tests: verifying registry values created by GameExplorer

This result is strange, cause routine modified by this patch (called test_add_remove_game ) is not even called on these operating systems - and test added by my previous patch demonstrates it (and it succeeded). Did I something wrong? I cannot imagine how it could fail when previous test was succe

Re: [PATCH 3/3] gameux/tests: verifying registry values created by GameExplorer

The testbot gives weird results at times. I wouldn't worry about it. 2010/8/18 Mariusz Pluciński : > W dniu 18.08.2010 17:49,  (Marvin) pisze: >> >> Hi, >> >> While running your changed tests on Windows, I think I found new failures. >> Being a bot and all I'm not very good at pattern recognition,

Re: [PATCH 3/3] gameux/tests: verifying registry values created by GameExplorer

W dniu 18.08.2010 17:49, (Marvin) pisze: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/Jo

Re: [PATCH 1/3] gameux: Add definitions of resource identifiers to header file

> @@ -32,7 +33,6 @@ > > #include "wine/test.h" > > - > static void test_create(BOOL* gameExplorerAvailable, BOOL* > gameExplorer2Available) > { > HRESULT hr; Don't put formatting changes in functional patches, please. I think it would be helpful if you passed a string description to your

Re: [PATCH 3/3] gameux/tests: verifying registry values created by GameExplorer

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4540 Your paranoid android.

Re: [PATCH 5/6] gameux: Add initial implementation of IGameExplorer2::CheckAccess method

Hello W dniu 16.08.2010 10:00, Mariusz Pluciński pisze: --- dlls/gameux/gameexplorer.c | 7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) This is patch I sent to wine-patches yesterday. It was marked as "Pending". I know that what I sent is not proper solution. But as I wrote in

Re: [PATCH 1/1] d3dx9: Add tests for FVF <-> declaration conversion.

Misha Koshelev writes: > +#define VDECL_CHECK(fcall) \ > +if(fcall != S_OK) \ > +trace(" Test failed on line #%d\n", __LINE__); > + > +#define VDECL_CHECK_FAIL(fcall) \ > +if(fcall != E_FAIL)

Re: [PATCH 1/2] ntdll: Implement RtlIpv4AddressToString / RtlIpv4AddressToStringEx [try 3]

Detlef Riekenberg writes: > +in = *pin; What is this for? -- Alexandre Julliard julli...@winehq.org

Re: Wine64 debugger

On 18/08/10 01:51, Marcus Meissner wrote: On Wed, Aug 18, 2010 at 01:00:35AM +1000, Peter Urbanec wrote: I'm seeing crashes in FindNextFileW/FindNextFileA due to what looks like a 64 bit HANDLE value being truncated to 32 bits. Check if your code uses "int" in its FindNextFile or findfirst thi

have all MCI tests in winmm/tests/ or distributed across mci*/tests/?

Hi, although my patch creates mcicda/tests/ I'd like to query whether it would make more sense to have all mci tests grouped in winmm/tests/. Pro: + Future fixes to winmm/mci.c would affect winmm/tests/*.c only. E.g. when I'll make "stop all" work I'd have to touch mcicda/tests/mcicda.c as

Re: [PATCH] advapi32: Add magic codes to HCRYPTKEY and HCRYPTHASH.

On 18 August 2010 20:44, GOUJON Alexandre wrote: > On 08/18/2010 12:22 PM, Hans Leidekker wrote: >> >> They are often built from four character ascii strings to help find out >> where the structures come from. I don't know why this one was chosen >> but I guess you could use something like 0xA39E7

Re: wldap32: Fix handling of zero timeout value in ldap_search_extW. (try 2)

On Wed, 2010-08-18 at 13:41 +0200, test...@testbot.winehq.org wrote: > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at

Re: wldap32: Fix handling of zero timeout value in ldap_search_extW. (try 2)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4530 Your paranoid android.

Re: [4/5] msi: Handle signature filenames in short|long notation.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4528 Your paranoid android.

Re: [3/5] msi/tests: Skip SourceDir tests on win9x.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4527 Your paranoid android.

Re: Wine64 debugger

the assertion `addr->Mode == AddrModeFlat' failed is likely an address returned by dbghelp which is not properly initialized. Could you send me off line the .exe (and associated DLL if any) so that I can check it TIA 2010/8/17 Peter Urbanec > > Hi, > > I'm trying to get a fairly complex Win64 a

Re: [2/5] msi/tests: Use HKEY_CURRENT_USER instead of HKEY_LOCAL_MACHINE for registry tests.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4526 Your paranoid android.

Re: [PATCH] advapi32: Add magic codes to HCRYPTKEY and HCRYPTHASH.

On 08/18/2010 12:22 PM, Hans Leidekker wrote: They are often built from four character ascii strings to help find out where the structures come from. I don't know why this one was chosen but I guess you could use something like 0xA39E741E and 0xA39E741D. Yep, there are some magic values at h

Re: [1/5] msi/tests: Fix some WoW64 test failures.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4525 Your paranoid android.

Re: [PATCH] advapi32: Add magic codes to HCRYPTKEY and HCRYPTHASH.

On Wed, 2010-08-18 at 20:02 +1000, Austin Lund wrote: > On 18 August 2010 18:34, Hans Leidekker wrote: > > On Wed, 2010-08-18 at 10:14 +1000, Austin Lund wrote: > > > >> #define MAGIC_CRYPTPROV 0xA39E741F > >> +#define MAGIC_CRYPTKEY 0xA39E741F > >> +#define MAGIC_CRYPTHASH 0xA39E741F > > > > Th

kernel32/tests: GetVolumeInformationA X: succeeds iff drive's default dir is root. (try 2)

Hi, please consider that patch, submitted on the 3rd of August, for inclusion. Tests pass on native w95,w98,w2k,xp,7. Greg Geldorp went into the extra effort to instrument the testbot machines (NT upto 7, not win9X) http://www.winehq.org/pipermail/wine-devel/2010-August/085919.html with a second

Re: [PATCH] advapi32: Add magic codes to HCRYPTKEY and HCRYPTHASH.

On 18 August 2010 18:34, Hans Leidekker wrote: > On Wed, 2010-08-18 at 10:14 +1000, Austin Lund wrote: > >>  #define MAGIC_CRYPTPROV 0xA39E741F >> +#define MAGIC_CRYPTKEY 0xA39E741F >> +#define MAGIC_CRYPTHASH 0xA39E741F > > The app might pass a crypto handle of the wrong type, so it would be > be

Re: wldap32: Fix handling of zero timeout value in ldap_search_extW.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4524 Your paranoid android.

Re: [PATCH] advapi32: Add magic codes to HCRYPTKEY and HCRYPTHASH.

On Wed, 2010-08-18 at 10:14 +1000, Austin Lund wrote: > #define MAGIC_CRYPTPROV 0xA39E741F > +#define MAGIC_CRYPTKEY 0xA39E741F > +#define MAGIC_CRYPTHASH 0xA39E741F The app might pass a crypto handle of the wrong type, so it would be better to use different magic values.