Re: [PATCH 2/2] opencl: Basic OpenCL 1.0 implementation. (try 2)

2010-11-30 Thread Alexandre Julliard
Peter Urbanec winehq@urbanec.net writes: +static BOOL load_funcs(void *handle) +{ +#define LOAD_FUNCPTR(f) if((p##f = (void*)wine_dlsym(handle, #f, NULL, 0)) == NULL) \ +{ ERR(Can not find #f \n); return FALSE; } else { TRACE(Loaded function #f \n); }; + +/* Platform API

Re: shdocvw: Do not annoy user when he disabled winemenubuilder

2010-11-30 Thread Alexandre Julliard
André Hentschel n...@dawncrow.de writes: @@ -85,6 +85,9 @@ static BOOL run_winemenubuilder( const WCHAR *args ) GetSystemDirectoryW( app, MAX_PATH - sizeof(menubuilder)/sizeof(WCHAR) ); strcatW( app, menubuilder ); +if( GetFileAttributesW(app) == INVALID_FILE_ATTRIBUTES) +

Re: [PATCH 3/5] mshtml: Added SetUIHandler tests.

2010-11-30 Thread Jacek Caban
On 11/29/10 11:41 PM, Paul Vriens wrote: Hi Jacek, On 11/29/2010 12:18 AM, Jacek Caban wrote: --- dlls/mshtml/tests/htmldoc.c | 111 --- 1 files changed, 104 insertions(+), 7 deletions(-) This one introduced some test failures:

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework

2010-11-30 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: --- configure |8 +- configure.ac |5 + dlls/wineqtdecoder/Makefile.in| 11 + dlls/wineqtdecoder/main.c | 135 + dlls/wineqtdecoder/qtvdecoder.c |

Re: mshtml: Added beginning ActiveX tests.

2010-11-30 Thread Paul Vriens
Hi Jacek, On 11/30/2010 01:38 PM, Jacek Caban wrote: +static HRESULT WINAPI PropertyNotifySink_OnChanged(IPropertyNotifySink *iface, DISPID dispID) +{ +if(dispID == DISPID_READYSTATE){ +BSTR state; +HRESULT hres; + +static const WCHAR completeW[] =

Translation patches for wine-1.2.2

2010-11-30 Thread Michael Stefaniuc
Hello Alexandre, attached is the list of translation patches for wine-1.2.2. This time I manually checked the changes to the En.rc files if they are indeed a wine-1.2 incompatible change. Thus there are some patches in the list that I missed for wine-1.2.1 with the automatic stop at first

Re: mshtml: Added beginning ActiveX tests.

2010-11-30 Thread Paul Vriens
On 11/30/2010 01:56 PM, Paul Vriens wrote: Hi Jacek, On 11/30/2010 01:38 PM, Jacek Caban wrote: +static HRESULT WINAPI PropertyNotifySink_OnChanged(IPropertyNotifySink *iface, DISPID dispID) +{ + if(dispID == DISPID_READYSTATE){ + BSTR state; + HRESULT hres; + + static const WCHAR completeW[]

Re: mshtml: Added beginning ActiveX tests.

2010-11-30 Thread Jacek Caban
Hi Paul, On 11/30/10 2:46 PM, Paul Vriens wrote: Changing the lstrcmpW and using A-functions to create the window makes the tests succeed on my win98 box (changed activex.c attached). Thanks for catching it. How about this version: http://source.winehq.org/patches/data/68936 I would prefer to

Re: mshtml: Added beginning ActiveX tests.

2010-11-30 Thread Paul Vriens
On 11/30/2010 03:42 PM, Jacek Caban wrote: Hi Paul, On 11/30/10 2:46 PM, Paul Vriens wrote: Changing the lstrcmpW and using A-functions to create the window makes the tests succeed on my win98 box (changed activex.c attached). Thanks for catching it. How about this version:

Re: mshtml: Added beginning ActiveX tests.

2010-11-30 Thread Jacek Caban
On 11/30/10 3:49 PM, Paul Vriens wrote: On 11/30/2010 03:42 PM, Jacek Caban wrote: Hi Paul, On 11/30/10 2:46 PM, Paul Vriens wrote: Changing the lstrcmpW and using A-functions to create the window makes the tests succeed on my win98 box (changed activex.c attached). Thanks for catching it.

Re: mshtml: Added beginning ActiveX tests.

2010-11-30 Thread Alexandre Julliard
Jacek Caban ja...@codeweavers.com writes: I can see that these tests may be useful sometimes, eg. if someone is interested in old apps that don't run on new Windows. But the honest true is that it's not what happens with our tests. All we usually do with old Windows or old IEs is blindly

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework

2010-11-30 Thread Ken Thomases
On Nov 30, 2010, at 6:52 AM, Alexandre Julliard wrote: Aric Stewart a...@codeweavers.com writes: --- configure |8 +- configure.ac |5 + dlls/wineqtdecoder/Makefile.in| 11 + dlls/wineqtdecoder/main.c | 135

Re: [1/4] winmm/tests: Add tests for mmioOpen for the file name of the form EXAMPLE.EXT+ABC.

2010-11-30 Thread Dmitry Timoshkov
Alexander Puzankov alx...@gmail.com wrote: Ok, I missed that MSDN says that the first parameter of the custom I/O procedure is of type LPSTR instead of LPMMIOINFO (could be this an error in the documentation?). Both PSDK and Wine headers use the same definition for MMIOPROC. I can make

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework

2010-11-30 Thread Aric Stewart
Sent a revised patch using the ICMDecompression apis just before seeing your e-mail. So I figured out that part. I will have to look into the pixel buffer copying improvement once the base framework is in place. thanks! -aric On 11/30/10 10:33 AM, Ken Thomases wrote: On Nov 30, 2010, at

Re: mshtml: Added beginning ActiveX tests.

2010-11-30 Thread Paul Vriens
On 11/30/2010 04:41 PM, Alexandre Julliard wrote: Jacek Cabanja...@codeweavers.com writes: I can see that these tests may be useful sometimes, eg. if someone is interested in old apps that don't run on new Windows. But the honest true is that it's not what happens with our tests. All we

Death to win9x?

2010-11-30 Thread Dan Kegel
I'm all for removing stuff that nobody needs anymore. I imagine there are still a few popular older apps that will force us to keep some old win9x behaviors around, though, so we probably won't be able to remove the 'emulate win98' choice from winecfg any time soon.

Re: Death to win9x?

2010-11-30 Thread Eric Durbin
On Tue, Nov 30, 2010 at 12:17 PM, Dan Kegel d...@kegel.com wrote: I'm all for removing stuff that nobody needs anymore. I imagine there are still a few popular older apps that will force us to keep some old win9x behaviors around, though, so we probably won't be able to remove the 'emulate

Re: Death to win9x?

2010-11-30 Thread Paul Vriens
On 11/30/2010 08:53 PM, Eric Durbin wrote: On Tue, Nov 30, 2010 at 12:17 PM, Dan Kegel d...@kegel.com mailto:d...@kegel.com wrote: I'm all for removing stuff that nobody needs anymore. I imagine there are still a few popular older apps that will force us to keep some old win9x

Stopping Win9x testing

2010-11-30 Thread Greg Geldorp
From: Paul Vriens On 11/30/2010 04:41 PM, Alexandre Julliard wrote: The value of running tests on Win9x these days is certainly questionable. We don't try to emulate the Win9x behavior anyway, except in a very few cases (which most likely don't have tests...) so it only serves to

Re: [1/4] winmm/tests: Add tests for mmioOpen for the file name of the form EXAMPLE.EXT+ABC.

2010-11-30 Thread Alexander Puzankov
Ok, I missed that MSDN says that the first parameter of the custom I/O procedure is of type LPSTR instead of LPMMIOINFO (could be this an error in the documentation?). I can make cast in mmio_test_IOProc instead, something like: static LRESULT CALLBACK mmio_test_IOProc(LPSTR lpMMIOInfo, UINT

Re: [PATCH 2/2] opencl: Basic OpenCL 1.0 implementation. (try 2)

2010-11-30 Thread Roderick Colenbrander
It looks fine to me, but I'm worried whether it can work properly in the end. A few months ago I worked on Cuda support for something (I implemented nvcuda.dll which is what cuda runtime libraries like cudart or physx are using). Certain lowlevel nvcuda applications worked, but more fancy