Re: wintrust/tests: make sure return values are used (LLVM/Clang) (3/4)

2011-02-03 Thread Juan Lang
Hey Austin, ok(ret, "WintrustSetRegPolicyFlags failed: %d\n", GetLastError()); size = sizeof(flags1); r = RegQueryValueExA(key, State, NULL, NULL, (LPBYTE)&flags1, &size); -ok(flags1 == flags3, "Got %08x flags instead of %08x\n", flags1, flags3); +ok(!r || r == ERROR_FILE_NO

Re: wintrust/tests: make sure return values are used (LLVM/Clang) (1/4)

2011-02-03 Thread Juan Lang
Hey Austin, +ok(ret == S_FALSE, "Expected S_OK, got %08x\n", ret); Copy/pasto. --Juan

Re: Wine FAQ edits

2011-02-03 Thread Vitaliy Margolen
On 02/03/2011 09:17 AM, Albert Lee wrote: The instructions were intended to give some context for users who might not be familiar with the ~ expansion. Then mention that if you must. "~" is used in number of other places in FAQ, and all over the net. Please keep it simple. It's a fairly trivi

updated LLVM/Clang static analysis results (and valgirind :-))

2011-02-03 Thread Austin English
Original results: Date: Thu Jan 20 22:59:57 2011 All Bugs2922 Argument with 'nonnull' attribute passed null 99 Idempotent operation154 Dead assignment 1464 Dead increment 155 Dead initialization 22 Array subscript is undefined5 Assigned

Re: Re: user32/tests: Test for behavior of WM_SETTEXT handler (try 2)

2011-02-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8839 Your paranoid android.

Re: Re: user32/tests: Test for behavior of WM_SETTEXT handler

2011-02-03 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8838 Your paranoid android.

Re: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-02-03 Thread Alexandre Julliard
Janne Hakonen writes: > The test cases at http://source.winehq.org/patches/ are still in > pending state. Should I improve them somehow, or leave them as they > are? I'm not sure that there's a good way of testing this. You can't use exception handlers in tests, and you can't assume that ebp is

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-03 Thread Charles Davis
On 2/3/11 11:46 AM, Henri Verbeet wrote: > On 3 February 2011 18:58, Alexandre Julliard wrote: >> It shouldn't have hacks, but I don't think it's unreasonable to use >> platform-specific services for things that don't have widely accepted >> standards. >> > That was mostly in reply to the general

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-03 Thread James Mckenzie
Charles Davis wrote: > >On 2/3/11 9:22 AM, James Mckenzie wrote: >> 2. Building ANYTHING Unix'y on a Mac may require 'hacky' patches to get >> around some of the code issues. Both of the >>known UNIX to MacOSX porting projects provide GnuTLS but have to patch it to >>build and work on MacOSX w

Re: Wine FAQ edits

2011-02-03 Thread Albert Lee
On Thu, Feb 3, 2011 at 12:32 PM, David Laight wrote: > On Thu, Feb 03, 2011 at 11:17:39AM -0500, Albert Lee wrote: >> >> > >> >> ?It's exec(2)'ed so it doesn't matter what the program is. >> > >> > Basically run in a shell. So you need an extra wrapper (env) why? >> >> To handle PATH search, since

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-02-03 Thread Janne Hakonen
Ah, I see you had already corrected the stack overflowing, and found better way even. :) I tested the correction with the test cases and they passed. I also tried AwesomiumGL and I couldn't get it to crash, so looks to me that this bug is fixed. The test cases at http://source.winehq.org/pat

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-03 Thread Henri Verbeet
On 3 February 2011 18:58, Alexandre Julliard wrote: > Henri Verbeet writes: > >> On 3 February 2011 18:01, Charles Davis wrote: >>> I'm for that. In fact, my humble opinion is that Wine on Mac should only >>> use libraries that are part of the OS (i.e. only dylibs in /usr/lib and >> I think Wine

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-03 Thread Alexandre Julliard
Henri Verbeet writes: > On 3 February 2011 18:01, Charles Davis wrote: >> I'm for that. In fact, my humble opinion is that Wine on Mac should only >> use libraries that are part of the OS (i.e. only dylibs in /usr/lib and > I think Wine should have as few OS X (or Ubuntu for that matter) > speci

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-03 Thread Juan Lang
> It sounds like things aren't nearly as murky as other licenses, but if > we were in the position where we had to ship OpenSSL ourselves we > might run into a problem. We don't, we load it dynamically. --Juan

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-03 Thread Brian Vincent
On Mon, Jan 31, 2011 at 6:08 PM, Juan Lang wrote: >> As Henri said, it's that it's a set of external dependencies (not just one; >> GnuTLS has its own dependencies) and that they are security-related.  To the >> greatest extent practical, security-related libraries should come from one's >> dis

Re: Wine FAQ edits

2011-02-03 Thread David Laight
On Thu, Feb 03, 2011 at 11:17:39AM -0500, Albert Lee wrote: > > > > >> ?It's exec(2)'ed so it doesn't matter what the program is. > > > > Basically run in a shell. So you need an extra wrapper (env) why? > > To handle PATH search, since Wine requires an absolute path. This is a > common trick use

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-03 Thread Henri Verbeet
On 3 February 2011 18:01, Charles Davis wrote: > I'm for that. In fact, my humble opinion is that Wine on Mac should only > use libraries that are part of the OS (i.e. only dylibs in /usr/lib and I think Wine should have as few OS X (or Ubuntu for that matter) specific hacks as possible.

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-03 Thread Charles Davis
On 2/3/11 9:22 AM, James Mckenzie wrote: > 2. Building ANYTHING Unix'y on a Mac may require 'hacky' patches to get > around some of the code issues. Both of the known UNIX to MacOSX porting > projects provide GnuTLS but have to patch it to build and work on MacOSX > without stepping on the exi

Re: user32/tests: Test for behavior of WM_SETTEXT handler

2011-02-03 Thread Alexandre Julliard
Alexander LAW writes: > +{ WM_CTLCOLORSTATIC, sent|parent|optional}, /*Windows sends it, Wine > doesn't*/ > +{ WM_CTLCOLORSTATIC, sent|parent|optional}, /*Windows sends it, Wine > doesn't*/ > +{ WM_APP, sent|wparam|lparam, 0, 0 }, > +{ WM_PAINT, sent }, > +{ WM_NCPAINT, sent

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-03 Thread James Mckenzie
Juan Lang wrote: I'll make this quick and address a comment here from Juan from the viewpoint of someone building Wine from scratch using one of the porting services: Fink. > >Besides, I'm still not convinced that GnuTLS on the Mac is such an >onerous problem. This is not just a Codeweavers' pro

Re: Wine FAQ edits

2011-02-03 Thread Albert Lee
On Thu, Feb 3, 2011 at 12:13 AM, Vitaliy Margolen wrote: > On 02/02/2011 09:52 PM, Albert Lee wrote: >> >> I meant 'cd' is the command preceding this one in the block this is a >> part of, if you look at the context. > > Then you should remove that cd instead. Starting instructions from "go to > y

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-03 Thread Juan Lang
Hi Francois, > As far as I understand it's not going to be another implementation. But > you're probably right to warn about having multiple backends; that can > be bad too as has been seen with sound. Yes, that's part of my concern. > Not true. Anyone using Wine on Mac OS X will benefit by not

RE: gdi32: Upper 24 bits of a character range must be same.

2011-02-03 Thread Kusanagi Kouichi
On 2011-02-03 04:11:39 -0800, Greg Geldorp wrote: > Hi, > > I'm sure you've noticed that this change causes some failures on a Simplified > Chinese-language test machine, see > http://test.winehq.org/data/5ae2b0f219cb5aed2bdf32746a57a699a32767a2/xp_wtb-wxpprozhsp3/gdi32:font.html > Can you take a

RE: gdi32: Upper 24 bits of a character range must be same.

2011-02-03 Thread Greg Geldorp
Hi, I'm sure you've noticed that this change causes some failures on a Simplified Chinese-language test machine, see http://test.winehq.org/data/5ae2b0f219cb5aed2bdf32746a57a699a32767a2/xp_wtb-wxpprozhsp3/gdi32:font.html Can you take a look at that please? I'm wondering if it wouldn't make more se

Re: msvcrt: Partially implement type_info::name_internal_method()

2011-02-03 Thread Alexandre Julliard
Nikolay Sivov writes: > @@ -260,3 +307,24 @@ int CDECL _atoflt( _CRT_FLOAT *value, char *str ) > { > return _atoflt_l( value, str, NULL ); > } > + > +/* > + * ?_name_internal_method@type_info@@QBEPBDPAU__type_info_node@@@Z

Re: RFC: Adding Mac support to secur32/schannel.c

2011-02-03 Thread Francois Gouget
On Tue, 1 Feb 2011, Juan Lang wrote: [...] > I may be flogging a dead horse here, but I personally am loath to see > another implementation creep in, side by side with the existing one, > that has no guarantee of working any better. As far as I understand it's not going to be another implementatio

Re: Try to Implement my first Stub function - AbortPrinter().

2011-02-03 Thread Nikolay Sivov
On 2/3/2011 13:51, Loïc Maury wrote: Hello, I try to implement my first stub function - *AbortPrinter()*. But before to make a patch, I need your advice. For what I understood, AbortPrinter(), remove the document spool file for a printer, created by StartDocPrinter(), who indicate that a docume

Try to Implement my first Stub function - AbortPrinter().

2011-02-03 Thread Loïc Maury
Hello, I try to implement my first stub function - *AbortPrinter()*. But before to make a patch, I need your advice. For what I understood, AbortPrinter(), remove the document spool file for a printer, created by StartDocPrinter(), who indicate that a document was spooled. I saw that the API pr

Re: [PATCH 2/5] winex11.drv: Complain a bit about missing s3tc support.

2011-02-03 Thread Tobias Jakobi
I'm not entirely sure on how to do this properly. Making it an ERR would be too loud for applications that never use s3tc textures, as a WARN it's never going to be seen unless you look at the debug channel. Printing a message in wined3d in CreateSurface() would probably work, but the resulting ch