Re: oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext

2011-07-07 Thread Nikolay Sivov
On Thu, Jul 7, 2011 at 2:09 PM, Alistair Leslie-Hughes leslie_alist...@hotmail.com wrote: Hi, Changelog:    oleaut32: Implement ICreateTypeInfo2 SetHelpStringContext +ICreateTypeInfo2Impl *This = impl_from_ICreateTypeInfo2(iface); + +TRACE((%p,%d), stub!\n, iface,

Re: [PATCH 1/2] kernel32: Fixes various 'profile' functions (profile.c). (try 3)

2011-07-07 Thread Alexandre Julliard
Christian Inci chris.pcguy.i...@gmail.com writes: kernel32: Fixes various 'profile' functions. Try 2: Formatting change. Try 3: Splitted tests/profile.c patch You can't split it that way. What you need is to split each separate fix together with its own test fix. Also please use a subject

Re: [PATCH 2/2] mshtml: Mark some functions as cdecl.

2011-07-07 Thread Juan Lang
Hi Jacek, These are functions that I missed when revieweing Gecko headers. I will probably change their calling convention in the next Gecko release. In that case, why not change the calling convention now? The matrix of possible configurations is much simpler that way. Right now, we have:

Re: [PATCH 2/2] mshtml: Mark some functions as cdecl.

2011-07-07 Thread Jacek Caban
On 7/7/11 6:02 PM, Juan Lang wrote: Hi Jacek, These are functions that I missed when revieweing Gecko headers. I will probably change their calling convention in the next Gecko release. In that case, why not change the calling convention now? The matrix of possible configurations is much

Re: [PATCH 2/2] mshtml: Mark some functions as cdecl.

2011-07-07 Thread Juan Lang
BTW, the current plan is to do the new Gecko release together with Firefox 6 release, which is about 6 weeks from now. The first beta version should be out in a week or two, depending on how Firefox beta will behave. Then shouldn't the beta have the calling convention change anyway? In this

Re: [PATCH 2/2] mshtml: Mark some functions as cdecl.

2011-07-07 Thread Jacek Caban
On 7/7/11 6:19 PM, Juan Lang wrote: BTW, the current plan is to do the new Gecko release together with Firefox 6 release, which is about 6 weeks from now. The first beta version should be out in a week or two, depending on how Firefox beta will behave. Then shouldn't the beta have the calling

Re: msvcrt/tests: Remove dead assignment (Clang)

2011-07-07 Thread Octavian Voicu
2011/7/7 Frédéric Delanoy frederic.dela...@gmail.com: --- a/dlls/msvcrt/tests/file.c +++ b/dlls/msvcrt/tests/file.c @@ -132,21 +132,21 @@ static void test_fileops( void )         rewind(file);         for (i = 0, c = EOF; i sizeof(outbuffer); i++) Isn't c = EOF in for initialization also a

Re: msvcrt/tests: Remove dead assignment (Clang)

2011-07-07 Thread Octavian Voicu
2011/7/7 Frédéric Delanoy frederic.dela...@gmail.com:         c = outbuffer[sizeof(outbuffer) - 1];         ok(ungetc(c, file) == c, ungetc did not return its input for bufmode=%x\n, bufmodes[bufmode]);         ok(!feof(file), feof after ungetc returned EOF for bufmode=%x\n,

Re: msvcrt/tests: Remove dead assignment (Clang)

2011-07-07 Thread Frédéric Delanoy
On Thu, Jul 7, 2011 at 19:07, Octavian Voicu octavian.vo...@gmail.com wrote: 2011/7/7 Frédéric Delanoy frederic.dela...@gmail.com:         c = outbuffer[sizeof(outbuffer) - 1];         ok(ungetc(c, file) == c, ungetc did not return its input for bufmode=%x\n, bufmodes[bufmode]);        

Re: msvcrt/tests: Remove dead assignment (Clang)

2011-07-07 Thread Frédéric Delanoy
On Thu, Jul 7, 2011 at 18:56, Octavian Voicu octavian.vo...@gmail.com wrote: 2011/7/7 Frédéric Delanoy frederic.dela...@gmail.com: --- a/dlls/msvcrt/tests/file.c +++ b/dlls/msvcrt/tests/file.c @@ -132,21 +132,21 @@ static void test_fileops( void )         rewind(file);         for (i = 0, c

Bug #2082

2011-07-07 Thread Charles Welton
This is one of the longest standing bugs which don't get much love from developers. Today I took some time with traces and wrote a test case which fails against git: http://bugs.winehq.org/attachment.cgi?id=35469 What is happening? When there's a child window to the ddraw window over it(the ddraw

Re: [PATCH 2/6] shell32: Implement SHQueryRecycleBin (try 3)

2011-07-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12302 Your paranoid

Re: [PATCH 2/6] shell32: Implement SHQueryRecycleBin (try 3)

2011-07-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12302 Your paranoid

Re: [PATCH 1/6] shell32/tests: Add tests for SHQueryRecycleBin

2011-07-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12300 Your paranoid

Visual Studio project to compile the d3d code

2011-07-07 Thread Stefan Dösinger
Hi, After two people told me they might have use for my Visual Studio setup to compile wined3d I finally got around to put it on my git server. You can download it with GIT_SSL_NO_VERIFY=1 git clone https://84.112.174.163/~git/wined3d_vs What is this good for? My aims were to have

Re: Bug #2082

2011-07-07 Thread Stefan Dösinger
Hi, Your test app is pretty helpful, I'll reply with more details in the bug report. Note however that this is not an easy buy, if it was it would have been fixed years ago. I am not convinced that a proper fix is possible at all. The apps in question, and your test app, are essentially

Re: [PATCH 1/6] kernel32: Fix PROFILE_Load (try 4)

2011-07-07 Thread Juan Lang
Hi Christian, this isn't quite what Alexandre meant. *What* did you fix? Saying you did so isn't enough. Thanks, --Juan

Re: [PATCH 1/6] kernel32: Fix PROFILE_Load (try 4)

2011-07-07 Thread Christian Inci
On 07/08/2011 01:22 AM, Juan Lang wrote: Hi Christian, this isn't quite what Alexandre meant. *What* did you fix? Saying you did so isn't enough. Thanks, --Juan I'm sorry, I thought you can see it out of the sourcecode. PATCH 1: Don't load any variables which aren't in a section. PATCH 2:

Re: [PATCH 1/6] kernel32: Fix PROFILE_Load (try 4)

2011-07-07 Thread Ricardo Filipe
2011/7/8 Christian Inci chris.pcguy.i...@gmail.com On 07/08/2011 01:22 AM, Juan Lang wrote: Hi Christian, this isn't quite what Alexandre meant. *What* did you fix? Saying you did so isn't enough. Thanks, --Juan I'm sorry, I thought you can see it out of the sourcecode. PATCH 1:

Re: [PATCH 1/6] kernel32: Fix PROFILE_Load (try 4)

2011-07-07 Thread Christian Inci
On 07/08/2011 02:06 AM, Ricardo Filipe wrote: 2011/7/8 Christian Inci chris.pcguy.i...@gmail.com mailto:chris.pcguy.i...@gmail.com On 07/08/2011 01:22 AM, Juan Lang wrote: Hi Christian, this isn't quite what Alexandre meant. *What* did you fix? Saying you did so isn't