Re: cmd: an issue with cd .. command

2011-08-11 Thread Jerome Leclanche
You need to write tests for as many cases you can think of. eg cd ., cd .., some invalid directories and so on. Im not familiar with the cmd code but this feels like a bit of a hack. Jerome On Thu, Aug 11, 2011 at 6:19 AM, Nowres Rafid nowres.ra...@gmail.com wrote: Hello, the command cd ..  

Re: cmd: an issue with cd .. command

2011-08-11 Thread Frédéric Delanoy
On Thu, Aug 11, 2011 at 05:19, Nowres Rafid nowres.ra...@gmail.com wrote: Hello, the command cd ..   doesn't work when there is extra spaces at the end. I propose this patch and ask for your confirmation about it. best regards. } else { + +/* Remove any space at the end of

Re: d3dx9: CloneMesh test and improvements

2011-08-11 Thread Matteo Bruni
2011/8/11 Michael Mc Donnell mich...@mcdonnell.dk: +dst_ptr[0] = src-x 0.0f ? (SHORT)ceilf(src-x * SHRT_MAX + 0.5f) :(SHORT)floorf(src-x * SHRT_MAX + 0.5f); You can use roundf() instead. Actually, notice that maybe what you actually need for correct rounding is rintf() (which

Re: cmd: an issue with cd .. command

2011-08-11 Thread Frédéric Delanoy
2011/8/11 Nowres Rafid nowres.ra...@gmail.com: where is the code that eliminates extra spaces after normal directories name? (because cd dir   works) Don't know. You'll have to find yourself, possibly by running with cmd debug channel and/or debugger Frédéric

Re: cmd: an issue with cd .. command

2011-08-11 Thread Frédéric Delanoy
2011/8/11 Nowres Rafid nowres.ra...@gmail.com: here we change the command   if (CompareStringW(LOCALE_USER_DEFAULT, NORM_IGNORECASE | SORT_STRINGSORT, command, 2, parmD, -1) == 2) {     command += 2;     while (*command *command==' ') command++;  

Re: cmd: an issue with cd .. command

2011-08-11 Thread Nowres Rafid
I corrected the code as suggested and added some test cases On Thu, 2011-08-11 at 14:03 +0200, Frédéric Delanoy wrote: On Thu, Aug 11, 2011 at 05:19, Nowres Rafid nowres.ra...@gmail.com wrote: Hello, the command cd ..doesn't work when there is extra spaces at the end. I propose

Re: d3dx9: CloneMesh test and improvements

2011-08-11 Thread Michael Mc Donnell
On Thu, Aug 11, 2011 at 3:01 PM, Matteo Bruni matteo.myst...@gmail.com wrote: 2011/8/11 Michael Mc Donnell mich...@mcdonnell.dk: +            dst_ptr[0] = src-x 0.0f ? (SHORT)ceilf(src-x * SHRT_MAX + 0.5f) :(SHORT)floorf(src-x * SHRT_MAX + 0.5f); You can use roundf() instead. Actually,

Re: gsoc mentor summit

2011-08-11 Thread Stefan Dösinger
On Wednesday 10 August 2011 21:00:24 Owen Rudge wrote: Any further thoughts on this from any of the other mentors? It looks like the latest date to officially confirm things is the 30th September, but we probably want to figure things out before then to sort out travel, etc. I guess if nobody

Assining .bat and .com files with the desktop

2011-08-11 Thread Nowres Rafid
I propose to associate .bat and .com files with wine's cmd in GNOME, KDE and others

Re: Assining .bat and .com files with the desktop

2011-08-11 Thread Damjan Jovanovic
On Thu, Aug 11, 2011 at 5:21 PM, Nowres Rafid nowres.ra...@gmail.com wrote: I propose to associate .bat and .com files with wine's cmd in GNOME, KDE and others AFAIK COM files are ancient self-contained real-mode DOS code, with no ability to load DLLs. Shouldn't they rather be loaded by

Re: Assining .bat and .com files with the desktop

2011-08-11 Thread Vincent Povirk
I'm not sure DOSBox is able to competently open some random executable file. One would have to make a config file that sets up a drive mapping, runs the file, and quits. If Wine can do these things (and maybe also properly handle cases where the COM executable expects to be run on a windows

Re: Assining .bat and .com files with the desktop

2011-08-11 Thread Jerome Leclanche
Damjan, I dont believe it is necessary to have separate desktop files for different commands. Just append whatever you need in a new section. I believe chromium does that to differentiate some --flags. On Thu, Aug 11, 2011 at 6:57 PM, Damjan Jovanovic damjan@gmail.com wrote: On Thu, Aug 11,

Re: Assining .bat and .com files with the desktop

2011-08-11 Thread André Hentschel
Am 11.08.2011 18:18, schrieb Vincent Povirk: I'm not sure DOSBox is able to competently open some random executable file. One would have to make a config file that sets up a drive mapping, runs the file, and quits. If Wine can do these things (and maybe also properly handle cases where the COM

Re: [1/3] gdi32: Initial Gamma setting tests

2011-08-11 Thread André Hentschel
Am 10.08.2011 23:24, schrieb Nikolay Sivov: On 8/11/2011 00:58, André Hentschel wrote: --- dlls/gdi32/tests/dc.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) thx for the hints, i just sent try2 which should be much cleaner. -- Best

Re: wined3d: Only update the sampler map when needed

2011-08-11 Thread Stefan Dösinger
On Tuesday 26 July 2011 23:13:53 Henri Verbeet wrote: +device-fixed_function_usage_map = 0xff; This looks questionable, it will cause unused textures to be loaded. I'll try to cover this with my draw overhead test, but I have to get rid of its use of a pixel shader first. Performance

Re: Assining .bat and .com files with the desktop

2011-08-11 Thread Damjan Jovanovic
On Thu, Aug 11, 2011 at 6:18 PM, Vincent Povirk madewokh...@gmail.com wrote: I'm not sure DOSBox is able to competently open some random executable file. One would have to make a config file that sets up a drive mapping, runs the file, and quits. If Wine can do these things (and maybe also