Re: new d3d9/device.ok test always fails here, but not a regression?

2012-01-02 Thread Saulius Krasuckas
* On Mon, 2 Jan 2012, Dan Kegel wrote: > > If an app stops working because some missing feature is added to an > existing DLL, it should not be tagged as a regression even though it is > from the app's point of view, right? > (Thinking of the installers for Photoshop CS3 and Visual Studio 2005.)

Re: [PATCH 2/5] wined3d: Recognize some more Intel GPUs.

2012-01-02 Thread Henri Verbeet
On 3 January 2012 03:03, Christian Inci wrote: > I'm using a Netbook with an Intel Atom N450 (Pineview, PCI ID: 8086:a011), > which has 256MB under 2GB of RAM. > Personally, I think we need a way for detecting the correct VRAM size for > IGD's, as it usually depends on the total RAM size. (If no

Re: [PATCH 2/5] wined3d: Recognize some more Intel GPUs.

2012-01-02 Thread Christian Inci
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Henri, I'm using a Netbook with an Intel Atom N450 (Pineview, PCI ID: 8086:a011), which has 256MB under 2GB of RAM. Personally, I think we need a way for detecting the correct VRAM size for IGD's, as it usually depends on the total RAM size. (If

Warning report for wine-1.3.36

2012-01-02 Thread Jerome Leclanche
No change since 1.3.35. J. Leclanche == 32-bit == Clean! == 64-bit == ccache gcc -msse4 -O3 -Wall -c -I../../../dlls/dbghelp -I. -I../../../include -I../../include -D__WINESRC__ -D_IMAGEHLP_SOURCE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclarat

Re: [PATCH 3/5] d3d10/tests: Add a state groups test.

2012-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16235 Your paranoid android

[PATCH RFC 4/5] dsound: Clean up channels

2012-01-02 Thread Joerg-Cyril . Hoehle
Alexander, I'm not familiar with dsound + if (ichannels > 2) + FIXME("Conversion from %u to %u channels is not implemented, falling back to stereo", ichannels, ochannels); + dsb->mix_channels = 2; Does you code support 8 channels? Look through git history, and you'll se

Re: ieframe: Improved test traces

2012-01-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16234 Your paranoid android

Re: urlmon: When detecting text/html look for HEAD or BODY tags too and only in first 256 bytes

2012-01-02 Thread Jacek Caban
On 01/02/12 14:53, Paul Chitescu wrote: Changelog: urlmon: When detecting text/html look for HEAD or BODY tags too and only in first 256 bytes Please add a test case. This fixes bug #27115 and similar. Note that this is just a minor improvement. The entire implementation should be

Re: new d3d9/device.ok test always fails here, but not a regression?

2012-01-02 Thread Dan Kegel
On Mon, Jan 2, 2012 at 2:58 AM, Alexandre Julliard wrote: > Obviously it's important, and we have an importance field in bugzilla > for that. But the regression keyword has a specific meaning: there has > to be a piece of code that worked and then got broken. Bugs in newly > added code cannot be r

Release plans

2012-01-02 Thread Alexandre Julliard
Happy New Year to everyone! As you probably know, 2012 will be the year when we release 1.4. I know I already said this last year, but this time I mean it... The release features are in good shape now, and the plan is to enter code freeze as soon as the DIB engine can be considered done, which s

Re: new d3d9/device.ok test always fails here, but not a regression?

2012-01-02 Thread Alexandre Julliard
Dan Kegel writes: > On Sun, Jan 1, 2012 at 6:32 PM, Austin English > wrote: >> That _particular_ test never worked, so it's not a regression. A code >> change in d3d itself that broke a previously working test/application >> would be a valid regression. > > IMHO a code change in a d3d test that

Re: [PATCH] jscript: functions that return -1 should have signed return (Coverity)

2012-01-02 Thread Jacek Caban
Hi Marcus, On 12/31/11 15:43, Marcus Meissner wrote: Hi, Side issue of CID 5504. Ciao, Marcus --- dlls/jscript/compile.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/compile.c b/dlls/jscript/compile.c index 60b0c2e..96497b6 100644 --- a/dlls/jscri