Re: [PATCH 1/4] shell32: Add IQueryInfo in ShellFolder2_GetUIObjectOf

2012-05-18 Thread Nikolay Sivov
On 5/18/2012 14:06, Detlef Riekenberg wrote: +if (ppv == NULL) +return E_POINTER; This is usually redundant. + +if (IsEqualGUID(IID_IUnknown, riid) || +IsEqualGUID(IID_IQueryInfo, riid)) { +*ppv =This-IQueryInfo_iface; +IUnknown_AddRef((IUnknown*)*ppv);

Re: [PATCH 3/4] shell32: Add IQueryInfo to more shellfolder

2012-05-18 Thread Nikolay Sivov
On 5/18/2012 14:06, Detlef Riekenberg wrote: +} else if (IsEqualIID(riid,IID_IQueryInfo) (cidl == 1)) { +pidl = ILCombine (This-pidlRoot, apidl[0]); +pObj = (IUnknown *) IQueryInfo_Constructor (pidl); +SHFree (pidl); +hr = S_OK;

Logging issue ?

2012-05-18 Thread GOUJON Alexandre
Hi, To understand why a game does not work with the disc while it does with the ISO (created from the same disc), I made a log with +tid,+relay,+volume in both cases and noticed : - some lines (call or ret) are not printed / missing - some lines are half-printed and joined with the following

Re: Logging issue ?

2012-05-18 Thread Nikolay Sivov
On 5/18/2012 17:23, GOUJON Alexandre wrote: Hi, To understand why a game does not work with the disc while it does with the ISO (created from the same disc), I made a log with +tid,+relay,+volume in both cases and noticed : - some lines (call or ret) are not printed / missing - some lines

Fwd: Re: Logging issue ?

2012-05-18 Thread GOUJON Alexandre
Also replying to wine-devel Original Message Subject:Re: Logging issue ? Date: Fri, 18 May 2012 16:52:34 +0200 From: GOUJON Alexandre ale.gou...@gmail.com To: Nikolay Sivov bungleh...@gmail.com On 05/18/2012 05:31 PM, Nikolay Sivov wrote: On 5/18/2012

Re: quartz: COM cleanup for Parser_OutputPin

2012-05-18 Thread Michael Stefaniuc
Hello Aric, On 05/18/2012 04:27 PM, Aric Stewart wrote: diff --git a/dlls/quartz/avisplit.c b/dlls/quartz/avisplit.c index 5027e90..bac1b24 100644 --- a/dlls/quartz/avisplit.c +++ b/dlls/quartz/avisplit.c @@ -288,7 +288,7 @@ static HRESULT AVISplitter_next_request(AVISplitterImpl *This,

Re: quartz: COM cleanup for Parser_OutputPin

2012-05-18 Thread Aric Stewart
Ahh, my understanding of COM cleanup grows... -aric On 5/18/12 10:27 AM, Michael Stefaniuc wrote: Hello Aric, On 05/18/2012 04:27 PM, Aric Stewart wrote: diff --git a/dlls/quartz/avisplit.c b/dlls/quartz/avisplit.c index 5027e90..bac1b24 100644 --- a/dlls/quartz/avisplit.c +++

Re: [PATCH 1/5] programs: First version of the joystick testing tool. Just lists connected joysticks.

2012-05-18 Thread Alexandre Julliard
Lucas Fialho Zawacki lfzawa...@gmail.com writes: From: Lucas Fialho Zawacki lfzawa...@gmail.com --- configure.ac |1 + programs/joystick/Makefile.in | 17 +++ programs/joystick/main.c | 102 + 3 files changed, 120

Re: [1/2] comctl32/tests: Added tests for treeview right mouse click handling (try 3)

2012-05-18 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=18480 Your paranoid

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold

2012-05-18 Thread James Eder
IMO, AppDB should gather enough information form the user to assign the rating automatically. For example, answering no for Installs? should automatically lower the rating. Runs? might be a bit too is a bit too ambiguous. More over, the ratings should not be something you have to click on a

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold

2012-05-18 Thread Rosanne DiMesio
On Fri, 18 May 2012 14:52:28 -0600 James Eder jimpor...@gmail.com wrote: With the current system, rating is open to ambiguity and misuse. Users often use it as an indicator of how much they like the application or how excited they are that it works with Wine. Yes. If we generate the