Austin English wrote:
> >> +ok(!lstrcmp(lf.lfFaceName, "Arial") ||
> >> + !lstrcmp(lf.lfFaceName, "Liberation Sans"), "wrong face name
> >> %s\n", lf.lfFaceName);
> >
> > The tests are supposed to reflect Windows behaviour, what Windows version
> > does return "Liberation Sans" in this
On Wed, Oct 17, 2012 at 7:54 PM, Dmitry Timoshkov wrote:
> Austin English wrote:
>
>> +ok(!lstrcmp(lf.lfFaceName, "Arial") ||
>> + !lstrcmp(lf.lfFaceName, "Liberation Sans"), "wrong face name %s\n",
>> lf.lfFaceName);
>
> The tests are supposed to reflect Windows behaviour, what Window
Austin English wrote:
> +ok(!lstrcmp(lf.lfFaceName, "Arial") ||
> + !lstrcmp(lf.lfFaceName, "Liberation Sans"), "wrong face name %s\n",
> lf.lfFaceName);
The tests are supposed to reflect Windows behaviour, what Windows version
does return "Liberation Sans" in this test?
--
Dmitry.
I just upgraded to 12.04, until they fix the "32-bit headers problem"
you'll have to manually create the symbolic links for the "-dev"
package behavior:
cd /usr/lib/i386-linux-gnu
sudo ln -s libfreetype.so.6 libfreetype.so
sudo ln -s libXau.so.6 libXau.so
sudo ln -s libXcursor.so.1 libXcursor.
On Wed, Oct 17, 2012 at 11:21 PM, Joey Yandle wrote:
> I've been happily building 32-bit wine on 64-bit ubuntu 12.04. I just
> had to make a debootstrap chroot:
>
> https://help.ubuntu.com/community/DebootstrapChroot/
>
The Wine Wiki page on this has a nice How-to
http://wiki.winehq.org/WineOn
Jason wrote:
>>It's clearly time to start splitting WCMD_for into several helper functions.
>
> I completely agree, and it was definitely on my radar to do... its really
> ugly code in there (I take responsibility for a lot of that!) as it has
> been a slow incremental increase in what we actually
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=22302
Your paranoid android
> Is it possible to compile 32bit wine in 64bit ubuntu 12.10? I heard
> there were problems in 12.04 - were they resolved?
>
I've been happily building 32-bit wine on 64-bit ubuntu 12.04. I just
had to make a debootstrap chroot:
https://help.ubuntu.com/community/DebootstrapChroot/
It only ta
Op 17-10-12 20:59, Austin English schreef:
> On Tue, Oct 16, 2012 at 5:10 AM, Maarten Lankhorst
> wrote:
>> From: Maarten Lankhorst
>>
>> Fixes midi on winepulse
>> ---
>> dlls/winmm/lolvldrv.c | 5 -
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/dlls/winmm/lolvldrv.c
Your patch pass the tests. Good.
I think my additionnal tests are enought for now. They prove really well what
it happens for this function.
I let you send your patch. I will send the tests when your patch is committed.
Can you use j++ instead of ++j. Like this, it will be as the other loops fo
On Tue, Oct 16, 2012 at 5:10 AM, Maarten Lankhorst
wrote:
> From: Maarten Lankhorst
>
> Fixes midi on winepulse
> ---
> dlls/winmm/lolvldrv.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/winmm/lolvldrv.c b/dlls/winmm/lolvldrv.c
> index f387323..3b1be27 100644
Hello,
Is it possible to compile 32bit wine in 64bit ubuntu 12.10? I heard
there were problems in 12.04 - were they resolved?
Regards,
Daniel
> You can't add return value to locale__Locimp_dtor since it have to be
> compatible with what native returns. I'm not sure how it's supposed to
> work, I guess locale__Locimp_dtor should be only called when refcount
> already is 0. I'll do some testing tomorrow.
How about something like the attac
On 10/17/12 5:04 PM, Daniel Lehman wrote:
Memory allocated for locale__Locimp object should be freed in locale
class (locale_dtor function). You can't delete it here.
Yeah, wasn't entirely sure about the location, but I want to call delete as
soon as the refcount is 0 and can only reliably do
On Oct 17, 2012, at 9:50 AM, Aric Stewart wrote:
> -if (iconDirEntries[i].wBitCount >= best[slot].maxBits)
> +if (((best[slot].maxBits && !scaled) || (!best[slot].maxBits) ||
> (scaled && best[slot].scaled)) && (iconDirEntries[i].wBitCount >=
> best[slot].maxBits || (!scaled && b
> Memory allocated for locale__Locimp object should be freed in locale
> class (locale_dtor function). You can't delete it here.
>
Yeah, wasn't entirely sure about the location, but I want to call delete as
soon as the refcount is 0 and can only reliably do that there. locale_dtor
can't count
>It's clearly time to start splitting WCMD_for into several
helper functions.
I completely agree, and it was definitely on my radar to do... its really
ugly code in there (I take responsibility for a lot of that!) as it has
been a slow incremental increase in what we actually supported... I was
ai
On 10/17/12 3:11 AM, Per Johansson wrote:
> On Wed, Oct 17, 2012 at 6:08 AM, Vincent Povirk wrote:
>> I agree that scaling to 32x32 would probably work out better.
>> Personally, I probably would've chosen 128x128, since that would
>> involve no loss of information or distortion (but maybe we don'
krnl386.exe.diff
Description: Binary data
Ann and Jason Edmeades writes:
> Parse the options you can provide with for /f to control the
> subsequent parsing, and add support for the simplest (skip).
> @@ -1546,6 +1545,13 @@ void WCMD_for (WCHAR *p, CMD_LIST **cmdList) {
>intitemNum;
>CMD_LIST *thisCmdStart;
>intparame
On 17.10.2012 08:35, Nozomi Kodama wrote:
My bad.
My patch pass the tests but not yours. Can you check these facts?
Nozomi
Oups, I didn't respect the order while setting the output values.
Splitting the loop and starting with the smallest index should make the
behavior exactly the same as y
On Wed, Oct 17, 2012 at 10:36:44AM +0200, joerg-cyril.hoe...@t-systems.com
wrote:
> Please note that the patch queue failed to detect some superseded patches:
>
> 90588: I should not have named that 17/25 in the first place.
> 90672 + 90674: the original 20-21/25 were never marked superseded by l
2012/10/16 Francois Gouget
> On Mon, 15 Oct 2012, Christian Costa wrote:
> [...]
> > >> Why not if I can make it run the test after the extraction.
> > >> That said why not improving test bot download extra files? Is there a
> > >> specific reason for that?
> > > I'm not against improving the tes
On 10/17/12 02:35, Daniel Lehman wrote:
@@ -7241,10 +7241,11 @@ void __thiscall
locale__Locimp_dtor(locale__Locimp *this)
MSVCP_size_t i;
for(i=0; ifacet_cnt; i++)
if(this->facetvec[i] &&
locale_facet__Decref(this->facetvec[i]))
-call_locale_facet
On Wed, Oct 17, 2012 at 6:08 AM, Vincent Povirk wrote:
> I agree that scaling to 32x32 would probably work out better.
> Personally, I probably would've chosen 128x128, since that would
> involve no loss of information or distortion (but maybe we don't like
> the increased file size?).
It's howev
Hi,
While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=22282
Your paranoid android
Christian Costa wrote:
> >> Indeed that would be great to be able to download some files along with the
> >> test.
> >> Typically for me avi files and dlls (or .drv) would be great ! :D
> > Just do what other tests do: embed all the required data into the test:
> > be it a PE executable, TIFF/GIF
27 matches
Mail list logo
