Re: [PATCH 2/4] [cmd] Prevent external env vars causing tests to fail

2012-11-19 Thread Ann and Jason Edmeades
> IMHO it might be better to use variable names like WINE_xxx for tests > involving "enumerations" to avoid needlessly altering the environment. > (not that BAR, FOO or FOOBAR are likely to be already used environment > variables) > > Frédéric > Thanks! We dont really change the environment long

Re: [PATCH 3/4] [cmd] Add support for NUL in copy

2012-11-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23016 Your paranoid android

Re: [PATCH 2/4] [cmd] Prevent external env vars causing tests to fail

2012-11-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23015 Your paranoid android

Re: [PATCH 1/4] [cmd] Add support for tokens= (for /f)

2012-11-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23014 Your paranoid android

Re: [PATCH 2/4] [cmd] Prevent external env vars causing tests to fail

2012-11-19 Thread Frédéric Delanoy
On Mon, Nov 19, 2012 at 10:03 PM, Ann and Jason Edmeades wrote: > Existance of external environment variables should not cause > make test to fail, but it can cause extra lines in some of the > set commands if the test does not first clear them out. > > [Fixes bug 32087] > diff --git a/programs/c

Re: [PATCH 4/4] [kernel] Support opening of console for read

2012-11-19 Thread Christian Costa
+ * write_console_input + * + * Helper function for bare_console_fetch_input calling WriteConsoleInput + * The handle passed to ReadConsole etc may not have been opened for write, + * and hence the calls to WriteConsoleInput may fail. This routine handles such + * a failure, and retries the write

Re: [PATCH 1/2] usp10: Fixed wgBlank, wgDefault, wgInvalid and wgKashida (try 4).

2012-11-19 Thread Qian Hong
On Tue, Nov 20, 2012 at 2:12 AM, Alexandre Julliard wrote: > > It doesn't seem useful to have all these separate set and get functions, > particularly since their implementation is very similar. Ah, yes, thanks for reminder! I must drank too much Wine LOL. -- Regards, Qian Hong - Sent from Ubun

Re: [PATCH 1/2] usp10: Fixed wgBlank, wgDefault, wgInvalid and wgKashida (try 4).

2012-11-19 Thread Alexandre Julliard
Qian Hong writes: > @@ -813,6 +926,12 @@ static HRESULT init_script_cache(const HDC hdc, > SCRIPT_CACHE *psc) > return E_INVALIDARG; > } > sc->sfnt = (GetFontData(hdc, MS_MAKE_TAG('h','e','a','d'), 0, NULL, > 0)!=GDI_ERROR); > + > +set_cache_blank_char(hdc, sc); > +se

Re: [1/5] windowscodecs: Implement QueryCapability in the PNG decoder.

2012-11-19 Thread Dmitry Timoshkov
Vincent Povirk wrote: > >> For JPEG and TIFF, which are extensible formats, there's also the > >> possibility that an image has something in it that we don't support > >> (and that the corresponding decoder on Windows doesn't support) but > >> some other decoder on the system can. > > > > A not s

Re: [1/5] windowscodecs: Implement QueryCapability in the PNG decoder.

2012-11-19 Thread Vincent Povirk
>> For JPEG and TIFF, which are extensible formats, there's also the >> possibility that an image has something in it that we don't support >> (and that the corresponding decoder on Windows doesn't support) but >> some other decoder on the system can. > > A not supported stream format is a bug and

Re: [1/5] windowscodecs: Implement QueryCapability in the PNG decoder.

2012-11-19 Thread Dmitry Timoshkov
Vincent Povirk wrote: > You should at least look at the stream and check that it looks like an > image in a format the decoder can read. An invalid image format is a completely not related case, that I'd prefer ignore for now. > For PNG, you could maybe argue that given a correct magic number a

Re: [1/5] windowscodecs: Implement QueryCapability in the PNG decoder.

2012-11-19 Thread Vincent Povirk
You should at least look at the stream and check that it looks like an image in a format the decoder can read. For PNG, you could maybe argue that given a correct magic number and a correctly-working decoder, the decoder must be able to read all the images or either the decoder or image is broken.

Re: Wine and multiarch on Debian Testing

2012-11-19 Thread Francois Gouget
On Mon, 12 Nov 2012, Francois Gouget wrote: [...] >libtiff4-dev - #689085 I got bad news on this one: the maintainer has closed it as wontfix. The rational is that he does not have time to do it and does not want to deviate from upstream. So if upstream does not fix it or a patch is not pro

Re: [PATCH] regedit: fixed a fclose(stdin) issue (Coverity)

2012-11-19 Thread Frédéric Delanoy
On Sat, Nov 17, 2012 at 9:28 PM, Marcus Meissner wrote: > Hi, > > If we have multiple filenames on the commandline, and the second one is -, > we would fclose(stdin) as realname is not NULL. > > (And also double free realname.) > > So set it back to NULL after free and in the stdin case. > > Ciao,

Re: cmd: Fix possible NULL pointer access in heap_strdupW

2012-11-19 Thread Frédéric Delanoy
On Sat, Nov 17, 2012 at 10:52 PM, André Hentschel wrote: > we already do that (ieframe,vbscript,wininet,.. are good examples), but not > consistent all over the place > --- > programs/cmd/wcmd.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/programs/cmd/wcmd.h b/prog