Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-19 Thread Frédéric Delanoy
On Sat, Aug 17, 2013 at 5:31 PM, Ken Sharp kennyb...@o2.co.uk wrote: On 17/08/13 09:02, Frédéric Delanoy wrote: Hwang YunSong (황윤성) Looks like UTF-8 works fine, so you could always use your real Chinese name. Of course Ken but then you miss the point of transliteration ;) -- Frédéric

Re: [PATCH 1/5] wined3d: Keep GL_UNPACK_CLIENT_STORAGE_APPLE off by default

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Henri, Matteo, When reviewing those patches, please have a look at the attached archive. It contains the rest of the volume cleanup patches and some tests. Cheers, Stefan -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.20 (GNU/Linux) Comment:

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Henri Verbeet
On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: +struct wined3d_heap_memory *wined3d_alloc_resource_mem(UINT size) +{ +struct wined3d_heap_memory *ret; + +ret = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*ret)); +if (!ret) +return NULL;

Re: [PATCH 3/5] wined3d: Properly allocate heap memory for volumes

2013-08-19 Thread Henri Verbeet
On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: @@ -184,7 +184,16 @@ HRESULT CDECL wined3d_volume_map(struct wined3d_volume *volume, volume, map_desc, box, flags); if (!volume-resource.allocatedMemory) -volume-resource.allocatedMemory =

Re: [PATCH 4/5] wined3d: Move volume booleans into a flags field

2013-08-19 Thread Henri Verbeet
On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: +volume-flags |= WINED3D_VFLAG_LOCKABLE; /* FIXME */ You'll probably want to fix that :-) I think you can just leave the flag out until you rename it to WINED3D_VFLAG_MAPPABLE in one of the later patches.

Re: [PATCH 5/5] wined3d: Store the mipmap level in the volume

2013-08-19 Thread Henri Verbeet
On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: +void wined3d_volume_set_texture_level(struct wined3d_volume *volume, GLint level) +{ +volume-texture_level = level; +} I think that's a step in the wrong direction. I think this should be set on volume creation. We

Re: [PATCH 10/11] widl: Set pointer_size according to host's pointer-size.

2013-08-19 Thread Alexandre Julliard
Kai Tietz ktiet...@googlemail.com writes: diff --git a/tools/widl/widl.c b/tools/widl/widl.c index 5df99fc..6d8ec87 100644 --- a/tools/widl/widl.c +++ b/tools/widl/widl.c @@ -139,7 +139,7 @@ int line_number = 1; static FILE *idfile; -unsigned int pointer_size = 0; +unsigned int

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-19 12:29, schrieb Henri Verbeet: I don't think this is a good idea. How about something like the following? The corresponding free function would be trivial. I guess this works for the purposes of this patchset. However, in my command

Re: [PATCH 5/5] wined3d: Store the mipmap level in the volume

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-19 12:39, schrieb Henri Verbeet: On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: +void wined3d_volume_set_texture_level(struct wined3d_volume *volume, GLint level) +{ +volume-texture_level = level; +} I

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Henri Verbeet
On 19 August 2013 13:38, Stefan Dösinger ste...@codeweavers.com wrote: I guess in theory any kind of payload could be added to your implementation, but growing this larger than RESOURCE_ALIGNMENT(=16) bytes moots the point I guess. The point is mostly that I don't think we want the

Re: [PATCH 5/5] wined3d: Store the mipmap level in the volume

2013-08-19 Thread Henri Verbeet
On 19 August 2013 13:51, Stefan Dösinger ste...@codeweavers.com wrote: Am 2013-08-19 12:39, schrieb Henri Verbeet: On 19 August 2013 10:52, Stefan Dösinger ste...@codeweavers.com wrote: +void wined3d_volume_set_texture_level(struct wined3d_volume *volume, GLint level) +{ +

Re: msxml3: Defer the conversion of XPath expressions to UTF-8. (try 4)

2013-08-19 Thread Alexandre Julliard
John Chadwick johnwchadw...@gmail.com writes: This patch was posted a bit ago without any objections, but seemingly slipped through the cracks. Very slight revisions were made since try 3 to improve the conciseness of code. From 8157b8a3d347c47f7f21e74d621632b4a9f50fd6 Mon Sep 17 00:00:00

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-19 13:53, schrieb Henri Verbeet: On 19 August 2013 13:38, Stefan Dösinger ste...@codeweavers.com wrote: I guess in theory any kind of payload could be added to your implementation, but growing this larger than RESOURCE_ALIGNMENT(=16)

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Henri Verbeet
On 19 August 2013 14:20, Stefan Dösinger stefandoesin...@gmail.com wrote: Am 2013-08-19 13:53, schrieb Henri Verbeet: That's actually a bug in what I posted. What's your suggested fix? Allocating size + align + alignment, and adding alignment to mem if mem happens to be already aligned? I

re: open bugs / multi thread / recommendation on new system

2013-08-19 Thread Dan Kegel
Damian wrote: 1) ATI or nVidia for new GPU? Does SLI/Crossfire work with wine? Don't know. I just use nvidia cards I find in the trash :-) But then I don't actually play games, so I don't care about 3d performance. 2) FX 8320 or intel same price class CPU? As the AMD has far inferior single

Re: [PATCH 10/11] widl: Set pointer_size according to host's pointer-size.

2013-08-19 Thread Kai Tietz
2013/8/19 Alexandre Julliard julli...@winehq.org: Kai Tietz ktiet...@googlemail.com writes: diff --git a/tools/widl/widl.c b/tools/widl/widl.c index 5df99fc..6d8ec87 100644 --- a/tools/widl/widl.c +++ b/tools/widl/widl.c @@ -139,7 +139,7 @@ int line_number = 1; static FILE *idfile;

Re: [PATCH 10/11] widl: Set pointer_size according to host's pointer-size.

2013-08-19 Thread Alexandre Julliard
Kai Tietz ktiet...@googlemail.com writes: 2013/8/19 Alexandre Julliard julli...@winehq.org: Kai Tietz ktiet...@googlemail.com writes: diff --git a/tools/widl/widl.c b/tools/widl/widl.c index 5df99fc..6d8ec87 100644 --- a/tools/widl/widl.c +++ b/tools/widl/widl.c @@ -139,7 +139,7 @@ int

Re: [PATCH 10/11] widl: Set pointer_size according to host's pointer-size.

2013-08-19 Thread Kai Tietz
2013/8/19 Alexandre Julliard julli...@winehq.org: Kai Tietz ktiet...@googlemail.com writes: 2013/8/19 Alexandre Julliard julli...@winehq.org: Kai Tietz ktiet...@googlemail.com writes: diff --git a/tools/widl/widl.c b/tools/widl/widl.c index 5df99fc..6d8ec87 100644 --- a/tools/widl/widl.c

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-19 14:34, schrieb Henri Verbeet: On 19 August 2013 14:20, Stefan Dösinger stefandoesin...@gmail.com wrote: Am 2013-08-19 13:53, schrieb Henri Verbeet: That's actually a bug in what I posted. What's your suggested fix? Allocating size +

Re: [PATCH 2/5] wined3d: Wrap resource-heapMemory into a structure

2013-08-19 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-19 17:08, schrieb Stefan Dösinger: I'm not entirely sure about the SIZE_T align = RESOURCE_ALIGNMENT - 1 + sizeof(*p); line though. Msvcrt doesn't have the - 1, and allocating size + RESOURCE_ALIGNMENT bytes might be enough. msvcrt

Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-19 Thread Hin-Tak Leung
-- On Sat, Aug 17, 2013 09:02 BST Frédéric Delanoy wrote: On Sat, Aug 17, 2013 at 5:57 AM, xulixin xulixin1...@gmail.com wrote: Should I change my name's spelling to Lixin Xu, or LiXin Xu, or other format? Not sure, most people (at least non-Chinese) use firstname

Re: Could you update/rerun that report on bugs without AppDB links?

2013-08-19 Thread André Hentschel
Am 19.08.2013 01:57, schrieb Dan Kegel: I don't seem to have saved the (crappy) script. There is something similar at https://code.google.com/p/winezeug/source/browse/#svn%2Ftrunk%2Fappdb-mashup and it wouldn't be too hard to whip something up again for somebody who is motivated. Please