Re: [1/2] ntdll: Properly handle 0-length reads.

Marvin wrote: > === wxppro (32 bit comm) === > comm.c:863: Test failed: WaitCommEvent failed with a timeout > comm.c:875: recovering after WAIT_TIMEOUT... > comm.c:886: Test failed: WaitCommEvent error 0 > comm.c:888: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 > comm.c:892: WaitCommEv

Re: [1/2] ntdll: Properly handle 0-length reads.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2127 Your paranoid andr

Re: [PATCH 3/6] user32: Export WINPOS_GetMinMaxInfo() as __wine_get_min_max_info() so it can be called by drivers.

Ken Thomases wrote: > +@ cdecl __wine_get_min_max_info(long ptr ptr ptr ptr) WINPOS_GetMinMaxInfo What's wrong with calling SendMessage(WM_GETMINMAXINFO) from the driver? -- Dmitry.

Re: ws2_32/tests: Add more WSASocket tests

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2126 Your paranoid andr

Re: [try3] gdi32: abc values remain the same despite any changes in layout direction or Viewport

Alexandre, Do you want me to rewrite this patch with your new width_to_LP helper function or are you going to do that rewrite yourself? (assuming it is acceptable in other ways) thanks! -aric

Re: kernel32/tests: Add tests for ResolveDelayLoadedAPI (try3)

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2121 Your paranoid andr

Re: ws2_32: Fix WSADuplicateSocket implementation

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2119 Your paranoid andr

Re: wininet: Don't assume that end of chunk means end of stream.

On 09/11/13 17:32, Hans Leidekker wrote: > On Wed, 2013-09-11 at 16:38 +0200, Jacek Caban wrote: >> Hi Hans, >> >> On 09/11/13 13:50, Hans Leidekker wrote: >>> static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t >>> *req) >>> { >>> -/* Allow reading only from read buffe

Re: wininet: Don't assume that end of chunk means end of stream.

On Wed, 2013-09-11 at 17:53 +0200, Jacek Caban wrote: > > Network traces tell me that native also performs a read on the first call to > > InternetQueryDataAvailable. > > Are you sure it's not an asynchronous read from a separated thread that > is ordered by InternetQueryDataAvailable if no data is

Re: RFC: HKCR merge implementation

Am 11.09.2013 01:15, schrieb Juan Lang: > Hi George, > > On Tue, Sep 10, 2013 at 3:55 PM, George Stephanos > wrote: > > I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. > Feel free to comment. > So far, I've written code for all funct

Re: [PATCH 4/5] ddraw: Avoid LPVOID.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-11 19:05, schrieb Marvin: > === wxppro (32 bit d3d) === d3d.c:1260: Test failed: Homogeneous > output was generated despite UNCLIPPED flag Fyi, I am seeing those on my Windows machines as well. No idea why it suddenly started popping up on t

Re: wininet: Don't assume that end of chunk means end of stream.

On 9/11/13 7:09 PM, Hans Leidekker wrote: On Wed, 2013-09-11 at 17:53 +0200, Jacek Caban wrote: Network traces tell me that native also performs a read on the first call to InternetQueryDataAvailable. Are you sure it's not an asynchronous read from a separated thread that is ordered by Internet

Re: [PATCH 4/5] ddraw: Avoid LPVOID.

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2112 Your paranoid andr

Re: wininet: Don't assume that end of chunk means end of stream.

On Wed, 2013-09-11 at 16:38 +0200, Jacek Caban wrote: > Hi Hans, > > On 09/11/13 13:50, Hans Leidekker wrote: > > static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t > > *req) > > { > > -/* Allow reading only from read buffer */ > > +chunked_stream_t *chunked_strea

Re: wininet: Don't assume that end of chunk means end of stream.

Hi Hans, On 09/11/13 13:50, Hans Leidekker wrote: > static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t > *req) > { > -/* Allow reading only from read buffer */ > +chunked_stream_t *chunked_stream = (chunked_stream_t*)stream; > +DWORD res; > + > +if(!chunke

Re: [PATCH 2/2] d3d11.idl: Added some missing declarations.

On 09/11/13 14:22, Michael Stefaniuc wrote: > On 09/11/2013 02:11 PM, Henri Verbeet wrote: >> On 11 September 2013 12:09, Jacek Caban wrote: >>> +typedef enum D3D11_RESOURCE_MISC_FLAG >>> +{ >>> +D3D11_RESOURCE_MISC_GENERATE_MIPS= 0x0001, >>> +D3D11_RESOURCE_MISC_SH

riched20/tests: Add tests for ITextDocument_Save. (try 2)

Update: Add todo_wine From 8f464b1ffa384ffba25af5041065c23d21ede041 Mon Sep 17 00:00:00 2001 From: Jactry Zeng Date: Wed, 11 Sep 2013 18:06:02 +0800 Subject: riched20/tests: Add tests for ITextDocument_Save. To: wine-patches Reply-To: wine-devel --- dlls/riched20/tests/richole.c | 102 +++

Re: [PATCH 2/2] d3d11.idl: Added some missing declarations.

On 09/11/2013 02:11 PM, Henri Verbeet wrote: On 11 September 2013 12:09, Jacek Caban wrote: +typedef enum D3D11_RESOURCE_MISC_FLAG +{ +D3D11_RESOURCE_MISC_GENERATE_MIPS= 0x0001, +D3D11_RESOURCE_MISC_SHARED = 0x0002, +D3D11_RESOUR

Re: [PATCH 2/2] d3d11.idl: Added some missing declarations.

On 11 September 2013 12:09, Jacek Caban wrote: > +typedef enum D3D11_RESOURCE_MISC_FLAG > +{ > +D3D11_RESOURCE_MISC_GENERATE_MIPS= 0x0001, > +D3D11_RESOURCE_MISC_SHARED = 0x0002, > +D3D11_RESOURCE_MISC_TEXTURECUBE

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context.

On 11 September 2013 13:37, Stefan Dösinger wrote: > The next element is a BYTE. The 8 bits padding were stupid considering > that, it just generates a hole. Now I am removing one bit, which > leaves one bit of padding left. > It doesn't really work like that, the layout is like this: UINT (4) WO

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-11 13:32, schrieb Henri Verbeet:> On 11 September 2013 11:31, Stefan Dösinger wrote: >> @@ -1880,9 +1888,8 @@ struct wined3d_device WORD d3d_initialized >> : 1; WORD inScene : 1; /* A flag to check for proper BeginScene /

Re: [PATCH 5/5] wined3d: Explicitly pass the state information to buffer_internal_preload

On 11 September 2013 11:31, Stefan Dösinger wrote: > -/* Reading the declaration makes only sense if the stateblock is > finalized and the buffer bound to a stream */ > -if (device->isInDraw && buffer->resource.bind_count > 0) > +/* Reading the declaration makes only sense if we have

Re: [PATCH 3/5] wined3d: Pass stream info and needed fixups to buffer_find_decl.

On 11 September 2013 11:31, Stefan Dösinger wrote: > @@ -330,7 +331,7 @@ static BOOL buffer_find_decl(struct wined3d_buffer *This) > if(This->resource.usage & WINED3DUSAGE_STATICDECL) return FALSE; > } > > -if (use_vs(state)) > +if (fixup_flags & WINED3D_BUFFER_FIXUP_USE_SHAD

Re: [PATCH 4/5] wined3d: Move the decoded stream info into the context.

On 11 September 2013 11:31, Stefan Dösinger wrote: > @@ -1880,9 +1888,8 @@ struct wined3d_device > WORD d3d_initialized : 1; > WORD inScene : 1; /* A flag to check for proper > BeginScene / EndScene call pairs */ > WORD softwareVertexProcessing : 1; /* process ve

Re: (resend) gdi32: abc values remain the same despite any changes in layout direction or Viewport

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2103 Your paranoid andr

Re: po: Add English (Philippines) resource (resend)

Ken Sharp writes: > @@ -111,6 +111,9 @@ filter: dummy > .svg.bmp: > CONVERT="$(CONVERT)" ICOTOOL="$(ICOTOOL)" RSVG="$(RSVG)" $(BUILDIMAGE) > $< $@ > > +$(top_srcdir)/po/en_PH.po: $(top_srcdir)/po/en_US.po > + $(LN_S) -f en_US.po $@ > + You can't create links in the source tree, and