Re: riched20: Set control content in WM_CREATE message

2013-10-08 Thread Akihiro Sagawa
len++; > + } Although this patch has been committed as e660bf676c111ce20d9e868280094f1c5bb81c79, I doubt that it works properly. Did you mean '\0' or 0? Regards, Akihiro Sagawa

Re: [5/9] gdiplus: Fix empty glyph handling.

2013-09-17 Thread Akihiro Sagawa
mask after that character. So, I just ignore the error and > > continue at that point. > > I think a comment saying just /* empty glyph */ inside the if blocks > for these new cases would make the code much clearer. Indeed. I'll add some comments in the next try. Akihiro Sagawa

Re: [5/9] gdiplus: Fix empty glyph handling.

2013-09-15 Thread Akihiro Sagawa
&gm, bufsize, buf, ...) case. Please note that bufsize and buf are specified and guess they aren't null. The second loop is for creating mask bitmaps. We don't need to update bitmaps if the character is empty. However, we also need to update the bitmap mask after that character. So, I just ignore the error and continue at that point. Akihiro Sagawa

Re: patch:try 2 of adding wine ja mannual

2013-08-29 Thread Akihiro Sagawa
q.org/git/wine.git/blobdiff/wine-1.4..wine-1.6:/loader/wine.man.in I noticed that you added Japanese specific section -- 文字化けについて -- to the man page. I'm not sure about this because other translators didn't do like this and it is difficult to keep up-to-date language specific information. Regards, Akihiro Sagawa

Re: [patch fix]for 98152 and 98151,the encoding type was wrong.

2013-08-26 Thread Akihiro Sagawa
ile seems to be based on wine 1.4 release. Makefile.in has a lot of formatting errors. You'd also refine it before resubmitting. Regards, Akihiro Sagawa

Re: RFC: Three dots or Unicode ellipsis character

2013-07-03 Thread Akihiro Sagawa
anese Industrial Standard, JIS X 0208. JIS X 0208 defines 3-dot leader character. As its example glyph is three middle dots, most font vendors designed the glyph like that. In Unicode conversion, the character is mapped into U+2026. Thus, its glyph is not like ellipsis. Regards, Akihiro Sagawa

Re: po: Revert Japanese shell path name updates.

2013-07-03 Thread Akihiro Sagawa
On Wed, 03 Jul 2013 16:23:11 +0200, Alexandre Julliard wrote: > Akihiro Sagawa writes: > > As I mention in the last mail[2], patch 91758[3] has some issues, > > especially when retrieving shell path names. Although path names are not > > localized in Japanese Windows Vist

po: Revert Japanese shell path name updates.

2013-07-03 Thread Akihiro Sagawa
http://bugs.winehq.org\n"; "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2013-07-02 23:19+0900\n" -"Last-Translator: Akira Nakagawa \n" +"PO-Revision-Date: 2013-07-03 19:21+0900\n" +"Last-Translator: Akihiro Sagawa \n" "Language-Team

Re: [patch]update po/ja.po for wine ver.1.6-rc4

2013-06-30 Thread Akihiro Sagawa
gid "Pictures" > -msgstr "" > +msgstr "ピクチャ" > > #: shell32.rc:220 > msgid "Videos" > -msgstr "" > +msgstr "ビデオ" > > #: shell32.rc:213 > msgid "Program Files (x86)" > @@ -7991,19 +7994,19 @@ msgstr "Program Files (x86)" > > #: shell32.rc:221 > msgid "Contacts" > -msgstr "" > +msgstr "連絡先" > > #: shell32.rc:222 winefile.rc:110 > msgid "Links" > -msgstr "" > +msgstr "リンク" > > #: shell32.rc:223 > msgid "Slide Shows" > -msgstr "" > +msgstr "スライドショー" > > #: shell32.rc:224 > msgid "Playlists" > -msgstr "" > +msgstr "プレイリスト" > > #: shell32.rc:148 taskmgr.rc:326 > msgid "Status" > @@ -8019,35 +8022,35 @@ msgstr "機種名" > > #: shell32.rc:225 > msgid "Sample Music" > -msgstr "" > +msgstr "サンプルミュージック" > > #: shell32.rc:226 > msgid "Sample Pictures" > -msgstr "" > +msgstr "サンプルピクチャ" > > #: shell32.rc:227 > msgid "Sample Playlists" > -msgstr "" > +msgstr "サンプルプレイリスト" > > #: shell32.rc:228 > msgid "Sample Videos" > -msgstr "" > +msgstr "サンプルビデオ" > > #: shell32.rc:229 > msgid "Saved Games" > -msgstr "" > +msgstr "保存済みのゲーム" > > #: shell32.rc:230 > msgid "Searches" > -msgstr "" > +msgstr "検索" > > #: shell32.rc:231 > msgid "Users" > -msgstr "" > +msgstr "ユーザー" > > #: shell32.rc:233 > msgid "Downloads" > -msgstr "" > +msgstr "ダウンロード" > --- > #: netstat.rc:28 > msgid "Proto" > -msgstr "" > +msgstr "合意" Proto means protocol, but there is no enough space to display it. > #: oleview.rc:138 > msgid "Registry" > -msgstr "" > +msgstr "レジストリ" Oleview has a small issue. When I try this translation before, it can't display well if this message is Japanese. So, please verify that these messages are shown properly in the application. > #: oleview.rc:139 > msgid "Implementation" > -msgstr "" > +msgstr "実装" ditto. > #: oleview.rc:140 > msgid "Activation" > -msgstr "" > +msgstr "発動" ditto. > #: winefile.rc:109 > msgid "Index/Inode" > -msgstr "" > +msgstr "索引・Iノード" Although easily guess it, Iノード is not widely used. iノード might be preferred but more common term is "inode". inode (as Japanese technical term) is used in Wikipedia[1], Linux Japanese Manual (debugfs [2]), WDIC[3]. [1] http://ja.wikipedia.org/wiki/Inode [2] http://linuxjm.sourceforge.jp/html/e2fsprogs/man8/debugfs.8.html [3] http://www.wdic.org/w/TECH/inode Contact me for any questions. Regards, Akihiro Sagawa

Re: [PATCH 1/6] fonts: Add default glyph to Tahoma.

2013-05-16 Thread Akihiro Sagawa
> We already have .notdef, we shouldn't need a second one. Thank you for pointing out this. I withdraw patch #1 and #2. Could you consider to commit #3 and a later series of patches? Regards, Akihiro Sagawa

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-04 Thread Akihiro Sagawa
ffect another applications, and conformance tests show that there is upper bound for lfHeight in Windows. Therefore I implement upperbounds test in advance. Regards, Akihiro Sagawa

Re: [PATCH 1/3] msvcrt: Added _mbsncoll and _mbsncoll_l implementation.

2013-04-19 Thread Akihiro Sagawa
perly handle this situation, or add FIXME message based on multibyte code page if your application just needs this function. Regards, Akihiro Sagawa

Re: [PATCH 2/2] msvcrt: Fixed fgetwc behavior on multibyte characters and unicode files

2013-03-20 Thread Akihiro Sagawa
CRT_isleadbyte(mbs[0])) { This doesn't work correctly if char is signed. Because _isleadbyte() expects the value of unsigned char or EOF as well as other is- functions. I wrote some fgetwc() tests. Please refer following page: https://testbot.winehq.org/JobDetails.pl?Key=24806 Akihiro Sagawa

Re: gdi32: Fix the GdiGetCodePage() support ANSI_CHARSET font associated charset

2013-02-26 Thread Akihiro Sagawa
when codepages changed, not logpixels. When > logpixels has been changed, MS-Windows does not update the font associated > charset registry. "memset(buf, 0, sizeof(buf))" has been added. Good work. I got it. Including other changes, it looks good for me. Please send your patch to wine-patches. Akihiro Sagawa

Re: gdi32: Fix the GdiGetCodePage() support ANSI_CHARSET font associated charset

2013-02-25 Thread Akihiro Sagawa
cp); > + > +/* update locale dependent font association info in registry */ > + if (strcmp(buf, cpbuf)) > +update_font_association_info(ansi_cp); > } > > static BOOL init_freetype(void) This condition should be rewritten. buf is not initialized when RegQueryValueExA is failed in line 3542. And strcmp(buf, cpbuf) has already done in line 3544. > diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c > index 943f584..9d57806 100644 > --- a/dlls/gdi32/tests/font.c > +++ b/dlls/gdi32/tests/font.c Why are there no tests against OEM_CHARSET and SYMBOL_CHARSET? Regards, Akihiro Sagawa

Re: gdi32: Fix the GdiGetCodePage() support ANSI_CHARSET font associated charset.

2013-02-22 Thread Akihiro Sagawa
> "System\\CurrentControlSet\\Control\\FontAssoc\\Associated Charset", As far as I know, in SBCS locale, this key doesn't exist. Therefore it should delete in SBCS locale initialization and create the key in DBCS locale initialization. Regards, Akihiro Sagawa

Re: Failing tests in the Japanese and Hebrew languages

2013-02-20 Thread Akihiro Sagawa
ale or ANSI codepage as you observe. If I find another issue related locales, I'll send a patch or file a bug. Akihiro Sagawa

Re: Failing tests in the Japanese and Hebrew languages

2013-02-18 Thread Akihiro Sagawa
;, StartupTitle, TRUE, DDE_TEST_SHOWGROUP|testnum++); Ditto. There is ANSI conversion error, too. I guess "?" is localized startup folder name that didn't convert into Windows 1252 characters. This test also succeeded on my PC. Regards, Akihiro Sagawa

Re: [PATCH] gdi32: Adjust a fixed-pitch full-width character has double advance of a half-width character. (try 5)

2013-01-25 Thread Akihiro Sagawa
d by font file (*.ttf) or FreeType bug. Because I had no test failures with IPAGothic on my environment (Ubuntu 12.04 with fonts-ipafont-gothic 00303-5). Regards, Akihiro Sagawa

Re: [PATCH 1/2] winmm/tests: Add more mmioSeek tests.

2012-11-08 Thread Akihiro Sagawa
nother issue in mmioSeek. If mmioSeek patches are accepted, I'm sending some patches to fix bug 19566. The patch is now proposal stage [1]. [1] http://bugs.winehq.org/show_bug.cgi?id=19566#c12 Regards, Akihiro Sagawa

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)

2012-06-19 Thread Akihiro Sagawa
On Tue, 19 Jun 2012 23:40:33 +0900, Dmitry Timoshkov wrote: > Akihiro Sagawa wrote: > > > Please ignore these patches. They were sent over 48 hours ago. It seems > > there is a huge delay between Gmail and wine-patches. > > If you are not subscribed to wine-patches

Re: [PATCH 1/3] gdi32/tests: Make GetStockObject tests pass on East-Asian machines. (try 2)

2012-06-19 Thread Akihiro Sagawa
ter a while, my modified version was delivered and tested although they have already been applied. * ... http://www.winehq.org/pipermail/wine-devel/2012-June/095956.html Akihiro Sagawa

Re: translation: meaning of 'magazine' in winerror string

2012-03-06 Thread Akihiro Sagawa
s error or message on native Windows PC. This document may help you to understand the concept of magazine: http://www.epicycle.org.uk/pioneercd/User%20Guide.pdf#page=29 linked from http://www.epicycle.org.uk/pioneercd/pioneer.htm Akihiro Sagawa

Re: po: Remove extraneous full stops from the Japanese translation.

2012-01-24 Thread Akihiro Sagawa
d for the error message. So a Japanese Wine user might feel something wrong with the message if I translate without full-stops. Best regards, Akihiro Sagawa

RFC: wined3d: Let GetRasterStatus return D3D_OK, again.

2012-01-14 Thread Akihiro Sagawa
problem reports about my patch. [1] http://bugs.winehq.org/show_bug.cgi?id=26917 [2] http://bugs.winehq.org/show_bug.cgi?id=23556 -- Akihiro Sagawa raster_status.patch Description: Binary data

Re: wineconsole: Remove the character-width check as we need newer FreeType library.

2011-12-15 Thread Akihiro Sagawa
it doesn't occur in ASCII characters. And it is better than showing the error message, "Couldn't find a decent font, aborting," at starting up. -- Akihiro Sagawa <>

Re: [PATCH 1/2] gdi32: Add a string table resource for the translation.

2011-10-18 Thread Akihiro Sagawa
On Tue, 18 Oct 2011 16:14:36 +0200, Alexandre Julliard wrote: > Akihiro Sagawa writes: > > > @@ -1,7 +1,7 @@ > > EXTRADEFS = -D_GDI32_ > > MODULE= gdi32.dll > > IMPORTLIB = gdi32 > > -IMPORTS = advapi32 > > +IMPORTS = advapi32 user32 >

Various locale tests for wine

2011-06-07 Thread Akihiro Sagawa
XP bots. So how about adding non-English wine environments to the testbot farm? -- Best Regards, Akihiro Sagawa

Re: Translating a same message used in different contexts

2011-01-21 Thread Akihiro Sagawa
ated' too. > > The prefix is actually #msgctxt#, but yes that's how it works, it's > already used in a couple of places. Thank you for your advice. This is what I want to know. I'll update the PO files with #msgctxt# to distinguish a desktop directory name from a displyed one. And continue tranlating ja.po file. Akihiro Sagawa

Re: Translating a same message used in different contexts

2011-01-20 Thread Akihiro Sagawa
ge), are there no differences between directory name and display name, especially in Vista? Akihiro Sagawa

Translating a same message used in different contexts

2011-01-19 Thread Akihiro Sagawa
and the latter was localized. However, in the po file, they merged into one! Therefore we need to distinguish above contexts somehow. But I'm afraid I don't familiar with gettext and wrc. Could someone please resolve this issue? Akihiro Sagawa