Hello.
You'll probably want to check out the appdb source code from git and
see where to add php pages that export data in xml/json or your
favorite data interface format. Then you and others can query the
appdb via a reasonably defined api. We've had a few other questions
about this issue so you
>>
>> I have found that many of the "useless" comments show up as good Google
>> searches when I'm looking up errors. This kind of behavior has been
>> incredibly useful in the past for figuring out what to do with a bug I've
>> encountered. Unfortunately, lately it's been much harder for me to u
On Mon, May 25, 2009 at 9:32 PM, Chris Morgan wrote:
> On Mon, May 25, 2009 at 10:49 AM, Alexandre Julliard
> wrote:
>> Zachary Goldberg writes:
>>
>>> On Mon, May 25, 2009 at 7:03 AM, Alexandre Julliard
>>> wrote:
>>>>
>>>> Writin
On Mon, May 25, 2009 at 10:49 AM, Alexandre Julliard
wrote:
> Zachary Goldberg writes:
>
>> On Mon, May 25, 2009 at 7:03 AM, Alexandre Julliard
>> wrote:
>>>
>>> Writing a DIB engine is not a fill-in-the-blanks exercise. A large part
>>> of the task is precisely to come up with a good design, v
On Fri, Mar 20, 2009 at 7:50 PM, Scott Ritchie wrote:
> For a while now I've been hoping someone would tackle a pet project of
> mine. It occurred to me that it would be a great summer of code project.
>
> Basically, I want a magic script that can convert a visual studio
> project file into a win
On Fri, Mar 20, 2009 at 10:21 PM, Ben Klein wrote:
> 2009/3/21 Pau Garcia i Quiles :
>> Hello,
>>
>> If you don't mind using CMake ( http://cmake.org ) instead of Scons,
>> here is a starting point:
>>
>> http://dgwarp.hd.free.fr/vcproj2cmake.rb
>>
>> On Sat, Mar 21, 2009 at 12:50 AM, Scott Ritchi
>
> Theres enough information from the discussion to begin moving forward
> with coding. Andrew Riedi and I thus far are the volunteers to begin
> digging in. If anybody else is interested in getting their hands
> dirty please do respond to this, and we'll work out how to get it
> done. I imagin
On Mon, Aug 25, 2008 at 2:46 PM, James Hawkins <[EMAIL PROTECTED]> wrote:
> On Mon, Aug 25, 2008 at 1:11 PM, Ken Thomases <[EMAIL PROTECTED]> wrote:
>> On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote:
>>
>>> "Dan Kegel" <[EMAIL PROTECTED]> writes:
>>>
On Mon, Aug 25, 2008 at 8:47 AM, Ale
On Thu, Jun 26, 2008 at 8:13 AM, Francois Gouget <[EMAIL PROTECTED]> wrote:
>
> I see that these patches have not yet been applied to the AppDB. Is
> there anything wrong with them?
>
> * [AppDB] Assorted spelling fixes.
> http://www.winehq.org/pipermail/wine-patches/2008-June/056192.html
>
> *
On Wed, Jun 4, 2008 at 11:56 AM, Alexander Nicolaysen Sørnes
<[EMAIL PROTECTED]> wrote:
> På Onsdag 04 juni 2008 , 17:37:15 skrev Chris Morgan:
>> On Wed, Jun 4, 2008 at 4:15 AM, Alexander Nicolaysen Sørnes
>>
>> <[EMAIL PROTECTED]> wrote:
>> > På Onsdag
On Wed, Jun 4, 2008 at 4:15 AM, Alexander Nicolaysen Sørnes
<[EMAIL PROTECTED]> wrote:
> På Onsdag 04 juni 2008 , 01:24:07 skrev Chris Morgan:
>> What new policy on dissidents? ;-)
>>
>> How does this patch enable admins to remove themselves? I'm afraid I
>> c
On Fri, May 16, 2008 at 7:39 PM, Scott Ritchie <[EMAIL PROTECTED]> wrote:
> On Ubuntu, doing something like apt-get build-dep wine will prevent
> those kind of user errors.
>
> Really we just need to improve the wiki page a bit rather than bother
> with extra work on make test.
>
> Thanks,
> Scott
> Regarding the design itself, the colored boxes remind me more of a
> children's party than a useful piece of software. If you want to add
> color to the page, it seems like there are other ways to do it without
> calling garish attention to the Wine logo.
>
Garish? ;-) I thought the top X e
On Tue, Apr 8, 2008 at 9:30 AM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> On Mon, Apr 7, 2008 at 11:40 PM, Scott Ritchie <[EMAIL PROTECTED]> wrote:
> > It's not that big a deal now, so long as the Hardy version (0.9.59
> > likely) stays around for a while ;)
>
> I think Chris was planning on remo
Hey John.
Looks like you've gotten the nice urls working, great job man. It will
be great to have this before 1.0 is shipped since it will make our
urls a lot nicer looking.
I had a few comments about the code changes. You don't follow the
variable naming convention of the appdb. We have some pre
On Sun, Apr 6, 2008 at 5:05 PM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> On Sun, Apr 6, 2008 at 1:49 PM, Chris Morgan <[EMAIL PROTECTED]> wrote:
> > > It seems reasonable to me to include the version bundled with gutsy,
> > > even if it's getting old, beca
On Sun, Apr 6, 2008 at 3:02 PM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> On Sun, Apr 6, 2008 at 11:56 AM, Chris Morgan <[EMAIL PROTECTED]> wrote:
> > The appdb code currently prunes the list to several of the most recent
> > versions so people don't submit e
The appdb code currently prunes the list to several of the most recent
versions so people don't submit entries against older or obsolete
versions.
Is it really useful to have test results submitted such an old version
when we almost always ask users to upgrade to the latest version in
the #winehq
thanks for the feedback, i'm new to this so it's very much appreciated -
helped a lot.
I've updated the patch which hopefully covers the issues raised, but
wanted to ask about the returning of an error:
> w.r.t. the implementation:
> * ChangeDisplaySettings returns a long
> (http://msdn2.micr
On Wed, Mar 19, 2008 at 12:12 PM, John Klehm <[EMAIL PROTECTED]> wrote:
> On Wed, Mar 19, 2008 at 10:55 AM, Chris Morgan <[EMAIL PROTECTED]> wrote:
> > I can provide help with integrating the code with the appdb if you
> > have any questions. The real question I&#
e:
> On Wed, Mar 19, 2008 at 11:55 AM, Chris Morgan <[EMAIL PROTECTED]> wrote:
> > I can provide help with integrating the code with the appdb if you
> > have any questions. The real question I've got, since I haven't done
> > it befor
I can provide help with integrating the code with the appdb if you
have any questions. The real question I've got, since I haven't done
it before, is how to get the path the user specified, eg.
appdb.winehq.org/vendor/adobe (or whatever), into a php script so we
can redirect to the list of applicat
On Wed, Feb 20, 2008 at 8:36 PM, Francois Gouget <[EMAIL PROTECTED]> wrote:
>
> On Wed, 20 Feb 2008, Jeff Zaroyko wrote:
>
> > The default colours for warnings and notes on the appdb pages feel
> > rather strong, this patch changes the red and blue to be a bit softer.
> >
> > I think this makes
In include/query.php in query_appdb() we only call mysql_connect() if
the global $hAppdbLink isn't a valid resource. So, when a user
connects to display a page the first query should open the connection
and upon completion of the script $hAppdbLink will be freed and the
connection should be closed.
> And thanks Alky, why not help wine? ;)
>
Ahh, the question we've been asking since the Alky project was started :-)
Chris
i'd argue that this means we need to be smarter about how we process
the test results. We need both a confidence and a rating and some way
to reflect this in the results.
Your other point about configuration, if users have problems with
configuration then while it may be their fault its not really
I think I'm ok with the gpl/agpl v3 change. Are there any other people
using the appdb code that this might affect?
Chris
On Nov 23, 2007 10:34 PM, Alexander Nicolaysen Sørnes
<[EMAIL PROTECTED]> wrote:
> On Saturday 24 November 2007 04:01:24 Trent Waddington wrote:
> > interesting. Do you hav
On 11/5/07, Kai Blin <[EMAIL PROTECTED]> wrote:
> On Monday 05 November 2007 06:12:42 Chris Morgan wrote:
>
> > I agree that this isn't something that should continue. Kicking should
> > be reserved for people being disruptive. There is no reason to be
> >
On 11/4/07, feba thatl <[EMAIL PROTECTED]> wrote:
> Sorry if this mailing list is less than appropriate, but from what
> I've seen this is where the conversation was last time, and there
> doesn't seem to be much better.
>
> A while ago (Probably one-three months), I went to #winehq to ask
> about
Can you attach the patch instead of including it inline?
Also, can you provide an example of what is broken and why wrapping
things with is going to fix it.
Chris
On 10/10/07, Tony Lambregts <[EMAIL PROTECTED]> wrote:
> Change log: Get additional comments in test results to display properly
>
> >>
> >> The right way is to use XInput, and work with the X.org guys to fix
> >> what's necessary to make it work for our needs.
> >>
> > I don't see how will that solve (c,d,f,g)? Also how long should we wait on
> > that? Year? 5 years? I looked at the current Xorg source and it still
> > explic
This has happened in the past a handful of times. I suspect that our
own code is taking the server down via retries. I'm thinking we should
detect a too many connections error and cause the client to wait for a
period of time before retrying. I'm not sure how best to do this or if
this really is th
Yes, please file a bug report, http://bugs.winehq.org
Chris
On 9/15/07, Willi Mann <[EMAIL PROTECTED]> wrote:
>
> > Please let me know if I can do anything to help fixing this bug.
>
> As nobody answered so far, should I file a bug report?
>
> Willi
>
> Plase CC: me on replies.
>
>
>
>
Excellent news. Thanks Jeremy.
Chris
On 9/12/07, Jeremy Newman <[EMAIL PROTECTED]> wrote:
> OK, the server is back online. There still may be small outages for the
> next few days as I tweak config files and such.
>
> For the web developers (appdb guys), WineHQ.org is now using:
>
> PHP 5.2
> m
> Rewriting:
>
> We can conclude that VM was distracted first by the mention of the ies4lin and
> second by attempts to attribute the problem to ies4lin, and that, because of
> these distractions, he was unable to assess properly the issue at hand. One
> also concludes that VM over-relied on the fe
On 8/2/07, Kuba Ober <[EMAIL PROTECTED]> wrote:
> On Wednesday 01 August 2007, Vitaliy Margolen wrote:
> > Whit Blauvelt wrote:
> > > Hi,
> > >
> > > Is there a formal process for reviewing an arguably incompetent bugzilla
> > > staffer? Obviously it wouldn't be to submit their name as a bug. But i
You'll want to clear out your cookies. The site was forwarded to the
codeweavers site and that added a cookie that doesn't match with the
appdb cookie format. I've added a note to the error message.
Chris
On 7/5/07, Stefan Leichter <[EMAIL PROTECTED]> wrote:
Hello,
is anyone else getting the
On 7/2/07, Tom Wickline <[EMAIL PROTECTED]> wrote:
On 7/1/07, Jeremy Newman <[EMAIL PROTECTED]> wrote:
> Alexander Nicolaysen Sørnes wrote:
> > Currently the Screenshots link on the WineHQ site points to a page with 9
> > screenshots and some links, while there are 3992 screenshots in the AppDB.
On 6/29/07, Ben Hodgetts <[EMAIL PROTECTED]> wrote:
Chris Morgan wrote:
> On 6/29/07, Chris Morgan <[EMAIL PROTECTED]> wrote:
>> On 6/29/07, Jesse Allen <[EMAIL PROTECTED]> wrote:
>> > On 6/29/07, Louis Lenders <[EMAIL PROTECTED]> wrote:
>>
On 6/29/07, Chris Morgan <[EMAIL PROTECTED]> wrote:
On 6/29/07, Jesse Allen <[EMAIL PROTECTED]> wrote:
> On 6/29/07, Louis Lenders <[EMAIL PROTECTED]> wrote:
> >
> > Yeah, so maybe we could add a list of "Common failures" to the documention,
> >
On 6/29/07, Jesse Allen <[EMAIL PROTECTED]> wrote:
On 6/29/07, Louis Lenders <[EMAIL PROTECTED]> wrote:
>
> Yeah, so maybe we could add a list of "Common failures" to the documention,
> with the solution. I can live with that. Then we could point garbage test
> submitters to that page. That woul
On 6/29/07, Louis Lenders <[EMAIL PROTECTED]> wrote:
Chris Morgan gmail.com> writes:
>
> How do you normally judge if the result is valid or not? What if the
> result says that everything works?
Basically i'm only talking about garbage test results. If the app is
g
On 6/28/07, Louis Lenders <[EMAIL PROTECTED]> wrote:
Ben Hodgetts (Enverex atomnet.co.uk> writes:
>
> Me and Chris Morgan changed it to this because we were sick of people
> pasting pages and pages of terminal output into the What works or What
> doesn't work boxes
On 6/18/07, Alex Waite <[EMAIL PROTECTED]> wrote:
Alexander Nicolaysen Sørnes wrote:
> This should make it easier for people to notice the menu options. From 10px
> to 11px.
>
>
> Regards,
>
> Alexander N. Sørnes
>
>
>
>
>
Also, there are no changes to tests that show that the uninstaller
changes are adding/correcting behavior so it matches windows. Unit
tests would make the change more compelling.
Chris
On 6/14/07, Misha Koshelev <[EMAIL PROTECTED]> wrote:
First of all, of course I am not Alexandre.
But I hav
Indeed they would. Only I would say picasa to steam ratio would be
1-to-100. And btw only most rudimentary things work in both! Steam
worked _perfectly_ before. And I'm sure would still worked. But now, you
can't buy stuff, you can't open screen-shots (because they are popups)
you don't see MOTO w
Yep, that account was created by the person who was deleting things
from the appdb.
As of right now the appdb site is back online, the account we suspect
was used to delete the data has been removed, the 'roop' account isn't
present and most everything appears to be back, except the screenshots
t
(*) Alexandre, if you want to freeze now its ok with me :-) The current d3d
code is feature rich enough for 1.0 IMHO, but of course I'll try to get the
fundamentals of more in :-)
On that topic, I'd like as much advance notice of a 1.0 release as
possible, I'll even swear to silence if a date is
Opinions contained in this e-mail do not necessarily reflect
the opinions of the Queensland Department of Main Roads,
Queensland Transport or Maritime Safety Queensland, or
endorsed organisations utilising the same infrastructure.
If you
On 4/4/07, Maarten Lankhorst <[EMAIL PROTECTED]> wrote:
As far as I can tell, it has been disabled for at least 4 months, and I didn't
hear anyone about it, so it seems like a good idea to remove winearts, if
anybody feels like reviving it, it would be easy to do so by reversing this
commit, b
There are a lot of emails from the appdb that have your name in it.
Some things may be queued, others may have been rejected but in any
case if there were any changes to the submitted items you'll get an
email about it.
Chris
On 3/18/07, Dan Kegel <[EMAIL PROTECTED]> wrote:
I tried submitting
On 3/10/07, Felix Nawothnig <[EMAIL PROTECTED]> wrote:
Chris Morgan wrote:
> What would the purpose of having untested applications in the appdb
> be? Users would search for the app and find that it shows up but then
> find that it doens't work.
At which point the applicat
What would the purpose of having untested applications in the appdb
be? Users would search for the app and find that it shows up but then
find that it doens't work. I'd prefer we simply left out untested
applications to keep the signal-to-noise ratio high.
Chris
On 3/10/07, Dan Kegel <[EMAIL P
On 3/5/07, Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> wrote:
Mandag 05 mars 2007 03:27, skrev Nick Law:
> Tony Lambregts wrote:
> > Nick Law wrote:
> >> I still find appdb really slow 60 seconds to view some pages, post on
> >> the forums etc It's driving me nuts to the point I've gone b
Are particular pages slow? I'm not seeing slow page loads to the main
page or to an application version page from here, a few seconds for
each.
Chris
On 2/11/07, Tony Lambregts <[EMAIL PROTECTED]> wrote:
Nick Law wrote:
> Hi Tony,
> Just lately, I've noticed that AppDB seems to be very slow,
On Monday 08 January 2007 2:48 pm, Tony Lambregts wrote:
> On 1/4/07, Chris Morgan <[EMAIL PROTECTED]> wrote:
> > On Thursday 04 January 2007 7:55 pm, Tony Lambregts wrote:
> > > This patch breaks xinha editing...
> > >
> > > --
> > >
> &
On Saturday 06 January 2007 12:56 pm, Tony Lambregts wrote:
> http://appdb.winehq.org/admin/adminAppDataQueue.php?iId=5572
Should be all set. It was a mistaken rename from 'type' to 'TYPE' for a column
name in the appData table. I've renamed it back.
Chris
editVendor.php moveAppVersion.php
> > help : index.php
> > include: application.php bugs.php comment.php
> > distribution.php filter.php form_edit.php
> > form_login.php form_new.php incl.php note.ph
.php incl.php note.php
>screenshot.php sidebar.php testData.php url.php
>util.php version.php vote.php
>
> Log message:
> Chris Morgan <[EMAIL PROTECTED]>
> Fix and enable input filtering through include/filter.php
>
> Patch:
I've updated the Application Database todo and sorted the list
according to each item's difficulty. You can find the todo list at
http://wiki.winehq.org/AppdbInfo This list is by no means complete
so if you have an idea for a new entry feel free to email it to the
AppDB mailing list at [EMAIL PR
On 03 Jan 2007 22:46:31 +0200, Kari Hurtta <[EMAIL PROTECTED]> wrote:
"Chris Morgan" <[EMAIL PROTECTED]> writes in gmane.comp.emulators.wine.devel:
> On 03 Jan 2007 16:34:21 +0200, Kari Hurtta <[EMAIL PROTECTED]> wrote:
> > &quo
On 03 Jan 2007 16:34:21 +0200, Kari Hurtta <[EMAIL PROTECTED]> wrote:
"Dan Kegel" <[EMAIL PROTECTED]> writes in gmane.comp.emulators.wine.devel:
> The appdb says
> "Only applications which install and run flawlessly on an out-of-the-box
> Wine installation make it to the Platinum list"
Yes. Al
On 12/31/06, Dan Kegel <[EMAIL PROTECTED]> wrote:
The appdb says
"Only applications which install and run flawlessly on an out-of-the-box
Wine installation make it to the Platinum list"
But several platinum-rated apps seem to deserve
a silver or bronze rating.
For instance, Call to Duty,
http://
Is it ok if we link to this entry in the Wine documentation instead:
http://winehq.org/site/docs/wineusr-guide/config-wine-main#AEN282
Chris
On Friday 15 December 2006 12:27 pm, Alexander Nicolaysen Sørnes wrote:
> (I assume this was overlooked.)
>
> Add a paragraph about sound problems on the
track the last time the row was modified, etc.
Chris
On 12/13/06, Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> wrote:
Onsdag 13 desember 2006 19:14, skrev Chris Morgan:
> If you didn't receive an email about how you haven't logged in in a
> while then it isn't li
Have you recently submitted any new applications or versions? Have you
logged in to appdb within the last few months?
Chris
On 12/13/06, Aaron Slunt <[EMAIL PROTECTED]> wrote:
Alexander Nicolaysen Sørnes wrote:
> Hello,
>
> It seems like I have been removed from all the applications I was prev
On Wednesday 29 November 2006 1:58 pm, Alexander Nicolaysen Sørnes wrote:
> New and improved version.
>
>
> Regards,
>
> Alexander N. Sørnes
Looks a lot better.
+// Allow user to apply as super maintainer if this is a new app
+if(!$this->iAppId or $this->iAppId == "/")
+{
On Wednesday 29 November 2006 10:08 am, Alexander Nicolaysen Sørnes wrote:
> Allow the user to submit a maintainer request along with an application, by
> ticking a checkbox.
> If the application is accepted, the maintainer request is accepted as well;
> and if it is deleted or marked as a duplicat
On Sunday 26 November 2006 12:49 pm, Alexander Nicolaysen Sørnes wrote:
> Add basic rating logic checking, by asking the user to correct the error if
>
> - Installs? = No and the rating is Platinum
> - Runs? is not 'yes' and rating is not Garbage
>
>
> Regards,
>
> Alexander N. Sørnes
When the ero
On 11/22/06, Andreas Mohr <[EMAIL PROTECTED]> wrote:
Hi,
On Wed, Nov 22, 2006 at 11:53:22AM +0100, Mirek wrote:
> The aim is to prepare all apps below working under the Windows on Nvidia
> GF 6XXX series, with at least 50% of speed in WinXP. There is not needed
> sound after merging those patche
2. Alexandre documents the exact logic he uses to determine patch
acceptability which becomes the patch acceptance policy in the interim. This
should be done to the point that someone else could take over from Alexandre
and achieve the same result. This opens the way to multiple maintainers as
wel
On 9/27/06, Dan Kegel <[EMAIL PROTECTED]> wrote:
On 9/27/06, Chris Morgan <[EMAIL PROTECTED]> wrote:
> When test results were added Tony and myself talked about all kinds of
> interesting ways we could farm information from those results.
> [suggestion for two particular ki
On 9/27/06, Dan Kegel <[EMAIL PROTECTED]> wrote:
The appdb has a "browse by ratings" page, e.g. you can
see all apps that have at least one Gold-rated version at
http://appdb.winehq.org/browse_by_rating.php?sRating=Gold
This can serve as a kind of poor man's application regression finder;
look a
On 7/30/06, Alexander Nicolaysen Sørnes <[EMAIL PROTECTED]> wrote:
Søndag 30 juli 2006 18:49, skrev du :
> On Sunday 30 July 2006 7:45 am, Alexander Nicolaysen Sørnes wrote:
> > The patch is the same; I would just like to point out that this change
> > has been discusses, and there were no object
On Sunday 30 July 2006 7:45 am, Alexander Nicolaysen Sørnes wrote:
> The patch is the same; I would just like to point out that this change has
> been discusses, and there were no objections to it.
>
> Change 'vendor' to 'developer'. Variable names are not changed, so this
> patch should not cause
You'll want to make these functions static member functions of the version
class. Since we can't really mark them static with php4 that means just
putting them in the version class and making sure they don't refer to $this.
There should be other examples of this with calls to functions in the
This doesn't look right, we aren't setting any $sMsg or $sSubject in this
case.
Chris
On Saturday 29 July 2006 8:09 pm, Alexander Nicolaysen Sørnes wrote:
> If a user deletes a bug link he has submitted, don't send him an e-mail
> telling him it has been rejected.
>
>
> Regards,
>
> Alexander
> That is a good idea but that does not solve the problem with the fields
> in test results since we cannot and do not use include/filter.php
> because of problems with xinha variables. I do not see a problem with
> this patch going in but for now we need my patch as well.
No worries about Xinha.
Tony has an admin account I think.
Chris
On Thursday 13 July 2006 1:37 pm, James Hawkins wrote:
> Hey,
>
> Who has control over bugzilla accounts? I can't remember.
>
> Thanks,
> James Hawkins
On Saturday 08 July 2006 4:27 pm, Tony Lambregts wrote:
> This patch is meant to start a discussion more than anything else. We
> currently have no way of sorting test results in a reasonable order. If we
> sort by testedRating the order is not what we want. IE: Bronze, Garbage,
> Gold, Platinum an
On Thursday 06 July 2006 10:11 pm, Dan Kegel wrote:
> All the links in Google to the appdb are of the form
> http://appdb.winehq.org/appview.php?appId=86
> This no longer works. The new format appears to be
> http://appdb.winehq.org/appview.php?iAppId=86
> Can we change the appdb code to also acce
This is in progress.
I'll take care of it right now since its likely that many people are noticing
similar issues.
Chris
On Thursday 06 July 2006 10:11 pm, Dan Kegel wrote:
> All the links in Google to the appdb are of the form
> http://appdb.winehq.org/appview.php?appId=86
> This no longer w
Here is a patch that does all instances and removes compile_update_string() as
well.
Chris
On Monday 03 July 2006 10:52 pm, Tony Lambregts wrote:
> Chris Morgan wrote:
> > We'll want to remove ALL uses of compile_update_string() and
> > compile_insert_string(). I'l
We'll want to remove ALL uses of compile_update_string() and
compile_insert_string(). I'll take care of this since there are 9 or 10
other instances of it.
Chris
On Sunday 02 July 2006 5:08 pm, Tony Lambregts wrote:
> Chris Morgan wrote:
> > Is this the case when insertin
> So, the fix is quite simple, stop using compile_insert_string() and
> compile_update_string() and let query_parameters() do the work. This
> way we can be sure that we won't be inserting strings with special
> formatting characters into the format portion of the
> query_parameters() call.
>
> I
Is this the case when inserting data from a xinha editor into the
database? Is this being seen only in application related data?
Sorry for the time you've spent investigating this, it only took a
moment for me to realize what the problem was after knowing the
symptoms. I should have caught this
There are several issues that I've found so far in this patch.
It appears that you used a search and replace. You'll need to go through
EVERY line of the patch and undo the changes to things like sql queries and
others where the changes don't make sense.
At some point we can discuss altering t
Yeah, lets pass the parameters into this function so we can move it around and
reuse it without needing a global.
Chris
On Friday 30 June 2006 7:24 am, Jonathan Ernst wrote:
> Le jeudi 29 juin 2006 à 12:19 -0400, Chris Morgan a écrit :
> > Can we pass the parameters we need into the
Should be fixed now.
Chris
On Thursday 29 June 2006 2:53 pm, Tony Lambregts wrote:
> Viewing application famlies screen shots is broken. I don't think is from
> todays patches. You can see the problem in the following link.
>
> http://appdb.winehq.org/screenshots.php?appId=631
>
> The random scr
Oh ok. If you wanted you could put that on the TODO page so we didn't forget
about it.
Chris
On Thursday 29 June 2006 2:18 pm, Tony Lambregts wrote:
> > Are they supposed to be able to monitor application familes? I'm
> > confused as to whether that is a bug or just how things are working.
>
On Thursday 29 June 2006 1:51 pm, Tony Lambregts wrote:
> > This patch breaks the monitor notification emails.
>
> more specificly...
>
> > diff -u -p appdb/include/monitor.php:1.5 appdb/include/monitor.php:1.6
> > --- appdb/include/monitor.php:1.5 Thu Jun 29 17:43:08 2006
> > +++ appdb/include/m
Patch looks good and although it is large like you said it isn't something we
can do much about at this point.
It unfortunately doesn't apply cleanly against cvs head.
If you could submit all of the smaller cleanup patches ahead of big patches
like this that would be the best. Its more likely
Patch doesn't apply against CVS head.
Chris
On Thursday 29 June 2006 7:05 am, Jonathan Ernst wrote:
> You might need to apply the previous patches first.
>
> Changelog:
> - factor exit calls after redirect
Why not replace the require_once() with requires instead of putting it on the
todo?
We don't really need the $aClean TODO item since thats high on the priority
list at the moment and we'll just end up removing it in a day or two right?
The move of show_note() into its class is on my todo list f
Can we pass the parameters we need into the function instead of using a
global?
Chris
On Thursday 29 June 2006 2:29 am, Jonathan Ernst wrote:
> Changelog:
> - $aClean was not visible in function
with our unit testing
so we can turn hours of manual testing into seconds of automated testing.
This ultimately is the only way we can really be sure any given patch doesn't
break things.
Chris
On Wednesday 28 June 2006 3:01 pm, Tony Lambregts wrote:
> Chris Morgan wrote:
>
We'll want to perform this move of error_page() and the renaming of calls to
it in a single patch.
Chris
On Wednesday 28 June 2006 1:21 pm, Jonathan Ernst wrote:
> Changelog:
> - new util_show_error_page that will replace errorpage
Can we put a module prefix on this function so it is easier to locate in the
tree? I'm not sure what but it seems like we should try to prefix something
that matches the file the function is in.
Chris
On Monday 26 June 2006 6:18 pm, Jonathan Ernst wrote:
> Changelog:
> - rename errorpage fun
> > As we've discussed before I'd rather we did a single full pass of manual
> > testing than several full passes. It saves us time in that we don't have
> > to test the same things repeatedly like we would have to do when making
> > changes to things like classes that are used all over the code.
Wow, thats a pretty neat idea.
A few comments.
We should do something to the values in $_REQUEST so they can't be used after
this function is called.
We should error if there are variables that don't fit the format we expect. We
can't have anything getting past this filter by default or we'll
1 - 100 of 295 matches
Mail list logo
