-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
this patch is causing CS:GO (Counter Strike: Global Offensive) to exit
silently on startup.
(Commit: 5fae649bdf14fb63b8d44984eda6edd1094a3314)
- -Chris
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Henri,
I'm using a Netbook with an Intel Atom N450 (Pineview, PCI ID: 8086:a011),
which has 256MB under 2GB of RAM.
Personally, I think we need a way for detecting the correct VRAM size for
IGD's, as it usually depends on the total RAM size. (If
Hello,
I've tested it now with a value of 0x75 (hex) and it fails.
But my C is a bit rusty, so I don't know a clean way to enumerating an enum.
Greetings,
Christian
On 11/03/2011 02:35 PM, Alexander Morozov wrote:
-1 in this test is only a sample of a bad constant. Do you sure
that
On 07/08/2011 01:22 AM, Juan Lang wrote:
Hi Christian,
this isn't quite what Alexandre meant. *What* did you fix? Saying
you did so isn't enough.
Thanks,
--Juan
I'm sorry, I thought you can see it out of the sourcecode.
PATCH 1: Don't load any variables which aren't in a section.
PATCH 2:
On 07/08/2011 02:06 AM, Ricardo Filipe wrote:
2011/7/8 Christian Inci chris.pcguy.i...@gmail.com
mailto:chris.pcguy.i...@gmail.com
On 07/08/2011 01:22 AM, Juan Lang wrote:
Hi Christian,
this isn't quite what Alexandre meant. *What* did you fix? Saying
you did so isn't
Am 2011-01-11 16:18, schrieb Juan Lang:
Please don't introduce whitespace-only changes, it's harder to see
what your patch is doing.
Sorry, that wasn't intended.
Since these changes pass on unpatched wine, they don't demonstrate the
necessity for your patch. We need tests that show what the
Am 2011-01-11 16:58, schrieb Juan Lang:
Ah, right. Sorry, I wasn't thinking clearly. In that case, you need
to number the patches as a series to show the dependency between them.
--Juan
First the normal then the test, or reverse?
--Christian
Am 2011-01-11 17:03, schrieb Juan Lang:
Tests must pass with every commit. In general, I prefer to see tests
first, with failing tests marked todo_wine. Then the second patch,
with implementation, removes the todo_wines. In this case adding
todo_wine might be more trouble than it's worth,
Am 2011-01-11 17:11, schrieb Juan Lang:
Also, since CertRDNValueToStr doesn't need quote_string, you should
probably invert the order in which they appear in the file.
The calls or the definitions?
If the definition, should I move is_quotable_char too?
--Christian
Am 2011-01-11 00:02, schrieb Juan Lang:
Hi Christian,
hi,
Adding tests that demonstrate that would help a great deal.
I've sended my patches, they look a little bit weird, but they work.
Don't use Hungarian notation for internal functions, it's hard to
distinguish them from Win32 API
10 matches
Mail list logo
