Re: user32: test processing of expose events (try 3)

2008-03-17 Thread Clinton Stimpson
Paul Vriens wrote: > Clinton Stimpson wrote: >> Simplified from first try by removing unecessary thread. >> Also fixing style to other code in file (thanks for feedback). >> >> ChangeLog:user32: test processing of expose events >&g

Re: user32: add tests for handling exposed regions created by other threads

2007-12-14 Thread Clinton Stimpson
Anything wrong with this patch? I'm guessing its the Sleep(). Any other way to force X server to put expose events in the queue, if any? This is for bug #9875. Clinton Stimpson diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c index 49fe766..0d369c8 100644 --- a/dlls/u

Re: x11drv: don't consume Expose events when filter contains QS_PAINT

2007-10-09 Thread Clinton Stimpson
Clinton Stimpson wrote: > Fix for bug 9875 (There are more details in that bug report if you want). > Existance of update regions in the wine server correspond with WM_PAINT > existing in queue. Existance of Expose events in the X event queue don't > correspond with update re

Re: [oleaut32/tests] Error when running tests on Wine, anyone?

2007-08-10 Thread Clinton Stimpson
Stefan Leichter wrote: Am Friday 10 August 2007 13:34 schrieb Paul Vriens: Hi, Can somebody confirm if all oleaut32 tests run correctly on Wine. I'm trying to change LoadLibrary to GetModuleHandle and though it was my failure, but current GIT fails for me: ../../../tools/runtest -v -P wine -M

Re: user32: fix SetWindowPos to erase parent when child is hidden

2007-07-21 Thread Clinton Stimpson
Can someone help me with why this patch isn't correct enough? Thanks, Clinton Clinton Stimpson wrote: When hiding windows, WM_ERASEBKGND is supposed to be sent to the parent. The message will now be sent with this patch. An existing test was modified to also check for all parent mes

user32 patch unaccepted

2007-06-25 Thread Clinton Stimpson
Was there anything wrong with this patch, that it didn't get accepted? <http://www.winehq.org/pipermail/wine-patches/2007-March/037272.html> It limits update regions to the nearest clipping parent window. Thanks Clinton Stimpson

Re: 64-bit compilation broken today

2007-05-26 Thread Clinton Stimpson
The confusing thing to me is that I *do* have the libxml2-dev package installed, and see no errors about a missing header... If it didn't recognize the xmlNodePtr type, shouldn't it have choked on line 52 first? -J Bryan DeGrendel wrote: A couple of libxml2 externs were recently added

Re: mshtml: fix crash when opening help (bug 8077)

2007-04-26 Thread Clinton Stimpson
On Thursday 26 April 2007 10:50:59 am Jacek Caban wrote: > Hi Clinton, > > This patch is wrong, I've added a comment to bug. > > Thanks, > Jacek Thanks. I added a comment that your patch does fix the problem. I assume you'll submit the correct patch. Thanks, Clint

Re: ntdll/kernel32: LoadLibrary fails to load some dependent libs

2007-04-06 Thread Clinton Stimpson
Vitaliy Margolen wrote: Clinton Stimpson wrote: So I have this case: An application that can load libraries at runtime (plugins). Plugins reside in a different directory than the application directory. Some plugins have dependent dlls found only in the plugin directory. Wine fails to load the

ntdll/kernel32: LoadLibrary fails to load some dependent libs

2007-04-06 Thread Clinton Stimpson
So I have this case: An application that can load libraries at runtime (plugins). Plugins reside in a different directory than the application directory. Some plugins have dependent dlls found only in the plugin directory. Wine fails to load the dependent dlls. I can copy the dependent dlls into

Re: user32: WM_SETFONT on button shouldn't repaint directly

2007-01-22 Thread Clinton Stimpson
Anything wrong with this patch? It hasn't been accepted. Thanks, Clint Clinton Stimpson wrote: This patch includes a couple improvements over the patch submitted yesterday. Fix WM_SETFONT on a button to invalidate the rect instead of painting it directly. Test included. Thanks, Cl

window managment bug

2006-12-26 Thread Clinton Stimpson
Does bug #6006 fall under window management? When buttons are turned invisible, the invalidated area in the parent window is not repainted, so it looks like the button is still there. Also, there's two invisible buttons that seem to repaint themselves when the parent window resizes, clicking on

Re: usp10: impelment ScriptStringGetLogicalWidths

2006-12-20 Thread Clinton Stimpson
Quoting Alexandre Julliard <[EMAIL PROTECTED]>: > Clinton Stimpson <[EMAIL PROTECTED]> writes: > > > This patch implements ScriptStringGetLogicalWidths. > > Update usp10.spec so it isn't a stub anymore. > > Also added a test for this function. > > Th

Re: [5/5] usp10: remote todo_wine

2006-12-15 Thread Clinton Stimpson
s Hawkins wrote: On 12/14/06, Clinton Stimpson <[EMAIL PROTECTED]> wrote: Hi, Part 5 of 5. Remove many todo_wine's from the tests, now that the functions are implemented. You have to remove the todo_wine's in the same patch that fixes the tests, or the tests will fail for at l

Re: usp10: fix tests to allow atomic patches for new implementation

2006-12-15 Thread Clinton Stimpson
James Hawkins wrote: On 12/15/06, Clinton Stimpson <[EMAIL PROTECTED]> wrote: Hi, Here's a patch to make unimplemented functions return E_NOTIMPL instead of S_OK. Even dependent functions already return E_NOTIMPL. Also fixing tests to check that the return value is S_OK before

Re: [5/5] usp10: remote todo_wine

2006-12-15 Thread Clinton Stimpson
I can change the tests a bit, and change the currently empty functions to return E_NOTIMPL instead of S_OK. Then I can do it piecemeal. Is that how y'all want it? Clint Clinton Stimpson wrote: Ok. There are 4 functions that have to be implemented at the same time in order to not brea

Re: usp10: implement ScriptStringAnalyse, ScriptStringFree, ScriptStringXtoCP, ScriptStringCPtoX

2006-12-14 Thread Clinton Stimpson
Hi, Can I get some feedback on this patch? It appears to have been rejected. Thanks, Clinton Clinton Stimpson wrote: This patch implements ScriptStringAnalyse, ScriptStringFree, ScriptStringXtoCP, ScriptStringCPtoX. Also, many todo_wine's are removed. T

Re: lstrlen(A/W) patch

2006-06-07 Thread Clinton Stimpson
Mike McCormack wrote: Clinton Stimpson wrote: Oh, used internally, ok (I thought it was public and that the wine debugger said Paf 5.2 called that lstrlenW directly). The public version is defined in dlls/kernel/string.c, and has an exception handler as required by Win32. So here&#

Re: lstrlen(A/W) patch

2006-06-06 Thread Clinton Stimpson
Mike McCormack wrote: Clinton Stimpson wrote: The following patch will fix the crash. MSDN documentation says "*lstrlen* assumes that /lpString/ is a null-terminated string, or NULL" The inline lstrlenW is used only internally by Wine code, and we want it to crash when pas