Re: [1/1] kernel32: Implemented basic NUMA functions to replace the stubs

2013-07-29 Thread Detlef Riekenberg
Hi Chris. Welcome to Wine. > Main changes from HEAD: > 1) Implements GetNumaHighestNodeNumber which simulates a typical single node > system. > 2) Implements GetNumaNodeProcessorMask which returns the global processor > affinity mask for node 0, otherwise returns an error. > 3) Implements GetNu

Re: mscms: Use lcms2, when available [try 2]

2013-06-03 Thread Detlef Riekenberg
Hans wrote on Monday, 3. June 2013 at 10:30 > On Sun, 2013-06-02 at 22:49 +0200, Detlef Riekenberg wrote: > > try2: > > import the unchanged icc34.h from the lcms (v1) dev. package. > > (Do we need to add a Wine LGPL licence header for icc34.h?) > > > > The pla

Re: [PATCH] slc: Fix return type

2013-05-30 Thread Detlef Riekenberg
Christian wrote at Wednesday, 29. Mai 2013 at 23:12 Uhr > > + */ > > +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD *pvalue) > > +{ > > > > -SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, > > LPDWORD pdwValue); > > +SLCAPI HRESULT WINAPI SLGetWindowsIn

Re: [PATCH] mscms: Use lcms2, when available

2013-05-09 Thread Detlef Riekenberg
Hi Hans. > For most apps it will be a matter of adding a configure check for lcms2 > and then recompiling. This is not the case for Wine as you have pointed out. - cmsCreateLabProfile was renamed to cmsCreateLab2Profile cmsvirt.c (1.19: 570) / (2.4: 458 and 497) - cmsSetLogErrorHandler can be

IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) test failure [text only]

2013-03-03 Thread Detlef Riekenberg
Hi Alexandre. I have a test failure on my win7 Machine, while a valid cd was in the dvd drive. volume.c:785: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 1785 Example result: http://test.winehq.org/data/209b58c64e6181c9bf448cb4f3130d3ba705c5d2/win7_dr-w7sp

IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) test failure

2013-03-03 Thread Detlef Riekenberg
Hi Alexandre.I have a test failure on my win7 Machine, while a valid cd was in the dvd drive.volume.c:785: Test failed: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) failed, last error = 1785Example result:http://test.winehq.org/data/209b58c64e6181c9bf448cb4f3130d3ba705c5d2/win7_dr-w7sp1-wow-p61

Aw: Re: [PATCH 1/2] shell32: Add a basic implementation for SHGetStockIconInfo

2013-02-08 Thread Detlef Riekenberg
Dimitry wrote: >> +/ >> + * helper for SHGetStockIconInfo >> + */ >> +typedef struct stockiconentry_t { >> + SHSTOCKICONID id; >> + DWORD iconid; >> +} stockiconentry; >Why bother with a typedef? I prefer typedef to red

Patches for winspool.drv and other locations

2013-01-14 Thread Detlef Riekenberg
Hi Tatyana Welcome to Wine. Wine has a test suite to make sure, that new code is correct. Example, what you never tested: > -if(!pDeviceName) { > +if(!pDeviceName && !*pDeviceName) { Your code will crash, when pDeviceName is NULL. I expect, you want to use a logical OR, but i did not t

Mail problems for wine-patches

2012-12-26 Thread Detlef Riekenberg
I send several patches the last days with git and with the webmail interface from web.de, but nothing arrived at the wine-patches archive or the patches queue page. I also unsubscribed and subscribed again to the wine-patches list. Any ideas? Has wine-patches a whitelist? -- By by ... Detlef

Re: testbot failures in advapi32 (security)

2012-12-02 Thread Detlef Riekenberg
-- By by ... Detlef Gesendet: Samstag, 01. Dezember 2012 um 18:16 Uhr Von: "Erich E. Hoover" An: "Detlef Riekenberg" Cc: wine-devel Betreff: Re: testbot failures in advapi32 (security) On Sat, Dec 1, 201

testbot failures in advapi32 (security)

2012-12-01 Thread Detlef Riekenberg
Hi Erich.We somewhere missed us on #winehackers.Testbot works with your patch:http://testbot.winehq.org/JobDetails.pl?Key=23165For an account,  testbot has a menu item named "Register":https://testbot.winehq.org/Register.pl-- By by ... Detlef

Judge rules: APIs can not be copyrighted.

2012-05-31 Thread Detlef Riekenberg
HiThe result from the Oracle => Google battle is good to know:http://tech.slashdot.org/story/12/05/31/237208/judge-rules-apis-can-not-be-copyrighted-- By by ... Detlef  Ihr WEB.DE Postfach immer dabei: die kostenlose WEB.DE Mail App für iPhone und Android.   https://produkte.web.de/freemail_mobile_

RE: localspl: Only store the file part of the filenames in the registry

2012-05-16 Thread Detlef Riekenberg
Hi Huw. We have only filenames in the registry. The current code works fine with the adobe postscript driver and various other driver for PDF printers. Which native driver makes problems? Why do you add spaces before and after the the function args and change idention, bracket style and variab

Re: [PATCH] wined3d: Reduce console flood with an Ogre3D Game

2012-01-24 Thread Detlef Riekenberg
On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote: > On 22 January 2012 19:44, Detlef Riekenberg wrote: > > -if (usage & ~handled) > > +static DWORD reported_once; > > + > > +if (usage & ~(handled | reported_once)) > > +{ > &

Re: [PATCH 5/5] jscript/tests: Add tests with values related to INT_MAX

2011-06-30 Thread Detlef Riekenberg
On Mo, 2011-06-27 at 11:59 +0200, Jacek Caban wrote: > > How can we force tests to use VT_UI4? > It's not JScript builtin type, you need to extend tests host object for > that. Sorry, no clue. Which host object? > > +/* 0x7fff is 2147483647 is INT_MAX */ > > +tmp = 2147483647*-1; > > 0x...

Re: user32: Partially implement FlashWindowEx with tests

2011-05-22 Thread Detlef Riekenberg
On So, 2011-05-22, André Hentschel wrote > Thanks, will get into try 2 > pfwi->cbSize < sizeof(FLASHWINFO) || pfwi->cbSize > sizeof(FLASHWINFO) That code can be reduced to: pfwi->cbSize != sizeof(FLASHWINFO) -- By by ... Detlef

Re: Ubuntu likely to abandon HAL next cycle -- is this workable?

2011-05-17 Thread Detlef Riekenberg
Am Donnerstag, den 12.05.2011, 12:28 +0200 schrieb Scott Ritchie: > Consensus here seems to be to try and remove HAL from the archive. > > Wine still uses it, so this means we'll either need to lobby for keeping > HAL or to migrate to udisks. I expect for Wine: udisk (current linux) | hal (for o

Testmail

2011-02-11 Thread Detlef Riekenberg
Hi Just a test, as my patches do not show up in the mail archive. Detlef ___ WEB.DE DSL Doppel-Flat ab 19,99 €/mtl.! Jetzt mit gratis Handy-Flat! http://produkte.web.de/go/DSL_Doppel_Flatrate/2

Re: msvcrt: Partially implement _set_abort_behavior

2011-01-11 Thread Detlef Riekenberg
On Mi, 2011-01-12 at 00:48 +0300, Nikolay Sivov wrote: > Date: Wed, 12 Jan 2011 00:46:26 +0300 > Subject: [PATCH 1/1] Partially implement _set_abort_behavior Please search the patches queue first. try 2: http://source.winehq.org/patches/data/70231 try 1: http://source.winehq.org/patches/data/7013

Re: wine's configure says "gst/gstpad.h usability... No"

2010-12-12 Thread Detlef Riekenberg
On Sa, 2010-12-11 at 13:09 +0100, Paul Vriens wrote: > On 12/11/2010 08:26 AM, wy...@volny.cz wrote: > > Hi guys, > > > > gstreamer-0.10 development files not found, gstreamer support > > disabled > I'm on Fedora 13 and had to install gstreamer-plugins-base-devel. > > So I guess you need libgstre

kernel32: Add a stub for SetProcessDEPPolicy

2010-11-11 Thread Detlef Riekenberg
Any comments available for this Patch? http://source.winehq.org/patches/data/68113 -- By by ... Detlef

Apps for Wine on ARM

2010-10-18 Thread Detlef Riekenberg
Here is a free compiler to create apps on ARM: http://www.smorgasbordet.com/pellesc/ (Untested, how this app works in Wine) -- By by ... Detlef

Packagers: cups-bsd/cupsys-bsd (lpr and friends) no longer needed

2010-10-16 Thread Detlef Riekenberg
Hi Wine packing Team. Cups has a compatibility package for the BSD style printing system (lpr, lpq, lprm, lpc and related files). The package is named cups-bsd on ubuntu and cupsys-bsd on debian. This compatibility package is no longer needed since Wine-1.3.5, when cups is installed: http://sourc

Re: [PATCH] problem with color management with mscms and gdi

2010-10-16 Thread Detlef Riekenberg
Hi Tomasz. Welcome to Wine. You already fixed your missing real name in your first patch. That is good, but there are more suggestions. > For applications which uses EnumICMProfiles to detect monitor icc profile, > there should be a copy of monitor profile in > windows\system32\spool\drivers\c

Re: [PATCH] Compiling Wine at Ubuntu 10.10

2010-10-16 Thread Detlef Riekenberg
On Sa, 2010-10-16 at 10:02 +0200, Gerold Jens Wucherpfennig wrote: > You will need this patch to compile Wine at Ubuntu 10.10, > because of the new Xorg Server 1.9. You can't do that. Your patch will break the build on many systems. Are you missing libxxf86vm1 or libxxf86vm-dev? > If you still ge

Re: [PATCH] Compiling Wine at Ubuntu 10.10

2010-10-16 Thread Detlef Riekenberg
On Sa, 2010-10-16 at 13:29 +0200, Alexandre Julliard wrote: > Gerold Jens Wucherpfennig writes: > > You will need this patch to compile Wine at Ubuntu 10.10, > > because of the new Xorg Server 1.9. > > If you still get a compilation error in dlls/winex11.drv you > > will need to add the flag "-l

Re: LLVM compilation

2010-10-11 Thread Detlef Riekenberg
On Mon, 2010-10-11 at 08:54 -0600, Jeff Cook wrote: > Just wondering if anyone has experimented building WINE with LLVM > instead of GCC. Yes, several people used LLVM/CLANG for Wine and send patches. >From the commits: http://source.winehq.org/git/wine.git/?a=search&st=commit&s=CLANG&sr=1 You a

Re: winspool.drv: Support pDevMode field in {Get/Set}Job

2010-09-20 Thread Detlef Riekenberg
Hi Vitaly. Thanks for fixing printing issues. You use sizeof(DEVMODEW) in you patch, but the correct size is: devmodeW->dmSize + devmodeW->dmDriverExtra You should change the FIXME in the comment of get_job_info_2 to a real FIXME, when unicode is FALSE I'm fine with the unicode - only patch for

Re: inetcpl: Implement LaunchSiteCertDialog on top of cryptui.CryptUIDlgCertMgr

2010-09-17 Thread Detlef Riekenberg
On Fri, 2010-09-17 at 10:32 -0700, Juan Lang wrote: > Hi Detlef, > I have no issue with the patch, just a question: are you sure native > does this? Or does it call wintrust.OpenPersonalTrustDBDialog? I followed your mail from 25. Aug, where you mentioned cryptui.CryptUICertMgr That was a typo

Re: user32: Implement support for getting class data GCLP_HBRBACKGROUND on other process window

2010-09-17 Thread Detlef Riekenberg
On Fri, 2010-09-17 at 22:30 +0400, Aleksey Bragin wrote: > So this patch implements required GetClassLong functionality of > getting background brush handle of another process window's class. You introduce unneeded padding in various struct. How can anybody use such strange names? -- By by

Re: [PATCH] inetcpl: Add initial applet

2010-08-26 Thread Detlef Riekenberg
Am Dienstag, den 24.08.2010, 17:56 -0700 schrieb Juan Lang: > Hi Detlef, > were you planning to resubmit this patch? [1] Yes, after the next release but as a more complete Patchset. > Using our own inetcpl.cpl would allow us to avoid > that, by exposing cryptui.CryptUICertMgr without using any n

Re: [2/7] shlwapi/tests: Add tests for StrStrA.

2010-07-19 Thread Detlef Riekenberg
Hi Andrew. While reading your Patches, i stumble over deadbeef. We use the value 0xdeadbeef almost everywhere in the tests to initialize a variable to an unusual value. Using deadbeef as a variable name looks strange and make the code harder to read and understand. Please change the name in you

Re: Anotated 'make test' log

2010-07-17 Thread Detlef Riekenberg
Hi Max Welcome to Wine. Your Patch "[Add '_ONCE' variants of DPRINTF, FIXME, WARN.]" ( http://source.winehq.org/patches/data/63503 ) has a typo near the end: #define ERR_ONCE WINE_ERR_ONCEE -- By by ... Detlef ___ Neu:

Internet Explorer in Wine

2010-04-23 Thread Detlef Riekenberg
I test sometimes native IE in Wine with the least possible changes. With my implementation of shlwapi,SHCreateThreadRef this week, the native IE UI came up in Wine, using our shell replacement, mshtml with gecko and all that low level stuff: http://www.myimg.de/?img=ieinwineef89e.png The relate

Re: [PATCH 2/8] urlmon/tests: CoInternetCreateZoneManager not present on W95B

2010-04-18 Thread Detlef Riekenberg
On Fr, 2010-04-16 at 08:57 +0200, Paul Vriens wrote: > > Wouldn't it be better to just check for one (or all) and bail out with > a (only one) win_skip()? I guess if one is not present, none are? The checks are in different test files and some tests work on W95B (IE 4) I prefer to have a comple

Re: [PATCH] msvcr90/tests: Add tests for _initterm_e [try 2]

2010-03-20 Thread Detlef Riekenberg
On Sa, 2010-03-20 at 01:08 +0100, Piotr Caban wrote: > > You forgot to attach changes to configure.ac. Nope. That part is auto-generated, when Makefile.in is in the git tree: tools/make_makefiles Never add auto-generated changes to a patch -- By by ... Detlef

Re: [PATCH] attrib.exe: Add stubbed command

2010-03-17 Thread Detlef Riekenberg
On Mi, 2010-03-17 at 12:22 +0100, Christian Costa wrote: > +printf("attrib.exe is currently only a stub command\n"); > +printf("cmdline:"); UNICODE would be better, even for a stub. -- By by ... Detlef

Re: cmd: fix buffer overflow in WCMD_run_program

2010-03-04 Thread Detlef Riekenberg
On Do, 2010-03-04 at 09:20 -0800, Eric Ho wrote: Hi Eric. Welcome to Wine. > Fixes http://bugs.winehq.org/show_bug.cgi?id=21344. Overflows fixed: > 1. overflow due to long path name (unchecked memcpy,strcpy to thisDir) > 2. overflow due to long file name (unchecked strcpy into stemofsearch) > 3.

Re: tools/wine.inf: Add a symlink for WindowsNT.CurrentVersion.Print.Printers

2010-02-17 Thread Detlef Riekenberg
On Mi, 2010-02-17 at 11:15 +0100, Alexandre Julliard wrote: > Detlef Riekenberg writes: > > > @@ -905,6 +905,7 @@ HKLM,%CurrentVersionNT%\Ports,"COM1:",2,"9600,n,8,1" > > HKLM,%CurrentVersionNT%\Ports,"COM2:",2,"9600,n,8,1" > >

Re: oldconfig.c: produce DEVICEMAP//SERIALCOMM entries

2010-02-13 Thread Detlef Riekenberg
On Fr, 2010-02-12 at 13:00 +0100, Alexandre Julliard wrote: > A C Hurst writes: > > > Fixes bug 11811 [http://bugs.winehq.org/show_bug.cgi?id=11811] and its > > duplicates. > > This patch sent some time back (over a year) was ignored/lost in noise. > > Could someone review please? > > this belo

New Icon set

2010-01-06 Thread Detlef Riekenberg
Hi Joel When I read your preview page in Firefox, the lens for print preview in idb_std_small.bmp is to large. You can't detect the printer behind the lens. (LCD Resolution here is 1400x1050) As an Idea for an improvement, the print preview menu icon in Firefox is readable: The lens is a bit sm

Re: [winspool 2/6] Move the dlopen of libcups to a sep =?iso-8859-15?Q?arate_function, _allowing_CUPS_to_be_used_prior_to_the_?= full on loading of CUPS printers.

2009-12-24 Thread Detlef Riekenberg
Hi Jeremy What is your reason for your work in winspool.drv? What are your plans? Even if the Patchset changes some things, it's not the correct location to do that. winspool.drv must not do anything with the registry or the driver files. winspool.drv must not use cups at all wineps.drv must no

wine-devel@winehq.org

2009-12-24 Thread Detlef Riekenberg
___ Preisknaller: WEB.DE DSL Flatrate für nur 16,99 Euro/mtl.! http://produkte.web.de/go/02/

Re: [PATCH 2/7] dsound: Clean up DSPROPERTY_DescriptionW, try 2

2009-12-10 Thread Detlef Riekenberg
On Mi, 2009-12-09 at 16:57 +0100, Maarten Lankhorst wrote: > +{ > +/* FIXME: Still a memory leak.. */ This should be fixed before sending to wine-patches -- By by ... Detlef

Re: [PATCH 3/4] jscript: Added Function constructor tests.

2009-12-10 Thread Detlef Riekenberg
On Do, 2009-12-10 at 01:15 +0100, Jacek Caban wrote: > +func = new Function(); > +tmp = func(); > +ok(tmp === undefined, "func(1,3,2) = " + tmp) Greetings from Copy & Paste -- By by ... Detlef

Re: Very long printernames and test failures

2009-12-07 Thread Detlef Riekenberg
On So, 2009-12-06 at 19:28 +0100, Paul Vriens wrote: > Some test failures are shown on boxes with long printernames, for example: > > http://test.winehq.org/data/17b7ee13fb55e872902be3156610e583e4cd324b/vista_test-on-vista/winspool.drv:info.html > http://test.winehq.org/data/17b7ee13fb55e872902be

Re: winspool.drv: Acroread 9.2 relies on the buffer sizes returned by GetPrinterA and GetPrinterDriverA being large enough to hold their respective unicode versions' data.

2009-11-19 Thread Detlef Riekenberg
On Do, 2009-11-19 at 13:18 +, Huw Davies wrote: > --- > dlls/winspool.drv/info.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) ANSI functions in winspool.drv have this behavior since w2k. We have already a test for EnumPrintersA/W [required by Outlook2003) I prefer to m

Re: d3d8/tests: Avoid a crash, when CreateTexture failed

2009-11-11 Thread Detlef Riekenberg
On Mi, 2009-11-11 at 15:16 +0100, Henri Verbeet wrote: > I.e., does the attached patch work for you? yes, with 0 failures :-) d3d9 has the same code (but i cant test d3d9 on my machine). Thanks. Do you want to send the patches yourself? -- By by ... Detlef

Re: avifile bugfixes

2009-11-10 Thread Detlef Riekenberg
On Di, 2009-11-10 at 00:43 +0100, Julius Schwartzenberg wrote: > I will add tests to show this and submit the patches then. I created a test for avifil32 in June 2008, but it was not comitted. ( http://www.winehq.org/pipermail/wine-patches/2008-June/056310.html ) The bug 14085 was created to docu

Re: Another virus-in-wine story

2009-10-31 Thread Detlef Riekenberg
On Sa, 2009-10-24 at 22:07 -0700, Dan Kegel wrote: > This is about the fifth article of this sort, so it's not really news > anymore, but it's still fun to read about. > http://linux.slashdot.org/story/09/10/24/1759213/Now-Linux-Can-Get-Viruses-Via-Wine The blogger mention the bad website, but the

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)

2009-10-04 Thread Detlef Riekenberg
On Do, 2009-10-01 at 16:59 -0700, Dan Kegel wrote: > +/*** > + * wrap_getxattr > + * Retrieve extended attribute of posix file into given buffer. > + * Use fd if given, else use fname; caller only sets one or the > other.

Re: wininet: Handle finding ftp files in subdirectories and using wildcards.

2009-09-29 Thread Detlef Riekenberg
On Sa, 2009-09-26 at 22:15 -0500, Mike Ruprecht wrote: > +if (lpszSearchPath) > +HeapFree(GetProcessHeap(), 0, lpszSearchPath); > + Please remove the unneeded if(lpszSearchPath) before HeapFree. -- By by ... Detlef

Re: help with dwBackBufferCount in backbuffer surfaces needed

2009-09-29 Thread Detlef Riekenberg
On Di, 2009-09-29 at 13:27 +0200, Markus Stockhausen wrote: > The test will fail in Windows and Wine to get the results in both > cases. > The result will show like this: > > dsurface.c:1264: Test failed: backbuffer surface has > dwBackBufferCount==2 This is 0 here with ATI Radeon R100 on Win98se

Re: [PATCH 2/4] mshtml: Add test suite for IHTMLLocation

2009-09-26 Thread Detlef Riekenberg
On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote: > +todo_wine ok(SUCCEEDED(hres), "get_hash failed: 0x%08x\n", > hres); > +if(SUCCEEDED(hres)){ > +if(str_pass) > +ok(strcmp_wa_null(str, exp) == 0, "expected retrieved > hash to be L\"%s\", was: %s\n", exp, wine_d

Re: sti: test behavior of creation with the A/W functions versus STI_VERSION_FLAG_UNICODE

2009-09-26 Thread Detlef Riekenberg
On Fr, 2009-09-25 at 16:35 +0200, Damjan Jovanovic wrote: > * sti: test behavior of creation with the A/W functions versus > STI_VERSION_FLAG_UNICODE Using the name "sti_tests" is bad. The short "sti" is enough. You forgot the license notice We usually cast the result of GetProcAddress() as (void

Re: [PATCH 3/4] mshtml: Add helper function get_url_components

2009-09-26 Thread Detlef Riekenberg
On Fr, 2009-09-25 at 15:30 -0500, Andrew Eikum wrote: > +static HRESULT get_url_components(HTMLLocation *This, URL_COMPONENTSW > *url) > +{ > +const WCHAR *doc_url; > +if(!InternetCrackUrlW(doc_url, 0, 0, url)) { > +FIXME("InternetCrackUrlW failed\n"); Such a FIXME does not help t

Re: cppcheck sept 18 redux

2009-09-26 Thread Detlef Riekenberg
On Di, 2009-09-22 at 07:46 -0700, Chris Robinson wrote: > so dmW->dmFormName is the same as &(*dmW).dmFormName, When the target is an array, the address of the first member is returned: dmW->fmFormName is: &(dmW->dmFormName[0]) similar: char buffer[32]; printf("buffer at %p\n", buffer); which

Re: tools/winegcc: fix linker for Haiku

2009-09-21 Thread Detlef Riekenberg
On Mo, 2009-09-21 at 01:52 -0500, Austin English wrote: > +#ifdef __HAIKU__ > + strarray_add(link_args, "-lroot"); > +#else > + strarray_add(link_args, "-lm"); > + strarray_add(link_args, "-lc"); > +#endif > + } "autoconf.ac" was designed to avoid OS dependant "#ifdef". Test

Re: [(try 3) 3/3] opengl32/tests: Improve test for wglMakeCurrent.

2009-09-19 Thread Detlef Riekenberg
On Sa, 2009-09-19 at 13:15 +0200, Rico Schüller wrote: > > +ret = wglMakeCurrent( NULL, NULL ); > > +ok( !ret, "wglMakeCurrent failed\n" ); > > > > shouldn't that message read "wglMakeCurrent succeeded" ? > Yes, probably something like "wglMakeCurrent succeeded, but should > fail!" is real

Re: Wine in Tango

2009-09-19 Thread Detlef Riekenberg
On Sa, 2009-09-19 at 12:13 +0100, Joel Holdsworth wrote: > The full set of Tango graphics can be seen here: > http://www.airwebreathe.org.uk/wine-icon/ . As I already mentioned a while ago, the new Icons looks nice, but some things are Strange: - the lens is wrong in idb_std_small.bmp for print

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt

2009-08-20 Thread Detlef Riekenberg
On Do, 2009-08-20 at 18:22 +0200, Alexandre Julliard wrote: > Juan Lang writes: > > >> There can be several other ways to handle this, it needs test cases to > >> determine which way Windows is using. > > > > Sorry for my lack of imagination: could you suggest at least one > > other way so I can

Re: ws2_32: Only examine lower-order bits in getsockopt/setsockopt

2009-08-20 Thread Detlef Riekenberg
On Do, 2009-08-20 at 17:58 +0200, Alexandre Julliard wrote: > Juan Lang writes: > > > @@ -1779,6 +1779,8 @@ INT WINAPI WS_getsockopt(SOCKET s, INT level, > > TRACE("socket: %04lx, level 0x%x, name 0x%x, ptr %p, len %d\n", > >s, level, optname, optval, *optlen); > > > > +/*

Re: [8/21] comctl32: Add basic structure for IImageList interface

2009-08-15 Thread Detlef Riekenberg
On Mi, 2009-08-12 at 23:31 +0100, Owen Rudge wrote: > > You can't do that. HIMAGELIST should be the same thing as IImageList. > > Hmm. Looking at the HIMAGELIST/IImageList internals in a debugger on > Windows, the layout appears to be ... :-( Disassembling Windows Code is not allowed for Wine.

Wine icon refresh

2009-08-15 Thread Detlef Riekenberg
On Sa, 2009-08-08 at 20:42 +0100, Joel Holdsworth wrote: > If you want, I can draw a Tango-style icon for it, as part of my work in > progress wine icon refresh: http://www.airwebreathe.org.uk/wine-icon/ They look nice, but I have some comments: idb_std_large.bmp and idb_std_small.bmp: The prin

Re: New winetricks 20090716: new verbs droid, wenquanyi, dinput8

2009-07-17 Thread Detlef Riekenberg
On Fr, 2009-07-17 at 02:01 +0200, Matijn Woudt wrote: > (to the list this time) > > On Fri, Jul 17, 2009 at 1:54 AM, Ben Klein wrote: > > 2009/7/16 Hin-Tak Leung : > >> I have decided against responding to the chinese thread (so much > >> mis-information, ignorance and wrongful entitlement in it,

Re: XInput [1/4]: Implement XInputGetState

2009-07-15 Thread Detlef Riekenberg
On Do, 2009-07-09 at 12:50 +0200, Michael Gruber wrote: > On Thu, Jul 9, 2009 at 09:50, Stefan Dösinger wrote: > > Is it possible to implement XInput on top of DirectInput? DirectInput > > already has some internal abstraction layers for differnet joystick APIs, > > and has basic support for OSX jo

Re: fix overflow in several advapi32 crypt functions hidden by broken WideCharToMultiByte

2009-07-02 Thread Detlef Riekenberg
On Mo, 2009-06-29 at 16:49 +0900, Dmitry Timoshkov wrote: > "Christoph von Wittich" wrote: > > > + if (*pcbProvName > INT_MAX) > > + *pcbProvName = INT_MAX; > > In which way WideCharToMultiByte is broken? It always helps to provide > an explanation and if possible a test case. While working on

Re: configure.ac: make sure we can run cmdlgtst and view from outside wine tree

2009-06-29 Thread Detlef Riekenberg
On Mo, 2009-06-29 at 12:50 -0500, Austin English wrote: > With this patch, they are treated like other programs, e.g., winhlp32, > and installed, so one can use: > $ wine view > and get the same effect. That parts of configure.ac are created by tools/make_makefiles tools/make_makefiles-50-# Progr

Crash in the mlang test

2009-06-21 Thread Detlef Riekenberg
Hi Ge The mlang tests where reordered and now it crashed on on your Win98 machine with mlang.dll "4.72.3110.0". http://test.winehq.org/data/675e6e93b1d2b4555d05e311764510abf763d21d/98_gvg-w98/mlang:mlang.html Please send me the results for the test with: set WINETEST_REPORT_SUCCESS=1 Thanks

Re: Wine translation statistics sources

2009-06-21 Thread Detlef Riekenberg
On Mo, 2009-06-08 at 23:24 +0200, Michael Stefaniuc wrote: > >> And we of course need something to cope with the change to the clock > >> resource files as mentioned by Michael Stefaniuc. > >> > > Or we should change our clock resources to fit in the rest of wine? > You mean reverting Alexandre's

Re: W-related helper functions for our tests

2009-06-21 Thread Detlef Riekenberg
On Fr, 2009-06-19 at 12:44 +0200, Paul Vriens wrote: > I was wondering if it would make sense to introduce several helper > functions that could be used by all our tests. > > The main ones needed are the ones to cope with Win9x missing several > W-functions. > > Another one used quite often in

Re: Wine translation statistics sources

2009-06-21 Thread Detlef Riekenberg
On Sa, 2009-06-20 at 19:19 +0200, Alexandre Julliard wrote: > Mikołaj Zalewski writes: > > > It's online again. Having it on WineHQ would probably give a better > > uptime > > It's now online at http://source.winehq.org/transl/ and will be updated > every time there's a git push. Please let me

Re: advpack: Implement ExtractFilesW [try 2]

2009-06-19 Thread Detlef Riekenberg
On Do, 2009-06-11 at 15:04 -0700, James Hawkins wrote: > 2009/6/11 Vladimir Pankratov : > > Hello all. > > > > Implemented ExtractFilesW > > > > Changed files: > > advpack/files.c > You're converting A -> W -> A. > This happens because cabinet.Extract is (as far as we know) ansi-only. > In this

Re: shell32: update file type associations when requested

2009-06-12 Thread Detlef Riekenberg
On Do, 2009-06-11 at 20:52 +0200, Damjan Jovanovic wrote: > + > +if (wEventId & SHCNE_ASSOCCHANGED) > +{ > +TRACE("refreshing file type associations"); > +RefreshFileTypeAssociations(); > +} "\n" is missing in the TRACE. The helper function looks like an API call. Plea

Re: PATCH - enhance the help message in expand

2009-06-12 Thread Detlef Riekenberg
On Do, 2009-06-11 at 11:16 -0400, Steven Edwards wrote: > +"expand [-r] source destination\n" > +"expand -r source [destination]\n" > +"expand -D source.cab [-F:Files]\n" > +"expand source.cab -F:files destination\n" > +"\n" > +" -rRename expanded files.\n" > +

Re: opengl32: get rid of glext.h

2009-06-11 Thread Detlef Riekenberg
On Mi, 2009-06-10 at 21:56 +0200, Roderick Colenbrander wrote: > -#ifdef HAVE_GL_GLEXT_H > -# include > -#endif The same code is used in winex11.drv/opengl.c Can this also be removed? When that's the case, then "GL/glext.h" can be removed from AC_CHECK_HEADERS in configure.ac -- By by ... D

Re: kernel32/tests: Add tests for GetLocaleInfo with SUBLANG_NEUTRAL

2009-06-02 Thread Detlef Riekenberg
> This one introduces failures on NT4 and below and on some boxes with a > non-English locale. Argh .. > Could you have a look? Yes. Thanks for the fast report. -- By by ... Detlef

Re: PowerPC MacOSX work...

2009-05-26 Thread Detlef Riekenberg
On Mo, 2009-05-25 at 22:06 +0200, Stefan Dösinger wrote: > they won't work because WinPPC uses little endian while MacOS uses big > endian. > I am wondering > how that would be possible though, can PPCs switch modes? Yes, a PowerPC can switch endian. -- By by ... Detlef

Re: Entry point not found for GetDiskInfoA (wininet_crosstest.exe)

2009-05-22 Thread Detlef Riekenberg
On Do, 2009-05-21 at 12:05 +0200, Alexandre Julliard wrote: > > Using that executable on Windows or Wine is not possible > > (Entry point not found for GetDiskInfoA) > > > > The wininet_test.exe on winehq has an ordinal Import of 102 in that > > place. > > How can we fix that? > > You have to use

Entry point not found for GetDiskInfoA (wininet_crosstest.exe)

2009-05-20 Thread Detlef Riekenberg
In "dlls/wininet/tests/urlcache.c", GetDiskInfoA is called, but wininet.dll (native and wine) export this function only by ordinal. When I build the crosstest, my mingw [i586-mingw32msvc-gcc (GCC) 4.2.1-sjlj (mingw32-2)] creates a named Import for GetDiskInfoA with an ordinal hint of 65. Using

Re: [wintrust/tests] Add some basic CryptCATOpen tests

2009-05-18 Thread Detlef Riekenberg
On Mo, 2009-05-18 at 16:07 +0200, Paul Vriens wrote: > +hcat = pCryptCATOpen(emptyW, 0, 0, 0, 0); > +todo_wine > +{ > +ok(hcat != NULL && hcat != INVALID_HANDLE_VALUE, "Expected a > correct handle\n"); > +ok(GetLastError() == ERROR_SUCCESS, > + "Expected ERROR_SUCCESS, got

Re: winspool.drv: implement semi-stub of EnumJobsW

2009-05-18 Thread Detlef Riekenberg
On Mo, 2009-05-18 at 19:30 +0400, Vitaly Perov wrote: > --- > dlls/winspool.drv/info.c | 36 +++- > 1 files changed, 35 insertions(+), 1 deletions(-) The correct location for an implementation is localspl.dll For which Application did you changed the stub? The

Re: [1/4] ws2_32/tests: Resend: IPv6 tests for WSAAddressToStringA

2009-04-27 Thread Detlef Riekenberg
On Mo, 2009-04-27 at 20:48 +1000, Jeff Latimer wrote: > -ok( len == sizeof( expect4 ), "Got size %d\n", len); > +ok( len == sizeof( expect4 ), "Expected size to be %d, got %d\n", > sizeof( expect4 ), len); Do not use sizeof() in a test. > +/*check to see it IPv6 is available */ > +

Re: Reparse point unit tests patches

2009-04-26 Thread Detlef Riekenberg
On So, 2009-04-26 at 13:18 +1000, Paul TBBle Hampson wrote: > [PATCH 2/2] Add unit tests for junction points using reparse point interface > http://www.winehq.org/pipermail/wine-patches/2009-January/067227.html I didn't test the patches, but from the quick lock: The test must compile with the M

Re: Need help writing test

2009-04-25 Thread Detlef Riekenberg
Hi Igor > I've found few visual glitches in comctl32/toolbar, and now try to > write this all down as conformance tests, Thanks for your work on comctl32 > TB_SETBITMAPSIZE 20,20 > TB_SETBUTTONSIZE 30,30 > TB_SETBITMAPSIZE 10,10 > > Now, if you do TB_SETBUTTONSIZE, you'll see the difference. b

Re: Changing the language that wine runs in (testing language versions of dialogs)

2009-04-21 Thread Detlef Riekenberg
On Di, 2009-04-21 at 21:06 +0100, Reece Dunn wrote: > >> LANG=es_ES.UTF-8 ./wine winecfg > >> works for me. The language code is "es_ES" and not just "es". > That works. I have started a page on the wiki > (http://wiki.winehq.org/TestingLanguages) to document how to launch > Wine in the different

Re: dsound: Allow a special cbSize case in CreateSoundBuffer (updated)

2009-04-21 Thread Detlef Riekenberg
On Mo, 2009-04-20 at 21:51 -0700, Jesse Allen wrote: > In CreateSoundBuffer, some apps pass sizeof(WAVEFORMATEXTENSIBLE) for > the cbSize and we have to allow it, but only when the SubFormat is > KSDATAFORMAT_SUBTYPE_PCM. > > This updated patch is simpler... at the expense of being less clear ;) >

Re: Janitor: list.h functions defined but not used

2009-04-20 Thread Detlef Riekenberg
On Mo, 2009-04-20 at 10:01 +0200, Henri Verbeet wrote: > More specifically, you need to protect this with an #ifdef. > #ifdef __GNUC__ > #define __WINE_ATTR_UNUSED __attribute__((unused)) > #else > #define __WINE_ATTR_UNUSED > #endif Support for compiler specific features should be tested during

Re: [2/2] ntdll: Implement NtQueryInformationToken(TokenDefaultDacl).

2009-04-17 Thread Detlef Riekenberg
On Fr, 2009-04-17 at 12:53 +0200, Hans Leidekker wrote: > +Dacl = HeapAlloc(GetProcessHeap(), 0, Size); > +ret = GetTokenInformation(Token, TokenDefaultDacl, Dacl, Size, > &Size); > +ok(ret, "GetTokenInformation(TokenDefaultDacl) failed with error > %u\n", GetLastError()); > + > Cl

Re: Winprinfo tool

2009-04-16 Thread Detlef Riekenberg
On Mi, 2009-04-15 at 10:13 +0300, Saulius Krasuckas wrote: > I just have struck one tool related to Windows printer drivers [*]: > [*] http://unixwiz.net/tools/winprinfo.html Thanks for your Post. I know that tool, but i wrote my own API test tool before I found winprinfo. My tool allows me to c

Re: oleaut32: [Patch 1/2] VarCat must use localized names for VT_BOOL

2009-04-16 Thread Detlef Riekenberg
On Mi, 2009-04-15 at 13:37 +0200, Paul Vriens wrote: > The lstrcpyW and lstrcatW additions to init() in the tests don't work on > Win95. I guess that's where the new failures come from: I removed a "broken(hres == VARCMP_GT)", and that's what VarCmp on your w95 machine returned. My second Pat

Re: FYI -- Dragon Naturally Speaking running a bit better today.

2009-04-14 Thread Detlef Riekenberg
On Do, 2009-04-09 at 16:05 -0400, Susan Cragin wrote: > Dragon Naturally Speaking ... > the amount of time one can use it before it crashes crept up about 2 > minutes, ... > Today I dictated for about 14 minutes until it crashed. > That's progress. Susan, thanks a lot for your sedulous testing o

Re: [1/1]msctf/test: test Enableing and Disabling Language Profiles

2009-04-13 Thread Detlef Riekenberg
On Fr, 2009-04-10 at 07:55 -0500, Aric Stewart wrote: > +static void test_Disable(void) ... > +trace("Disabling\n"); ... > +ok(SUCCEEDED(hr),"Failed to enable text service\n"); With greetings from Copy & Paste -- By by ... Detlef

Re: SoC: DirectShow/Gstreamer

2009-04-09 Thread Detlef Riekenberg
On Di, 2009-03-17 at 15:56 +0100, Maarten Lankhorst wrote: > You will probably find graphedt.exe from the microsoft sdk useful, A GPL alternative exists, but does not work in Wine yet: http://blog.monogram.sk/janos/tools/monogram-graphstudio/ -- By by ... Detlef

Re: urlmon/misc test and the use of URLZONEREG_DEFAULT

2009-04-04 Thread Detlef Riekenberg
On Fr, 2009-04-03 at 20:49 +0200, Paul Vriens wrote: > >> urlmon:misc > >> misc.c:884: Test failed: (1400) policy=3, expected 0 > >> misc.c:884: Test failed: (1e05) policy=1, expected 2 > >> So the question is, does somebody now what URLZONEREG_DEFAULT defaults > >> to? HKCR or HKLM and i

Re: gdi32: don't compile printdtv16 on 64-bit

2009-04-01 Thread Detlef Riekenberg
On Di, 2009-03-24 at 22:19 -0500, Austin English wrote: > +@ stdcall -i386 WriteSpool16(long ptr long) You disable Printing in Wine with that. -- By by ... Detlef

Re: Implement [Un]RegisterHotKey with test

2009-03-31 Thread Detlef Riekenberg
On Mo, 2009-03-30 at 18:17 +0500, Vladimir Pankratov wrote: > +return DefWindowProcW (hWnd, msg, wParam, lParam); > +WCHAR className[] = {'T','e','s','t','H','o','t','K','e','y',0}; > +WCHAR winName[] = {'H','o','t','K','e','y','T','e','s','t',0}; > +ATOM classatom; > +WND

Re: mciqtz32: Implement driver messages

2009-03-30 Thread Detlef Riekenberg
On So, 2009-03-29 at 18:12 +0200, Christian Costa wrote: > That said, I don't understand then why we don't just convert wine's > code (in > several steps off course) and avoid troubles particularity switch from > one > style to another depending on the dll we are working on. Changing only the inde

Re: mciqtz32: Implement driver messages

2009-03-29 Thread Detlef Riekenberg
On So, 2009-03-29 at 12:50 +0200, Christian Costa wrote: > There are some discrepancies in the indentation and I don't mind > removing tabs but what's > wrong with them, they are commonly use in wine depending on one's > taste. Wine use 4 SPACE for indention. There is old code that use 2 or 3 SPA

Re: mciqtz32: Add basic play capability

2009-03-29 Thread Detlef Riekenberg
On Sa, 2009-03-28 at 16:36 +0100, Christian Costa wrote: > +hr = CoCreateInstance(&CLSID_FilterGraph, NULL, > CLSCTX_INPROC_SERVER, &IID_IGraphBuilder, (LPVOID*)&wma->pgraph); > +if (FAILED(hr)) { > +TRACE("Cannot create filtergraph (hr = %x)\n", hr); > + return MCIERR_INTERNA

  1   2   3   4   5   6   >