Re: winedump: Print the network share name in .lnk files.

2010-05-14 Thread Eric Pouech
-dwTotalSize)) me wonders if if (loc-dwNetworkVolTableOfs (loc-dwNetworkVolTableOfs + sizeof(NETWORK_VOLUME_INFO)loc-dwTotalSize)) wouldn't be better (same also would apply for test in old code above for dwVolTableOfs -- -- Eric Pouech

Re: RFC on console management

2010-05-10 Thread Eric Pouech
be able to get input from it the solutions - let A run until all of its children have died (tricky it we want to hide A from the windows process list) - have another program be the parent of all processes started from command line (and wineconsole could do the trick) A+ -- Eric Pouech

RFC on console management

2010-05-09 Thread Eric Pouech
convert properly the unix events to the windows one. I'd rather favor ScII, but the differences are not that big, so your comments are welcome. -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Compilation failure in wine-1.1.44

2010-05-08 Thread Eric Pouech
(except if gcc really optimizes things out, but wine now behaves as gcc, so you should be way less hindered by debugging with -O2 as you were) A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Minor dlls/dbghelp/dwarf.c simplification

2010-04-24 Thread Eric Pouech
); this is wrong: dwarf_parse family set makes the pointer in the cxt advance by the size of the object which is being parse and actually, the correct fix would be to make use of those variables (like checking if the version is a known one), instead of throwing things away A+ -- Eric Pouech The problem

Re: Francois Gouget : winedbg: Fix compilation with gcc 2. 95 and non-GNU compilers.

2010-04-21 Thread Eric Pouech
() would be to check the gcc version before trying to use __attribute__(). does the attached patch works better ? (I tried your suggestion starting at gcc 3.0) A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot

Re: [PATCH 4/6] [WineGcc]: when specifying -m32, force i386 cpu when compiling on x86_64 boxes

2010-04-20 Thread Eric Pouech
winegcc for linking either 32bit or 64bit execs (with the --sysroot switch) not use what you propose will help... it'll prevent an error later on in gcc (or ld), but if winegcc is passed directories with wrong libraries, it should, IMO, fail and not try to find the right lib A+ -- Eric Pouech

Re: Francois Gouget : winedbg: Fix compilation with gcc 2. 95 and non-GNU compilers.

2010-04-17 Thread Eric Pouech
dbg_vprintf which doesn't exist) does the attached patch work in your configuration ? A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams) diff --git a/programs/winedbg/db_disasm64.c b/programs/winedbg

Re: [PATCH 1/5] winmm: Improve MCI's Sysinfo command.

2010-04-01 Thread Eric Pouech
joerg-cyril.hoe...@t-systems.com a écrit : Hi, Eric Pouech wrote: did you test the 16 = 32 bit conversion for the MCI_ALL_DEVICE ? Which ones do you have in mind? There are tests involving MCI_ALL_DEVICE_ID that pass on both win9x and later (also in patch #5). I wrote a few more MCI

Re: [PATCH 1/5] winmm: Improve MCI's Sysinfo command.

2010-04-01 Thread Eric Pouech
joerg-cyril.hoe...@t-systems.com a écrit : Hi, Eric Pouech wrote: did you test the 16 = 32 bit conversion for the MCI_ALL_DEVICE ? It's good you asked. Upon closer inspection, MCI_Sysinfo appears to behave differently. I'd say it's even a bug in MS that setting

Re: winmm: For MCI parsing, use 64bit compatible structures.

2010-04-01 Thread Eric Pouech
joerg-cyril.hoe...@t-systems.com a écrit : Hi, Eric Pouech wrote: this patch is ugly as hell... Please qualify. To me, - data[3] = (DWORD_PTR)dev; + parms.open.lpstrElementName = dev; looks more robust than before: - no magic offsets, - no casts that may silence

Re: [PATCH 1/5] winmm: Improve MCI's Sysinfo command.

2010-03-29 Thread Eric Pouech
A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: winmm: For MCI parsing, use 64bit compatible structures.

2010-03-29 Thread Eric Pouech
on the Sysinfo patch from earlier today. Regards, Jörg Höhle this patch is ugly as hell... and it still believe we can do the MCI parser without knowing about MCI structures internals A+ -- Eric Pouech The problem

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-24 Thread Eric Pouech
Dmitry Timoshkov a écrit : Eric Pouech eric.pou...@orange.fr wrote: hmm sounds like most of the code we have in not in sync [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep %[0-9]*d | wc -l 8767 [eric:~/work/wine-git debug64|(none)]$ grep TRACE dlls/*/*.c | grep %[0-9

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-19 Thread Eric Pouech
Dmitry Timoshkov a écrit : Eric Pouech eric.pou...@orange.fr wrote: Can I ask again, why to jump through the hoops if all required information is already there in appropriate and ready to use/easy to understand format? because others users want information in decimal, as any

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-19 Thread Eric Pouech
values A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: inconsistencies in MCI headers w.r.t. to 64bit

2010-03-19 Thread Eric Pouech
/dd743409%28VS.85%29.aspx yet I refuse to believe it. I believe that all the MCI_XYZ_PARMS structures are consistent, so that a generic MCI string command parser is possible. That requires regular types. Eric Pouech wrote: http://www.winehq.org/pipermail/wine-devel/2010-February/081660.html

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-18 Thread Eric Pouech
Dmitry Timoshkov a écrit : Eric Pouech eric.pou...@orange.fr wrote: bt /x will do what you want. How will it help with all those backtraces generated and sent by users to bugzilla? Or those intermittent crashes which are very hard to reproduce? Is there any reason to spend

Re: [PATCH 04/16] [DbgHelp]: made the ELF mapping code easier to use

2010-03-16 Thread Eric Pouech
Alexandre Julliard a écrit : Eric Pouech eric.pou...@orange.fr writes: - now exporting the file mapping facility to the debug info loader which need it - allow to mark a section as to be kept (after debug info loading has been done) This breaks the non-ELF builds. where does

Re: [PATCH] [WineDbg]: allow to specify which format to be used for integers in backtraces

2010-03-16 Thread Eric Pouech
and ready to use/easy to understand format? if it's information sent by user (in any form), you can always write a small script to do the job (and also extend, message number, styles...) A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity

Re: [PATCH 2/2] kernel32: Implement CheckRemoteDebuggerPresent().

2010-03-05 Thread Eric Pouech
on NtQueryProcessInformation anyway. There's ProcessDebugObjectHandle, but it's not clear to me what kind of handle that actually returns. It's not a process handle at least. ProcessDebugPort would be preferred (any non zero value would do) A+ -- Eric Pouech The problem with designing something completely

Re: Understanding 64bit implications and wine64

2010-02-08 Thread Eric Pouech
pointers as DWORD_PTR A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: winedbg: output of the bt command misses sometimes a frame

2010-02-06 Thread Eric Pouech
in some cases) to disassembly the first bytes of the functions to guess the prolog size A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Windows-version dependent callback?

2010-01-28 Thread Eric Pouech
ensure that the difference in behavior does come from the OS version, not the driver (or soundcards) from different boxes A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: RFC: dwarf merge patch

2010-01-21 Thread Eric Pouech
André Hentschel a écrit : Eric Pouech schrieb: André Hentschel a écrit : Hi, I made a patch to merge code from ntdll/signal_x86_64.c to dbghelp/dwarf.c The operator DW_OP_deref_size needs to read different sizes of variables from memory into a fixed size variable. Now i am not sure

Re: RFC: dwarf merge patch

2010-01-20 Thread Eric Pouech
: stack[++stk] = *(DWORD64*)deref; break; } A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: dbghelp: merge dwarf code from ntdll/signal_x86_64.c

2010-01-11 Thread Eric Pouech
André Hentschel a écrit : Eric Pouech schrieb: André Hentschel a écrit : thanks Eric Pouech for the reviews --- dlls/dbghelp/dwarf.c | 229 +- dlls/dbghelp/dwarf.h | 15 2 files changed, 204 insertions(+), 40 deletions(-) diff

Re: dbghelp: merge dwarf code from ntdll/signal_x86_64.c

2010-01-10 Thread Eric Pouech
André Hentschel a écrit : thanks Eric Pouech for the reviews --- dlls/dbghelp/dwarf.c | 229 +- dlls/dbghelp/dwarf.h | 15 2 files changed, 204 insertions(+), 40 deletions(-) diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c index

Re: Is native dbghelp useful?

2010-01-02 Thread Eric Pouech
for most of the cases no, as it'll mean you won't get any debug information for the built-in modules so I don't think it's useful (except for testing dbghelp itself, but you don't need to add it to winetricks for that) A+ -- Eric Pouech The problem with designing something completely foolproof

Re: [rfc] initial conformance test for programs/cmd

2010-01-02 Thread Eric Pouech
decide, command by command, which input strings you send to cmd and how to interpret the final result out of the shell. the file approach you're currently using could be of course implemented on top of this first layer A+ -- Eric Pouech The problem with designing something completely foolproof

Re: msvcrt: add some demangle features

2009-12-28 Thread Eric Pouech
André Hentschel a écrit : Eric Pouech schrieb: André Hentschel a écrit : - +if (*sym-current == 'A') sym-current++; I don't understand how this would be necessary? Are you sure it's needed ? A+ There is also the possibility P for multidimensional arrays

Re: msvcrt: add some demangle features

2009-12-27 Thread Eric Pouech
André Hentschel a écrit : - +if (*sym-current == 'A') sym-current++; I don't understand how this would be necessary? Are you sure it's needed ? A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot

Re: Parser for cmd language?

2009-12-23 Thread Eric Pouech
(as a way to split in small patches) A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Conformance tess for cmd?

2009-12-19 Thread Eric Pouech
Dan Kegel a écrit : On Fri, Dec 18, 2009 at 11:50 PM, Eric Pouech eric.pou...@orange.fr wrote: If you want to control more closely commands vs output you can toy with http://github.com/ericZp/wdtp/blob/master/test_cl.h I would have thought that overkill for a batch mode program like

Re: Conformance tess for cmd?

2009-12-19 Thread Eric Pouech
What about redirecting io pipes and use CreateProcess ? msdn has some examples : http://msdn.microsoft.com/en-us/library/ms682499%28VS.85%29.aspx that's what test_cl.h does... A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity

Re: Parser for cmd language?

2009-12-18 Thread Eric Pouech
A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Conformance tess for cmd?

2009-12-18 Thread Eric Pouech
, using autohotkey pretty easily. If you want to control more closely commands vs output you can toy with http://github.com/ericZp/wdtp/blob/master/test_cl.h A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot

Re: Parser for cmd language?

2009-12-17 Thread Eric Pouech
is unmaintainable as it is A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Alexandre Julliard : user32: Add a thunking mechanism for 16-bit edit word break procedures.

2009-12-17 Thread Eric Pouech
Alexandre Julliard a écrit : Eric Pouech eric.pou...@orange.fr writes: Alexandre Julliard a écrit : Module: wine Branch: master Commit: dcec342b50524562844f64d43d423ed2c83c1f97 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dcec342b50524562844f64d43d423ed2c83c1f97 Author

Re: [dbghelp 1/2] Check for incorrectly set ClientPointers flag

2009-12-17 Thread Eric Pouech
Jason Green a écrit : I don't think it's a good idea to change the exception structure passed by the caller to the minidump creation it's better to hard wire the optimization in dump_exception_info A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate

Re: Alexandre Julliard : user32: Add a thunking mechanism for 16-bit edit word break procedures.

2009-12-14 Thread Eric Pouech
user32: Add a thunking mechanism for 16-bit edit word break procedures. Alexandre, shouldn't the thunk be released in EDIT_WM_NCDestroy upon EDITSTATE destruction ? A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete

Re: [PATCH 14/14] [WineDbg]: fix some casts issues on 64bit platform

2009-12-14 Thread Eric Pouech
Alexandre Julliard a écrit : Eric Pouech eric.pou...@orange.fr writes: diff --git a/programs/winedbg/dbg.y b/programs/winedbg/dbg.y index 855407f..7ed6307 100644 --- a/programs/winedbg/dbg.y +++ b/programs/winedbg/dbg.y @@ -281,9 +281,9 @@ info_command: | tINFO tCLASS

Re: [PATCH] [Server]: when getting the status of an exception, ensure the debugger continue information is not erased when releasing objects

2009-11-30 Thread Eric Pouech
Alexandre Julliard a écrit : Eric Pouech eric.pou...@orange.fr writes: diff --git a/server/debugger.c b/server/debugger.c index 795a24a..4458a3b 100644 --- a/server/debugger.c +++ b/server/debugger.c @@ -677,6 +677,8 @@ DECL_HANDLER(get_exception_status) if ((event = (struct

Re: ntdll: implement FLG_HEAP_ENABLE_TAIL_CHECK

2009-11-18 Thread Eric Pouech
is N, whereas you should repaint GN into ZG (zero of size(N), Guard) which may also explain lots of errors when running the tool A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: [PATCH 2/2] [Msvcrt]: in undname functions, no longer use a fixed-size array for storing internal information

2009-11-17 Thread Eric Pouech
Paul Vriens a écrit : On 11/15/2009 10:07 PM, Eric Pouech wrote: (fix for #20681) Hi Eric, This new test fails on all 32bit systems: http://test.winehq.org/data/tests/msvcrt:cpp.html The only box where there are no failures is a 64bit one, but no tests are actually run there ;) Could

Re: Where to receive MCI PostMessageW notifications?

2009-11-11 Thread Eric Pouech
(which means you must force MCI_NOTIFY flag with this window handle when sending a MCI command down to a driver) I wonder how native does when no message loop exists in the application (should be tested) (maybe peek for the notif message upon entrance of some of the MCI funcs ?) A+ -- Eric Pouech

Re: Question on using winedbg when program does not crash, just becomes unresponsive

2009-11-09 Thread Eric Pouech
so, finding another solution might be preferable what are the thread's missing information you were thinking of ? A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: [PATCH] winedbg: gdb proxy mode: support qAttached packet

2009-11-04 Thread Eric Pouech
pointer) A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Playing ULAW sample correctly?

2009-10-31 Thread Eric Pouech
on the fly the needed file) we already test some .exe this way in winetest A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: mciwave: need to serialize record and play

2009-10-31 Thread Eric Pouech
bugs). What do you think? BTW, please don't change mciwave now as I still have many patches in the queue. I'm lagging answering my email yes, actually, only one thread should be running in background, so what you suggest sounds fine A+ -- Eric Pouech The problem with designing something

Re: [PATCH 3/5] [WinMM]: allow 32-bit mciLoadCommandResource to load out of 16 bit module

2009-10-19 Thread Eric Pouech
Alexandre Julliard a écrit : Eric Pouech eric.pou...@orange.fr writes: @@ -1566,7 +1554,41 @@ UINT WINAPI mciLoadCommandResource(HINSTANCE hInst, LPCWSTR resNameW, UINT type) if (!(hRsrc = FindResourceW(hInst, resNameW, (LPWSTR)RT_RCDATA))) { WARN(No command table found

Re: Playing ULAW sample correctly?

2009-10-19 Thread Eric Pouech
/ how are the msacm/gsm711/gsm722/gsm602 tested? Does anybody know whether ULAW works in Wine? (Any app that uses it outside of MCI?) Thanks, Jörg Höhle IIRC, I never tested µ-law wave file, so it may well be that the ACM converter is broken A+ -- Eric Pouech The problem with designing

Re: question about concurrent access to resources

2009-10-02 Thread Eric Pouech
requires some testing A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: [Bug 19523] winmm: Multiple waveOutOpen calls on single device supported by Windows, not Wine

2009-09-19 Thread Eric Pouech
of it) A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: msvcrt: dont overwrite the standard streams (with test, try 5)

2009-09-07 Thread Eric Pouech
André Hentschel a écrit : Eric Pouech schrieb: Hi André a couple of comments to your patch always welcome! IMO, we should also test that cbReserved2 is = sizeof(unsigned) otherwise we'd be in trouble maybe you had something like that patch in mind: http://www.winehq.org

Re: msvcrt: dont overwrite the standard streams (with test, try 5)

2009-09-06 Thread Eric Pouech
. instead of doing this +while (MsgWaitForMultipleObjects( 1, proc.hProcess, FALSE, INFINITE, QS_ALLINPUT ) != 0) +{ +while (PeekMessage(msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(msg); +} you could simply wait for the child process to terminate A+ -- Eric Pouech The problem

Re: [PATCH] [Msvcrt]: fixing errno handling in strtol and strtoul (#18151)

2009-08-31 Thread Eric Pouech
You can't simply use long here, you need to handle the difference in the size of long between Win32 and Unix. but that's what we currently do ! A+ -- Eric Pouech

Re: mapi32/tests: Skip tests if no default email client is installed

2009-08-25 Thread Eric Pouech
+static BOOL HaveDefaultMailClient() this should be +static BOOL HaveDefaultMailClient(void) A+ -- Eric Pouech

Re: Build failure on current git

2009-08-24 Thread Eric Pouech
to stop for tonight, more on this tomorrow A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: ws2_32(6/8): Implement ws_sockaddr_u2ws for AF_IRDA (try 2)

2009-08-11 Thread Eric Pouech
Juan Lang a écrit : Uses %u rather than %d, based on Henri's feedback. --Juan Hi Juan don't you miss a break statement (or a more likely a return 0) at the end of the block ? A+ -- Eric Pouech The problem

Re: Is there any way to debug driver?

2009-06-22 Thread Eric Pouech
break your_func_in_dri_driver Wine-dbg cont TIA -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: winhlp32: Avoid duplicate assignment in WINHELP_GetWindowInfo(). (RESEND)

2009-05-25 Thread Eric Pouech
; -mwi.sr_color = mwi.sr_color = 0xFF; +mwi.sr_color = 0xFF; } return mwi; } fix is wrong the second should be nr_color instead of sr_color (hence the double assignment) A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate

Re: winedbg and exceptions

2009-05-05 Thread Eric Pouech
to filter out some exceptions and some other ones however, this may work: try the following commands (before run) set $BreakOnFirstChance=0 run and see what gives A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot

Re: winedbg: Accept a 3rd parameter to --auto to be used as extra info in the crash dialog

2009-04-29 Thread Eric Pouech
. this is not necessary to pass the information to winedbg, everything's needed is accessible from winedbg see tgt_active.c / dbg_handle_exception A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

strange git object

2009-03-29 Thread Eric Pouech
while updating my git tree, I ran (actually not finished downloading) this pack: Resuming fetch of pack 119463f192a563f17ac18ff9b717fbe57199eed7 at byte 95266539 which size looks quite enormous to me... any idea of what's going on ? A+ -- Eric Pouech The problem with designing something

Re: Dwarf2 - support e0 ie DW_OP_lo_user

2009-03-28 Thread Eric Pouech
case in dwarf2_parse_variable (for the DW_AT_location case) by simply doing nothing the correct long term fix is to implement TLS based variable addressing in the parser A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete

Re: Dead code in winedbg

2009-01-21 Thread Eric Pouech
2009/1/15 Francois Gouget fgou...@free.fr On Wed, 14 Jan 2009, Eric Pouech wrote: Francois Gouget a écrit : Hi, I have noticed that expr_alloc_uconstant() is unused in winedbg. Is that normal? the main point is that the lexer only returns signed integers, while it should

Re: Dead code in winedbg

2009-01-14 Thread Eric Pouech
unsigned:s from 0x8000 up to 0xf (which current code doesn't) the proper fix would be to fix the lexer to return both signed and unsigned integers for example: WineDbg p 0x8000 -2147483648 while it should be 2147483648 A+ -- Eric Pouech The problem with designing something completely

Re: Commit stats

2009-01-01 Thread Eric Pouech
234 in year: 2008 of course, this doesn't take into account the different names used by the same person (ie there is for example a frangois gouget in the committers' list...) but this gives a good idea of the variation A+ -- Eric Pouech The problem with designing something completely foolproof

Re: Compiling dbghelp with MinGW

2008-12-21 Thread Eric Pouech
Francois Gouget a écrit : On Sat, 13 Dec 2008, Eric Pouech wrote: [...] 1) #ifdef-out regexp support if regex.h is missing? Maybe with an autoconf check for regcomp()? 2) Add some reg*() stubs that do nothing if regex.h co are missing? [...] 1,2) most of the dbghelp

Re: Compiling dbghelp with MinGW

2008-12-13 Thread Eric Pouech
http://sourceforge.net/project/showfiles.php?group_id=2435package_id=73286release_id=140957 we could be a bit more verbose in mingw configuration for this case A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot

Re: Wine release 1.1.9

2008-11-22 Thread Eric Pouech
, but it's not their main use, as demonstrated by the number of failures and todos we currently have. So I'll continue to call them regression tests, if you don't mind ;-) actually, *non* regression tests would be more appropriate... g A+ -- Eric Pouech The problem with designing something completely

Re: uninitialized reference in wineconsole in call to WriteConsoleInput?

2008-11-16 Thread Eric Pouech
fnWCUSER_GenerateMouseInputRecord/fn dirprograms/wineconsole/dir fileuser.c/file line1066/line /frame /stack /origin -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Detecting Wine

2008-09-30 Thread Eric Pouech
, and the full-disk search provides a nicer user experience if they're upgrading from an ancient copy of the software. Under Wine, I need to either skip the full-disk search, or warn the user that it may take several hours. -- Mark -- -- Eric Pouech

Re: [PATCH] [WinHelp]: fix for 5314

2008-09-21 Thread Eric Pouech
Dmitry Timoshkov a écrit : From: Eric Pouech [EMAIL PROTECTED] wrote: +#include ctype.h ... +if (!ch || !isalpha(ch)) break; Since that's apparently a Windows encoding shouldn't this be GetStringType() instead of isalpha()? no, the issue (here

Re: Taking advantage of debug libraries

2008-09-18 Thread Eric Pouech
through the _NT_SYMBOL_PATH environment variable - under gdb: no, unless you use the winedbg's gdb remote stub (and the _NT_SYMBOL_PATH must also be correctly set) A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot

Re: Fixed an infite loop in winedbg: review wanted

2008-09-10 Thread Eric Pouech
lines) A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Debugging Wine thoughts

2008-09-10 Thread Eric Pouech
://www.winehq.org/site/docs/winedev-guide/dbg-others isn't fully uptodate A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Alexander Nicolaysen Sørnes : regedit: Con vert printinghelp to unicode.

2008-08-20 Thread Eric Pouech
ID_REGISTRY_DISCONNECTNETWORKREGISTRY: break; case ID_REGISTRY_PRINT: -PrintRegistryHive(hWnd, _T()); +{ +const WCHAR empty = 0; +PrintRegistryHive(hWnd, empty); break; +} this looks very wrong to me -- Eric Pouech The problem with designing

Re: crypt32(4/7): Add tests for CMSG_CMS_SIGNER_INFO_PARAM

2008-08-20 Thread Eric Pouech
); +} +CryptMsgClose(msg); } static void test_decode_msg(void) -- 1.5.2.2 -- 1.5.2.2 -- Eric Pouech The problem with designing something

Re: Alexander Nicolaysen Sørnes : regedit: Con vert printinghelp to unicode.

2008-08-20 Thread Eric Pouech
Alexander Nicolaysen Sørnes a écrit : På Onsdag 20 august 2008 , 19:30:44 skrev Eric Pouech: Alexandre Julliard a écrit : Module: wine Branch: master Commit: 5cb8bccf462790338677dac3bfb394df8f4da020 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5cb8bccf462790338677dac

Re: winmm: Test opening the same device twice

2008-08-19 Thread Eric Pouech
several opening including the mixing of the two streams if the driver doesn't provide this flexibility, I don't see a point of implementing it in Wine A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas

Re: Patch feedback

2008-07-06 Thread Eric Pouech
should be moved to unicode first then your patch will be relatively straightforward A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: dbghelp: Fix stabs_pts_read_type_def() for when typename is NULL

2008-06-22 Thread Eric Pouech
that you get a null typename here can you send me the DLL/.so file on which you get the seg fault A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: dbghelp: Fix stabs_pts_read_type_def() for when typename is NULL

2008-06-22 Thread Eric Pouech
Andrew Talbot a écrit : Eric Pouech wrote: looks like a bit strange to me that you get a null typename here can you send me the DLL/.so file on which you get the seg fault A+ No known segfaults; I'm just doing static analysis. But stabs_pts_read_type_def() is called several

Re: dbghelp: Implement SymEnumerateSymbols64

2008-06-19 Thread Eric Pouech
ptr ptr) -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Development plans

2008-06-18 Thread Eric Pouech
of code), or do you plan to handle yourself the task of retrofit ? A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: winedbg: Add support for printing c++ bool values

2008-06-12 Thread Eric Pouech
Jon Griffiths a écrit : Hi, Subject says it all. +dbg_printf(%s, val_int ? true : false); what about the simpler: +dbg_printf(val_int ? true : false); A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity

Re: winedbg: Fix 'winedbg --auto' so it does just one backtrace.

2008-06-02 Thread Eric Pouech
better to have two backtraces than none. can you reproduce those cases ? it may be even better to fix those cases instead of having two backtraces g A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas

Re: How long does it take you to compile wine?

2008-06-01 Thread Eric Pouech
30minutes... now I barely wait... 6mn26s make -j5, Q6600 @ 2.4GHz gcc version also matters (4.2.3 for me) A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: How long does it take you to compile wine?

2008-06-01 Thread Eric Pouech
I'm using same version. What graphics card, btw? ATI Radeon HD 2600 XT A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: richedit: empty text should result in a scroll range of 0. Tests for this behavior.

2008-05-13 Thread Eric Pouech
A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: [PATCH] [cmd]: use correct codepage when outputing unicode text to an ANSI stream

2008-05-13 Thread Eric Pouech
Vitaliy Margolen a écrit : Eric Pouech wrote: @@ -1437,7 +1437,7 @@ static void WCMD_output_asis_len(const WCHAR *message, int len, HANDLE device) { } /* Convert to OEM, then output */ -convertedChars = WideCharToMultiByte(GetConsoleOutputCP(), 0, message

Re: [PATCH] fixed if check before strchr

2008-05-06 Thread Eric Pouech
, '/'); +if (spath) spath = strchr(spath, '/'); if (!spath) break; spath++; found = SearchPathA(dbg_curr_process-search_path, spath, NULL, MAX_PATH, path, NULL); actually no the code intends to find the first occurence of / or \ A+ -- Eric

Re: kernel32: Implementation of GetLargestConsoleWindowSize.

2008-05-02 Thread Eric Pouech
in return from server calls - where do the 2 (resp 3) factors come from ? A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: Switching threads in winedbg

2008-04-30 Thread Eric Pouech
and threads in the system as of today, you cannot switch to another thread A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: msvcrt: Remove two tests that fail on all platforms

2008-04-27 Thread Eric Pouech
send a corrected test however, the second seems ok (except some space difference) can you post the failing test information ? A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Call for testers

2008-04-24 Thread Eric Pouech
.hlp files The new rendering is turned on by setting the env variable WINHELP_RICHEDIT to 1 A+ -- Eric Pouech The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot. (Douglas Adams)

Re: [PATCH 01/21] [WinHelp]: get rid of the reuse concept for Windows and refactor the code a bit for window creation / deletion

2008-04-22 Thread Eric Pouech
Alexandre Julliard a écrit : Eric Pouech [EMAIL PROTECTED] writes: programs/winhelp/winhelp.c | 257 1 files changed, 116 insertions(+), 141 deletions(-) This breaks window repaints for me, when switching pages the window

Re: [PATCH] [WinHelp]: fix regression introduced by Dmitry's Win64 warning fixes

2008-04-16 Thread Eric Pouech
] -- -- Eric Pouech

<    1   2   3   4   5   6   7   8   >