Re: dlls/winedos/int21.c -- type adjustments

2007-11-22 Thread Gerald Pfeifer
On Thu, 22 Nov 2007, Dmitry Timoshkov wrote: It wouldn't take more than 30 additional seconds to look up the SetFilePointer prototype in include/ and use real type instead. Which I had done -- except that I apparently lost that update when creating the patch a couple of weeks ago. My bad.

Re: Remove four useless checks in dlls/gdi32/enhmetafile.c (RESEND)

2007-11-19 Thread Gerald Pfeifer
On Mon, 19 Nov 2007, Alexandre Julliard wrote: The members of EMRCREATEDIBPATTERNBRUSHPT are of type DWORD, so comparing them for = 0 is a noop which always evaluates to true. Gerald ChangeLog: Remove four unnecessary comparisions of DWORD variables for = 0. Validating the record is not

Re: taskmgr/perfpage.c simplification (RESEND)

2007-11-15 Thread Gerald Pfeifer
On Thu, 15 Nov 2007, Alexandre Julliard wrote: CpuUsage and CpuKernelUsage are of type ULONG, so it does not make sense checking whether they are less than 0. The checks should most likely done in PerfDataGetProcessorUsage before converting to ULONG. Fair enough. I wasn't sure we want to

Re: dlls/msi/string.c -- fix use of signed versus unsigned (RESEND)

2007-11-15 Thread Gerald Pfeifer
On Thu, 15 Nov 2007, James Hawkins wrote: ChangeLog: Fix use of signed versus unsigned variables. This change is unnecessarily complicated. How do you propose to address the following? string.c: In function 'msi_addstring': string.c:208: warning: comparison between signed and unsigned

Re: dlls/msi/string.c -- fix use of signed versus unsigned (RESEND)

2007-11-15 Thread Gerald Pfeifer
On Thu, 15 Nov 2007, James Hawkins wrote: I don't see how silencing warnings catches any regression. With default options older versions of GCC currently issue two warnings for all of Wine, so any warning regression immediately jumps out for analysis to see whether it is a real regression. If

Re: Bugs in dlls/wsock32/socket.c

2007-11-08 Thread Gerald Pfeifer
On Sun, 4 Nov 2007, Juan Lang wrote: Heh - no, that's not the intended purpose ;) I'll send a patch. Cool, thanks a bunch! :-) Gerald

Re: dlls/comctl32/listview.c warning elimination

2007-11-04 Thread Gerald Pfeifer
On Mon, 29 Oct 2007, Alexandre Julliard wrote: Not a patch I am particularily proud of, but the best way I found to get rid of listview.c:5043: warning: 'strW' might be used uninitialized in this function issued by GCC, and apart from the added cast it actually is simpler than the

Bugs in dlls/wsock32/socket.c

2007-11-03 Thread Gerald Pfeifer
dlls/wsock32/socket.c has the following code: DWORD routeTableSize, numRoutes, ndx, ret; numRoutes = min(routeTableSize - sizeof(MIB_IPFORWARDTABLE), 0) / sizeof(MIB_IPFORWARDROW) + 1; The problem here is that both routeTableSize and sizeof(...) are of an unsigned type,

Re: dlls/msi/streams.c -- simplify and constify

2007-11-03 Thread Gerald Pfeifer
On Sat, 3 Nov 2007, James Hawkins wrote: This change is wrong. If you'd actually read what the code intended to do instead of just fixing warnings, you'd see that add_streams_to_table returns -1 on error. That's what I am actually doing -- trying to read the code, including all invocations

Re: Fix type of loop variable in alloc_device().

2007-11-02 Thread Gerald Pfeifer
On Fri, 2 Nov 2007, Vitaliy Margolen wrote: We iterate between 0 and and the value of an usigned variable, so we should adjust the loop variable accordingly (not the list to silence GCC). -int i; +unsigned i; If there is nothing wrong about it, then why do you change it? If even gcc

Re: Bug in dlls/oleaut32/tests/vartype.c?

2007-11-01 Thread Gerald Pfeifer
[ Updated patch at the end, Alexandre. ] On Mon, 29 Oct 2007, Alex Villací­s Lasso wrote: Sorry to object, but which version of exactly which compiler optimizes away the negative sign? You're right, I misread this, sorry. My original patch wasn't wrong, but the explanation was, and there

Dead code in dlls/ntdll/tape.c

2007-11-01 Thread Gerald Pfeifer
We currently have the following code in tape.c: if (data-Offset.u.LowPart = 0) { cmd.mt_op = MTFSF; cmd.mt_count = data-Offset.u.LowPart; } else { cmd.mt_op = MTBSF; cmd.mt_count = -data-Offset.u.LowPart; } data is

Re: tools/widl/typegen.c pointer initialization

2007-10-30 Thread Gerald Pfeifer
On Mon, 29 Oct 2007, Dan Hipschman wrote: Compiling with -O2 -W -Wall using either gcc 4.0 or 3.4 I don't get any warnings. Even adding -Wuninitialized doesn't do anything: I am mostly using GCC 3.4 with -O2 -Wall as you did, and occasionally a snapshot of GCC 4.3, with and without -Wextra in

Re: tools/widl/typegen.c pointer initialization

2007-10-29 Thread Gerald Pfeifer
On Sun, 28 Oct 2007, Dan Hipschman wrote: The logic is as follows: Thanks for the explanation, Dan! Better than this would be to put assert(is_user_type(type)); above the initializations to convince the programmer at least that name will get initialized correctly in get_user_type. If that

Re: Bug in dlls/oleaut32/tests/vartype.c?

2007-10-29 Thread Gerald Pfeifer
On Mon, 15 Oct 2007, Gerald Pfeifer wrote: dlls/oleaut32/tests/vartype.c has the following snippet of code: + f = -1e-400;/* deliberately cause underflow */ + hres = pVarBstrFromR4(f, lcid, 0, bstr); + ok(hres == S_OK, got hres 0x%08lx\n, hres); + if (bstr

Re: dlls/rpcrt4/rpc_server.c initiale variable

2007-10-24 Thread Gerald Pfeifer
On Wed, 24 Oct 2007, Robert Shearman wrote: It's a false positive, probably coming from the compiler not picking up that it is set when the exception variable is false and that when exception is true it is set earlier in the function. Ah, thanks for the analysis. I couldn't convince myself

Re: libs/wine/mmap.c: conditionally provide reserve_area()

2007-10-15 Thread Gerald Pfeifer
On Sun, 14 Oct 2007, Vitaliy Margolen wrote: In this and all of your patches, please diff from the top of the tree. The above line should say +++libs/wine/mmap.c. And it would be even better if you can use GIT instead of cvs. Thanks for the feedback. I'll certainly try to keep the former in

Re: Fix casts in dlls/crypt32/decode.c

2007-10-15 Thread Gerald Pfeifer
Thanks for all your feedback! On Mon, 15 Oct 2007, Dmitry Timoshkov wrote: Your fix still won't work for a 64-bit target. You would need to use ULONG_PTR cast for that. 'if (!HIWORD(lpszStructType))' line also doesn't look right in the 64-bit case. The latter is left unchanged and I'll leave

Bug in dlls/oleaut32/tests/vartype.c?

2007-10-15 Thread Gerald Pfeifer
dlls/oleaut32/tests/vartype.c has the following snippet of code: + f = -1e-400;/* deliberately cause underflow */ + hres = pVarBstrFromR4(f, lcid, 0, bstr); + ok(hres == S_OK, got hres 0x%08lx\n, hres); + if (bstr) + { +todo_wine ok(memcmp(bstr, szZero, sizeof(szZero)) ==

Re: Have `make distclean` also remove .i and .s files

2007-10-15 Thread Gerald Pfeifer
On Mon, 15 Oct 2007, Alexandre Julliard wrote: After using GCC's -save-temps option to debug something, I noticed that `make distclean` fails to actually remove .i and .s files. It would be, but I don't think we want make clean to remove all possible output files from all possible tools. I

Re: Wine on FreeBSD (Was: Re: How to determine if something is debuggable ... ?)

2007-06-03 Thread Gerald Pfeifer
On Sat, 2 Jun 2007, Marc G. Fournier wrote: Just built 0.9.38 under FreeBSD, and it doesn't even run :( Never a good sign ... but explains why the port is 2 releases old ... I debugged this a bit, and believe the change that broke FreeBSD is revision 1.82 of dlls/ntdll/thread.c and related

New dlls/crypt32/tests/cert.c breakage

2007-01-13 Thread Gerald Pfeifer
The following change to dlls/crypt32/cert.c revision 1.36 date: 2007-01-12 20:56:12 +0100; author: julliard; state: Exp; lines: +56 -57 Paul Vriens [EMAIL PROTECTED] crypt32/tests: Cast-qual warning fixes. breaks the bootstrap on some of my systems. Specifically, it added a new

dlls/mshtml/tests/htmldoc.c breakage

2007-01-13 Thread Gerald Pfeifer
The following change to dlls/mshtml/tests/htmldoc.c date: 2007-01-12 19:56:11 +; author: julliard; state: Exp; lines: +2 -1 Paul Vriens [EMAIL PROTECTED] mshtml/tests: Cast-qual warning fix. breaks the build with GCC 3.4: /usr/bin/gcc -c -I. -I. -I../../../include

dlls/advapi32/lsa.c warning regression

2006-10-21 Thread Gerald Pfeifer
The following change to dlls/advapi32/lsa.c revision 1.16 date: 2006-10-20 13:02:57 +; author: julliard; state: Exp; lines: +40 -32 Eric Pouech [EMAIL PROTECTED] advapi32: Plug a couple of memory leaks. causes the following new warning: lsa.c:64: warning: 'ptr' might be used

Re: Freetype configure checks are backward

2006-07-25 Thread Gerald Pfeifer
Mike, I just saw your change to Wine's configure scripts to implement a change along the lines I raised below. Thank you very much!! Gerald On Fri, 2 Jun 2006, Gerald Pfeifer wrote: I believe the Freetype configure checks are backward. First we check for the library being present, and only

New dlls/ddraw/device.c warnings

2006-06-27 Thread Gerald Pfeifer
After the recent sets of changes, I found that GCC 3.4 issues the following warnings (on FreeBSD 5.4. I checked and depending on how a compiler implements assert(), the warnings are valid, insofar as the compiler doesn't have a way to automatically determine that all code paths are covered:

Duplicate message by configure

2006-06-14 Thread Gerald Pfeifer
Disclaimer: I am aware that the system I tested this on is lacking a required library, this is not what I'm trying to describe. When running configure, I get the following message twice: checking for xmlParseMemory in -lxml2... yes checking for xmlReadMemory in -lxml2... yes Package

Freetype configure checks are backward

2006-06-02 Thread Gerald Pfeifer
I believe the Freetype configure checks are backward. First we check for the library being present, and only then do we check for the freetype-config problem: AC_SUBST(FREETYPELIBS,) AC_SUBST(FREETYPEINCL,) AC_CHECK_LIB(freetype,FT_Init_FreeType,ft_lib=yes,ft_lib=no,$X_LIBS) if test

Re: undefined reference to `GetCharABCWidthsI'

2006-04-22 Thread Gerald Pfeifer
On Fri, 21 Apr 2006, Jeff Latimer wrote: Gerald, sorry about this. I notice that Alexandre has patched this as there is a cunning #ifdef HAVE_FREETYPE in freetype.c that I did not notice. Thanks for the info. Last night's automated builds now went fine again, both on FreeBSD 5.4 and SUSE

undefined reference to `GetCharABCWidthsI'

2006-04-20 Thread Gerald Pfeifer
After the following change to dlls/gdi/font.c revision 1.32 date: 2006-04-19 18:16:36 +; author: julliard; state: Exp; lines: +49 -0 Jeff Latimer [EMAIL PROTECTED] gdi: Added implementation of GetCharABCWidthsI. I now get the following build error on FreeBSD 5.4:

Re: Change threading defaults on FreeBSD

2006-04-14 Thread Gerald Pfeifer
On Fri, 14 Apr 2006, Alexandre Julliard wrote: On FreeBSD, build wine-pthread in addition to wine-kthread and make the former the default. If you build both, then you need a way to decide which one will be used. That's not the sort of detail we want to have users worry about. Well, but isn't

dlls/d3d9/volume.c regression

2006-04-08 Thread Gerald Pfeifer
The following patch revision 1.20 date: 2006-04-07 15:06:58 +0200; author: julliard; state: Exp; lines: +1 -1 Stefan Dösinger [EMAIL PROTECTED] wined3d: Add WINED3DBOX to wined3d_types.h. has one, and only one, effect as far as I can tell: it adds a new compiler warning volume.c:

Re: GL_STENCIL-related build failures in dlls/wined3d/device.c

2006-03-11 Thread Gerald Pfeifer
I've seen half a dozen or more changes to dlls/wined3d/device.c since that message of mine, but appare On Sun, 5 Mar 2006, Gerald Pfeifer wrote: The recent changes to dlls/wined3d/device.c cause the following build failures for me on FreeBSD 5.4, though I assume this is in fact not related

GL_STENCIL-related build failures in dlls/wined3d/device.c

2006-03-05 Thread Gerald Pfeifer
The recent changes to dlls/wined3d/device.c cause the following build failures for me on FreeBSD 5.4, though I assume this is in fact not related to FreeBSD but to xorg 6.8.2 or libglut 6.4.1 on this system. device.c: In function `IWineD3DDeviceImpl_SetRenderState': device.c:3776: error:

Re: libxml2 use in Wine?

2006-02-28 Thread Gerald Pfeifer
On Tue, 28 Feb 2006, Raphael wrote: Yes wine use libxml2 for msxml implementation (see dlls/msxml3/Makefile.in) but autoconf/automake check it Thanks for this information. Alexandre, patch for you below. ;-) Gerald ChangeLog: Fix spelling Red Hat. Remove unneeded references to Debian and

Fix for server/change.c breakage (and request for help)

2006-02-04 Thread Gerald Pfeifer
The following change to server/change.c revision 1.32 date: 2006-01-30 18:46:00 +; author: julliard; state: Exp; lines: +223 -15 Mike McCormack [EMAIL PROTECTED] server: Initial inotify support. broke (all?) systems without pnotify support: The second set of errors is addressed

Re: dlls/ntdll/tape.c portability

2006-02-04 Thread Gerald Pfeifer
On Sat, 4 Feb 2006, Alexandre Julliard wrote: ChangeLog: Take into account that FreeBSD and others have MTSETBSIZ instead of MTSETBLK and that struct mt_blksiz is laid out somewhat differently. Please add configure checks instead of #ifdef __FreeBSD__. I considered that, but am not really

Re: dlls/ntdll/tape.c portability

2006-02-04 Thread Gerald Pfeifer
On Sat, 4 Feb 2006, Alexandre Julliard wrote: Please add configure checks instead of #ifdef __FreeBSD__. Like so? Tested on SUSE Linux 10.0 and FreeBSD 4.10. Gerald ChangeLog: Use struct mtget.mt_blksiz on systems featuring this. Work around using struct mtget.mt_gstat on systems lacking

dlls/shell32/shfldr_unixfs.c breaks non-GNU/Linux platforms

2006-02-01 Thread Gerald Pfeifer
The following patches to dlls/shell32/shfldr_unixfs.c break FreeBSD and other non-GNU platforms: revision 1.70 date: 2006-01-31 17:24:37 +; author: julliard; state: Exp; lines: +1 -1 Michael Jung [EMAIL PROTECTED] unixfs: Only append '/' to base path if not already present in

New, flex-related warnings

2006-01-05 Thread Gerald Pfeifer
Using flex 2.5.4 and GCC 3.4, I started getting the following new warnings for my Wine builds about two days ago (which I never got before): ./ppl.l:176:1: warning: YY_NO_UNPUT redefined ./ppl.l:129:1: warning: this is the location of the previous definition ./parser.l:57:1: warning:

Re: PATCH: dlls/winsock/socket.h portability fix

2005-11-21 Thread Gerald Pfeifer
On Mon, 21 Nov 2005, Alexandre Julliard wrote: ChangeLog: On some systems like FreeBSD, EAI_NODATA is defined in lwres/netdb.h, so include this if present. Why isn't it in netdb.h? On recent version of FreeBSD (5.3 and later, which are required to run Wine), /usr/include/netdb.h has the

Re: PATCH: dlls/winsock/socket.h portability fix

2005-11-21 Thread Gerald Pfeifer
On Mon, 21 Nov 2005, Alexandre Julliard wrote: I did some archeology, and for earlier versions of FreeBSD the definition in netdb.h indeed was used, and in fact the reference to EAI_NODATA under /usr/include. If it's being obsoleted then we should probably just #ifdef it out. On recent

Today's release fails to build for me

2005-08-31 Thread Gerald Pfeifer
...with the following error (FreeBSD 5.4): /usr/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o add.o add.c In file included from add.c:39:

The recent include/wine/wined3d_types.h changes

2005-08-26 Thread Gerald Pfeifer
The following patch to include/wine/wined3d_types.h revision 1.8 date: 2005/08/23 09:34:57; author: julliard; state: Exp; lines: +2 -2 Oliver Stieber [EMAIL PROTECTED] Tidy up d3d9 and finalize passing d3d9 calls to wined3d for now. @@ -401,7 +401,7 @@ typedef struct

dlls/wined3d/drawprim.c warnings

2005-07-22 Thread Gerald Pfeifer
I'm currently seeing the following, new warnings for dlls/wined3d/drawprim.c: drawprim.c: In function `primitiveConvertToStridedData': drawprim.c:540: warning: unused variable `canDoViaGLPointers' drawprim.c: At top level: drawprim.c:702: warning: `draw_vertex' defined but not used The

Re: wine/dlls/mscms build failures

2005-07-19 Thread Gerald Pfeifer
On Mon, 18 Jul 2005, Hans Leidekker wrote: You have the lcms headers but somehow linking against lcms fails on your system. Can you find out why? Jacek had traced this problem to a 64-bit version of lcms on his system. I found that on that test system lcms was installed in /usr/local:

wine/dlls/mscms build failures

2005-07-18 Thread Gerald Pfeifer
I started getting the following failures about two days ago: ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./mscms.spec handle.o icc.o mscms_main.o profile.o stub.o transform.o mscms.dll.dbg.o version.res -o mscms.dll.so -L../../dlls -L../../dlls/kernel32

Re: dlls/ntdll/cdrom.c breakage

2005-07-08 Thread Gerald Pfeifer
On Fri, 1 Jul 2005, Dmitry Timoshkov wrote: This means that HAVE_SCSIREQ_T_CMD is not defined for you, i.e. scsireq_t has not been detected. Very likely this is caused by a wrong/missing header I found that FreeBSD does not have this type defined anywhere Any idea why it was in the '#elif

Re: dlls/ntdll/cdrom.c breakage

2005-06-30 Thread Gerald Pfeifer
On Thu, 30 Jun 2005, Dmitry Timoshkov wrote: Alexandre, please find below another patch which does not fix this either, but gets rid of some unused variable warnings. ChangeLog: Avoid unused variable warnings in CDROM_ScsiPassThroughDir() and CDROM_ScsiPassThrough(). This means that

Re: dlls/ntdll/cdrom.c breakage

2005-06-30 Thread Gerald Pfeifer
On Thu, 30 Jun 2005, Dmitry Timoshkov wrote: cdrom.c: In function `CDROM_ScsiPassThroughDirect': drom.c:1423: error: invalid application of `sizeof' to an incomplete type cdrom.c: In function `CDROM_ScsiPassThrough': cdrom.c:1543: error: invalid application of `sizeof' to an incomplete

Re: dlls/ntdll/cdrom.c breakage

2005-06-29 Thread Gerald Pfeifer
On Wed, 29 Jun 2005, Dmitry Timoshkov wrote: breaks on FreeBSD cdrom.c: In function `CDROM_ScsiPassThroughDirect': cdrom.c:1419: error: invalid application of `sizeof' to an incomplete type cdrom.c:1411: warning: unused variable `io' cdrom.c: In function `CDROM_ScsiPassThrough':

dlls/ntdll/cdrom.c breakage

2005-06-28 Thread Gerald Pfeifer
The following change to dlls/ntdll/cdrom.c revision 1.57 date: 2005/06/27 12:07:49; author: julliard; state: Exp; lines: +13 -19 Dmitry Timoshkov [EMAIL PROTECTED] Add a check for sg_io_hdr_t and (not tested) check for scsireq_t presence. breaks on FreeBSD cdrom.c: In function

dlls/shell32/shv_item_cmenu.c regression

2005-06-09 Thread Gerald Pfeifer
After last night's updates, I'm no seeing the following warning in dlls/shell32/shv_item_cmenu.c shv_item_cmenu.c:203: warning: assignment discards qualifiers from pointer target type The last two changes to this file were revision 1.32 date: 2005/06/07 20:30:30; author: julliard;

dlls/kernel/tests/locale.c warning regression

2005-06-02 Thread Gerald Pfeifer
The following change to dlls/kernel/tests/locale.c revision 1.36 date: 2005/05/31 09:30:46; author: julliard; state: Exp; lines: +4 -4 Mike McCormack [EMAIL PROTECTED] Some warning fixes for the regression tests. actually doesn't fix any warning on FreeBSD 4.x, but adds the following

dlls/msvcrt/time.c build breakage

2005-05-15 Thread Gerald Pfeifer
The following change to dlls/msvcrt/time.c revision 1.22 date: 2005/05/14 11:07:10; author: julliard; state: Exp; lines: +31 -4 Juan Lang [EMAIL PROTECTED] - move _timezone to time.c, and correct its type - implement _tzset, and initialize _daylight, _timezone, and _tzname from

dlls/dbghelp/elf_module.c, possible problem?

2005-03-13 Thread Gerald Pfeifer
Eric et al, the recent changes to dlls/dbghepl/elf_module.c have triggered the following compiler warning (using GCC 3.3) elf_module.c:1167: warning: passing arg 2 of pointer to function makes integer from pointer without a cast Would you mind having a look? Thanks,

Re: Warnings left when compiling on GNU/Linux

2005-01-11 Thread Gerald Pfeifer
On Wed, 5 Jan 2005, Walt Ogburn wrote: There's a patch to make the metafile test pass, which also un-comments the test, at http://www.winehq.org/hypermail/wine-patches/2004/12/0191.html The patch hasn't been committed, but if anybody wants to make it nicer and try again, feel free to do

typelib2.c problems

2005-01-10 Thread Gerald Pfeifer
The following change to dlls/oleaut32/typelib2.c revision 1.32 date: 2005/01/09 17:32:17; author: julliard; state: Exp; lines: +14 -14 Paul Vriens [EMAIL PROTECTED] - use Interlocked* functions in AddRef and Release. - store the result of the Interlocked functions and use only this.

tools/widl/write_msft.c warnings

2005-01-07 Thread Gerald Pfeifer
The addition of tools/widl/write_msft.c added the following four warnings, basically doubling the number of warnings we are getting with GCC 3.4. write_msft.c:582: warning: `ctl2_alloc_importinfo' defined but not used write_msft.c:620: warning: `ctl2_alloc_importfile' defined but not used

Warnings left when compiling on GNU/Linux

2005-01-05 Thread Gerald Pfeifer
When compiling on SUSE LINUX 9.2 using GCC 3.3.5 the following are the only warnings I'm getting for current Wine CVS: metafile.c:395: warning: `test_mf_PatternBrush' defined but not used rtlstr.c:552: warning: `test_RtlUpcaseUnicodeChar' defined but not used rtlstr.c:578: warning:

Re: PATCH: revive FreeBSD support

2004-12-14 Thread Gerald Pfeifer
On Tue, 14 Dec 2004, Alexandre Julliard wrote: Looks OK, but this is a job for wine_anon_mmap, it's supposed to abstract these sorts of platform dependencies so that the callers don't have to worry about it. How about the following? Gerald ChangeLog: Make us work on FreeBSD again by working

Re: dlls/mscms/profile.c breakage

2004-11-26 Thread Gerald Pfeifer
On Thu, 25 Nov 2004, Hans Leidekker wrote: lcms 1.09 as standard, you can't require to update it for all users if the replacement version (1.13 or so) is not the standard one for that distro. No, I'm not requiring or forcing users to upgrade. I'm asking packagers (specifically those that

winecfg/drivedetect.c breaks portability (#include mntent.h)

2004-11-24 Thread Gerald Pfeifer
=getmntinfo has the man page for FreeBSD. Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

Re: dlls/mscms/profile.c breakage

2004-11-24 Thread Gerald Pfeifer
your help on the latter. ;-) Thanks, Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

Re: winecfg/drivedetect.c breaks portability (#include mntent.h)

2004-11-24 Thread Gerald Pfeifer
On Wed, 24 Nov 2004, Gerald Pfeifer wrote: The addition of winecfg/drivedetect.c via revision 1.1 date: 2004/11/23 13:50:23; author: julliard; state: Exp; Mike Hearn [EMAIL PROTECTED] - More heapification. - Split drive code into core, UI and autodetect. - Implement drive

dlls/mscms/profile.c breakage

2004-11-22 Thread Gerald Pfeifer
:174: error: `cmsprofile' undeclared (first use in this function) profile.c:174: error: parse error before ')' token gmake[2]: *** [profile.o] Error 1 gmake[2]: Leaving directory `/.amd_mnt/nashira/files5/test/wine/dlls/mscms' Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http

Re: dlls/commdlg/fontdlg.c regression

2004-11-13 Thread Gerald Pfeifer
On Tue, 7 Sep 2004, Jacek Caban wrote: On Sun, 15 Aug 2004, Gerald Pfeifer wrote: The following change to dlls/commdlg/fontdlg.c revision 1.70 date: 2004/08/14 00:42:35; author: julliard; state: Exp; lines: +2 -5 Jacek Caban [EMAIL PROTECTED] Fix a bug in passing parameters

Re: Wine on FreeBSD current

2004-10-31 Thread Gerald Pfeifer
On Tue, 22 Jun 2004, Alexandre Julliard wrote: Gerald Pfeifer [EMAIL PROTECTED] writes: ...and in fact, Alexandre, wouldn't it be better to have _some_ apps broken under Wine on FreeBSD than a completely broken Wine on FreeBSD for all apps? Nope. What matters is not so much how many apps run

programs/winecfg/winecfg.c and setkey()

2004-10-16 Thread Gerald Pfeifer
declaration of `setkey' (How) can we address this in Wine? Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

programs/winecfg/libraries.c warnings regressions

2004-10-16 Thread Gerald Pfeifer
I believe the following patch of programs/winecfg/libraries.c revision 1.3 date: 2004/09/28 03:55:16; author: julliard; state: Exp; lines: +288 -501 Mike Hearn [EMAIL PROTECTED] - rewrite the transaction system to be based on a settings overlay, to have a nicer API, and to actually

include/wine/port.h and socklen_t breakage

2004-09-15 Thread Gerald Pfeifer
The following change to include/wine/port.h revision 1.58 date: 2004/09/03 18:30:28; author: julliard; state: Exp; lines: +3 -0 Added configure check for socklen_t. +#ifndef HAVE_SOCKLEN_T +typedef unsigned int socklen_t; +#endif causes the following build failure on an old version

Re: dlls/winsock/socket breakage

2004-09-13 Thread Gerald Pfeifer
: Roderick Colenbrander [EMAIL PROTECTED] Gerald Pfeifer [EMAIL PROTECTED] Make WS2_Send(), WS_getsockopt(), and WS_setsockopt() work on FreeBSD. Index: socket.c === RCS file: /home/wine/wine/dlls/winsock/socket.c,v retrieving

Re: dlls/winsock/socket breakage

2004-09-12 Thread Gerald Pfeifer
4.10 and SUSE LINUX 9.1. Thanks again, Gerald ChangeLog: Roderick Colenbrander [EMAIL PROTECTED] Gerald Pfeifer [EMAIL PROTECTED] Make WS2_Send(), WS_getsockopt(), and WS_setsockopt() work on FreeBSD. Index: socket.c === RCS file: /home

Re: dlls/winsock/socket breakage

2004-09-11 Thread Gerald Pfeifer
On Thu, 9 Sep 2004, Roderick Colenbrander wrote: I made some more progress with the fix but I'm not fully sure how it works. I checked the freebsd source code to figure out how it works. Compared to the linux source the code was very complicated as in linux there's a special ipx setsockopt

dlls/winsock/socket breakage

2004-09-09 Thread Gerald Pfeifer
sipx_family; struct ipx_addr sipx_addr; charsipx_zero[2]; }; Finally, I could not find anything remotely similiar to IPX_TYPE. I hope this will allow you to fix this breakage? (To check for FreeBSD, you can use #ifdef __FreeBSD_...) Thanks, Gerald -- Gerald Pfeifer

Re: dlls/commdlg/fontdlg.c regression

2004-09-06 Thread Gerald Pfeifer
I believe I saw a patch for this, but WineHQ CVS still has this problem. On Sun, 15 Aug 2004, Gerald Pfeifer wrote: The following change to dlls/commdlg/fontdlg.c revision 1.70 date: 2004/08/14 00:42:35; author: julliard; state: Exp; lines: +2 -5 Jacek Caban [EMAIL PROTECTED] Fix a bug

dlls/commdlg/fontdlg.c regression

2004-08-15 Thread Gerald Pfeifer
with GCC 3.3.2 on FreeBSD 4.10: fontdlg.c:1161: warning: passing arg 4 of `CFn_WMCommand' from incompatible pointer type Would you mind fixing this? Thanks, Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

dlls/kernel/heap.c breakage

2004-08-13 Thread Gerald Pfeifer
Robert, the following change to dlls/kernel/heap.c broke FreeBSD, both 4.10 and 5.2: revision 1.10 date: 2004/08/13 00:41:34; author: julliard; state: Exp; lines: +115 -88 Robert Reif [EMAIL PROTECTED] Use GlobalMemoryStatusEx in GlobalMemoryStatus rather than the other way around.

Re: dlls/kernel/heap.c breakage

2004-08-13 Thread Gerald Pfeifer
On Fri, 13 Aug 2004, Robert Reif wrote: the following change to dlls/kernel/heap.c broke FreeBSD, both 4.10 and 5.2: Here is the bsd fix. Thanks! Builds like a charm now. Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

Re: Wine on FreeBSD current

2004-06-23 Thread Gerald Pfeifer
On Mon, 21 Jun 2004, John Birrell wrote: For FreeBSD5, which will become the stable branch sometime soon, I think the kernel code needs to change. I have a FreeBSD src commit bit, but I'm not a vm person, so I can only prototype a change and submit it for review. Excellent, thanks! Would you

Re: Wine on FreeBSD current

2004-06-20 Thread Gerald Pfeifer
? Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

mmap of entire address space failed

2004-06-17 Thread Gerald Pfeifer
Wine, even without any parameters: wine: failed to initialize: /swtest/wine/dlls/ntdll.dll.so: mmap of entire address space failed: Cannot allocate memory Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

Re: Wine on FreeBSD current

2004-06-17 Thread Gerald Pfeifer
compilable on FreeBSD 4.9 and 5.2/5.3. Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

Re: Wine on FreeBSD current

2004-06-17 Thread Gerald Pfeifer
. :-( Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

(no subject)

2004-06-16 Thread Gerald Pfeifer
: warning: format argument is not a pointer (arg 11) shlexec.c:722: warning: format argument is not a pointer (arg 12) Would you mind fixing this? Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

dlls/d3dxof/d3dxof and unused functions

2004-06-03 Thread Gerald Pfeifer
but not used d3dxof.c:453: warning: `IDirectXFileDataReference_Vtbl' defined but not used d3dxof.c:612: warning: `IDirectXFileObject_Vtbl' defined but not used d3dxof.c:690: warning: `IDirectXFileSaveObject_Vtbl' defined but not used Would you mind addressing these? Gerald -- Gerald Pfeifer

dlls/d3d8/utils.c regression

2004-05-01 Thread Gerald Pfeifer
of function `glActiveTextureARB' Would you mind looking into that? Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

programs/winecfg/main.c breakage

2004-03-17 Thread Gerald Pfeifer
-mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o main.o main.c In file included from main.c:35: /usr/include/unistd.h:189: error: conflicting types for `select' ../../include/winsock.h:975: error: previous declaration of `select' Gerald -- Gerald Pfeifer

Re: statvfs breakage

2004-03-09 Thread Gerald Pfeifer
/03/05 21:03:46; author: julliard; state: Exp; lines: +11 -22 Use statvfs instead of statfs, and provide a default implementation in libwine_port if necessary. Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

dlls/comctl32/string.c problems

2004-02-20 Thread Gerald Pfeifer
helpers. introduced the following two problems: string.c:486: warning: passing arg 4 of `COMCTL32_StrRChrHelperA' from incompatible pointer type string.c:499: warning: passing arg 4 of `COMCTL32_StrRChrHelperW' from incompatible pointer type Would you mind having a look? Gerald -- Gerald

Re: programs/winedbg/elf.c breaks non-Linux platforms

2004-02-07 Thread Gerald Pfeifer
Eric, I happily confirm that with your updates of elf.c, FreeBSD 4.x now compiles that code without problems. Thanks for your quick and effective response and the patch! Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

programs/winedbg/elf.c breaks non-Linux platforms

2004-02-03 Thread Gerald Pfeifer
in this function) elf.c:345: error: `DT_HIOS' undeclared (first use in this function) elf.c:346: error: `DT_LOPROC' undeclared (first use in this function) elf.c:346: error: `DT_HIPROC' undeclared (first use in this function) Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com

Re: programs/winedbg/elf.c breaks non-Linux platforms

2004-02-03 Thread Gerald Pfeifer
/include/sys/elf32.h and /usr/include/sys/elf_common.h from a 4.8-RELEASE-p13 system. If you'd like me to check a 5.2 system, I should also be able to do that, but -STABLE is still 4.x.) Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald//*- * Copyright (c) 1996-1998

/dlls/gdi/freetype.c breakage

2004-01-19 Thread Gerald Pfeifer
that DEVICEFONTENUMPROC is not defined, though on some of my other test boxes with slightly different versions of FreeType, I did not see this problem. http://www.rtp.freebsd.org/~gerald/config.h contains the config.h file from autoconf. Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http

Re: PATCH: tools/winewrapper and memory limits

2004-01-18 Thread Gerald Pfeifer
invoking the real thing? Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

Re: PATCH: dlls/winmm/wineoss/audio.c

2003-12-31 Thread Gerald Pfeifer
On Tue, 30 Dec 2003, Alexandre Julliard wrote: I'm not sure whether you want to make this change in general, for all platforms, so for now I have embedded it in an #if(n)def. I think we should do that on all platforms, yes. And you probably want to fix OSS_WaveInInit too. Good catch! As

Re: Further loader/pthread.c issues

2003-11-15 Thread Gerald Pfeifer
as well). If you want to keep it like that nevertheless, I volunteer to submit a small and clean patch to provide the workaround on FreeBSD once you re-enabled POSIX threads there. On Sun, 9 Nov 2003, Gerald Pfeifer wrote: After last night's changes to loader/pthread.c,v we have a new portability

Re: PATCH: dlls/wineps/type42.c

2003-11-12 Thread Gerald Pfeifer
are the same size. It's only a cosmetic issue. Gosh, I really had my head with some other machines (with larger int); you are right, of course! Gerald -- Gerald Pfeifer (Jerry) [EMAIL PROTECTED] http://www.pfeifer.com/gerald/

Re: PATCH: dlls/oleaut32/variant.c -- minor fix

2003-11-09 Thread Gerald Pfeifer
On Sat, 8 Nov 2003, Dimitrie O. Paun wrote: +#if USHRT_MAX DATE_MAX if( uiIn DATE_MAX ) Please find a non-#if solution. It's too minor to justify the resulting ugliness. I think you'll like the variant of the patch Alexandre committed last night. :-) Gerald -- Gerald Pfeifer

Further loader/pthread.c issues

2003-11-09 Thread Gerald Pfeifer
After last night's changes to loader/pthread.c,v revision 1.2 date: 2003/11/09 01:25:23; author: julliard; state: Exp; lines: +67 -11 Moved the remaining SYSDEPS_* functions to the wine_pthread interface. Let the pthread library allocate the stack itself. we have a new portability

<    1   2   3   >