Re: Gecko64 status

2010-06-07 Thread Maarten Lankhorst
Hi Jacek, 2010/6/5 Jacek Caban : > Hi all, > > I'd like to share with you progress on gecko64. First of all, I think that > it was never said in public, although I've been asked about it: there won't > be gecko64 for 1.2 release. I think we will have Gecko release in the second > half of this year

Re: configure.ac: when checking for ALSA, look for snd_pcm_recover() instead of snd_pcm_hw_params_get_access()

2010-06-06 Thread Maarten Lankhorst
Hello, On 06-06-10 21:09, Austin English wrote: On Sun, Jun 6, 2010 at 3:27 AM, Andrew Nguyen wrote: On Sun, Jun 6, 2010 at 2:50 AM, Austin English wrote: See http://bugs.winehq.org/show_bug.cgi?id=23003 -- -Austin You should probably drop the snd_pcm_hw_params_get_ac

Re: Last Minute Submission: Winecfg>About

2010-05-29 Thread Maarten Lankhorst
Hello Joel, 2010/5/29 Joel Holdsworth : > Hi All, > > I know it's late and we're in freeze mode now, but I wanted to offer > some work I've been doing: > > http://www.airwebreathe.org.uk/space/new-about-screen.png > > Basically I've been giving the about page of winecfg a face lift. It > seemed li

Re: d3dx9effect.h; Errors in h files are bugs?

2010-05-29 Thread Maarten Lankhorst
Hoi, 2010/5/29 Luis Busquets : > winehq in include/d3dx9effect.h adds in the definition of > ID3DXEffectCompiler > the methods: > > STDMETHOD(SetPixelShader)(THIS_ D3DXHANDLE parameter, LPDIRECT3DPIXELSHADER9 > pshader) PURE; > >  STDMETHOD(SetVertexShader)(THIS_ D3DXHANDLE parameter, > LPDIRECT3D

Re: Voting for own bugs not allowed?

2010-05-25 Thread Maarten Lankhorst
Hi Florian, On 25-05-10 10:59, Florian Köberle wrote: Hello, I got some replys at other places (bug tracker and private email). As I want to keep the discussion on the mailinglist I will place my arguments for voting here: 1. Not all bugs I report are important to me. I sometimes just fill in

Re: make "bisected" a keyword in bugzilla?

2010-05-22 Thread Maarten Lankhorst
Hi Dan, On 23-05-10 01:57, Dan Kegel wrote: I think it's a good idea. 'regression' isn't as strong as 'bisected'. Unless there are objections, I'll add the keyword on Monday. I think I'll object. I don't see any point in the bisected tag that regression doesn't already cover. As far as I

Re: make "bisected" a keyword in bugzilla?

2010-05-22 Thread Maarten Lankhorst
Hello, On 22-05-10 17:15, Wolfram Sang wrote: I noticed that Wylda uses "--private keyword: bisected" when appropriate. IMHO this could be useful as a real keyword, e.g. if you search for bugs you'd like to try tackling. Has this been considered already? I don't think that keyword is needed,

Re: winecfg audio tab contents

2010-05-18 Thread Maarten Lankhorst
Hello Joerg, On 18-05-10 15:33, joerg-cyril.hoe...@t-systems.com wrote: did you notice that in winecfg-1.1.44, the audio tab content is broken: nothing is displayed below ALSA, and OSS lists 5 things only. There used to be much more content. This is likely a side effect from not calling DRV

[rfc] server: Use rtkit to set realtime priority, try 3

2010-05-05 Thread Maarten Lankhorst
arten From 9e494e4a1587cc07752897a787f626b99f711756 Mon Sep 17 00:00:00 2001 From: Maarten Lankhorst Date: Fri, 23 Apr 2010 23:21:37 +0200 Subject: [PATCH 03/10] server: Use rtkit to set realtime priority, try 3 --- configure | 117 configure.ac| 41 +--

Re: configure: Refuse to build wine64 with buggy gcc

2010-04-26 Thread Maarten Lankhorst
Hi Michael, 2010/4/26 Michael Stefaniuc : > Maarten Lankhorst wrote: >> --- >> ;D > As there is no fixed gcc out there I'd rather see configure warn here > instead of aborting. We do want to make it easy for people to compile > Wine64. Any bug report would be useless

gcc64 float bug

2010-04-25 Thread Maarten Lankhorst
Hi AJ, I isolated and fixed the gcc bug, but it will take some time before the changes make it into wine stable. Should I add a testcase to configure to detect a broken version of gcc, and refuse to build wine64 if this is the case? See this link for the fix, and the testcase: http://gcc.gn

wine + rtkit, take 2

2010-04-23 Thread Maarten Lankhorst
Hi all, Just thought I'd try my luck again with rtkit, so here's what I came up with this time without a bizarre dbus call in ntdll. :) This requires a patch to rtkit, since I'm setting the realtime priority of a different process. However since rtkit will validate the pid/tid, userid and st

Re: [PATCH] configure: win32 has 4 byte argument aligment, we have more

2010-04-19 Thread Maarten Lankhorst
Hi Marcus, 2010/4/19 Marcus Meissner : > Hi, > > The Win32 ABI has its stack arguments aligned at 4 (2^2) bytes. > For MMX/SSE operations we however need to have the stack aligned > to 16 (2^4). > > So specify this explicitly. > > (This should probably be even part of attribute((stdcall)) perhaps

Re: [rfc] realtime priority patch based on rtkit

2010-04-17 Thread Maarten Lankhorst
Hi James, 2010/4/17 James McKenzie : > Maarten Lankhorst wrote: >> >> Hi all, >> >> I decided to dig through the sample documentation for rtkit and see if I >> could find a way to make it work for wine. >> There's still a few things missing: hardcod

Re: mciseq: Prevent busy-wait while paused.

2010-04-15 Thread Maarten Lankhorst
Hi Joerg, 2010/4/15 : > Hi, > > any comment on that patch? It's currently the bottommost in > source.winehq.org/patches hence may fall into the bitbucket anytime. > > I had noticed that the MCI MIDI player would busy loop while paused > because of a while(xyz) ; statement therein. > > Test it usi

[rfc] realtime priority patch based on rtkit

2010-04-12 Thread Maarten Lankhorst
rtkit requires the affected process to call dbus. Any moral objections to this approach? Cheers, Maarten >From aeace7baf8a926f162cbd96dfdb5c767b4346d26 Mon Sep 17 00:00:00 2001 From: Maarten Lankhorst Date: Fri, 20 Nov 2009 18:14:50 +0100 Subject: [PATCH 04/17] server: Thread prio patch based

Re: msvidc32/msvideo1 question: upside down buffers?

2010-04-06 Thread Maarten Lankhorst
Hi Joerg, On 06-04-10 17:47, joerg-cyril.hoe...@t-systems.com wrote: does anybody know why msvideo_decode_8bit(), when imported from the FFmpeg project in 2004, was changed such that the pixels[] array became filled upside down? See how #ifdef ORIGINAL, which shows the original FFmpeg code,

Application period ends in ~4 days

2010-04-05 Thread Maarten Lankhorst
Hi all, I've seen a few very good proposals on the mailing list, but not enough of them ended up as a proposal on the official summer of code app. So if you haven't done so already please apply there now. You can still modify your proposal there after submitting it based on feedback, but you'l

Re: [PATCH 4/5] mmdevapi: Add dependency on openal

2010-03-31 Thread Maarten Lankhorst
Hi Chris, 2010/4/1 Chris Robinson : > On Wednesday 31 March 2010 2:00:57 pm Maarten Lankhorst wrote: >> +        local_contexts = palcIsExtensionPresent(NULL, > "ALC_EXTX_thread_local_context"); > > Missed a spot? Don't forget to use the correct function names f

Wanted: Summer of Code Mentors

2010-03-20 Thread Maarten Lankhorst
Hi all, Any contributing wine members wishing to mentor for summer of code, or help out with ranking proposals, please sign up as mentor for wine at http://socghop.appspot.com/gsoc Of course if you want to apply as student, you can't be a mentor. More feedback on the proposals is appreciated as we

Re: GSoC '10 Project Proposal: Buildbot Automated Testing System

2010-03-19 Thread Maarten Lankhorst
Hi Arjun, On 19-03-10 05:25, Arjun Comar wrote: GSoC 2010 Proposal: Buildbot Automated Testing System For those who aren't aware, http://buildbot.net/ provides an automated testing suite. I propose to set up a Buildbot system for Wine, using both a periodic scheduler, and a try scheduler. I al

Summer of code 2010 -- wine accepted as organization

2010-03-18 Thread Maarten Lankhorst
Topic says it all, Here's to an awesome start of summer of code 2010 for wine! Let the proposals begin! Cheers, Maarten

Re: mmdevapi: Implement IMMDeviceEnumerator::GetDevice. patch

2010-03-17 Thread Maarten Lankhorst
Hoi Joris, On 16-03-10 21:31, Joris Huizer wrote: Hello, Maarten Lankhorst, I was browsing through the recent patches in git, I noticed some possible issue in this code: +for (i = 0; i< MMDevice_count; ++i) +{ +WCHAR *str; +dev = (IMMDevice*)MMDevice_hea

Re: mciavi: Prevent deadlock when closing while playing or when paused.

2010-03-12 Thread Maarten Lankhorst
Hi Joerg, On 12-03-10 16:02, joerg-cyril.hoe...@t-systems.com wrote: Hi, Maarten Lankhorst wrote: Using a winmm timer there would remove the need for that thread altogether Please explain the idea. as part of my sound rewrite I will write a new winmm driver My

Re: mciavi: Prevent deadlock when closing while playing or when paused.

2010-03-11 Thread Maarten Lankhorst
Hi Joerg, 2010/3/11 : > Hi, > > alas, even though mciavi contains lots of Critical Sections, > it's not enough to protect against 2 threads calling Play and Close > concurrently.  I believe something entirely different would be > needed: either a complete serialization of messages (like the OSS >

Re: measuring audio latency?

2010-03-09 Thread Maarten Lankhorst
Hi Dan, 2010/3/9 Dan Kegel : > Hey folks, > before Maarten goes and implements wine audio > on top of OpenAL, does anyone know of a nice > automated tool for measuring audio latency > that works on multiple APIs?  i.e. it'd be cool > if one could plug in a loopback cable, > run an app once, and ge

Re: winmm/midi tests and VMware

2010-03-02 Thread Maarten Lankhorst
Hoi Paul, On 02-03-10 17:38, Paul Vriens wrote: On 03/02/2010 04:19 PM, Paul Vriens wrote: On 03/02/2010 04:05 PM, Maarten Lankhorst wrote: Instead of trying to work around the problem, could you try to find out exactly where and why it is hanging first? Hi Maarten, I've been in talks

Re: winmm/midi tests and VMware

2010-03-02 Thread Maarten Lankhorst
Hi Paul, On 02-03-10 11:28, Paul Vriens wrote: Just wanted your opinion on the following: VMware Workstation officially only supports MIDI output via the synthesizer device. The problem I'm having with several of my VMware boxes (and from the looks, Francois' boxes have the same issues) is t

Re: msvcrt: Implement _mbctombb.

2010-02-23 Thread Maarten Lankhorst
Hi David, David Hedberg wrote: On Wed, Feb 24, 2010 at 7:12 AM, Maarten Lankhorst wrote: Hi David, Hi Maarten, David Hedberg wrote: +/* Maps multibyte cp932 punctuation marks to single byte equivalents */ +static unsigned int mbctombb_932_punct

Re: msvcrt: Implement _mbctombb.

2010-02-23 Thread Maarten Lankhorst
Hi David, David Hedberg wrote: +/* Maps multibyte cp932 punctuation marks to single byte equivalents */ +static unsigned int mbctombb_932_punct[] = { + 0x20,0xa4,0xa1,0x2c,0x2e,0xa5,0x3a,0x3b,0x3f,0x21,0xde,0xdf,0x00,0x00,0x00,0x5e, + 0x7e,0x5f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x

Re: includes: Fix IsEqualPropertyKey definitions

2010-02-22 Thread Maarten Lankhorst
Hi AJ, 2010/2/22 Alexandre Julliard : > Maarten Lankhorst writes: > >>> This doesn't match the PSDK. Where does this come from? >> In C, REFPROPERTYKEY becomes PROPERTYKEY*, in C++ it's PROPERTYKEY &, >> so IsEqualPropertyKey will need a different macro.

Re: includes: Fix IsEqualPropertyKey definitions

2010-02-22 Thread Maarten Lankhorst
Hi AJ, 2010/2/22 Alexandre Julliard : > Maarten Lankhorst writes: > >> @@ -48,7 +48,11 @@ >>  #endif >> >>  #ifndef IsEqualPropertyKey >> +#ifdef __cplusplus >>  #define IsEqualPropertyKey(a,b) (((a).pid == (b).pid) && >> IsEqualIID((a).fm

Re: [PATCH] shell32: replace strcpy by memcpy due to slightly undefined struct handling

2010-02-16 Thread Maarten Lankhorst
Hello Marcus, 2010/2/15, Marcus Meissner : > Hi, > > Writing over the end of a struct via char[1] is only well defined if the > struct > is standalone and not contained in another struct. > > So for gcc 4.5 the strcpy triggers a fortify overflow error and we > better use memcpy. > > Ciao, Marcus >

Re: kernel32: Add support for InterlockedCompareExchange64, try 2

2010-02-05 Thread Maarten Lankhorst
Hello Alexandre, Alexandre Julliard wrote: Maarten Lankhorst writes: --- Fix the definitions in winbase.h, and the inline assembly :) There are still several problems with your assembly, and I don't understand why you want to reinvent the wheel when we have a perfectly

mmdevapi update

2010-02-04 Thread Maarten Lankhorst
Hi all, Just thought I'd post an update on my work, after working a few weeks on it I am finally at the point where the first applications that use this new sound api start to work. Currently it's at http://repo.or.cz/w/wine/multimedia.git/shortlog/refs/heads/mmdevapi but I will clean it up

Re: [PATCH] userenv: Implement DestroyEnvironmentBlock().

2010-02-01 Thread Maarten Lankhorst
Hi Lei, 2010/2/2 Lei Zhang : > Hi, > > Over the weekend, someone wrote a Chromium base unit test that calls > DestroyEnvironmentBlock(). So I guess it's time to implement it. The > modified Wine test case passed on my WinXP machine. Are you sure that DestroyEnvironmentBlock needs that null pointer

Re: [PATCH] mmdevapi: Add some basic tests for property store

2010-01-17 Thread Maarten Lankhorst
Hi Paul, Paul Vriens schreef: On 01/17/2010 02:11 PM, Maarten Lankhorst wrote: +static void test_propertystore(IPropertyStore *store) +{ +} Is that one supposed to be empty ? Yeah, I didn't get around to writing decent tests for it yet, it will probably require adding some more he

Re: [PATCH 1/2] mmdevapi: Add code to enumerate NOTPRESENT devices

2010-01-09 Thread Maarten Lankhorst
Hi Alexandre, Alexandre Julliard schreef: Maarten Lankhorst writes: @@ -33,6 +35,13 @@ WINE_DEFAULT_DEBUG_CHANNEL(mmdevapi); +static const WCHAR software_wine_mmdevapi[] = +{ 'S','o','f','t','w','a','r

Re: [PATCH 1/2] mmdevapi: Add code to enumerate NOTPRESENT devices

2010-01-07 Thread Maarten Lankhorst
Hi Alexandre, Alexandre Julliard schreef: Maarten Lankhorst writes: @@ -33,6 +35,13 @@ WINE_DEFAULT_DEBUG_CHANNEL(mmdevapi); +static const WCHAR software_wine_mmdevapi[] = +{ 'S','o','f','t','w','a','r

Re: [PATCH] Don't generate FIXME warnings for DllCanUnloadNow.

2010-01-06 Thread Maarten Lankhorst
Hi Reece, Reece Dunn schreef: NOTE: Some of the DllCanUnloadNow functions always return S_OK. I intend to address that in a separate patch once I have investigated whether the DLLs implement COM objects or not. When a dll is first implemented it probably returns S_OK since no interfaces were

Re: Revert "dsound: Remove refcounting in classfactory."

2010-01-05 Thread Maarten Lankhorst
Hi AJ, Sorry, wrong revert. I shouldn't send patches after 18 hours no sleep :) Cheers, Maarten.

Re: [PATCH] Revert "dsound: Only initialize one guid for capture and renderer."

2010-01-04 Thread Maarten Lankhorst
Hi Alexandre, 2010/1/4 Alexandre Julliard : > Maarten Lankhorst writes: > >> This reverts commit b474649e0e9491f938f1daec74cdca01343dd97e. Fixes bug 21196, Max Payne apparently uses the pointer to the guid after having done the enumeration, which means it used random stack conte

Re: Patch feedback requested for OleCreatePropertyFrame()

2010-01-03 Thread Maarten Lankhorst
Hi Geoffrey, 2010/1/4 Geoffrey Hausheer : > Some software I'm using is configured via an OleCreatePropertyFrame > call which isn't implemented in Wine (ticket #16564).  I can use > winetricks + dcom98 to get it working, but would prefer not to need > that.  I found a patch from 2001 written by TAK

Re: Is native dbghelp useful?

2010-01-02 Thread Maarten Lankhorst
Hi Austin, Austin English schreef: I noticed Microsoft's got dbghelp in a download available...would the native dll be useful to anyone? E.g., should I add it to winetricks? http://www.microsoft.com/downloads/details.aspx?FamilyID=cd1fc4b2-0885-47f4-af45-7fd5e14db6c0&DisplayLang=en Probably

Re: [PATCH 1/3] mmdevapi: Add class factory

2009-12-15 Thread Maarten Lankhorst
Hi Alexandre, 2009/12/15 Alexandre Julliard : > Maarten Lankhorst writes: > >> +static ULONG WINAPI MMCF_Release(LPCLASSFACTORY iface) >> +{ >> +    IClassFactoryImpl *This = (IClassFactoryImpl *)iface; >> +    ULONG ref = InterlockedDecrement(&(This->re

Re: [PATCH 2/2] mmdevapi: Add more tests

2009-12-14 Thread Maarten Lankhorst
Hi Paul, Paul Vriens schreef: On 12/14/2009 10:09 AM, Maarten Lankhorst wrote: +hr = IMMDeviceEnumerator_GetDefaultAudioEndpoint(mme, eRender, eMultimedia,&dev); +ok(hr == S_OK, "GetDefaultAudioEndpoint failed: 0x%08x\n", hr); +if (hr != S_OK) +{

Re: Sound concerns

2009-12-12 Thread Maarten Lankhorst
Hi Stefan, 2009/12/12 Stefan Dösinger : >> OpenAL supports per stream volume. The service is basically needed if an >> application wants to 'audio groups' all using the same sound card across >> processes, and be able to switch it to some different card with 1 command. >> Since I don't think th

Re: Sound concerns

2009-12-11 Thread Maarten Lankhorst
Hi Roderick, Roderick Colenbrander schreef: If there are any other open concerns, apart from packaging, let me know, since I really want to get dsound openal merged. :) If there are still concerns that are open I would like to know, especially if they affect wasapi which is defined in include/

Sound concerns

2009-12-11 Thread Maarten Lankhorst
Hi all, I believe most oconcerns about OpenAL have been addressed. One of the open questions was whether midi and wave would be synced. And I think the most likely answer is that they aren't, even on windows. On windows winmm midi drivers use winmm timeGetTime or QueryPerformanceCounter for D

Re: [PATCH 2/7] dsound: Clean up DSPROPERTY_DescriptionW, try 2

2009-12-10 Thread Maarten Lankhorst
Hi Detlef, Detlef Riekenberg schreef: On Mi, 2009-12-09 at 16:57 +0100, Maarten Lankhorst wrote: +{ +/* FIXME: Still a memory leak.. */ This should be fixed before sending to wine-patches The original code had no way to handle it, and msdn doesn't mention ho

Re: [PATCH 1/7] dsound: Implement DSPROPERTY_WaveDeviceMappingA on top of *W

2009-12-09 Thread Maarten Lankhorst
Hi AJ, Alexandre Julliard schreef: Maarten Lankhorst writes: +data.DataFlow = ppd->DataFlow; +len = strlen(ppd->DeviceName)+1; +data.DeviceName = HeapAlloc(GetProcessHeap(), 0, len); +if (!data.DeviceName) +return E_OUTOFMEMORY; +MultiByteToWideChar(CP_

Re: [PATCH 1/2] dsound: Only initialize 1 guid for capture and renderer

2009-12-09 Thread Maarten Lankhorst
Hi, Alexandre Julliard schreef: Maarten Lankhorst writes: @@ -355,8 +357,8 @@ HRESULT WINAPI DirectSoundEnumerateW( if (devs > 0) { if (GetDeviceID(&DSDEVID_DefaultPlayback, &guid) == DS_OK) { static const WCHAR empty[] = { 0 }; - for (w

Re: Cruft left behind by tests

2009-12-09 Thread Maarten Lankhorst
Hoi, 2009/12/9 Greg Geldorp : > During WineConf we briefly discussed files/registry keys left behind by > running winetest.exe on Windows machines. I promised to look at that and then > promptly forgot about it. Anyway, this is the list of files that get left > behind when running the tests on

Re: Wine sound discussion summary

2009-12-08 Thread Maarten Lankhorst
Hi Stefan, Stefan Dösinger schreef: Am 08.12.2009 um 13:06 schrieb Robert Reif: Yes, a single ring buffer for all the software mixed direct sound buffers. A good driver implementation would have a ring buffer for every direct sound buffer. Therefore no requirement for any software mixing.

Re: How does --with-wine64 work?

2009-12-07 Thread Maarten Lankhorst
Austin English schreef: Vincent asked me to get add a --with-wine64 option to my build script. I was testing around, and can't seem to get it to work: $ mkdir - p $HOME/wine{32,64} $ cd $HOME/wine64 $ ~/wine-git/configure --enable-win64 $ make -j4 $ cd $HOME/wine32 $ ~/wine-git/configure --with-w

Re: Wine sound discussion summary

2009-12-07 Thread Maarten Lankhorst
Hi Reif, 2009/12/8 Robert Reif : > Francois Gouget wrote: >> >> Also, as far as I know, DirectSound works on top of all our backend >> drivers. >> >> > > It works through the WAVE API on most drivers which > requires software mixing and format conversions.  Even > the direct sound drivers only imp

Re: Wine sound discussion summary

2009-12-07 Thread Maarten Lankhorst
Hello, 2009/12/8 Robert Reif : ... > Can we drop all current audio drivers now that don't have midi? > Any driver that doesn't implement the complete winmm API and > direct sound shouldn't be in the current tree anyway. I wish, but aj wouldn't even let me delete winenas.drv that has been obviously

Re: Wine sound discussion summary

2009-12-06 Thread Maarten Lankhorst
Hello, Roderick Colenbrander schreef: On Sun, Dec 6, 2009 at 10:42 PM, Stefan Dösinger wrote: Though, how would MIDI be handled. I think that OpenAL doesn't handle MIDI... Good question. As far as I can see PulseAudio doesn't support MIDI either, but it is certainly available in A

Re: [PATCH 1/7] dsound: Remove support for IKsPropertySet for now

2009-12-04 Thread Maarten Lankhorst
Hi, Robert Reif schreef: The current wine direct sound implementation can do multiple opens of the same device and hardware mixing and hardware 3d acceleration without any modifications if the low level driver supports it. No wine audio driver implements all that because the linux audio APIs

Re: [PATCH 1/7] dsound: Remove support for IKsPropertySet for now

2009-12-04 Thread Maarten Lankhorst
Hi Robert, Robert Reif schreef: I believe the approach you are taking moving openal into direct sound is not a good idea and is going to create a lot of regressions that can not be fixed with your current approach. Windows audio programmers know that they can get access to the same hardware

Re: [PATCH 1/7] dsound: Remove support for IKsPropertySet for now

2009-12-03 Thread Maarten Lankhorst
David Adam schreef: 2009/12/3 Robert Reif mailto:r...@earthlink.net>> Maarten Lankhorst wrote: -- As I said, I'm confident nobody uses it, since wine never implemented it properly anyway --- I think you will find that you will hav

Re: [PATCH 1/7] dsound: Remove support for IKsPropertySet for now

2009-12-03 Thread Maarten Lankhorst
Hi Robert, Robert Reif schreef: Maarten Lankhorst wrote: -- As I said, I'm confident nobody uses it, since wine never implemented it properly anyway --- I think you will find that you will have to add it back later because both interfaces are commonly used. The private interfa

Re: RFC: dsound: Add support for enumerating capture devices through openal, try 4

2009-12-03 Thread Maarten Lankhorst
Hi Ken, Ken Thomases schreef: On Dec 2, 2009, at 12:11 PM, Maarten Lankhorst wrote: This patch doesn't apply, just a rfc email to see if this approach is correct :) +static void *openal_handle = RTLD_DEFAULT; +#ifdef SONAME_LIBOPENAL +char error[128]; +openal_h

Re: work underway: Dependency on openal incoming

2009-12-01 Thread Maarten Lankhorst
Hello Alexandre, Alexandre Julliard schreef: Maarten Lankhorst writes: Without openal at compile-time, dsound will still build, but report no sound devices found. Some games or other applications may refuse to run if no dsound devices are found, so its recommended that you build with

Re: [PATCH 4/5] dsound: Add support for OpenAL IDirectSoundCaptureBuffer

2009-12-01 Thread Maarten Lankhorst
Hi Chris, Chris Robinson schreef: On Monday 30 November 2009 1:56:20 pm Maarten Lankhorst wrote: +if (This->playing) +{ +pos2 = This->format->nSamplesPerSec / 100; +pos2 *= This->format->nBlockAlign; +pos2 += pos1; +if (!This->loop

work underway: Dependency on openal incoming

2009-11-30 Thread Maarten Lankhorst
Hi all, This message is mostly aimed towards package maintainers, since one of the discussions at wineconf last year was that package maintainers would like to hear in advance about changing dependencies. Wine's DirectSound implementation will, in the next release or the release after that,

Re: kernel32.dll: Reduce Registry access to KEY_READ or MAXIMUM_ALLOWED wherever possible

2009-11-26 Thread Maarten Lankhorst
Paul Chitescu schreef: Changelog: kernel32.dll: Reduce Registry access to KEY_READ or MAXIMUM_ALLOWED wherever possible In many places reading the Registry is enough to work even when write access is denied. Your patches cannot be applied with -Np1, consider using git for sending patches

re: Usual oss choices missing in winecfg, in today's git

2009-10-15 Thread Maarten Lankhorst
Hi, The explanation is probably much simpler: OSS likely won't show up if the sound device is in use, since it claims total control. If anything in the background is using sound, it is possible to not see OSS at all. lsof /dev/dsp* /dev/snd/* probably tells you if anything uses it. Cheers, M

Re: winelib include problem

2009-08-18 Thread Maarten Lankhorst
Hi Jesse, 2009/8/12 Jesse Allen : > Oh that may have been the correct way for vmrender.idl, but the patch > you proposed of protecting with a struct does compile.  My app does > not use a VMRGUID, so I don't know if it really works :) Commit a664043e1d1e93bcbe2 fixes this in the cleanest way for

Re: includes: Make vmrender.idl C++ friendly

2009-08-11 Thread Maarten Lankhorst
Hi Austin, Austin English schreef: On Tue, Aug 11, 2009 at 12:56 PM, Maarten Lankhorst wrote: C++ doesn't like: GUID GUID; which is valid in C, so replace with struct _GUID GUID; FYI, you're e-mail is messed up in the patch: From: Maarten Lankhorst I think AJ's scr

Re: winelib include problem

2009-08-11 Thread Maarten Lankhorst
Hi Jesse, Jesse Allen schreef: Maartan, In a patch committed on 10 Jul 2008, includes: Add video mixing renderer header, it included a construct that autogenerates this piece of code for strmif.h " typedef struct tagVMRGUID { GUID *pGUID; GUID GUID; } VMRGUID; " Unfortunately any C++

Re: Revert "winealsa.drv: Re-allow fallback to waveout (regression in dsound)."

2009-07-29 Thread Maarten Lankhorst
Heu, Fixing the bug would help, I replied on that bugtracker that I need more information since I'm not bit by that bug myself, but completely reverting a commit just because it has a bug for someone isn't particularly helpful. If you go to winecfg and set acceleration to emulation the old co

Re: dsound: Allow a special cbSize case in CreateSoundBuffer

2009-04-20 Thread Maarten Lankhorst
Hey Jesse, Jesse Allen schreef: OK now do you have comments? I have test cases. On Sun, Apr 19, 2009 at 6:30 PM, Jesse Allen wrote: In CreateSoundBuffer, some apps pass sizeof(WAVEFORMATEXTENSIBLE) for the cbSize and we have to allow it, but only when the SubFormat is KSDATAFORMAT_SUBTYPE

Re: SoC: DirectShow/Gstreamer

2009-03-20 Thread Maarten Lankhorst
Hello Trevor, 2009/3/17 Trevor Davenport : > Hi Maarten, > >> I think this is a great idea. I have no idea how gstreamer works, but >> a lot of quartz is automatic pulling the pipes etc together. There are >> 3 categories of filters in directshow: >> - Source filters (can be a file, can be a webca

Re: SoC: DirectShow/Gstreamer

2009-03-17 Thread Maarten Lankhorst
Hello Trevor, I think this is a great idea. I have no idea how gstreamer works, but a lot of quartz is automatic pulling the pipes etc together. There are 3 categories of filters in directshow: - Source filters (can be a file, can be a webcam, can be any filter that has only an output) - Intermedi

Re: IPinImpl_QueryInternalConnections() is unused

2009-02-06 Thread Maarten Lankhorst
Hi Francois, 2009/2/4 Francois Gouget : > > dlls/qcap/pin.c defines an IPinImpl_QueryInternalConnections() function > but it is not actually used anywhere. Is there any reason to keep it? > > It sort of looks like IPin is a virtual class and that > IPin::QueryInternalConnections() is going to be i

Re: Unused function in quartz

2009-01-07 Thread Maarten Lankhorst
Hello Francois, Rob Shearman schreef: > 2009/1/6 Francois Gouget : > >> In the following commit you added the OutputPin_DeliverNewSegment() >> function to pin.c. However today it is unused. Is there any plan to use >> it? Is it still relevant? >> > > Not, it looks like it has been supersed

Re: [06/10] wintrust: Implement CryptCATOpen and CryptCATClose.

2008-12-23 Thread Maarten Lankhorst
Hi Juan and Hans, Juan Lang schreef: > Hi Hans, > > >> Maarten, do you remember what the code to store attribute certs was >> needed for? I'd like to address Juan's concern by either adding a test >> or taking the code out. >> > > I wouldn't worry about it. The code looks correct to the e

Re: gdi32/winex11.drv: Change all gdi/opengl declarations to use __cdecl

2008-12-17 Thread Maarten Lankhorst
Hi Dmitry, Dmitry Timoshkov schreef: > "Maarten Lankhorst" wrote: > >> Needed to get +relay working in wine64 > > You should have used CDECL instead of __cdecl, have a look how it's > done in msvcrt.dll. In msvcrt both were used, so that doesn't really

Re: Unused vtables and debug channels

2008-12-16 Thread Maarten Lankhorst
Hi Andrew, Andrew Talbot schreef: > It appears that the following vtables and Wine debug channels are not being > used, so I am considering removing them. Please let me know, therefore, if > you have plans for any of them and want them kept. > > > Vtables: > > MemInputPin_Vtbl

Re: Wine64 hello world app runs!

2008-12-15 Thread Maarten Lankhorst
Hi Zach, Zachary Goldberg schreef: > 2008/12/5 Maarten Lankhorst : > >> ... > > So 9 days, a WWN article, and a Slashdot article this story's gotten a > lot of press. I know we've talked a bit offline Maarten about this > but would you perhaps have any othe

Wine64 hello world app runs!

2008-12-05 Thread Maarten Lankhorst
Hi guys, I can finally report success on the first ever win64 program running on wine. The program was a textbook classic, but to make it work gcc had to be changed a lot. This was done by Kai Tietz, who has put a lot of effort in the task of making gcc accept the calling convention. There are

Re: Status of 64 bit Wine

2008-12-02 Thread Maarten Lankhorst
Hi Michael, Michael Ost schreef: > Hi list, > > Every once in a while my boss asks me about 64 bit wine. And today was > the day. So what's the status? > > From my understanding there are two parts to the question. First, is > anyone using a 64 bit build of Wine? How successfully? Does it pass

Re: programs: Fix broken compilation on win64

2008-11-27 Thread Maarten Lankhorst
Hi Rob, Rob Shearman schreef: > 2008/11/27 Maarten Lankhorst <[EMAIL PROTECTED]>: > >> --- >> Set the Spare[0] at runtime after a critical section is entered. :-) >> >> I'm not testing Spare[0] at all calls to EnterCriticalSection, but if this &g

Re: ole32: Add Co*InitializeSpy functions

2008-11-27 Thread Maarten Lankhorst
Hi Rob, Rob Shearman schreef: > 2008/11/26 Maarten Lankhorst <[EMAIL PROTECTED]>: > >> + >> +HRESULT WINAPI CoRevokeInitializeSpy(ULARGE_INTEGER cookie) >> +{ >> +struct oletls *info = COM_CurrentInfo(); >> +TRACE("(%s)\n", wine_dbgst

Re: Windows mobile and ARM

2008-11-25 Thread Maarten Lankhorst
Hi scott, 2008/11/25 Scott Ritchie <[EMAIL PROTECTED]>: > Is it at all feasible to run Windows mobile apps under Wine? From what > I understand it's supposed to be largely the same API as standard Win32. > > How about a port to ARM for the purpose of running Windows Mobile apps, > or just recompi

Re: Users posting to wine-bugs

2008-11-13 Thread Maarten Lankhorst
Austin English schreef: > On Sat, Nov 1, 2008 at 12:13 PM, Matt Perry <[EMAIL PROTECTED]> wrote: > >> On Sat, Nov 1, 2008 at 3:11 AM, Luke Bratch <[EMAIL PROTECTED]> wrote: >> >>> Is anybody opposed to me setting up an auto-responder so that any mail >>> going to [EMAIL PROTECTED] gets aut

Re: winmm: Increase tolerance range in tests

2008-11-05 Thread Maarten Lankhorst
Hi Robert, 2008/11/5, Robert Reif <[EMAIL PROTECTED]>: > Alistair Leslie-Hughes wrote: >> Hi, >> >> Changelog: >> winmm: Increase tolerance range in tests >> >> Best Regards >> Alistair Leslie-Hughes >> > Please give an explanation why? If it's just to make the test pass, > then we need to k

Re: What happened to __TRY?

2008-11-05 Thread Maarten Lankhorst
Have you tried linking to kernel32 too? 2008/11/6, Michael Ost <[EMAIL PROTECTED]>: > Hi all, > > When I upgraded wine-develfrom 1.0 to 1.1.7, my winelib app that uses > __TRY no longer links. It complains that RtlUnwind cannot be found. I > can see that RtlUnwind was added to wine/exceptio

Re: [PATCH] wordpad: Make the Replace function work and the Find/Replace dialogs behave like expected.

2008-10-26 Thread Maarten Lankhorst
Hi Elias, Please don't send mail to wine-devel and wine-patches at the same time, if you want feedback, send it to wine-devel, if you want it committed, send it to wine-patches Elias Benali schreef: > diff --git a/programs/wordpad/wordpad.c b/programs/wordpad/wordpad.c > index d06b2d9..434b6fd

Re: Minimal subset of Wine that can do 'make test'?

2008-10-26 Thread Maarten Lankhorst
Hi Dan, Dan Kegel schreef: > On the theory that having a really small subset of > wine would help me bring up the new patchwatcher > faster, I tried building just ntdll and its tests. > I had to bring in a few dependencies... but the killer > was wineboot. It brings in the kitchen sink. > So much

Re: wintrust: Implement CryptCATAdminCalcHashFromFileHandle, try 2

2008-10-21 Thread Maarten Lankhorst
Hi AJ, Alexandre Julliard schreef: > Maarten Lankhorst <[EMAIL PROTECTED]> writes: > > >> +curpos.QuadPart = 0; >> +SetFilePointerEx(hFile, curpos, &oldpos, FILE_CURRENT); >> +SetFilePointerEx(hFile, curpos, NULL, FILE_BEGIN); >&g

Re: setupapi: Implement installing catalog files

2008-10-21 Thread Maarten Lankhorst
Hi AJ, Alexandre Julliard schreef: > Maarten Lankhorst <[EMAIL PROTECTED]> writes: > > >> +wintrust = LoadLibraryW(wintrust_dll); >> +pCryptCATAdminAcquireContext = (void *)GetProcAddress(wintrust, >> "CryptCATAdminAcquireContext"); &

Re: [PATCH] wintrust: Implement CryptCATAdminCalcHashFromFileHandle

2008-10-16 Thread Maarten Lankhorst
Juan Lang schreef: > Hi Maarten, > > overall this patch looks pretty good. A few minor comments: > > +tempbuffer = HeapAlloc(GetProcessHeap(), 0, TEMP_BLOCK_SIZE); > +if (!tempbuffer) > +goto out; > > You return TRUE in this case. You probably ought to set last error >

Re: setupapi: Implement installing catalog files

2008-10-16 Thread Maarten Lankhorst
Hi Vincent, Vincent Povirk schreef: > The patch you sent doesn't match the subject line. > Thanks for catching that, I sent the wrong patch by accident. The attached patch was never meant to be sent in because I knew aj wasn't going to accept it. I'll resend the patch tomorrow. Cheers, Maart

Re: wininet: quiet a noisy fixme

2008-10-15 Thread Maarten Lankhorst
I think this one can be better removed entirely, wine will never get support for dialup programs or other fancy ways to connect to the internet, so this fixme is useless.

Re: [PATCH] shell32: print the correct GUIDs in the shellpath tests.

2008-09-28 Thread Maarten Lankhorst
Juan's proposed version will cause a memory leak / valgrind warning. 2008/9/28, Reece Dunn <[EMAIL PROTECTED]>: > 2008/9/28 Maarten Lankhorst <[EMAIL PROTECTED]>: >> Hi Juan, >> >> 2008/9/28, Juan Lang <[EMAIL PROTECTED]>: >>> Hi Reece, I&#x

Re: [PATCH] shell32: print the correct GUIDs in the shellpath tests.

2008-09-28 Thread Maarten Lankhorst
Hi Juan, 2008/9/28, Juan Lang <[EMAIL PROTECTED]>: > Hi Reece, I'm not nak'ing your patch. I just wanted to point out a simpler > way: > > -static const char *printGUID(const GUID *guid) > +static char *printGUID(const GUID *guid) > { > -static char guidSTR[39]; > +char *guidSTR = HeapAl

Re: Wine PulseAudio Driver

2008-09-28 Thread Maarten Lankhorst
Hi Arthur, 2008/9/27, Arthur Taylor <[EMAIL PROTECTED]>: > "If someone wants to write a pulseaudio driver, he should feel free to > do so, but he should be aware that just writing a simple 20 line > linear PCM out driver is not sufficient." > http://bugs.winehq.org/show_bug.cgi?id=10495 > > I have

Re: configure.ac: add -Werror to default compiler options

2008-09-22 Thread Maarten Lankhorst
Hi All, Rob Shearman schreef: > 2008/9/18 Austin English <[EMAIL PROTECTED]>: > >> Should help avoid bugs like bug 15266 and promote more proper, portable code. >> > > >> Tried compiling Wine with -Werror, got a few interesting results. First one: >> >> [EMAIL PROTECTED]:~/wine-git/dlls

<    1   2   3   4   5   >