Re: Wine release 1.5.2

2012-04-14 Thread mike
I am no longer using this e-mail. Please contact me for my new e-mail address. Thank you, Mike

Re: Wine release 1.5.1

2012-03-31 Thread mike
I am no longer using this e-mail. Please contact me for my new e-mail address. Thank you, Mike

Re: USB Device Support - Nokia PC Suite

2011-02-19 Thread Mike Yates
After rebooting, I did get a full list of "fixme" lines:- mike@myvmubuntu:~$ wine .wine/drive_c/Program\ Files/Nokia/Nokia\ PC\ Suite\ 7/PCSuite.exe fixme:userenv:GetUserProfileDirectoryW 0x100 (nil) 0x32f43c err:ole:CoInitializeEx Attempt to change threading model of this apar

Re: USB Device Support - Nokia PC Suite

2011-02-18 Thread Mike Yates
ash now but brings up an empty list of connections to choose from. Unfortunately these are both too separated from a console launch to capture any "fixme" lines, I only get this one from the main program:- mike@myvmubuntu:~$ wine .wine/drive_c/Program\ Files/Nokia/Nokia\ PC\ Suite\ 7/PCSui

Re: USB Device Support

2011-02-17 Thread Mike Yates
later... The kernel connects to my Nokia 6300 by USB as /dev/ttyACM0 I have used this with with wvdial (and other apps) to use the 6300 as an Edge modem and also with kmobile-tools to sync contacts. Surely there is a way of linking /dev/ttyACM0 into wine as a raw USB or serial port? Anyone know how? Well? -- Mike Yates Cowley Middlesex England * *

Re: socks & wine, patching wininet to use winsock

2010-12-17 Thread Mike Kaplinskiy
I was thinking about looking at wininet soon myself, but haven't had the time. I don't know what the right approach should be, but the least I can tell you is stop including all the linux headers: #ifdef HAVE_NETDB_H # include #endif #ifdef HAVE_NETINET_IN_H # include # include #endif #ifdef HA

RE: ntdll: Implement missing 64 bit shifts

2010-12-07 Thread Mike Gibson
Alexandre Julliard [julli...@winehq.org] writes: > Mike Gibson writes: > > > +/** > > + *_allshr (NTDLL.@) > > + * > > + * Right arithmetic shift a 64 bit integer > >

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

2010-10-18 Thread Mike Kaplinskiy
On Sun, Oct 17, 2010 at 5:51 PM, Erich Hoover wrote: > On Sat, Oct 16, 2010 at 1:41 PM, Mike Kaplinskiy > wrote: >> On Thu, Oct 14, 2010 at 10:08 PM, Erich Hoover wrote: >>> ... >>>     DWORD                               flags; >>>     unsig

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

2010-10-16 Thread Mike Kaplinskiy
rt_sockopt will just fail. >+hdr.Control.buf = pktbuf; .len = sizeof(pktbuf)? >+if (!pWSARecvMsg) >+{ >+skip("WSARecvMsg is unsupported, some tests will be skipped.\n"); >+return; >+} You probably want win_skip. You also leak some sockets here. Mike.

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

2010-10-13 Thread Mike Kaplinskiy
any problems with it (although I can't speak for Alexandre). Mike.

Re: ws2_32: Add support and tests for WSARecvMsg and IP_PKTINFO.

2010-10-12 Thread Mike Kaplinskiy
ff --git a/include/mswsock.h b/include/mswsock.h index 322ab20..5749e59 100644 --- a/include/mswsock.h +++ b/include/mswsock.h This should be a separate patch. diff --git a/include/ws2ipdef.h b/include/ws2ipdef.h index 11b3689..ec0b85a 100644 --- a/include/ws2ipdef.h +++ b/include/ws2ipdef.h Same here. Mike.

Re: [2/3] ntdll: Implement NtQuerySystemInformation/SystemLogicalProcessorInformation (try 4)

2010-10-05 Thread Mike Kaplinskiy
e importantly you seem to be missing the tests for this. (sorry for top posting; mobile gmail doesn't seem to have the ability to bottom post) Mike. On Oct 6, 2010 2:16 AM, "Rudolf Mayerhofer" wrote: > Try 2: > - Exchange Patches #2 and #3. > - Fix errors in formatting > -

Re: kernel32/process: Implement GetLogicalProcessorInformation (rewrite - try 3)

2010-10-04 Thread Mike Kaplinskiy
ions, but even that's not complete. Some tests for the NT >>version would be useful. >> >>Mike. > > SystemLogicalProcessorInformation seems to be the right SystemClass for > NtQuerySystemInformation. But here's the Problem. I don't have any idea

Re: kernel32/process: Implement GetLogicalProcessorInformation (rewrite - try 3)

2010-10-03 Thread Mike Kaplinskiy
//native-nt-toolkit.googlecode.com/svn/trunk/ndk/extypes.h (read, don't copy) seems to have a pretty exhaustive set of definitions, but even that's not complete. Some tests for the NT version would be useful. Mike.

Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 3)

2010-09-22 Thread Mike Kaplinskiy
On Wed, Sep 22, 2010 at 6:13 PM, James Mckenzie wrote: > > > > -Original Message- >>From: Ricardo Filipe >>Sent: Sep 22, 2010 1:18 PM >>To: wine-devel@winehq.org >>Subject: Re: ws2_32: implement AcceptEx and GetAcceptExSockaddrs (try 3) >> >&g

Re: [PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-21 Thread Mike Frysinger
On Tuesday, September 21, 2010 04:21:28 Reece Dunn wrote: > On 21 September 2010 08:58, Mike Frysinger wrote: > > fortify is only adding security/sanity checks to functions. so if you > > do: char f[1]; > >strcpy(f, "1234"); > > the C library, w

Re: [PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-21 Thread Mike Frysinger
On Tuesday, September 21, 2010 03:34:33 Reece Dunn wrote: > On 20 September 2010 17:51, Mike Frysinger wrote: > > well, i dont think this issue is limited to shell32. it's just the only > > one to hit it atm. what about my other patch i posted ? > > http://www.winehq.

Re: [PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-20 Thread Mike Frysinger
On Monday, September 20, 2010 06:49:20 Alexandre Julliard wrote: > Mike Frysinger writes: > > On Sunday, September 19, 2010 17:17:53 Alexandre Julliard wrote: > >> Mike Frysinger writes: > >> > i dont see how that would help. the code is cu

Re: [PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-19 Thread Mike Frysinger
On Sunday, September 19, 2010 17:17:53 Alexandre Julliard wrote: > Mike Frysinger writes: > > i dont see how that would help. the code is currently: > > typedef struct ... { > > > > ... > > CHAR foo[1]; > > > > } ...; > > > > i

Re: [PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-19 Thread Mike Frysinger
On Sunday, September 19, 2010 08:58:42 Alexandre Julliard wrote: > Mike Frysinger writes: > > Newer versions of gcc/glibc with fortify checks enabled will complain > > about the handling of the network's szNames field. Currently it is > > always defined with a length

Re: RFC: Revised patchset to fix Bug 7929 (C&C 3 network does not work)

2010-09-19 Thread Mike Kaplinskiy
On Sun, Sep 19, 2010 at 1:33 PM, Erich Hoover wrote: > On Sat, Sep 18, 2010 at 9:59 PM, Mike Kaplinskiy > wrote: >> There's enough #ifdef's to make this mostly unreadable. > Sorry about this, I was concerned that pushing these out so that > changes do not appear d

Re: RFC: Revised patchset to fix Bug 7929 (C&C 3 network does not work)

2010-09-18 Thread Mike Kaplinskiy
Ah sorry, forgot to mention one more thing - fd's are different on the server side and the client side and between processes. So you're locking different semaphores everywhere effectively not locking anything. Mike. On Sat, Sep 18, 2010 at 11:59 PM, Mike Kaplinskiy wrote: > A few b

Re: RFC: Revised patchset to fix Bug 7929 (C&C 3 network does not work)

2010-09-18 Thread Mike Kaplinskiy
ork syscalls (+ read) with windows-style bind'ing correctly. I'd argue this may be easier and faster than putting the fix it into wine. This may be more user-friendly than having people compile wine themselves. Mike. On Sat, Sep 18, 2010 at 10:44 PM, Erich Hoover wrote: > I realize i

[PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-14 Thread Mike Frysinger
ad should solve the issue. Signed-off-by: Mike Frysinger --- note: i couldnt find a statement of what C standard wine aims for. if it is attempting pre-c99, then this will have to be done differently. perhaps introducing a project-wide define like "VARARRAY" which

[PATCH] shell32: use flexible arrays to avoid fortify failures

2010-09-14 Thread Mike Frysinger
ad should solve the issue. Signed-off-by: Mike Frysinger --- dlls/shell32/pidl.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/shell32/pidl.h b/dlls/shell32/pidl.h index 3dbfaa6..bbfacef 100644 --- a/dlls/shell32/pidl.h +++ b/dlls/shell32/pidl.h @@ -172,12

Re: [2/2] ws2_32: Fail when select is called with an invalid fd.

2010-09-13 Thread Mike Kaplinskiy
return SOCKET_ERROR; You're leaking pollfds here. (As a nitpick - braces for for's that contain more than one line are nice) Mike.

Re: ptrace, pokerstars and Ubuntu 10.10

2010-09-12 Thread Mike Kaplinskiy
On Sun, Sep 12, 2010 at 10:24 PM, Scott Ritchie wrote: > On 09/12/2010 05:57 PM, Mike Kaplinskiy wrote: >> CAP_NET_RAW should enable ping to work just fine I think. setuid seems >> a little too dangerous on the current wineserver, we don't do many >> checks and a few

Re: ptrace, pokerstars and Ubuntu 10.10

2010-09-12 Thread Mike Kaplinskiy
uid 0 features. Mike. On Sep 12, 2010 5:24 PM, "Michael Fox" <415...@gmail.com> wrote:

Re: [PATCH 1/5] server: move is_removeable to fd_ops

2010-08-23 Thread Mike Kaplinskiy
On Wed, Aug 4, 2010 at 1:29 AM, Mike Kaplinskiy wrote: > --- >  server/change.c     |    2 ++ >  server/device.c     |    1 + >  server/fd.c         |   18 -- >  server/file.c       |    1 + >  server/file.h       |    3 +++ >  server/mailslot.c   |    3 ++

Re: [2/2] ws2_32, WS2_sendto: Avoid error when sending zero byte buffer (try 2)

2010-08-14 Thread Mike Kaplinskiy
ht be better to test calling WSASendTo with 0 length on unconnected tcp (or udp if tcp doesn't work) sockets. Good luck, Mike. On Sat, Aug 14, 2010 at 5:45 AM, Wolfgang Schwotzer wrote: > This solves #19397. > > > > >

Re: [PATCH 2/5] ws2_32/tests: test ConnectEx

2010-08-02 Thread Mike Kaplinskiy
On Mon, Aug 2, 2010 at 11:50 PM, Mike Kaplinskiy wrote: > --- >  dlls/ws2_32/tests/sock.c |  227 > ++ >  1 files changed, 227 insertions(+), 0 deletions(-) > Shoot, any chance you can just take #1 and take 2-5 from the first batch? Tha

Re: ws2_32, WS2_send: Avoid error if total bytes sent is 0

2010-07-26 Thread Mike Kaplinskiy
On Mon, Jul 26, 2010 at 3:05 PM, Wolfgang Schwotzer wrote: > This fixes bug #19397 > > > > I don't think that's the right place for the fix. You should probably put it in WS2_sendto. Also could you add some tests to verify that this is the behavior for all protocols, not just IrDA? Mike.

Re: [Resend] Add '_ONCE' variants of DPRINTF, FIXME, WARN.

2010-07-17 Thread Mike Kaplinskiy
On Sat, Jul 17, 2010 at 1:29 AM, Max TenEyck Woodbury wrote: > +#define WINE_FIXME_ONCE(args...) do { } while(0) > +#define WINE_FIXME_ONCE_ONCE_(ch) WINE_FIXME_ONCE I think you want WINE_FIXME_ONCE_ not WINE_FIXME_ONCE_ONCE_. > +#define WINE_FIXME_ONCE(args...) do { } while(0) > +#define WINE_FI

Re: ws2_32: socket.c: wrapped WSASendTo/WSARecvFrom with a different function name

2010-07-17 Thread Mike Kaplinskiy
is fine). You might also want to give them better names. The names tend to be something like WS2_(lower_case_with_underscore_for_space) in that file. You may want to align the arguments as they were before, but now I'm just nitpicking :). If this does get in, we may want to nominate it for stable - it's a pretty simple change. Mike.

Re: xrender.c is does not find fontconfig.h on OS X Tiger

2010-07-12 Thread Mike Kronenberg
On 05.06.2010, at 01:36, Mike Kronenberg wrote: > Dear List > > OS X Tiger does has not have fontconfig, so I'm building it in > ~/buildwine/usr to keep it out of /usr. > I include the headers and libs from ~/buildwine/usr with CPPFLAGS and CFLAGS. > > This worked

Re: git rebase to _insert_ commits?

2010-07-09 Thread Mike Kaplinskiy
You can move commits around in an interactive rebase. Just create an empty commit, move it into place with rebase and edit it. Sorry for top post, mobile gmail doesn't let you bottom post. On Jul 9, 2010 8:56 PM, "Misha Koshelev" wrote: Dear All: I am still learning git and it seems that my so

Re: Update - no wine repo on github

2010-07-06 Thread Mike Kaplinskiy
nks again >> >> Misha >> >> On Jul 6, 2010 12:18 PM, "Mike Kaplinskiy" >> wrote: >> >> On Tue, Jul 6, 2010 at 11:27 AM, Misha Koshelev wrote: >>> Fyi I am just going to... >> >> It shouldn't be too hard. Something lik

Re: Update - no wine repo on github

2010-07-06 Thread Mike Kaplinskiy
forces a push even though your tree is not at the HEAD of origin This breaks git history and can make people forking/pulling your tree angry but assuming you don't care about them, all is well :). Mike.

Re: The __WINE__ macro does not identify the Wine platform

2010-06-17 Thread Mike Kaplinskiy
nt to compile a winelib program/dll (i.e. a dll built specifically for wine and not windows) you use winegcc which defines __WINE__. winegcc -E -dM foo.c should contain #define __WINE__ 1. Mike.

Re: Speed/latency issues for development in a Wine environment

2010-06-17 Thread Mike Kaplinskiy
awful lot of extra start baggage.  Is all that baggage really > needed for command-line commands such as cmake, mingw32-make, gcc, etc.? > > Alan > __ > Alan W. Irwin > > Astronomical research affiliation with Department of Physics and Astronomy, > University of Victoria (astrowww.phys.uvic.ca). > > Programming affiliations with the FreeEOS equation-of-state implementation > for stellar interiors (freeeos.sf.net); PLplot scientific plotting software > package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of > Linux Links project (loll.sf.net); and the Linux Brochure Project > (lbproject.sf.net). > __ > > Linux-powered Science > __ > > > To make sure your numbers are somewhat consistent, you might want to do `wineserver -p; wine notepad` before tests to make sure the wineserver is loaded. It should help with timing of a single app startup, but probably won't help in the cmake case. Mike.

xrender.c is does not find fontconfig.h on OS X Tiger

2010-06-04 Thread Mike Kronenberg
esulted in a correct FONTCONFIGINCL, but the compiling still failed. All the other custom compiled deps are working as usual. Any hint what I might missing? txs Mike smime.p7s Description: S/MIME cryptographic signature

Re: Work on WineQuartz for MacOSX

2010-05-19 Thread Mike Kronenberg
On 18.05.2010, at 17:53, Roderick Colenbrander wrote: > On Tue, May 18, 2010 at 3:12 PM, Mike Kronenberg > wrote: >> On 17.05.2010, at 07:52, Charles Davis wrote: >> >>> On 5/16/10 9:04 PM, James Mckenzie wrote: >>>> Roderick Colenbrander wrote: >

Re: Work on WineQuartz for MacOSX

2010-05-18 Thread Mike Kronenberg
. In the end, the OpenGL implementation won, as it was more portable, flexible and scaling comes for free (Fullscreen support). Basically one does the pixel manipulation in a buffer and loads that buffer as a texture at a fixed refresh rate (25/30/60hz?) if necessary. With Apples Client St

Re: [PATCH 5/5] server: get rid of sock_try_event

2010-05-13 Thread Mike Kaplinskiy
On Thu, May 13, 2010 at 6:28 AM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> We *might* need to ignore POLLERR messages for UDP sockets, as the >> condition is actually temporary and sock_try_event was hiding this. > > It doesn't work here: > > .

Re: ws2_32: negate return value of SIOCATMARK (try 2)

2010-04-29 Thread Mike Kaplinskiy
2010/4/28 André Hentschel : > confirmed by Mike Kaplinskiy > > try 1 was on 4th November 2009 > > --- >  dlls/ws2_32/socket.c     |   16 ++-- >  dlls/ws2_32/tests/sock.c |    2 +- >  2 files changed, 15 insertions(+), 3 deletions(-) > > diff --git a/dlls

Re: Crash when executing custom action in msi

2010-04-18 Thread Mike Kaplinskiy
gt; I'm not much of a COM expert, but from what it looks like in order to tell if an interface is really the interface you expect, the right way would be to QueryInterface it (idea from http://source.winehq.org/source/dlls/msxml3/domdoc.c#L1499 ). Mike.

Re: [PATCH 4/8] server: send the proper status code in case of socket error

2010-04-18 Thread Mike Kaplinskiy
iny. Looks like it's easier to catch pointer mistakes on 64 bit, forgot to 0 terminate a sequence. Will resend a new try :) Mike.

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

2010-04-09 Thread Mike Kaplinskiy
On Thu, Apr 8, 2010 at 8:29 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> This won't work for implementing half-closed sockets. If we have only >> the read half is closed, we will get POLLIN/0 recv indefinitely if we >> keep polling (not POLLHUP). If w

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

2010-04-08 Thread Mike Kaplinskiy
On Thu, Apr 8, 2010 at 11:16 AM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> But I see your point that perhaps it doesn't belong in the main loop >> when one of the halves gets closed. I guess we can keep sock_try_event >> around but only use it when the

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

2010-04-07 Thread Mike Kaplinskiy
On Tue, Apr 6, 2010 at 2:03 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> Would allowing adding the fd to the poll loop after it has been >> removed be more sane? Otherwise we have to resort to ugly things like >> sock_try_event (which only half work). >

Re: [PATCH 01/10] server: allow polling for no events in set_fd_events

2010-04-06 Thread Mike Kaplinskiy
On Tue, Apr 6, 2010 at 1:08 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> Remove the fd from the poll list so we don't get POLLHUP/POLLERR >> messages when we ask for no events > > This is wrong, even when selecting for no events you want to rece

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

2010-03-24 Thread Mike Kaplinskiy
On Wed, Mar 24, 2010 at 3:52 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> Hope this makes the rationale a bit clearer. Although admittedly the >> patch does allow for some busy waiting since >> if (mask & FD_READ  || async_waiting( sock->r

Re: [PATCH 9/9] ws2_32/tests: add some socket event tests

2010-03-24 Thread Mike Kaplinskiy
On Wed, Mar 24, 2010 at 12:17 PM, Paul Vriens wrote: > On 03/24/2010 03:03 AM, Mike Kaplinskiy wrote: >> >> --- >>  dlls/ws2_32/tests/Makefile.in |    2 +- >>  dlls/ws2_32/tests/sock.c      |  735 >> + >>  2 files c

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

2010-03-24 Thread Mike Kaplinskiy
On Wed, Mar 24, 2010 at 2:50 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> POLLIN/POLLOUT are selected if we have pending asyncs (as they should >> be), but we shouldn't add these as pending events since the associated >> overlapped operations aren

Re: [PATCH 2/9] server: pending asyncs should only affect FD_READ/FD_WRITE/FD_CLOSE messages

2010-03-24 Thread Mike Kaplinskiy
On Wed, Mar 24, 2010 at 2:28 PM, Alexandre Julliard wrote: > Mike Kaplinskiy writes: > >> --- >>  server/async.c |    8 >>  server/file.h  |    1 + >>  server/sock.c  |   26 +++--- >>  3 files changed, 20 insertions(+), 15 dele

Re: [PATCH 2/2] ws2_32/tests: test a WSARecv error condition

2010-03-23 Thread Mike Kaplinskiy
On Tue, Mar 23, 2010 at 3:56 PM, Paul Vriens wrote: > On 03/22/2010 07:56 PM, Mike Kaplinskiy wrote: >> >> + >> +    bret = GetOverlappedResult((HANDLE)dest,&ov,&bytesReturned, FALSE); >> +    todo_wine ok(!bret&&  GetLastError() == ERROR_NETNAME_DE

Re: [PATCH 1/2] ws2_32: use ntstatus in overlapped functions (try 3)

2010-01-24 Thread Mike Kaplinskiy
On Fri, Jan 22, 2010 at 6:46 PM, Mike Kaplinskiy wrote: > Also some style fixes. Sorry for the fuss over this :) > --- >  dlls/ws2_32/socket.c |   45 ++--- >  1 files changed, 34 insertions(+), 11 deletions(-) > Don't even look at thi

errno-ntstatus conversion

2010-01-23 Thread Mike Kaplinskiy
error events list, and just use wsa conversion when sending window messages. Mike.

Re: Usage of libxml2 for several modules

2010-01-16 Thread Mike Kaplinskiy
I also file a feature request to have the auto coalescing be toggleable? I don't think there is any good way of solving this ourselves. I guess this would also be a vote for importing libxml2 (or at least forking it). Mike.

Re: Please Review - Revised OS X Application Bundle patch

2009-12-07 Thread Mike Kronenberg
wrestool -x --type=group_icon --output=/tmp/MAINICON.ico --name=$MAINICON "$PATH_TO_EXECUTABLE" &> /dev/null sips -s format icns /tmp/MAINICON.ico --out "$PATH_TO_ICON" &> /dev/null rm /tmp/MAINICON.ico &> /dev/null Mike smime.p7s Description: S/MIME cryptographic signature

Re: Please Review - Revised OS X Application Bundle patch

2009-12-05 Thread Mike Kronenberg
On 05.12.2009, at 23:45, Steven Edwards wrote: > Hi Mike, > > On Sat, Dec 5, 2009 at 2:43 PM, Mike Kronenberg > wrote: > > I cut out the rest of the discussion for the moment as I am short on > time and it's clear we all have a different philosphical POV on how

Re: Please Review - Revised OS X Application Bundle patch

2009-12-05 Thread Mike Kronenberg
share/mime Can I somehow disable them or move them inside the prefix? I know the concept of "share", but since I started with answering mails about how to completely remove wine the list of files and folders to search and clean is growing constantly. Mike smime.p7s Description: S/MIME cryptographic signature

Re: Anti aliased fonts in wine - minimum font size

2009-12-03 Thread Mike Kaplinskiy
a way to disable embedded bitmaps it might help. The related bug is at https://savannah.nongnu.org/bugs/?func=detailitem&item_id=21205 Mike. On Thu, Dec 3, 2009 at 8:41 PM, Avery Pennarun wrote: > On Thu, Dec 3, 2009 at 7:33 PM, Aric Stewart wrote: >> Avery Pennarun wrote: >>&g

Re: Try to find out why "Unity3d (3D application)" doesn't work with Wine.

2009-10-06 Thread Mike Kaplinskiy
>> >> And I am not familiar with C  programming. >> >> Any ideas?  Thanks. >> >> >> >> >> >> >> >> > > > If you want to browse the source, your best bet is http://source.winehq.org . Just go to identifier search and search for SendMessageW. You don't need to do debug though - Jeff and Roderick outlined the problem pretty well. Mike.

Re: [PATCH 2/2] ws2_32/tests: test WSAAccept with CF_DEFER

2009-09-30 Thread Mike Kaplinskiy
On Wed, Sep 30, 2009 at 2:35 AM, Paul Vriens wrote: > On 09/25/2009 07:59 AM, Mike Kaplinskiy wrote: >> >> --- >>  dlls/ws2_32/tests/sock.c |   46 >> +- >>  1 files chang

Re: cppcheck sept 18 redux

2009-09-22 Thread Mike Kaplinskiy
#x27;' would be an actual pointer - that is, ``&arr != arr'', since it stores an address and has a location of its own (whereas fixed length arrays just have a location). This would make a nice interview question. Mike.

Re: cppcheck sept 18 redux

2009-09-22 Thread Mike Kaplinskiy
On Tue, Sep 22, 2009 at 3:06 AM, Ben Klein wrote: > 2009/9/22 Mike Kaplinskiy : >> On Tue, Sep 22, 2009 at 1:09 AM, Vitaliy Margolen >> wrote: >>>> [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible >>>> null pointer dereference: dmW

Re: cppcheck sept 18 redux

2009-09-21 Thread Mike Kaplinskiy
me - (const char >> *)dmW; > Does indeed dereference dmW to get the value of dmFormName. It actually doesn't, it's a tricky case where dmW->dwFormName == &dmW->dwFormName, because dwFormName is an array allocated as part of the struct. I made that mistake too the previous cppcheck round. > > Vitaliy. > Mike.

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Mike Kaplinskiy
LD_OFFSET, which does exactly the above. As for the context note, it is perfectly valid code (segfault-less, that is) as it stands, but we should either remove the null check on the next line or assign the value later. Mike.

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Mike Kaplinskiy
On Sat, Sep 12, 2009 at 11:24 AM, Mike Kaplinskiy wrote: > On Sat, Sep 12, 2009 at 11:19 AM, Nicolas Le Cam wrote: >> 2009/9/12 chris ahrendt : >>> >>> Here is the run for Friday Sept. 11 with the tools and the tests >>> directory results removed. >>>

Re: Sept 11 with tools and tests removed

2009-09-12 Thread Mike Kaplinskiy
shouldn't bother to free resources), but the next few aren't. fd_cwd is leaked if server connection fails, the bug in wineps is very real, we deref before we check for null on the next line. Mike.

Re: fixing ReadDirectoryChangesW()

2009-09-11 Thread Mike Kaplinskiy
run tools/make_requests - you have spacing problems in your patch. make sure you match the spacing format in the file - your patch does too many changes - split it up into multiple patches with each one changing one thing so its easier to review. Hope this helps, Mike.

Re: Question regarding SIO_GET_EXTENSION_FUNCTION_POINTER

2009-09-08 Thread Mike Kaplinskiy
nk we might want to take this off the list though, since it's a rejected patch. Mike.

Re: Question regarding SIO_GET_EXTENSION_FUNCTION_POINTER

2009-09-07 Thread Mike Kaplinskiy
On Mon, Sep 7, 2009 at 11:08 AM, Nicholas LaRoche wrote: > Mike Kaplinskiy wrote: >> >> On Mon, Sep 7, 2009 at 2:45 AM, Nicholas LaRoche wrote: >>> >>> I ran into a bug last week regarding the lack of >>> SIO_GET_EXTENSION_FUNCTION_POINTER support in W

Re: Question regarding SIO_GET_EXTENSION_FUNCTION_POINTER

2009-09-07 Thread Mike Kaplinskiy
emented. For AcceptEx & GetAcceptExSockaddrs, there is a patch in the mailing list that implemented them, but Alexandre rejected the patch. Mike.

Re: Asynchronus serial port

2009-09-02 Thread Mike Kaplinskiy
w, where to look > at. What code respond for asynchronous serial port in wineserver? > Alexander. > P.S. Test program attached. > > > > Hi, Alexandre would be the guy to talk to about wineserver-related things. Sadly he's off on a long weekend. Does the attached patch help s

Re: PATCH[1/6] user32.dll:SwitchDesktop API Implementation

2009-08-29 Thread Mike Kaplinskiy
thout setting an error code. - I'm not quite sure what you're doing in close_desktop. - Code: Don't do if (!(... == ...)), just use if (... != ...). If you break; in either case of the if, do it outside the if. You don't need to check &desktop_ops != NULL. - Don't use HTML emails, most people don't like those. Mike.

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-28 Thread Mike Kaplinskiy
x->dev_name, strerror(errno)); >        } >        close(mixer); >    } > > The code looks good to me. > > Ciao, Marcus > > > Yep this looks fine. For experimentation sake, see if cppcheck prefers != -1 as opposed to >= 0. Also a bug that they should probably know about. Mike.

Re: [PATCH 6/7] ws2_32: implement AcceptEx

2009-08-28 Thread Mike Kaplinskiy
On Fri, Aug 28, 2009 at 2:01 PM, Juan Lang wrote: > Hi Mike, I have one minor nit on this patch: > > +    if (wsa->read) HeapFree( GetProcessHeap(), 0, wsa->read ); > Please don't check if (wsa->read) is NULL before calling HeapFree. > HeapFree already does the correct

Re: Weekly cppcheck run against Aug 27 Git Tree

2009-08-27 Thread Mike Kaplinskiy
ble error) Buffer overrun More of sprintf with just a string nonsense. False positive. > [../wine-git/server/file.c:235]: (possible error) Buffer overrun Also sprintf nonsense, but slightly more dangerous. The buffer is declared with [16] and the string is of length 14+1, so a few more bytes wouldn't hurt. :) > > > Chris > If someone could send patches for the few bugs that would be nice. Chris - cppcheck is clearly crazy about sprintf's and ternary operators. You might want to report that. Mike.

Re: CPPCheck Run for Friday August 21

2009-08-21 Thread Mike Kaplinskiy
allocating a > deallocated pointer: fd > [../wine-git/tools/winedump/pe.c:1549]: (all) Memory leak: map > > > Chris > > Thanks for running these, keeps the code nicely in check. Mike.

Writing Conformance Tests

2009-08-15 Thread Mike
Being new to wine, I was thinking about starting to learn the system by writing conformance tests. Most of us do NOT have access to machines of every flavor of Windows. Is there a standard method to deal with differences across platforms? I realize that often, this won't be an issue, but was w

[PATCH 3/4] kernel32: implement CancelIoEx (try 2)

2009-08-13 Thread Mike Kaplinskiy
From 60e82c0890e7f435afcd200752226ed1fa4ee669 Mon Sep 17 00:00:00 2001 From: Mike Kaplinskiy Date: Sun, 9 Aug 2009 00:12:52 -0400 Subject: kernel32: implement CancelIoEx --- dlls/kernel32/file.c| 26 ++ dlls/kernel32/kernel32.spec |1 + include/winbase.h

Re: cppcheck run against 1.27

2009-08-08 Thread Mike Kaplinskiy
nd almost all functions use it). Then we end up closing the fd twice. > >> [../wine-git/tools/winebuild/res16.c:187]: (error) Resource leak: fd > > Fix submitted. Small issue though. > >> [../wine-git/tools/winedump/pe.c:1549]: (error) Memory leak: map > > Fix submitted. Small issue though. > > Ciao, Marcus > > > Mike.

Request for vista testing

2009-08-06 Thread Mike Kaplinskiy
Can someone test this on vista? It tests NtCancelIoFileEx. The goal is to find out the order of arguments. Thanks, Mike. diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index 164c2da..174daa5 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/ntdll/tests/file.c @@ -54,6 +54,7

Re: ODBC Databases: Jet/Access success

2009-07-23 Thread Mike Kaplinskiy
that's a > different topic.  Thanks! > --Juan > > > Dan/Austin might also add this to winetricks. Jet is already in there so this would be a nice addition. Mike.

Re: blocking/non-blocking socket question.

2009-07-23 Thread Mike Kaplinskiy
fcntl's wouldn't have any effect as the duped socket is closed when released. Rein, I think you can safely make a patch for this bug. In the worst case Alexandre will just not take it. ;) Mike.

Re: blocking/non-blocking socket question.

2009-07-23 Thread Mike Kaplinskiy
cket blocking, we can "freeze" the wineserver. I don't think we need to actually set the unix fd to non-blocking during ioctlsocket, so just removing those fcntl's should work. Just tested this and ws2_32&wininet tests still pass. Should probably consult Alexandre though. Mike.

Re: ws2/tests: Test AcceptEx with a deferred socket

2009-07-20 Thread Mike Kaplinskiy
Paul, I don't like NT4 anymore. We're breaking up. Does the attached patch fix the latest failures (not counting the build warnings)? Mike. On Mon, Jul 20, 2009 at 7:05 AM, Paul Vriens wrote: > Mike Kaplinskiy wrote: >> >> Paul (and anyone who can test on x86_64): &

Re: msi: Fix some pointer conversion warnings on 64-bit(try2)

2009-07-19 Thread Mike Kaplinskiy
sertions(+), 6 deletions(-) > > > > +UINT_PTR i > +UINT row_value; Missing a semicolon? ;) Mike.

Re: ws2/tests: Test AcceptEx with a deferred socket

2009-07-17 Thread Mike Kaplinskiy
Paul (and anyone who can test on x86_64): Can you confirm that the new patch gives no failures? Mike. On Fri, Jul 17, 2009 at 2:02 AM, Paul Vriens wrote: > Mike Kaplinskiy wrote: >> >> Paul, >> >> Does the attached fix test failures on at least NT4? The 4000 test &

Re: ws2/tests: Test AcceptEx with a deferred socket

2009-07-16 Thread Mike Kaplinskiy
eir kernel module is out. Mike. On Thu, Jul 16, 2009 at 3:40 AM, Paul Vriens wrote: > Mike Kaplinskiy wrote: >> >> This tests the following AcceptEx scenario: >>   WSAAccept->CF_DEFER->AcceptEx >> Windows seems to return the deferred socket with Acc

Re: Need help testing (acceptex)

2009-07-11 Thread Mike Kaplinskiy
000=40secs max) Mike. On Sat, Jul 11, 2009 at 5:47 PM, Paul Vriens wrote: > Mike Kaplinskiy wrote: >> >> Can someone try this test on win2000+? This tests the >> WSAAccept->Defer->AcceptEx scenario, and I've only verified th

Need help testing (acceptex)

2009-07-11 Thread Mike Kaplinskiy
Can someone try this test on win2000+? This tests the WSAAccept->Defer->AcceptEx scenario, and I've only verified the behavior on xp. Thanks, Mike diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index c90111d..f9856da 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/w

AcceptEx Patch Comments

2009-07-07 Thread Mike Kaplinskiy
so server side code would be my main concern right now. Thanks, Mike.

Re: winequartz.drv Mac OS X UI discontinued?

2009-07-06 Thread Mike Kronenberg
ulation is taking place in a texture and if it comes to 3d, half of the environment is already set. Mike

Re: AcceptEx Proposal

2009-07-05 Thread Mike Kaplinskiy
On Sun, Jul 5, 2009 at 6:55 AM, Damjan Jovanovic wrote: > On Fri, Jul 3, 2009 at 5:49 AM, Mike > Kaplinskiy wrote: >> I have been thinking about the correct way to implement AcceptEx, and >> I was looking for comments about the approach. Note I know all of >> these cases

AcceptEx Proposal

2009-07-02 Thread Mike Kaplinskiy
ex socket (need to check family, bound state) - accept: a = create_socket(), accept_socket(listener, a), ioctl)SO_UPDATE_ACCEPT_CONTEXT, a, &listener); I just started looking at wineserver, so don't be surprised if something above doesn't make sense. Mike.

Re: Review Request: Rough implementation of GdipBeginContainer and GdipEndContainer

2009-06-30 Thread Mike Kaplinskiy
;t be too far off the mark :) > > Thanks for taking a look, > Andrew > > Patch attached. > Also available at: > http://www.brightnightgames.com/wine/gdipcontainers.patch > > --- >  dlls/gdiplus/graphics.c |  125 -- >  1 files changed, 119 insertions(+), 6 deletions(-) > > > > Mike.

Re: why is Kronenberg's Wine/Mac work blacklisted on winehq?

2009-06-26 Thread Mike Kronenberg
On 26.06.2009, at 16:51, Dmitry Timoshkov wrote: "Emmanuel Maillard" wrote: Darwine tools WineHelper and create_darwine_distrib script are not GPL but LGPL. Don't know for Mike Kronenberg patches or other stuffs, but we never change Wine licensing in Darwine. Darw

  1   2   3   4   5   6   7   8   9   10   >