Re: [PATCH] wininet: Substitute strchrW with memchrW in InternetCrackUrlW.txt

2007-10-17 Thread Nigel Liang
On 10/17/07, Frank Richter [EMAIL PROTECTED] wrote: On 17.10.2007 06:49, Nigel Liang wrote: Hi, strchrW assumes a NULL-terminated string. May crash if terminating character is not found. memchrW is better because you can specify the maximum number of bytes to search

Re: [PATCH] wininet: Close sockets open in http requests

2007-10-17 Thread Nigel Liang
On 10/13/07, Nigel Liang [EMAIL PROTECTED] wrote: Hi, Http requests open sockets and forget to close them. Left running over a long period, the socket file descriptor starts getting large. Once it exceeds FD_SETSIZE, the behavior becomes unpredictable and results in funcky crashes. -Nigel

Re: [PATCH] wininet: Close sockets open in http requests

2007-10-17 Thread Nigel Liang
On 10/17/07, Misha Koshelev [EMAIL PROTECTED] wrote: On Wed, 2007-10-17 at 17:10 -0500, Misha Koshelev wrote: n 10/13/07, Nigel Liang ncliang at gmail.com wrote: Hi, Http requests open sockets and forget to close them. Left running over a long period, the socket file

Re: [PATCH] winecfg: Fix crash caused by calling set_reg_key with NULL value

2007-08-04 Thread Nigel Liang
On 8/3/07, Evan Stade [EMAIL PROTECTED] wrote: On 8/3/07, Nigel Liang [EMAIL PROTECTED] wrote: diff --git a/programs/winecfg/winecfg.c b/programs/winecfg/winecfg.c index 84dd4c8..05f322c 100644 --- a/programs/winecfg/winecfg.c +++ b/programs/winecfg/winecfg.c @@ -468,11 +468,15 @@ void

Re: Nigel Liang : winecfg: Read/write registry in unicode.

2007-08-03 Thread Nigel Liang
Author: Nigel Liang [EMAIL PROTECTED] Date: Thu Aug 2 16:33:24 2007 -0700 winecfg: Read/write registry in unicode. This patch breaks setting the windows version in winecfg (and I assume everything else that uses the registry): Ah~ This is because set_reg_key is called with NULL value

Re: [PATCH] winecfg: Add trackbar to set screen resolution in graphics tab (try 2)

2007-07-30 Thread Nigel Liang
On 7/30/07, Alexandre Julliard [EMAIL PROTECTED] wrote: Nigel Liang [EMAIL PROTECTED] writes: +/* Utility functions to convert between WCHAR and long */ +long wcstolong(WCHAR * wcs) +{ +int i; +long lRet = 0; +BOOL bNeg = FALSE; + +for (i = 0; wcs[i] != '\0'; i

Re: [PATCH] winecfg: Add menu font settings to desktop integration tab

2007-07-30 Thread Nigel Liang
On 7/27/07, Vitaliy Margolen [EMAIL PROTECTED] wrote: Nigel Liang wrote: On 7/25/07, Vitaliy Margolen [EMAIL PROTECTED] wrote: Nigel Liang wrote: diff --git a/programs/winecfg/En.rc b/programs/winecfg/En.rc index 5972c3b..e61bf29 100644 --- a/programs/winecfg/En.rc +++ b/programs

Re: [PATCH] winecfg: Add trackbar to set screen resolution in graphicstab

2007-07-27 Thread Nigel Liang
On 7/27/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Nigel Liang [EMAIL PROTECTED] wrote: diff --git a/programs/winecfg/En.rc b/programs/winecfg/En.rc index 5972c3b..9243e3c 100644 --- a/programs/winecfg/En.rc +++ b/programs/winecfg/En.rc Please add appropriate changes to other

Re: [PATCH] winecfg: Add menu font settings to desktop integration tab

2007-07-27 Thread Nigel Liang
On 7/25/07, Vitaliy Margolen [EMAIL PROTECTED] wrote: Nigel Liang wrote: diff --git a/programs/winecfg/En.rc b/programs/winecfg/En.rc index 5972c3b..e61bf29 100644 --- a/programs/winecfg/En.rc +++ b/programs/winecfg/En.rc @@ -200,6 +200,11 @@ BEGIN CONTROL Link

Re: programs/winefontcfg: Add winefontcfg

2007-07-12 Thread Nigel Liang
the registry entry. Instead of having a seperate binary for the preview area, winefontcfg calls itself with parameters to specify that it should act as a child window. It will be hard to do this with winecfg. On 7/12/07, Dan Kegel [EMAIL PROTECTED] wrote: On 7/11/07, Nigel Liang (梁乃強) [EMAIL

Re: programs/winefontcfg: Add winefontcfg

2007-07-12 Thread Nigel Liang (梁乃強)
On 7/11/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Dan Kegel [EMAIL PROTECTED] wrote: I think those static function prototypes in winefontcfg.h should not be there. .h files are for things shared between files; your prototypes were probably put there to avoid compiler errors. Better to

Remove font set when calling XCreateIC?

2007-06-18 Thread Nigel Liang
Hi, This patch removes a call to XCreateFontSet which was causing wine to be very slow in some Chinese locale settings. The server side font calls are supposed to be deprecated anyway as Dan pointed out in his comment here: http://bugs.winehq.org/show_bug.cgi?id=5309 According to the Xlib

Re: shell32: conformance tests for unicode filenames and fix a bug forfile deletion (try 2)

2007-06-08 Thread Nigel Liang
On 6/7/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Nigel Liang [EMAIL PROTECTED] wrote: +static const WCHAR UNICODE_PATH[] = {'c',':','\\','w',0x00ef,0x00f1,0x00eb, +'t',0x00e8,'s','t','\0','\0'}; /* c:\winetest */ The name above is definitely not c:\winetest, also if you need a double

Re: shell32: conformance tests for unicode filenames and fix a bugforfile deletion (try 2)

2007-06-08 Thread Nigel Liang
Yep, you are right, it is actually c:\wïñëtèst. I will fix it in the next try. That won't work. The actual unicode characters have different codes. Personally I don't see why you need non-acsii characters to test unicode APIs. In this case, the non-ascii characters are necesary to expose

Re: shlwapi: stub implementation for SHSetTimerQueueTimer (try 2)

2007-05-21 Thread Nigel Liang (梁乃強)
misunderstood the msdn documentation? http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/platform/shell/programmersguide/shell_new/shlwapi_wrappers.asp -Nigel On 5/21/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Nigel Liang [EMAIL PROTECTED] wrote: +HANDLE WINAPI