2010/1/21 Jacek Caban ja...@codeweavers.com:
Hi Rob,
On 1/21/10 12:57 PM, Rob Shearman wrote:
---
tools/wmc/wmc.c | 8 +---
tools/wmc/wmc.h | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
--- a/tools/wmc/wmc.h
+++ b/tools/wmc/wmc.h
@@ -65,7 +65,7 @@ extern node_t
-devel, so it needs
to be reverted. It causes these new Valgrind warnings:
http://kegel.com/wine/valgrind/logs/2010-01-11-14.17/diff-advapi32_security.txt
--
Rob Shearman
at least use NULL instead of 0 as both are pointers, but !ptr is
even better here. Accordingly
iface shouldn't generally be checked for NULL unless a program depends
on it and a testcase shows this behaviour in native.
--
Rob Shearman
2009/12/30 Jacek Caban ja...@codeweavers.com:
Hi Rob,
Thanks for your work on jscript. Unfortunately fixing Valgrind on jscript is
not going to be easy. Most of your fixes are good, except clear_global part
and jscript: Fix a circular reference caused by object and function objects
being
is also not implemented yet, applications usually install
an ISampleGrabberCB callback.
Thread-safety is non-existent in your newly written code. DirectShow
uses multiple threads so I would say thread-safety is a requirement,
not a nice-to-have.
--
Rob Shearman
I'll fix it :)
Those failures only occur because of modifications I made to them, but
thanks for fixing it anyway!
--
Rob Shearman
2009/12/14 Nikolay Sivov bungleh...@gmail.com:
On 12/14/2009 18:51, Alexandre Julliard wrote:
Module: wine
Branch: master
Commit: c20868e0a2f7af909cf8af2877ae8b024fa6d11e
URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c20868e0a2f7af909cf8af2877ae8b024fa6d11e
Author: Rob
this by setting an appropriate security
descriptor on the registry key before calling the function you are
changing.
However, the change to get_special_root_hkey looks fine to me. The
rest of your patch isn't easy to review because you haven't generated
the diff with the -p option.
--
Rob Shearman
, hServiceKey);
if (err == ERROR_SUCCESS)
{
err = load_service_config(hServiceKey, entry);
This change is fine since hServiceKey is only every used with
operations that require KEY_READ at the most.
--
Rob Shearman
[1] http://blogs.msdn.com/larryosterman/archive
to be specified.
--
Rob Shearman
2009/11/23 Louis Lenders xerox_xerox2...@yahoo.co.uk:
This fixes http://bugs.winehq.org/show_bug.cgi?id=20050
The dll is present on my XP system
This DLL is already partially implemented in a DLL called mapi32, so
there should be no need to add this completely stubbed out.
--
Rob Shearman
2009/11/24 Rob Shearman robertshear...@gmail.com:
This is caused by caching a pointer and reference to the data cache's
IPersistStorage interface without managing reference counts
appropriately.
---
dlls/ole32/defaulthandler.c | 22 ++
1 files changed, 22 insertions
),lstrlenW(pathOther))+1));
+ if (!commonPath)
+ return E_OUTOFMEMORY;
Ditto plus stringTable2.
*commonPath=0;
--
Rob Shearman
that all Wine
users on a given system would present themselves as admins to apps,
but then again the apps may be restricting permissions on a file
because it contains sensitive data and should only be shared with
other admins (which would be trusted as such, unlike other users on a
system).
--
Rob
changed, 6 insertions(+), 0 deletions(-)
You could easily add a testcase for this behaviour.
--
Rob Shearman
2009/11/12 Paul Vriens paul.vriens.w...@gmail.com:
Hi Rob,
There is still a crash in the rpcrt4 tests on NT4+.
These 2 tests both crash actually:
886 x = echo_ranged_int(0);
887 ok(x == 0, echo_ranged_int() returned %d instead of 0\n, x);
888 x = echo_ranged_int(100);
889 ok
2009/11/11 Dan Kegel d...@kegel.com:
On Mon, Nov 9, 2009 at 2:12 PM, Rob Shearman robertshear...@gmail.com wrote:
2009/11/9 Dan Kegel d...@kegel.com:
16 bytes in 1 blocks are definitely lost in loss record 123 of 728
at RtlAllocateHeap (heap.c:1423)
by RtlAllocateAndInitializeSid (sec.c
(rpc_server.c:453)
by ??? (signal_i386.c:2279)
by call_thread_entry_point (signal_i386.c:2306)
by start_thread (thread.c:469)
by start_thread (pthread_create.c:297)
by clone (clone.S:130)
I don't think that happened before today.
Rob/Hans, could you have a look?
Probably
at the context of your patch, but this
looks appropriate to it:
http://lkml.indiana.edu/hypermail/linux/kernel/0607.0/1566.html
Particularly the part about volatile storage vs. access.
--
Rob Shearman
, which should fix
it as a side-effect.
Thanks,
--
Rob Shearman
From 766547300875c677ea9cfa6b3a10a3fb717c68ee Mon Sep 17 00:00:00 2001
From: Robert Shearman robertshear...@gmail.com
Date: Mon, 27 Apr 2009 18:53:15 +0100
Subject: [PATCH] server: Extend get_token_user server call to also retrieve SIDs
.
assoc-refs++;
*assoc_out = assoc;
LeaveCriticalSection(assoc_list_cs);
Thanks,
--
Rob Shearman
code linked into the wineserver probably
gives many people the heebie-jeebies, given how critical the
wineserver is to allowing wine processes to continue to run and the
special rules of coding in the wineserver - not blocking, for one.
--
Rob Shearman
-Endpoint)
- ((!assoc-NetworkOptions !NetworkOptions) ||
!strcmpW(NetworkOptions, assoc-NetworkOptions)))
+ (!assoc-NetworkOptions || !NetworkOptions ||
!strcmpW(NetworkOptions, assoc-NetworkOptions)))
Thanks,
--
Rob Shearman
(pEntries[i].Trustee.ptstrName), i);
ret = ERROR_INVALID_PARAMETER;
--
Rob Shearman
some MSDN documentation on the limitations of size_is expressions in
IDL.
--
Rob Shearman
{ $$ = $1;
It looks like you'll have to find another way of fixing the issue you
are trying to fix.
--
Rob Shearman
of the oletls structure and it will eliminate the need of these types
of casts.
--
Rob Shearman
. It also appears that the function leaks memory in the
realloc small - large path.
--
Rob Shearman
s_context_handle_test should be removed and replaced
with another that uses widl-generated code for testing context handles
rather than low-level functions.
--
Rob Shearman
these functions properly shouldn't be much
more work than writing the code to marshall and unmarshall the ACL to
and from the server, with two new trivial functions in the server for
getting and setting the default_dacl field.
--
Rob Shearman
the time to...
--
Rob Shearman
change notification from
both HKCU\Software\Classes and HKLM\Software\Classes?
--
Rob Shearman
, and the DLL it resides in, something to do with Image Lists?
No:
http://msdn.microsoft.com/en-us/library/bb773321(VS.85).aspx
--
Rob Shearman
#endif
This looks right, but in recent PSDKs it has moved from ws2tcpip.h to in6addr.h.
--
Rob Shearman
2009/3/30 Alexandre Julliard julli...@winehq.org:
Rob Shearman robertshear...@gmail.com writes:
socketpair is only needed for the server functions for ncacn_ip_tcp.
The tower implementation that ncacn_http and ncacn_ip_tcp share
doesn't depend on it.
It doesn't need socketpair, but it needs
compiler did you use to compile wrc and libwine?
--
Rob Shearman
-fsState = lptbbi-fsState;
if (lptbbi-dwMask TBIF_STYLE)
Whitespace only changes shouldn't be included in patches with other changes.
--
Rob Shearman
of the TOOLBAR_DrawDDFlatSeparator function
and the comments above it if you think it should be called as a result
of the CCS_VERT window style and not the BTNS_DROPDOWN button style.
--
Rob Shearman
=versioniId=469
However, I don't know if IE6 currently installs or works in Wine.
--
Rob Shearman
2009/3/18 Igor Tarasov tarasov.i...@gmail.com:
2009/3/18 Rob Shearman robertshear...@gmail.com:
2009/3/18 Igor Tarasov tarasov.i...@gmail.com:
Please ensure that there are no regressions in the display of IE6's
toolbars after this patch. This is the main user of undocumented
toolbar features
writing a test code, but simply checking
if the above code returns the same as GetUserNameW seems not
correct, if test code should run under a different account as the actual
login user.
Is this a requirement for running the wine tests?
--
Rob Shearman
2009/3/9 Austin English austinengl...@gmail.com:
Howdy Rob,
Looks like one of your recent qmgr patches added failure to qmgr:
http://test.winehq.org/data/1b9a6fb4e9f5a76f1ca352bef121689df02d9289/#group_Wine
file.c:121: Test failed: GetRemoteName failed: 800706c6
file.c:124: Tests skipped
might be able to use a
native DLL to get round it, but I've no idea where it might reside! AFAIK
GetPrivateProfileString() doesn't do this expansion inherently.
Also if it is the case that the behaviour's different, then I would say it's
a Wine bug.
Any ideas appreciated.
--
Rob Shearman
2009/3/5 Alexandre Julliard julli...@winehq.org:
Rob Shearman robertshear...@gmail.com writes:
---
tools/widl/expr.c | 18
tools/widl/header.c | 34 ++--
tools/widl/parser.y | 103
++-
tools/widl/typelib.c
might not either.
+IMalloc_Free(malloc, ptr);
+}
+IMalloc_Release(malloc);
+OleUninitialize();
+}
--
Rob Shearman
just text.
In order for patches to be easily viewed in most email clients and
hence reviewed, they should be sent with a content type of text/*
(e.g. text/plain), regardless of whether the content is text and
compressed text.
--
Rob Shearman
need to be
changed.
--
Rob Shearman
(NtAllocateVirtualMemory, NtCreateMutex, etc.)
that depend on the server having started (i.e. after this function
having already executed).
--
Rob Shearman
.
--
Rob Shearman
of preventing such reports being
filed and one of the ways could be to add a check to the winetest
program.
--
Rob Shearman
). The old 7 models might have had an 800x600
resolution but I think these can be ignored now (no 7 netbook is
shipping anymore).
I think it's still valuable as an accessibility thing. Remember, not
everyone has excellent eyesight!
Turn the DPI up, not the resolution down.
--
Rob Shearman
the crash are not helpful in
pinpointing the failing test.
How can we get more information about these timeouts/crashes?
Something like the attached patch?
It needs changes in winetest along with the web dissector to integrate
properly, which I haven't got around to doing yet.
--
Rob Shearman
, GetLastError());
I'm wondering whether a better patch would be to change the persist
type from CRED_PERSIST_ENTERPRISE to CRED_PERSIST_LOCAL_MACHINE. Rob,
this is particularly aimed at you since you wrote the original tests:
is there a good reason to use CRED_PERSIST_ENTERPRISE here
LOCALE_INVARIANT when it's implemented.
And, yes, there's probably lots of other places where we do case
insensitive comparisons incorrectly like this, but we should stop
introducing new ones.
--
Rob Shearman
2009/2/9 Alexandre Julliard julli...@winehq.org:
Rob Shearman robertshear...@gmail.com writes:
@@ -874,8 +874,8 @@ unsigned char * WINAPI LPSAFEARRAY_UserMarshal(ULONG
*pFlags, unsigned char *Buf
*(ULONG *)Buffer = ulCellCount;
Buffer += sizeof(ULONG
();
+test_RpcServerUseProtseqEpEx();
}
--
Rob Shearman
( _RetVal = 0;\n);
}
print_proxy( RPC_MESSAGE _RpcMessage;\n );
if (has_ret) {
I think this is just hiding the problem. Can you give an example of
IDL which causes widl to generate code that causes compiler warnings?
--
Rob Shearman
2009/2/5 Jeremiah Flerchinger jeremiah.flerchin...@gmail.com:
On Thu, 2009-02-05 at 18:12 +, Rob Shearman wrote:
2009/2/3 Dmitry Timoshkov dmi...@codeweavers.com:
Jeremiah Flerchinger jeremiah.flerchin...@gmail.com wrote:
Stubs basic DDE interface of Progman.exe. Similar to Progman
);
print_proxy( }\n);
+ print_proxy(#endif /* USE_COMPILER_EXCEPTIONS */\n);
print_proxy( \n);
}
I think a better solution to this would be to use proxy_filter as the
expression in the RpcExcept statements.
Alexandre, what do you think?
--
Rob Shearman
2009/2/5 Luke Kenneth Casson Leighton luke.leigh...@googlemail.com:
http://bugs.winehq.org/show_bug.cgi?id=17263
The patch looks acceptable in theory. Please email the patch to
wine-patches (or wine-devel) and I'll review the implementation of it.
--
Rob Shearman
2009/2/6 Nikolay Sivov bungleh...@gmail.com:
Rob Shearman wrote:
2009/2/5 Nikolay Sivov bungleh...@gmail.com:
Changelog:
- Check for null endpoint in RpcServerUseProtseqEpExW.
Installed IE8 RC1 crashes on this call, parameter set is specified in
test case.
From
will
need to call the same set of routines from either method for full
functionality of DDE calls, including those to Progman.
http://en.wikipedia.org/wiki/Library_(computing)#Dynamic_linking
--
Rob Shearman
);
+MultiByteToWideChar(CP_ACP, 0, GECKO_VERSION, -1, url+strlenW(url),
(size-strlenW(url))/sizeof(WCHAR));
Dividing a string length (which returns character count) by
sizeof(WCHAR) doesn't look right.
--
Rob Shearman
DDE interface should be implemented by shell32.dll, nowhere else.
And it already is: ShellDDEInit.
All it needs is some always running process to call it. It looks like
explorer would be a good choice.
--
Rob Shearman
While I can see how using HKEY_CURRENT_USER instead of
HKEY_CLASSES_ROOT can help developers using a standard user rather
than Admin on Windows, I don't see it as useful in general as a lot of
the tests emulate what installers do and hence depend on having full
access to the system.
--
Rob Shearman
was involved in the actual fix can
dig up a pointer to the relevant thread.
http://www.winehq.org/pipermail/wine-devel/2006-July/049830.html
http://bugs.winehq.org/show_bug.cgi?id=5384
--
Rob Shearman
to be run on
Win9x and fixed if necessary to take this into account.
--
Rob Shearman
at the top of the
file.
--
Rob Shearman
ndr_marshall.c next
to the user marshal functions, which initialise the data structure
that it operates on). It also lacking a winapi comment.
--
Rob Shearman
will happen if the
IDirect3DDevice7 vtable field isn't the first one.
--
Rob Shearman
and you'll see #ifndef MIDL_PASS in PSDK header files to work around
these sorts of issues. If you really have to treat commctrl.h as an
IDL file, you'll need to #ifdef out problem statements.
--
Rob Shearman
2009/1/12 Alexandre Julliard julli...@winehq.org:
Rob Shearman robertshear...@gmail.com writes:
Skip calling the Pointer marshalling/unmarshalling/buffer
sizing/freeing function in this case.
Output code for calling union marshalling/unmarshalling/buffer
sizing/freeing functions
.
--
Rob Shearman
2009/1/10 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
Output NULL pointers into proxy table and STUB_FORWARDING_FUNCTION into
stub tables if a local function has no call_as function associated, just
as MIDL does.
Looks fine to me.
--
Rob Shearman
is being checked here.
--
Rob Shearman
. Eventually, I want to move this into
typegen.c:get_pointer_fc and in the future determine the pointer type
based on its attributes and whether it is a parameter or not.
Please send to wine-patches.
--
Rob Shearman
the
readability of the code, given that it only replaces two or three
lines of code and is only used in three places.
--
Rob Shearman
: ,
Looks good, once you expand the dubious functions used here. Also, can
you add a test for this in dlls/rpcrt4/tests/server.c?
--
Rob Shearman
)
Looks good.
--
Rob Shearman
last_ptr and is_string_type into
typegen.c/typegen.h, since that is where they are most used.
--
Rob Shearman
: there appears to be a bug in the current code where it walks
pointers looking for the pointer attribute, instead of walking just
aliases, so that should probably be fixed too.
--
Rob Shearman
2009/1/7 Ge van Geldorp g...@gse.nl:
Hi Rob,
Is WIDL supposed to generate code that's compatible with Windows RPCRT4.DLL?
Because it appears this is currently not the case. When you look at
http://test.winehq.org you'll see that the rpcrt4:server test fails on
pretty much any Windows version
further as to why it isn't working
for you. I suggest to start by running winedump dump -j import
shell32_crosstest.exe.
--
Rob Shearman
type of pin, PullPin.
--
Rob Shearman
the attributes. I plan to
clean this up in the near future so you don't need to change the patch
unless you want to.
--
Rob Shearman
the previous memory needs to be freed (on the
client side).
The correct fix for the problem you see is to implement (yet another)
check in cant_be_null.
--
Rob Shearman
is to change the
long type in widl to output int. This will allow the generated
code to work correctly on both 32-bit and 64-bit Linux and Windows
platforms (but not 16-bit platforms and possibly other platforms).
--
Rob Shearman
, 0) = 0) {
+#else
+ if (sysctl(mib, 2, value, value+1, NULL, 0) = 0) {
+#endif
...
--
Rob Shearman
penalty for this and the other similar changes too.
These kinds of optimisations need to be backed up by benchmarks, for
both memory and performance.
--
Rob Shearman
2009/1/1 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
Am Donnerstag, den 01.01.2009, 20:43 + schrieb Rob Shearman:
No, the [string] attribute in this case in redundant and it should
apply to the first pointer in the parameter.
Now, that makes sense.
I'm guessing by the
change
(
[in] LPCOLESTR pszPropName,
--
Rob Shearman
(
[in] IPropertyBag *pPropBag,
-[in] IErrorLog *pErrorLog);
+[in,unique] IErrorLog *pErrorLog);
HRESULT Save(
[in] IPropertyBag *pPropBag,
Same goes for this change.
--
Rob Shearman
leaking the memory in outVariant here, since VariantCopy does a
deep copy of all of the data. Is there a reason you don't just pass
pVar into IPropertyBag_RemoteRead_Proxy?
--
Rob Shearman
correct. IAutoCompleteDropDown::GetDropDownStatus should be
remoted as is.
HRESULT ResetEnumerator();
}
--
Rob Shearman
2009/1/1 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
Am Donnerstag, den 01.01.2009, 18:53 + schrieb Rob Shearman:
but MIDL ignores the pointer type for interface
pointers and never outputs a NULL reference pointer check for them. So
widl just needs to be fixed.
Is it OK for me
2009/1/1 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
Am Donnerstag, den 01.01.2009, 19:09 + schrieb Rob Shearman:
2009/1/1 Michael Karcher w...@mkarcher.dialup.fu-berlin.de:
+[call_as(AddPropertySheetPages)]
+HRESULT RemoteAddPropertySheetPages();
[...]
+[call_as
HBRUSH_UserSize
The functions should be added in the correct place so that the list of
functions remains sorted.
--
Rob Shearman
;
+}
+}
+received += ret;
+}
--
Rob Shearman
Sorry, this should have been in reply to patch [6/6].
2008/12/29 Henri Verbeet hverb...@gmail.com:
2008/12/29 Rob Shearman robertshear...@gmail.com:
2008/12/28 Henri Verbeet hverb...@gmail.com:
+while (received data_size)
+{
+ret = pgnutls_record_recv(ctx-session, data
pointer checks when using the same source IDL files.
--
Rob Shearman
1 - 100 of 327 matches
Mail list logo
