On 2013-09-18 11:31, Dmitry Timoshkov wrote:
> Thomas Faber wrote:
>> status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents,
>> sizeof(contents), &offset, NULL);
>> ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see below
>> */,
Hey Dmitry,
I noticed a couple of tests structured like this:
status = pNtWriteFile(hfile, 0, NULL, NULL, &iob, contents,
sizeof(contents), &offset, NULL);
ok(status == STATUS_PENDING || broken(status == STATUS_SUCCESS) /* see
below */, "expected STATUS_PENDING, got %#x\n", status);
ok(iob.Status
On 2013-07-31 02:48, Bruno Jesus wrote:
> +ok(!getsockopt(sock, SOL_SOCKET, SO_TYPE, (char *) &socktype, &size),
> "getsockopt failed with %d\n",
> + WSAGetLastError());
It's not guaranteed that getsockopt is called before WSAGetLastError
here. (in fact the latter will be evaluated firs
Sorry, should have replied to this.
These tests shouldn't even run on 2000, already seen e.g. in
http://www.winehq.org/pipermail/wine-devel/2013-April/099536.html
http://www.winehq.org/pipermail/wine-devel/2012-November/097823.html
Let me know if there's any issues.
Thanks,
Thomas
On 2013-07-1
I just tried running midl on dlls/oleaut32/tests/tmarshal.idl and it
complained:
tmarshal.idl(83) : error MIDL2270 : duplicate UUID. Same as : ItestDual [
Interface 'ITestSecondDisp' ]
This doesn't seem like it's intentional. But just giving
ITestSecondDisp a new uuid causes the following test f
e liked to use is_object in widl, but
that also triggers on the odl attribute.
I'll send it to -patches once I'm satisfied with it, but I'm pretty
fond of the simple approach already. Let me know if you have any
comments.
Thanks a lot.
-Thomas
From 55a00aae2900cec493b06d6a434809f053d76fe5
On 2013-06-26 22:49, André Hentschel wrote:
> On 26.06.2013 22:06, Thomas Faber wrote:
>> On 2013-06-26 21:47, André Hentschel wrote:
>>> The whitespace changes are bad, please don't do that.
>>
>> Ok, I can take them out no problem.
>> Why's it ba
On 2013-06-26 21:47, André Hentschel wrote:
> The whitespace changes are bad, please don't do that.
Ok, I can take them out no problem.
Why's it bad though? I thought the rule was "fix it while you're
working on it anyway".
On 2013-06-25 21:11, Alexandre Julliard wrote:
> Thomas Faber writes:
>
>> An alternative solution would be not to generate a vtable structure at all,
>> and instead add a dummy member to the class directly. That would be in line
>> with what the defined(__cplusplus) &
On 2012-10-04 13:07, Christian Costa wrote:
> 2012/10/4 Paul Chitescu
>> AFAIK the structure differs for each major version of Windows and some SP
>> too.
>>
>>
> I was expecting something like this. :(
>
>
>> At the minimum I saw some drivers expecting that at the returned pointer
>> to be
>> a
Hi,
what can I do to get this in committable shape?
I don't see how it can be reasonably split up; tests are in place.
I've noticed I forgot to remove the L prefixes on character constants,
which I'll correct.
I'll gladly fix any other style issues.
The function _could_ be implemented using strt
On 2012-06-21 23:47, David Laight wrote:
> On Thu, Jun 21, 2012 at 12:56:43PM +0200, Thomas Faber wrote:
>> On 2012-06-21 12:34, Dmitry Timoshkov wrote:
>>> Thomas Faber wrote:
>>>> FIELD_OFFSET isn't constant "enough".
>>>
>>> Th
On 2012-06-21 12:34, Dmitry Timoshkov wrote:
> Thomas Faber wrote:
>
>> FIELD_OFFSET isn't constant "enough".
>
> The problem is not with FIELD_OFFSET, but with applying shift and mask
> operations to a constant.
You're right, it's actually a
On 2012-04-29 12:05, Stefan Dösinger wrote:
> Am Samstag, 28. April 2012, 10:16:13 schrieb Thomas Faber:
>> Apparently NAN and INFINITE are C99 as well (I should really get a
>> version of the old standard instead of mostly reading C99 :|).
>>
>> How about a simple con
On 2011-12-25 17:12, Dmitry Timoshkov wrote:
> Thomas Faber wrote:
>
>> diff --git a/dlls/kernel32/tests/Makefile.in
>> b/dlls/kernel32/tests/Makefile.in
>> index dce27db..2ce3ec6 100644
>> --- a/dlls/kernel32/tests/Makefile.in
>> +++ b/dlls/kernel
On 2011-11-06 18:04, Vitaliy Margolen wrote:
> On 11/06/2011 09:14 AM, Thomas Faber wrote:
>>
>
>> +length = strlen(dll_directories[i]);
>> +assert(sizeof(buffer) > length + 1);
> Please don't do this. Tests shouldn't assert because progr
Hey,
On 2011-11-06 17:25, Vincent Povirk wrote:
> I don't think you can rely on C:\Windows existing.
indeed. :)
But the function only requires valid path syntax, not a path that
actually exists.
I guess I could have made that clearer -- but C:\Windows is as
good a path as any I suppose.
Thanks.
Hey,
On 2011-10-24 20:03, Alexandre Julliard wrote:
> Thomas Faber writes:
>
>> Windows's version of GetTextExtentExPointW, which is called in that function,
>> returns a value of 1 in this case (Wine's does not, which would appear to be
>> a bug), leading to t
Hi Michael,
On 2011-10-23 21:25, Michael Stefaniuc wrote:
> On 10/22/2011 10:38 PM, Thomas Faber wrote:
>> This makes the use of casts more consistent and shows the conversion
>> from WPARAM to CHAR/WCHAR is intentional for WM_CHAR/EM_SETPASSWORDCHAR.
>> Also fixes two MSVC w
Hi,
On 2011-10-22 22:45, Thomas Faber wrote:
> Windows's version of GetTextExtentExPointW, which is called in that function,
> returns a value of 1 in this case (Wine's does not, which would appear to be
> a bug), leading to the "i control.
this description isn
On 2011-10-23 00:10, Dan Kegel wrote:
> Fails to build here...
> On Oct 22, 2011 1:48 PM, wrote:
> editor.c:6369:5: error: passing argument 4 of 'SendMessageA' makes integer
> from pointer without a cast [-Werror]
Dangit. And I thought running on testbot would ensure I didn't forget
anything. H
Hey,
On 2011-10-15 12:10, Thomas Faber wrote:
> The patch fixes this by adding checks to ME_SetDefaultFormatRect to
> use the minimal rectangle that is still valid in this case.
I've made some tests (will post them later) and it turns out this rectangle
is also invalid in Windows i
22 matches
Mail list logo
